Hi Andre, On 09/06/17 18:41, Andre Przywara wrote:
For LPIs we later want to dynamically allocate struct pending_irqs. So beside needing to initialize the struct from there we also need to clean it up and re-initialize it later on. Export vgic_init_pending_irq() and extend it to be reusable.Signed-off-by: Andre Przywara <andre.przyw...@arm.com> --- xen/arch/arm/vgic.c | 4 +++- xen/include/asm-arm/vgic.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 2e4820f..7e8dba6 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -60,8 +60,10 @@ struct vgic_irq_rank *vgic_rank_irq(struct vcpu *v, unsigned int irq) return vgic_get_rank(v, rank); } -static void vgic_init_pending_irq(struct pending_irq *p, unsigned int virq) +void vgic_init_pending_irq(struct pending_irq *p, unsigned int virq) { + memset(p, 0, sizeof(*p));
So for initialization, we will clear the memory twice which looks rather pointless (see the current caller).
We probably to drop the memset or replace xzalloc by xalloc in the caller. I would be ok to see this change in a follow-up patch. Assuming you will sent a patch:
Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
