Re: [Xen-devel] [xen-4.3-testing test] 96176: regressions - FAIL

2016-06-23 Thread Jan Beulich
>>> On 24.06.16 at 05:12, wrote: > flight 96176 xen-4.3-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/96176/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-i386-libvirt5 libvirt-build

Re: [Xen-devel] [PATCH v2 4/4] VMX: fixup PI descritpor when cpu is offline

2016-06-23 Thread Wu, Feng
> >> > @@ -122,10 +124,25 @@ static void vmx_vcpu_block(struct vcpu *v) > >> > * new vCPU to the list. > >> > */ > >> > spin_unlock_irqrestore(&v->arch.hvm_vmx.pi_hotplug_lock, flags); > >> > -return; > >> > +return 1; > >> > } > >> > > >> > sp

Re: [Xen-devel] [PATCH v2 0/4] VMX: Properly handle pi descriptor and per-cpu blocking list

2016-06-23 Thread Wu, Feng
> -Original Message- > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > Sent: Thursday, June 23, 2016 5:33 AM > To: Wu, Feng ; xen-devel@lists.xen.org > Cc: k...@xen.org; Tian, Kevin ; jbeul...@suse.com; > andrew.coop...@citrix.com; george.dun...@eu.citrix.com; > konrad.w...@orac

Re: [Xen-devel] [PATCH v1 Altp2m cleanup 1/3] altp2m cleanup work

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 20:23, wrote: First of all - please don't top post. > I'm opposed to moving HVMOP_cmd_min and HVMOP_cmd_max somewhere else. That > would make reading/understanding of the macros more difficult. This practice > is common. Also, If min & max are defined elsewhere, it will b

Re: [Xen-devel] [PATCH v4 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2016-06-23 Thread Jan Beulich
>>> On 24.06.16 at 06:16, wrote: > I'm now willing to take your suggestions: > a> still need the p2m resetting when ioreq server is unbounded; > b> disable log dirty feature if one ioreq server is bounded. > > Does anyone else has different opinions? Thanks! Hmm, in particular for a) I don't thi

Re: [Xen-devel] [PATCH 0/3] VMX: Properly handle pi descriptor and per-cpu blocking list

2016-06-23 Thread Wu, Feng
> -Original Message- > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > Sent: Thursday, June 23, 2016 11:12 PM > To: Wu, Feng ; Jan Beulich > Cc: Tian, Kevin ; k...@xen.org; > george.dun...@eu.citrix.com; andrew.coop...@citrix.com; xen- > de...@lists.xen.org > Subject: Re: [Xen-

[Xen-devel] [PATCH v12 3/6] vt-d: convert conditionals of qi_ctrl->qinval_maddr into ASSERT()s

2016-06-23 Thread Xu, Quan
From: Quan Xu QI ought to have got disabled if any of the IOMMU table setup failed. A QI function (other than enable_qinval) is unreachable when qi_ctrl->qinval_maddr is zero. Signed-off-by: Quan Xu CC: Jan Beulich CC: Kevin Tian CC: Feng Wu --- xen/drivers/passthrough/vtd/qinval.c | 52 ++

[Xen-devel] [PATCH v12 6/6] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-23 Thread Xu, Quan
From: Quan Xu If Device-TLB flush timed out, we hide the target ATS device immediately and crash the domain owning this ATS device. If impacted domain is hardware domain, just throw out a warning. By hiding the device, we make sure it can't be assigned to any domain any longer (see device_assign

[Xen-devel] [PATCH v12 2/6] vt-d: synchronize for Device-TLB flush one by one

2016-06-23 Thread Xu, Quan
From: Quan Xu Today we do Device-TLB flush synchronization after issuing flush requests for all ATS devices belonging to a VM. Doing so however imposes a limitation, i.e. that we can not figure out which flush request is blocked in the flush queue list, based on VT-d spec. To prepare correct Dev

[Xen-devel] [PATCH v12 0/6] VT-d Device-TLB flush issue

2016-06-23 Thread Xu, Quan
From: Quan Xu This patches fix current timeout concern and also allow limited ATS support: 1. add a timeout parameter for device IOTLB invalidation The parameter 'iommu_dev_iotlb_timeout' specifies the timeout of device IOTLB invalidation in milliseconds. By default, the timeout is

[Xen-devel] [PATCH v12 1/6] IOMMU: add a timeout parameter for device IOTLB invalidation

2016-06-23 Thread Xu, Quan
From: Quan Xu The parameter 'iommu_dev_iotlb_timeout' specifies the timeout of device IOTLB invalidation in milliseconds. By default, the timeout is 1000 milliseconds, which can be boot-time changed. We also confirmed with VT-d hardware team that 1 milliseconds is large enough for VT-d IOMMU int

[Xen-devel] [PATCH v12 5/6] IOMMU: move the domain crash logic up to the generic IOMMU layer

2016-06-23 Thread Xu, Quan
From: Quan Xu Signed-off-by: Quan Xu CC: Julien Grall CC: Kevin Tian CC: Feng Wu CC: Jan Beulich CC: Suravee Suthikulpanit --- xen/drivers/passthrough/iommu.c | 30 -- xen/drivers/passthrough/vtd/iommu.c | 11 +++ 2 files changed, 39 insertions(+),

[Xen-devel] [PATCH v12 4/6] IOMMU/x86: using a struct pci_dev* instead of SBDF

2016-06-23 Thread Xu, Quan
From: Quan Xu a struct pci_dev* instead of SBDF is stored inside struct pci_ats_dev and parameter to enable_ats_device(). Signed-off-by: Quan Xu CC: Jan Beulich CC: Kevin Tian CC: Feng Wu CC: Suravee Suthikulpanit --- xen/drivers/passthrough/amd/iommu_cmd.c | 11 +++--- xen/drivers/pa

Re: [Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-23 Thread Gerd Hoffmann
On Do, 2016-06-23 at 17:18 +0100, Anthony PERARD wrote: > On Thu, Jun 23, 2016 at 04:57:54PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > How could xen_ram_init() find out if the value of max-ram-below-4g is > > > the default or if a user have set it? Is there another way we could fix > > > thi

[Xen-devel] [PATCH] MAINTAINERS: Add ARM scif serial driver

2016-06-23 Thread Dirk Behme
The scif-uart.c is an ARM specific UART driver for the Renesas RCar SoC family. Signed-off-by: Dirk Behme --- Note: This has been discussed in https://lists.xen.org/archives/html/xen-devel/2016-06/msg03051.html https://lists.xen.org/archives/html/xen-devel/2016-06/msg03062.html MAINTAINERS |

Re: [Xen-devel] [PATCH v4 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2016-06-23 Thread Yu Zhang
On 6/23/2016 6:33 PM, George Dunlap wrote: On 23/06/16 08:37, Yu Zhang wrote: On 6/22/2016 7:33 PM, George Dunlap wrote: On 22/06/16 11:07, Yu Zhang wrote: On 6/22/2016 5:47 PM, George Dunlap wrote: On 22/06/16 10:29, Jan Beulich wrote: On 22.06.16 at 11:16, wrote: On 22/06/16 07:39, Jan

[Xen-devel] [xen-4.3-testing test] 96176: regressions - FAIL

2016-06-23 Thread osstest service owner
flight 96176 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/96176/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt5 libvirt-build fail REGR. vs. 87893 build-amd64-libvi

[Xen-devel] [qemu-mainline test] 96175: regressions - FAIL

2016-06-23 Thread osstest service owner
flight 96175 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/96175/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 94856 test-amd64-i3

[Xen-devel] [ovmf test] 96169: regressions - FAIL

2016-06-23 Thread osstest service owner
flight 96169 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/96169/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-amd64-

[Xen-devel] [xen-unstable-smoke test] 96189: tolerable all pass - PUSHED

2016-06-23 Thread osstest service owner
flight 96189 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/96189/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH v2 17/17] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/2016 04:17, Shannon Zhao wrote: From: Shannon Zhao If Xen guest boots with ACPI, the guest kernel will get the event channel interrupt information via domain param HVM_PARAM_CALLBACK_IRQ. Initialize that domain param. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_ar

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/2016 04:17, Shannon Zhao wrote: From: Shannon Zhao Copy all the ACPI tables to guest space so that UEFI or guest could access them. Signed-off-by: Shannon Zhao --- tools/libxc/xc_dom_arm.c | 51 1 file changed, 51 inserti

Re: [Xen-devel] [PATCH v2 15/17] libxl/arm: Add ACPI module

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/2016 04:17, Shannon Zhao wrote: From: Shannon Zhao Add the ARM Multiboot module for ACPI, so UEFI or DomU can get the base address of ACPI tables from it. Signed-off-by: Shannon Zhao --- docs/misc/arm/device-tree/acpi.txt | 23 +++ tools/libxl/libxl_

Re: [Xen-devel] [PATCH v1 Altp2m cleanup 1/3] altp2m cleanup work

2016-06-23 Thread Lai, Paul C
I'm opposed to moving HVMOP_cmd_min and HVMOP_cmd_max somewhere else. That would make reading/understanding of the macros more difficult. This practice is common. Also, If min & max are defined elsewhere, it will be more likely to lead to mistakes/bugs. The use of "_min" and "_max" should b

[Xen-devel] [xen-unstable-smoke test] 96182: regressions - FAIL

2016-06-23 Thread osstest service owner
flight 96182 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/96182/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 6 xen-boot fail REGR. vs. 96177 Tests which di

[Xen-devel] [linux-3.18 test] 96161: regressions - FAIL

2016-06-23 Thread osstest service owner
flight 96161 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/96161/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 95844 test-amd

Re: [Xen-devel] [PATCH v2 13/17] libxl/arm: Link all ACPI tables into one buffer

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:17, Shannon Zhao wrote: From: Shannon Zhao Link all ACPI tables into one buffer, fill in the addresses of tables and update checksum of each table. Is there any reason to not allocate the acpitable_blob buffer before hand (and even reallocate if not enough space)

[Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-23 Thread Tamas K Lengyel
Since in-guest debug exceptions are now unconditionally trapped to Xen, adding a hook for vm_event subscribers to tap into this new always-on guest event. We rename along the way hvm_event_breakpoint_type to hvm_event_type to better match the various events that can be passed with it. We also intro

[Xen-devel] [PATCH v6 1/5] monitor: Rename vm_event_monitor_get_capabilities

2016-06-23 Thread Tamas K Lengyel
The monitor_get_capabilities check actually belongs to the monitor subsystem so relocating and renaming it to sanitize the code's name and location. Mechanical patch, no code changes introduced. Signed-off-by: Tamas K Lengyel Acked-by: Andrew Cooper Acked-by: Razvan Cojocaru Acked-by: Julien Gr

[Xen-devel] [PATCH v6 3/5] monitor: Rename hvm/event to hvm/monitor

2016-06-23 Thread Tamas K Lengyel
Mechanical renaming to better describe that the code in hvm/event is part of the monitor subsystem. Signed-off-by: Tamas K Lengyel Acked-by: Kevin Tian Acked-by: Razvan Cojocaru Acked-by: Jan Beulich --- Cc: Andrew Cooper Cc: Jun Nakajima --- xen/arch/x86/hvm/Makefile |

[Xen-devel] [PATCH v6 4/5] vm_event: clear up return value of vm_event_monitor_traps

2016-06-23 Thread Tamas K Lengyel
The return value has not been clearly defined, with the function never returning 0 which seemingly indicated a condition where the guest should crash. In this patch we define -rc as error condition where a subscriber is present but an error prevented the notification from being sent; 0 where there

[Xen-devel] [PATCH v6 2/5] monitor: Rename vm_event_monitor_guest_request

2016-06-23 Thread Tamas K Lengyel
Mechanical renaming and relocation to the monitor subsystem. Signed-off-by: Tamas K Lengyel Acked-by: Razvan Cojocaru Acked-by: Jan Beulich Acked-by: Julien Grall --- Cc: Stefano Stabellini Cc: Andrew Cooper --- xen/arch/arm/hvm.c | 4 ++-- xen/arch/x86/hvm/hvm.c | 3 ++- xen/

Re: [Xen-devel] [PATCH v2 12/17] libxl/arm: Add a helper to calculate the ACPI table checksum

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 45fc354..d8779af 100644

Re: [Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: [...] diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 264b6ef..5347480 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -77,7 +77,29 @@ endif LIBXL_OBJS-$(CONFIG_X86) += libxl_cpuid.o libxl_x86.o libxl_psr.o

Re: [Xen-devel] [PATCH v2 07/17] libxl/arm: Construct ACPI GTDT table

2016-06-23 Thread Julien Grall
On 23/06/16 17:26, Julien Grall wrote: enum { RSDP, XSDT, @@ -110,6 +113,30 @@ static void make_acpi_xsdt(libxl__gc *gc, struct xc_dom_image *dom) dom->acpitable_size += ROUNDUP(acpitables[XSDT].size, 3); } +static void make_acpi_gtdt(libxl__gc *gc, struct xc_dom_image *d

Re: [Xen-devel] RFC: XenSock brainstorming

2016-06-23 Thread Stefano Stabellini
Although discussing the goals is fun, feedback on the design of the protocol is particularly welcome. On Thu, 23 Jun 2016, Stefano Stabellini wrote: > Now that Xen 4.7 is out of the door, any more feedback on this? > > On Mon, 6 Jun 2016, Stefano Stabellini wrote: > > Hi all, > > > > a couple of

Re: [Xen-devel] [PATCH v5 02/14] libxc: Prepare a start info structure for hvmloader

2016-06-23 Thread Anthony PERARD
On Thu, Jun 23, 2016 at 10:44:26AM -0400, Boris Ostrovsky wrote: > On 06/22/2016 01:15 PM, Anthony PERARD wrote: > > +/* > > + * The memory layout of the start_info page and the modules, and where the > > + * addresses are stored: > > + * > > + * /--\ > > + * | struc

Re: [Xen-devel] RFC: XenSock brainstorming

2016-06-23 Thread Stefano Stabellini
On Thu, 23 Jun 2016, David Vrabel wrote: > On 06/06/16 10:33, Stefano Stabellini wrote: > > # Goals > > > > The goal of the protocol is to provide networking capabilities to any > > guests, with the following added benefits: > > > > * guest networking should work out of the box with VPNs, wireles

Re: [Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

2016-06-23 Thread Julien Grall
Hi, On 23/06/16 15:50, Stefano Stabellini wrote: On Thu, 23 Jun 2016, Shannon Zhao wrote: diff --git a/tools/libxl/libxl_empty_dsdt_arm.asl b/tools/libxl/libxl_empty_dsdt_arm.asl new file mode 100644 index 000..005fa6a --- /dev/null +++ b/tools/libxl/libxl_empty_dsdt_arm.asl @@ -0,0 +1,22

Re: [Xen-devel] [PATCH v2 09/17] libxl/arm: Construct ACPI MADT table

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: From: Shannon Zhao According to the GIC version, construct the MADT table. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 100 +++ 1 file changed, 100 insertions(+) diff --git a/too

Re: [Xen-devel] [PATCH v2 08/17] libxl/arm: Factor MPIDR computing codes out as a helper

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: From: Shannon Zhao Factor MPIDR computing codes out as a helper, so it could be shared between DT and ACPI. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 8 +--- tools/libxl/libxl_arm_acpi.h | 12 2 fil

Re: [Xen-devel] RFC: XenSock brainstorming

2016-06-23 Thread David Vrabel
On 06/06/16 10:33, Stefano Stabellini wrote: > # Goals > > The goal of the protocol is to provide networking capabilities to any > guests, with the following added benefits: > > * guest networking should work out of the box with VPNs, wireless > networks and any other complex network configurat

Re: [Xen-devel] [PATCH v2 07/17] libxl/arm: Construct ACPI GTDT table

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: From: Shannon Zhao Construct GTDT table with the interrupt information of timers. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 28 1 file changed, 28 insertions(+) diff --git a/tools/libxl/l

Re: [Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: [...] diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index cc5a717..f5db74b 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -1,6 +1,7 @@ #include "libxl_internal.h" #include "libxl_arch.h" #include "

Re: [Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-23 Thread Anthony PERARD
On Thu, Jun 23, 2016 at 04:57:54PM +0200, Gerd Hoffmann wrote: > Hi, > > > How could xen_ram_init() find out if the value of max-ram-below-4g is > > the default or if a user have set it? Is there another way we could fix > > this? > > Attached patch should fix it. Patch survived a quick smoke

Re: [Xen-devel] [PATCH v2 07/17] libxl/arm: Construct ACPI GTDT table

2016-06-23 Thread Julien Grall
Hi, On 23/06/16 16:00, Stefano Stabellini wrote: On Thu, 23 Jun 2016, Shannon Zhao wrote: [...] +static void make_acpi_gtdt(libxl__gc *gc, struct xc_dom_image *dom) +{ +struct acpi_table_gtdt *gtdt; +size_t size = sizeof(*gtdt); + +gtdt = libxl__zalloc(gc, size); + +gtdt->non

Re: [Xen-devel] [PATCH v4 0/3] Make hvm_fep available to non-debug build

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:10, Wei Liu wrote: > Wei Liu (3): > xen: add warning infrastructure > console: use warning infrastructure for sync console warning > xen: make available hvm_fep to non-debug build as well Committed, including the small adjustments. ~Andrew ___

Re: [Xen-devel] [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const

2016-06-23 Thread Andrew Cooper
On 23/06/16 17:00, Jan Beulich wrote: On 21.06.16 at 18:59, wrote: >> --- a/xen/include/xen/init.h >> +++ b/xen/include/xen/init.h >> @@ -86,10 +86,11 @@ struct kernel_param { >> void *var; >> }; >> >> -extern struct kernel_param __setup_start, __setup_end; >> +extern const struct ker

Re: [Xen-devel] RFC: XenSock brainstorming

2016-06-23 Thread Stefano Stabellini
Now that Xen 4.7 is out of the door, any more feedback on this? On Mon, 6 Jun 2016, Stefano Stabellini wrote: > Hi all, > > a couple of months ago I started working on a new PV protocol for > virtualizing syscalls. I named it XenSock, as its main purpose is to > allow the implementation of the PO

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 17:45, wrote: > In your patch (changing XSM_XS_PRIV semantic), you implicitly considered > all domctls allowed for xenstore domain to be always a subset of those > allowed for device model domain. For now this is true, but if this set > is going to be extended in the future, you

Re: [Xen-devel] [PATCH] xen/arm: domain_build: DT: add clocks node to the hypervisor node

2016-06-23 Thread Julien Grall
Hi Dirk, On 23/06/16 16:59, Dirk Behme wrote: On 23.06.2016 17:02, Julien Grall wrote: On 22/06/16 16:58, Julien Grall wrote: On 21/06/16 11:15, Dirk Behme wrote: +printk("Failed to remember the clock node of %s\n", path); +printk("Use the Linux kernel command 'clk_ign

Re: [Xen-devel] [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const

2016-06-23 Thread Jan Beulich
>>> On 21.06.16 at 18:59, wrote: > --- a/xen/include/xen/init.h > +++ b/xen/include/xen/init.h > @@ -86,10 +86,11 @@ struct kernel_param { > void *var; > }; > > -extern struct kernel_param __setup_start, __setup_end; > +extern const struct kernel_param __setup_start[], __setup_end[]; > >

Re: [Xen-devel] [PATCH] xen/arm: domain_build: DT: add clocks node to the hypervisor node

2016-06-23 Thread Dirk Behme
On 23.06.2016 17:02, Julien Grall wrote: On 22/06/16 16:58, Julien Grall wrote: On 21/06/16 11:15, Dirk Behme wrote: +printk("Failed to remember the clock node of %s\n", path); +printk("Use the Linux kernel command 'clk_ignore_unused'\n"); +return 0; I don'

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: From: Shannon Zhao Add a configuration option for ARM DomU so that user can deicde to use ACPI or not. This option is defaultly false. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 3 +++ tools/libxl/libxl_types.idl |

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Doug Goldstein
On 6/23/16 10:10 AM, Wei Liu wrote: > Originally hvm_fep was guarded by NDEBUG, which means it was only > available to debug builds. > > However there is value to have it for non-debug builds as well. User can > use that to run tests in setup that replicates production setup. "Users can use it to

[Xen-devel] [linux-4.1 test] 96160: regressions - FAIL

2016-06-23 Thread osstest service owner
flight 96160 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/96160/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 11 guest-start fail REGR. vs. 95848 Regressions which are r

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Marek Marczykowski-Górecki
On Thu, Jun 23, 2016 at 05:45:22PM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Jun 23, 2016 at 09:37:09AM -0600, Jan Beulich wrote: > > >>> On 23.06.16 at 17:22, wrote: > > > xen: allow XEN_DOMCTL_getdomaininfo for device model domains > > > > > > Allow device model domain to get info abou

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Marek Marczykowski-Górecki
On Thu, Jun 23, 2016 at 09:37:09AM -0600, Jan Beulich wrote: > >>> On 23.06.16 at 17:22, wrote: > > xen: allow XEN_DOMCTL_getdomaininfo for device model domains > > > > Allow device model domain to get info about its target domain. > > It is used during PCI passthrough setup (xc_domain_memory_map

Re: [Xen-devel] [PATCH v1 Altp2m cleanup 1/3] altp2m cleanup work

2016-06-23 Thread Jan Beulich
>>> On 21.06.16 at 18:04, wrote: > --- a/xen/include/public/hvm/hvm_op.h > +++ b/xen/include/public/hvm/hvm_op.h > @@ -479,6 +479,8 @@ struct xen_hvm_altp2m_op { > #define HVMOP_altp2m_set_mem_access 7 > /* Change a p2m entry to have a different gfn->mfn mapping */ > #define HVMOP_altp2m_

Re: [Xen-devel] [PATCH v5 1/2] x86/mem-sharing: Bulk mem-sharing entire domains

2016-06-23 Thread Tamas K Lengyel
On Wed, Jun 22, 2016 at 9:38 AM, George Dunlap wrote: > On Sun, Jun 12, 2016 at 12:24 AM, Tamas K Lengyel wrote: >> Currently mem-sharing can be performed on a page-by-page base from the >> control >> domain. However, when completely deduplicating (cloning) a VM, this requires >> at least 3 hype

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 17:22, wrote: > xen: allow XEN_DOMCTL_getdomaininfo for device model domains > > Allow device model domain to get info about its target domain. > It is used during PCI passthrough setup (xc_domain_memory_mapping > checks for guest being auto-translated). While it happens in stu

Re: [Xen-devel] [PATCH 01/11] public / x86: introduce hvmctl hypercall

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:10, Jan Beulich wrote: On 23.06.16 at 16:55, wrote: >> On 20/06/16 13:52, Jan Beulich wrote: >>> +/* >>> + * Note that this value is effectively part of the ABI, even if we don't >> need >>> + * to make it a formal part of it. Hence this value may only be changed if >>> + * a

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Daniel De Graaf
On 06/23/2016 11:22 AM, Marek Marczykowski-Górecki wrote: On Thu, Jun 23, 2016 at 11:00:42AM -0400, Daniel De Graaf wrote: On 06/23/2016 09:25 AM, Marek Marczykowski-Górecki wrote: [...] Ok, after drawing a flowchart of the control in this function after your change, on a piece of paper, this c

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:26, Wei Liu wrote: > On Thu, Jun 23, 2016 at 04:24:40PM +0100, Andrew Cooper wrote: >> On 23/06/16 16:10, Wei Liu wrote: >>> Originally hvm_fep was guarded by NDEBUG, which means it was only >>> available to debug builds. >>> >>> However there is value to have it for non-debug builds

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Wei Liu
On Thu, Jun 23, 2016 at 04:24:40PM +0100, Andrew Cooper wrote: > On 23/06/16 16:10, Wei Liu wrote: > > Originally hvm_fep was guarded by NDEBUG, which means it was only > > available to debug builds. > > > > However there is value to have it for non-debug builds as well. User can > > use that to ru

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:10, Wei Liu wrote: > Originally hvm_fep was guarded by NDEBUG, which means it was only > available to debug builds. > > However there is value to have it for non-debug builds as well. User can > use that to run tests in setup that replicates production setup. That is odd phrasing.

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Marek Marczykowski-Górecki
On Thu, Jun 23, 2016 at 11:00:42AM -0400, Daniel De Graaf wrote: > On 06/23/2016 09:25 AM, Marek Marczykowski-Górecki wrote: > [...] > > Ok, after drawing a flowchart of the control in this function after your > > change, on a piece of paper, this case looks fine. But depending on how > > the domai

Re: [Xen-devel] [PATCH v4 2/3] console: use warning infrastructure for sync console warning

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:10, Wei Liu wrote: > Move the warning text to a static variable and marked that as initconst > data. Call warning_add in console_init_preirq. Finally remove all > unused bits. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xe

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 17:10, wrote: > Originally hvm_fep was guarded by NDEBUG, which means it was only > available to debug builds. > > However there is value to have it for non-debug builds as well. User can > use that to run tests in setup that replicates production setup. > > Make it clear with

Re: [Xen-devel] [PATCH v4 1/3] xen: add warning infrastructure

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:10, Wei Liu wrote: > Use an array to keep track of warning text, provide a function to add > warning text to track. Print warnings (if any) in console_endboot. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v4 2/3] console: use warning infrastructure for sync console warning

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 17:10, wrote: > Move the warning text to a static variable and marked that as initconst > data. Call warning_add in console_init_preirq. Finally remove all > unused bits. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-d

Re: [Xen-devel] [PATCH v3 1/2] xen/arm: drivers: scif: Remove dead code

2016-06-23 Thread Julien Grall
(CC "THE REST" maintainers) Hi Dirk, On 22/06/16 12:49, Dirk Behme wrote: The two struct members baud and clock_hz are in the end read only variables nowhere used for anything useful. Removing them makes the code much simpler without changing any functionality. Signed-off-by: Dirk Behme Not

Re: [Xen-devel] [PATCH v4 1/3] xen: add warning infrastructure

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 17:10, wrote: > Use an array to keep track of warning text, provide a function to add > warning text to track. Print warnings (if any) in console_endboot. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing li

[Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Wei Liu
Originally hvm_fep was guarded by NDEBUG, which means it was only available to debug builds. However there is value to have it for non-debug builds as well. User can use that to run tests in setup that replicates production setup. Make it clear with a sync_console style warning that this option c

Re: [Xen-devel] [PATCH v3 1/2] xen/arm: drivers: scif: Remove dead code

2016-06-23 Thread Wei Liu
On Thu, Jun 23, 2016 at 04:09:39PM +0100, Julien Grall wrote: > (CC "THE REST" maintainers) > > Hi Dirk, > > On 22/06/16 12:49, Dirk Behme wrote: > >The two struct members baud and clock_hz are in the end read only > >variables nowhere used for anything useful. Removing them makes > >the code muc

Re: [Xen-devel] [PATCH v3] xen: arm: Update arm64 image header

2016-06-23 Thread Julien Grall
Hi Dirk, On 23/06/16 07:38, Dirk Behme wrote: With the Linux kernel commits https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/

Re: [Xen-devel] [PATCH 00/11] hvmctl hypercall

2016-06-23 Thread Andrew Cooper
On 20/06/16 13:39, Jan Beulich wrote: > A long while back separating out all control kind operations (intended > for use by only the control domain or device model) from the currect > hvmop hypercall has been discussed. This series aims at finally making > this reality (at once allowing to streamli

Re: [Xen-devel] [PATCH 11/11] x86/HVM: serialize trap injecting producer and consumer

2016-06-23 Thread Andrew Cooper
On 20/06/16 13:58, Jan Beulich wrote: > Since injection works on a remote vCPU, and since there's no > enforcement of the subject vCPU being paused, there's a potential race > between the prodcing and consuming sides. Fix this by leveraging the producing. > vector field as synchronization variabl

Re: [Xen-devel] [PATCH 0/3] VMX: Properly handle pi descriptor and per-cpu blocking list

2016-06-23 Thread Dario Faggioli
On Thu, 2016-06-23 at 12:33 +, Wu, Feng wrote: > > -Original Message- > > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > >  > > It goes through all the vcpus of all domains, and does not check or > > care whether they are running, runnable or blocked. > > > > Let's look at t

[Xen-devel] [xen-unstable-smoke test] 96177: tolerable all pass - PUSHED

2016-06-23 Thread osstest service owner
flight 96177 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/96177/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

[Xen-devel] [PATCH v4 0/3] Make hvm_fep available to non-debug build

2016-06-23 Thread Wei Liu
Wei Liu (3): xen: add warning infrastructure console: use warning infrastructure for sync console warning xen: make available hvm_fep to non-debug build as well docs/misc/xen-command-line.markdown | 8 -- xen/arch/x86/Kconfig| 17 xen/arch/x86/hvm/hvm.c

Re: [Xen-devel] [PATCH 01/11] public / x86: introduce hvmctl hypercall

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 16:55, wrote: > On 20/06/16 13:52, Jan Beulich wrote: >> +/* >> + * Note that this value is effectively part of the ABI, even if we don't > need >> + * to make it a formal part of it. Hence this value may only be changed if >> + * accompanied by a suitable interface version in

[Xen-devel] [PATCH v4 2/3] console: use warning infrastructure for sync console warning

2016-06-23 Thread Wei Liu
Move the warning text to a static variable and marked that as initconst data. Call warning_add in console_init_preirq. Finally remove all unused bits. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper v4: 1. Fix declaration of warning_sync_console. 2. Remove all asterisks in warning

Re: [Xen-devel] [PATCH v3 2/2] xen/arm: drivers: scif: Don't overwrite firmware settings

2016-06-23 Thread Julien Grall
Hi Dirk, On 22/06/16 12:49, Dirk Behme wrote: Besides the 14MHz external clock, the SCIF might be clocked by an internal 66MHz clock. If this is the case, the current clock source selection breaks this configuration. Same for the settings done by the firmware for data bits, stop bits and parity.

[Xen-devel] [PATCH v4 1/3] xen: add warning infrastructure

2016-06-23 Thread Wei Liu
Use an array to keep track of warning text, provide a function to add warning text to track. Print warnings (if any) in console_endboot. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper v4: 1. Fix __initdata annotation. 2. Move warning_print to console_endboot. 3. Use obj-bin-y in

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Andrew Cooper
On 23/06/16 15:59, Marek Marczykowski-Górecki wrote: > On Thu, Jun 23, 2016 at 03:12:04PM +0100, Andrew Cooper wrote: >> On 23/06/16 14:25, Marek Marczykowski-Górecki wrote: >>> On Thu, Jun 23, 2016 at 03:46:46AM -0600, Jan Beulich wrote: >>> On 23.06.16 at 11:23, wrote: > On Thu, Jun 23,

Re: [Xen-devel] [PATCH] xen/arm: domain_build: DT: add clocks node to the hypervisor node

2016-06-23 Thread Julien Grall
On 22/06/16 16:58, Julien Grall wrote: On 21/06/16 11:15, Dirk Behme wrote: +printk("Failed to remember the clock node of %s\n", path); +printk("Use the Linux kernel command 'clk_ignore_unused'\n"); +return 0; I don't think this is tolerable. We need to fix

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Daniel De Graaf
On 06/23/2016 09:25 AM, Marek Marczykowski-Górecki wrote: [...] Ok, after drawing a flowchart of the control in this function after your change, on a piece of paper, this case looks fine. But depending on how the domain was found (explicit loop or rcu_lock_domain_by_id), different locks are held,

Re: [Xen-devel] [PATCH v2 07/17] libxl/arm: Construct ACPI GTDT table

2016-06-23 Thread Stefano Stabellini
On Thu, 23 Jun 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Construct GTDT table with the interrupt information of timers. > > Signed-off-by: Shannon Zhao > --- > tools/libxl/libxl_arm_acpi.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/tools/li

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Marek Marczykowski-Górecki
On Thu, Jun 23, 2016 at 03:12:04PM +0100, Andrew Cooper wrote: > On 23/06/16 14:25, Marek Marczykowski-Górecki wrote: > > On Thu, Jun 23, 2016 at 03:46:46AM -0600, Jan Beulich wrote: > > On 23.06.16 at 11:23, wrote: > >>> On Thu, Jun 23, 2016 at 11:18:24AM +0200, Marek Marczykowski-Górecki >

Re: [Xen-devel] [PATCH v3 6/8] xen: Use the typesafe mfn and gfn in map_mmio_regions...

2016-06-23 Thread Julien Grall
On 23/06/16 15:15, Stefano Stabellini wrote: On Thu, 23 Jun 2016, Julien Grall wrote: On 23/06/16 15:05, Stefano Stabellini wrote: diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index aa4e774..47cb383 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1245,27 +1245,27 @@ int unm

Re: [Xen-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-23 Thread Gerd Hoffmann
Hi, > How could xen_ram_init() find out if the value of max-ram-below-4g is > the default or if a user have set it? Is there another way we could fix > this? Attached patch should fix it. Patch survived a quick smoke test on kvm so far, need to do some more testing tomorrow. Can you give it a

Re: [Xen-devel] [PATCH 01/11] public / x86: introduce hvmctl hypercall

2016-06-23 Thread Andrew Cooper
On 20/06/16 13:52, Jan Beulich wrote: > +/* > + * Note that this value is effectively part of the ABI, even if we don't need > + * to make it a formal part of it. Hence this value may only be changed if > + * accompanied by a suitable interface version increase. > + */ > +#define HVMCTL_iter_shift

Re: [Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

2016-06-23 Thread Stefano Stabellini
On Thu, 23 Jun 2016, Shannon Zhao wrote: > From: Shannon Zhao > > It uses static DSDT table like the way x86 uses. Currently the DSDT > table only contains processor device objects and it generates the > maximal objects which so far is 128. > > Signed-off-by: Shannon Zhao > --- > tools/libxl/M

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 15:25, wrote: > On Thu, Jun 23, 2016 at 03:46:46AM -0600, Jan Beulich wrote: >> >>> On 23.06.16 at 11:23, wrote: >> > On Thu, Jun 23, 2016 at 11:18:24AM +0200, Marek Marczykowski-Górecki wrote: >> >> On Thu, Jun 23, 2016 at 03:12:47AM -0600, Jan Beulich wrote: >> >> > >>> On 23

Re: [Xen-devel] [PATCH v5 02/14] libxc: Prepare a start info structure for hvmloader

2016-06-23 Thread Boris Ostrovsky
On 06/22/2016 01:15 PM, Anthony PERARD wrote: > ... and load BIOS/UEFI firmware into guest memory. > > This adds a new firmware module, system_firmware_module. It is loaded in > the guest memory and final location is provided to hvmloader via the > hvm_start_info struct. > > This patch create the h

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-06-23 Thread Shannon Zhao
On 2016年06月23日 21:39, Stefano Stabellini wrote: > On Thu, 23 Jun 2016, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > Add a configuration option for ARM DomU so that user can deicde to use >> > ACPI or not. This option is defaultly false. >> > >> > Signed-off-by: Shannon Zhao >> > --- >>

Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall"

2016-06-23 Thread Daniel De Graaf
On 06/23/2016 04:39 AM, Jan Beulich wrote: On 23.06.16 at 10:32, wrote: On 22.06.16 at 20:24, wrote: Either method works, and I agree allowing DM to invoke this domctl is both useful and not going to introduce problems. The getdomaininfo permission will also need to be added to the device_mo

Re: [Xen-devel] [PATCH v2] ArmVirtPkg/ArmVirtXen: Add ACPI support for Virt Xen ARM

2016-06-23 Thread Shannon Zhao
On 2016年06月23日 21:42, Ard Biesheuvel wrote: > On 23 June 2016 at 13:31, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Add ACPI support for Virt Xen ARM and only for aarch64. It gets the >> ACPI tables through Xen ARM multiboot protocol. >> >> Contributed-under: TianoCore Contribution Agreement

Re: [Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-23 Thread Stefano Stabellini
On Thu, 23 Jun 2016, Shannon Zhao wrote: > On 2016年06月23日 21:37, Stefano Stabellini wrote: > > On Thu, 23 Jun 2016, Shannon Zhao wrote: > >> + > >> +if (strcmp(dom->guest_type, "xen-3.0-aarch64")) { > >> +LOG(DEBUG, "Do not generate ACPI tables for %s", dom->guest_type); > >> +s

  1   2   >