On 23/06/16 17:00, Jan Beulich wrote: >>>> On 21.06.16 at 18:59, <andrew.coop...@citrix.com> wrote: >> --- a/xen/include/xen/init.h >> +++ b/xen/include/xen/init.h >> @@ -86,10 +86,11 @@ struct kernel_param { >> void *var; >> }; >> >> -extern struct kernel_param __setup_start, __setup_end; >> +extern const struct kernel_param __setup_start[], __setup_end[]; >> >> -#define __setup_str static __initdata __attribute__((__aligned__(1))) char >> -#define __kparam static __initsetup \ >> +#define __setup_str static const __initconstrel \ >> + __attribute__((__aligned__(1))) char > This slipped my attention during review, but causes build failure > with some gcc versions now: Why __initconstrel rather than > __initconst?
Because this was previously __initconst and you reverted it for breaking on older GCC. Message ID <56cb470e02000078000d4...@prv-mh.provo.novell.com> I can't replicate any build failures with any GCC or clang combination to hand. Are you able to find some solution which GCC is happy with? ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel