[Xen-devel] [xen-unstable test] 60076: regressions - FAIL

2015-07-28 Thread osstest service owner
flight 60076 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/60076/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 59817 test-armhf-armhf-xl-

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-28 Thread Juergen Gross
On 07/28/2015 06:17 PM, Dario Faggioli wrote: On Tue, 2015-07-28 at 17:11 +0200, Juergen Gross wrote: On 07/28/2015 06:29 AM, Juergen Gross wrote: I'll make some performance tests on a big machine (4 sockets, 60 cores, 120 threads) regarding topology information: - bare metal - "random" topo

[Xen-devel] [ovmf test] 60026: regressions - FAIL

2015-07-28 Thread osstest service owner
flight 60026 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/60026/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 11 guest-saverestore fail REGR. vs. 59964 version targeted for testing

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 8:01 PM, Boris Ostrovsky wrote: > On 07/28/2015 08:47 PM, Andrew Cooper wrote: >> >> On 29/07/2015 01:21, Andy Lutomirski wrote: >>> >>> On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky >>> wrote: On 07/28/2015 01:07 PM, Andy Lutomirski wrote: > > On Tue

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 8:01 PM, Boris Ostrovsky wrote: > On 07/28/2015 08:47 PM, Andrew Cooper wrote: >> >> On 29/07/2015 01:21, Andy Lutomirski wrote: >>> >>> On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky >>> wrote: On 07/28/2015 01:07 PM, Andy Lutomirski wrote: > > On Tue

[Xen-devel] [linux-3.16 bisection] complete test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm

2015-07-28 Thread osstest service owner
branch xen-unstable xen branch xen-unstable job test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm test guest-saverestore Tree: linux git://kernel.ubuntu.com/ubuntu/linux.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/staging/qemu-xen-un

Re: [Xen-devel] Xen Project Document Day is this Wednesday July 29

2015-07-28 Thread Russ Pavlicek
Xen Project Document Day is here! Join us as we seek to make our Wiki more accurate and useful! On Mon, Jul 27, 2015 at 11:52 PM, Russ Pavlicek wrote: > Our next Xen Project Document Day is this Wednesday, July 29! > > Our THEME OF THE MONTH: "The Reverse Yard Sale" > > For many of us in the nor

[Xen-devel] [ovmf bisection] complete test-amd64-i386-xl-qemuu-ovmf-amd64

2015-07-28 Thread osstest service owner
branch xen-unstable xen branch xen-unstable job test-amd64-i386-xl-qemuu-ovmf-amd64 test guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbit

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Boris Ostrovsky
On 07/28/2015 08:47 PM, Andrew Cooper wrote: On 29/07/2015 01:21, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky wrote: On 07/28/2015 01:07 PM, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper wrote: I suspect that the set_ldt(NULL, 0) call has

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Benjamin Herrenschmidt
On Tue, 2015-07-28 at 17:47 -0700, Andy Lutomirski wrote: > Yes, virtio flag. I dislike having a virtio flag at all, but so far > no one has come up with any better ideas. If there was a reliable, > cross-platform mechanism for per-device PCI bus properties, I'd be all > for using that instead.

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andrew Cooper
On 29/07/2015 01:21, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky > wrote: >> On 07/28/2015 01:07 PM, Andy Lutomirski wrote: >>> On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper >>> wrote: I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before xen

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 5:36 PM, Benjamin Herrenschmidt wrote: > On Tue, 2015-07-28 at 16:33 -0700, Andy Lutomirski wrote: >> On Tue, Jul 28, 2015 at 4:21 PM, Benjamin Herrenschmidt >> wrote: >> > On Tue, 2015-07-28 at 15:43 -0700, Andy Lutomirski wrote: >> >> Let me try to summarize a proposal:

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Benjamin Herrenschmidt
On Tue, 2015-07-28 at 16:33 -0700, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 4:21 PM, Benjamin Herrenschmidt > wrote: > > On Tue, 2015-07-28 at 15:43 -0700, Andy Lutomirski wrote: > >> Let me try to summarize a proposal: > >> > >> Add a feature flag that indicates IOMMU support. > >> > >> N

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky wrote: > On 07/28/2015 01:07 PM, Andy Lutomirski wrote: >> >> On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper >> wrote: >>> >>> I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before >>> xen_free_ldt() is attempting to nab back the page

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 4:21 PM, Benjamin Herrenschmidt wrote: > On Tue, 2015-07-28 at 15:43 -0700, Andy Lutomirski wrote: >> Let me try to summarize a proposal: >> >> Add a feature flag that indicates IOMMU support. >> >> New kernels acknowledge that flag on any device that advertises it. >> >> N

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Benjamin Herrenschmidt
On Tue, 2015-07-28 at 15:43 -0700, Andy Lutomirski wrote: > Let me try to summarize a proposal: > > Add a feature flag that indicates IOMMU support. > > New kernels acknowledge that flag on any device that advertises it. > > New kernels always respect the IOMMU (except on PowerPC). Why ? I disa

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
Let me try to summarize a proposal: Add a feature flag that indicates IOMMU support. New kernels acknowledge that flag on any device that advertises it. New kernels always respect the IOMMU (except on PowerPC). New kernels optionally refuse to talk to devices that don't have that feature flag i

[Xen-devel] [PATCH for-4.6 6/8] tools/libxl: Prepare to write multiple records with EMULATOR headers

2015-07-28 Thread Andrew Cooper
With the newly specified EMULATOR_XENSTORE_DATA record, there are two libxl records with an emulator subheader. Refactor the existing code to make future additions easier. * Calculate the subheader at stream start time, rather than on the fly. Its contents are not going to change. * Introduce a

[Xen-devel] [PATCH for-4.6 7/8] libxl/save&restore&convert: Switch to new EMULATOR_XENSTORE_DATA records

2015-07-28 Thread Andrew Cooper
Read and write "toolstack" information using the new EMULATOR_XENSTORE_DATA record, and have the conversion script take care of the old format. The entire libxc and libxl migration v2 streams are now bitness-neutral in their records. Signed-off-by: Andrew Cooper --- CC: Ian Campbell CC: Ian Jac

[Xen-devel] [linux-4.1 bisection] complete test-amd64-i386-xl

2015-07-28 Thread osstest service owner
branch xen-unstable xen branch xen-unstable job test-amd64-i386-xl test guest-saverestore Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstab

[Xen-devel] [PATCH for-4.6 8/8] tools/libxl: Drop all legacy "toolstack" record infrastructure

2015-07-28 Thread Andrew Cooper
No functional change. It is not used any more. Signed-off-by: Andrew Cooper --- CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/libxl_dom.c | 223 -- tools/libxl/libxl_internal.h |4 - tools/libxl/libxl_sr_stream_format.h

[Xen-devel] [PATCH for-4.6 4/8] docs/libxl: Re-specify XENSTORE_DATA as EMULATOR_XENSTORE_DATA

2015-07-28 Thread Andrew Cooper
The legacy "toolstack" record as implemented in libxl turns out not to be 32/64bit safe. As migration v2 has not shipped yet, take this opportunity to adjust the specification and fix the incompatibility. Libxl shall loose all knowledge of the old "toolstack" blob and use this EMULATOR_XENSTORE_D

[Xen-devel] [PATCH for-4.6 2/8] tools/libxl: Assert that libxl__ao_inprogress_gc() is not called with NULL

2015-07-28 Thread Andrew Cooper
libxl__ao_inprogress_gc() is hidden behind various macros used to construct local variables. Assert() that NULL is not passed, to make such an error very obvious, rather than a plain segfault at 0. No functional change. Signed-off-by: Andrew Cooper --- CC: Ian Campbell CC: Ian Jackson CC: Wei

[Xen-devel] [PATCH for-4.6 5/8] tools/libxl: Save and restore EMULATOR_XENSTORE_DATA content

2015-07-28 Thread Andrew Cooper
The new EMULATOR_XENSTORE_DATA content is a sequence of NUL terminated key/value strings, with the key relative to the device model's xenstore tree. A sample might look like (as decoded by verify-stream-v2): Emulator Xenstore Data (Qemu Upstream, idx 0) 'physmap/1f0/start_addr' = 'f

[Xen-devel] [PATCH for-4.6 0/8] Fix libxl TOOLSTACK records for migration v2

2015-07-28 Thread Andrew Cooper
The libxl blob for toolstack records was not 32/64bit safe. In 64bit builds, it had an extra 4 bytes of padding due to alignment, and because of the pointer arithmatic used to build it, leaked 4 bytes of libxl heap into the stream. Respecify XENSTORE_DATA as EMULATOR_XENSTORE_DATA and take remedi

[Xen-devel] [PATCH for-4.6 3/8] tools/libxl: Make libxl__conversion_helper_abort() safe to use

2015-07-28 Thread Andrew Cooper
STATE_AO_GC(chs->ao) uses chs->ao before determining whether the helper is active. In the case that the helper has not been started, its ao will not have been set up. Signed-off-by: Andrew Cooper --- CC: Ian Campbell CC: Ian Jackson CC: Wei Liu IMO, this is better than the alternative of req

[Xen-devel] [PATCH for-4.6 1/8] tools/libxl: Only continue stream operations if the stream is still in progress

2015-07-28 Thread Andrew Cooper
Part of the callback contract with check_all_finished() is that each running parallel task shall call it exactly once. Previously, it was possible for stream_continue() or write_toolstack_record() to fail and call into check_all_finished(). As the save helpers callback has fired, it no longer cou

[Xen-devel] [libvirt test] 60058: tolerable all pass - PUSHED

2015-07-28 Thread osstest service owner
flight 60058 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/60058/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt 12 migrate-sup

Re: [Xen-devel] xen-unstabel + linux 4.2: MMIO emulation failed: d23v0 64bit @ 0010:ffffffff814e2b1c -> 66 89 02 48 8d 55 c0 48 89 5d c0 44 89 65 c8 e8

2015-07-28 Thread linux
On 2015-07-27 16:07, Andrew Cooper wrote: On 24/07/15 19:56, li...@eikelenboom.it wrote: Hi All, On my AMD system running xen-unstable (last commit: ), after a few restarts of a HVM guest with pci-passthrough i got these on shutdown of the guest: (never seen this before, so it should be someth

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 12:33 PM, Jan Kiszka wrote: > On 2015-07-28 21:24, Andy Lutomirski wrote: >> On Tue, Jul 28, 2015 at 12:06 PM, Jan Kiszka wrote: >>> On 2015-07-28 20:22, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 10:17 AM, Jan Kiszka wrote: > On 2015-07-28 19:10, Andy

Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Andrew Cooper
On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is because

Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread H. Peter Anvin
On 07/28/2015 08:02 AM, Julien Grall wrote: > Hi all, > > This patch series aims to use the memory terminologies described in > include/linux/mm.h [1] for Linux xen code. > > Linux is using mistakenly MFN when GFN is meant, I suspect this is because the > first support of Xen was for PV. This has

Re: [Xen-devel] [PATCH v5 4/4] x86/ldt: Make modify_ldt optional

2015-07-28 Thread Willy Tarreau
On Tue, Jul 28, 2015 at 01:42:20PM -0700, Kees Cook wrote: > On Tue, Jul 28, 2015 at 1:03 PM, Willy Tarreau wrote: > > Hi Kees, > > > > On Tue, Jul 28, 2015 at 09:56:12AM -0700, Kees Cook wrote: > >> I look forward to the runtime disabling patch. :) > > > > Did you get my response to your comments

Re: [Xen-devel] [PATCH v5 4/4] x86/ldt: Make modify_ldt optional

2015-07-28 Thread Kees Cook
On Tue, Jul 28, 2015 at 1:03 PM, Willy Tarreau wrote: > Hi Kees, > > On Tue, Jul 28, 2015 at 09:56:12AM -0700, Kees Cook wrote: >> I look forward to the runtime disabling patch. :) > > Did you get my response to your comments regarding the proposed patch ? > > I can rebase it and update it if need

Re: [Xen-devel] [PATCH v5 4/4] x86/ldt: Make modify_ldt optional

2015-07-28 Thread Willy Tarreau
Hi Kees, On Tue, Jul 28, 2015 at 09:56:12AM -0700, Kees Cook wrote: > I look forward to the runtime disabling patch. :) Did you get my response to your comments regarding the proposed patch ? I can rebase it and update it if needed, I just want to make sure everyone's on the same line regarding

[Xen-devel] Second regression due to libxl: Remove linux udev rules (2ba368d13893402b2f1fb3c283ddcc714659dd9b)

2015-07-28 Thread Konrad Rzeszutek Wilk
Hey, I launch a bunch of guests at the same time or in parallel and the scripts end up timing out with: Parsing config from //g-vm8.cfg WARNING: you seem to be using "kernel" directive to override HVM guest firmware. Ignore that. Use "firmware_override" instead if you really want a non-defaul

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Chris (Christopher) Brand
> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is > meant, > I suspect this is because the first support for Xen was for PV. This brough > some Typo : "brought" Perhaps "resulted in" would be better ? > misimplementation of helpers on ARM and make the developper confused

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Jan Kiszka
On 2015-07-28 21:24, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 12:06 PM, Jan Kiszka wrote: >> On 2015-07-28 20:22, Andy Lutomirski wrote: >>> On Tue, Jul 28, 2015 at 10:17 AM, Jan Kiszka wrote: On 2015-07-28 19:10, Andy Lutomirski wrote: > The trouble is that this is really a prop

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 12:06 PM, Jan Kiszka wrote: > On 2015-07-28 20:22, Andy Lutomirski wrote: >> On Tue, Jul 28, 2015 at 10:17 AM, Jan Kiszka wrote: >>> On 2015-07-28 19:10, Andy Lutomirski wrote: The trouble is that this is really a property of the bus and not of the device. If yo

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Boris Ostrovsky
On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior.

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Jan Kiszka
On 2015-07-28 20:22, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 10:17 AM, Jan Kiszka wrote: >> On 2015-07-28 19:10, Andy Lutomirski wrote: >>> The trouble is that this is really a property of the bus and not of >>> the device. If you build a virtio device that physically plugs into a >>> PC

Re: [Xen-devel] [PATCH v5 10/22] xen/arm: ITS: Add GITS registers emulation

2015-07-28 Thread Julien Grall
Hi Vijay, On 27/07/15 12:11, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Emulate GITS* registers > > Signed-off-by: Vijaya Kumar K > --- > v4: - Removed GICR register emulation > --- > xen/arch/arm/irq.c|3 + > xen/arch/arm/vgic-v3-its.c| 365 > +

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 10:17 AM, Jan Kiszka wrote: > On 2015-07-28 19:10, Andy Lutomirski wrote: >> The trouble is that this is really a property of the bus and not of >> the device. If you build a virtio device that physically plugs into a >> PCIe slot, the device has no concept of an IOMMU in

Re: [Xen-devel] [PATCH v5 09/22] xen/arm: ITS: Export ITS info to Virtual ITS

2015-07-28 Thread Julien Grall
Hi Vijay, On 27/07/15 12:11, vijay.kil...@gmail.com wrote: > diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c > index aa4d3c5..e16fa03 100644 > --- a/xen/arch/arm/gic-v3-its.c > +++ b/xen/arch/arm/gic-v3-its.c > @@ -94,6 +94,7 @@ static LIST_HEAD(its_nodes); > static DEFINE_SPIN

Re: [Xen-devel] [PATCH v5 08/22] xen/arm: ITS: Add virtual ITS commands support

2015-07-28 Thread Julien Grall
Hi Vijay, On 27/07/15 12:11, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Add Virtual ITS command processing support to Virtual ITS driver > > Signed-off-by: Vijaya Kumar K > --- > v5: - Rename vgic_its_*() to vits_*() The changelog seems very small compared to the amount of discu

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 19:19, Jan Kiszka wrote: > On 2015-07-28 19:15, Paolo Bonzini wrote: >> >> >> On 28/07/2015 18:42, Jan Kiszka wrote: On the other hand interrupt remapping is absolutely necessary for production use, hence my point that x86 does not promise API stability. >>> >>> Well, we c

Re: [Xen-devel] Xen master hangs

2015-07-28 Thread Konrad Rzeszutek Wilk
On Tue, Jul 28, 2015 at 11:27:57AM -0500, Doug Goldstein wrote: > On Tue, Jul 28, 2015 at 10:01 AM, Konrad Rzeszutek Wilk > wrote: > > On Tue, Jul 28, 2015 at 09:30:59AM -0500, Doug Goldstein wrote: > >> On Mon, Jul 27, 2015 at 4:11 PM, Doug Goldstein wrote: > >> > On Mon, Jul 27, 2015 at 4:55 AM

Re: [Xen-devel] [PATCH] xen: allow 8bit input in Xen serial console

2015-07-28 Thread Andrew Cooper
On 28/07/15 18:02, Manfred Haertel wrote: > The Xen serial console cuts off the most significant bit from input > characters, so you can't use e.g. German umlauts when logging in to > the DOM0 Linux system from the serial console. > > The following patch fixes that problem. Thanks for the submissi

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Jan Kiszka
On 2015-07-28 19:15, Paolo Bonzini wrote: > > > On 28/07/2015 18:42, Jan Kiszka wrote: >>> On the other hand interrupt remapping is absolutely necessary for >>> production use, hence my point that x86 does not promise API stability. >> >> Well, we currently implement the features that the Q35 use

Re: [Xen-devel] [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: > The privcmd code is mixing the usage of GFN and MFN within the same > functions which make the code difficult to understand when you only work > with auto-translated guests. > > The privcmd driver is only dealing with GFN so replace all the mention > of MFN

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Boris Ostrovsky
On 07/28/2015 01:07 PM, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper wrote: I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before xen_free_ldt() is attempting to nab back the pages which Xen still has mapped as an LDT. I just instrumented it with yet more

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Jan Kiszka
On 2015-07-28 19:10, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 9:44 AM, Jan Kiszka wrote: >> The ability to have virtio on systems with IOMMU in place makes testing >> much more efficient for us. Ideally, we would have it in non-identity >> mapping scenarios as well, e.g. to start secondary

Re: [Xen-devel] [PATCH 7/8] hvc/xen: Further s/MFN/GFN clean-up

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: > HVM_PARAM_CONSOLE_PFN is used to retrieved the console PFN for HVM > guest. It returns a PFN (aka GFN) and not a MFN. > > Furthermore, use directly virt_to_gfn for both PV and HVM domain rather > than doing a special case for each of the them. Reviewed-by:

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN > is meant, I suspect this is because the first support for Xen was for > PV. This brough some misimplementation of helpers on ARM and make the > developper confused the expected behavior.

Re: [Xen-devel] [PATCH 6/8] video/xen-fbfront: Further s/MFN/GFN clean-up

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: > The PV driver xen-fbfront is only dealing with GFN and not MFN. Rename > all the occurence of MFN to GFN. > > Also take the opportunity to replace to usage of pfn_to_gfn by > page_to_pfn. Reviewed-by: David Vrabel David _

Re: [Xen-devel] [PATCH v5 07/22] xen/arm: ITS: Add virtual ITS driver

2015-07-28 Thread Julien Grall
Hi Vijay, On 27/07/15 12:11, vijay.kil...@gmail.com wrote: > diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c > new file mode 100644 > index 000..60f8332 > --- /dev/null > +++ b/xen/arch/arm/vgic-v3-its.c > +static int vits_access_guest_table(struct domain *d, paddr_t entry

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 18:42, Jan Kiszka wrote: > > On the other hand interrupt remapping is absolutely necessary for > > production use, hence my point that x86 does not promise API stability. > > Well, we currently implement the features that the Q35 used to expose. > Adding interrupt remapping will re

Re: [Xen-devel] [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress

2015-07-28 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress"): > check_all_finished() must only ever be called once for each started > task. Having > > if ( inuse ) > continue() > else > check_all_finished() > > will

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-28 Thread Dario Faggioli
On Tue, 2015-07-28 at 18:17 +0200, Dario Faggioli wrote: > So, my test box looks like this: > cpu_topology : > cpu:coresocket node > 0: 010 > 1: 010 > 2: 110 > 3: 110 > 4:

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 9:44 AM, Jan Kiszka wrote: > The ability to have virtio on systems with IOMMU in place makes testing > much more efficient for us. Ideally, we would have it in non-identity > mapping scenarios as well, e.g. to start secondary Linux instances in > the test VMs, giving them t

Re: [Xen-devel] Dom0 crash with apache bench (ab)

2015-07-28 Thread Christoffer Dall
On Tue, Jul 28, 2015 at 4:55 PM, Ian Campbell wrote: > On Tue, 2015-07-28 at 10:50 -0400, Konrad Rzeszutek Wilk wrote: > > On Tue, Jul 28, 2015 at 03:09:31PM +0200, Christoffer Dall wrote: > > > Hi, > > > > > > I've been doing some performance comparisons lately, and wanted to > > > compare > > >

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper wrote: > I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before > xen_free_ldt() is attempting to nab back the pages which Xen still has > mapped as an LDT. > I just instrumented it with yet more LSL instructions. I'm pretty sure that se

[Xen-devel] [PATCH] xen: allow 8bit input in Xen serial console

2015-07-28 Thread Manfred Haertel
The Xen serial console cuts off the most significant bit from input characters, so you can't use e.g. German umlauts when logging in to the DOM0 Linux system from the serial console. The following patch fixes that problem. --- xen/drivers/char/serial.c.orig 2015-07-28 18:44:49.443889719 +

Re: [Xen-devel] [PATCH v5 4/4] x86/ldt: Make modify_ldt optional

2015-07-28 Thread Kees Cook
On Mon, Jul 27, 2015 at 10:29 PM, Andy Lutomirski wrote: > The modify_ldt syscall exposes a large attack surface and is > unnecessary for modern userspace. Make it optional. > > Signed-off-by: Andy Lutomirski Reviewed-by: Kees Cook > --- > arch/x86/Kconfig | 17

Re: [Xen-devel] [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress

2015-07-28 Thread Andrew Cooper
On 28/07/15 16:59, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH v2 for-4.6 3/3] tools/libxl: Only continue > stream operations if the stream is still in progress"): >> On 28/07/15 16:12, Ian Jackson wrote: >>> What do you think about putting the inuse check in stream_continue ? >> That w

Re: [Xen-devel] [PATCH v5 3/4] selftests/x86, x86/ldt: Add a selftest for modify_ldt

2015-07-28 Thread Kees Cook
On Mon, Jul 27, 2015 at 10:29 PM, Andy Lutomirski wrote: > This tests general modify_ldt behavior (only writes, so far) as > well as synchronous updates via IPI. It fails on old kernels. > > I called this ldt_gdt because I'll add set_thread_area tests to > it at some point. > > Signed-off-by: And

Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-28 Thread Julien Grall
Hi Vijay, On 27/07/15 12:11, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > The linux driver is based on 4.1 with below commit id > > 3ad2a5f57656a14d964b673a5a0e4ab0e583c870 This doesn't include commit 591e5bec13f15feb13fc445b6c9c59954711c4ac "irqchip/gicv3-its: Fix mapping of LPIs

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Jan Kiszka
On 2015-07-28 18:11, Andy Lutomirski wrote: > On Jul 28, 2015 6:11 AM, "Jan Kiszka" wrote: >> >> On 2015-07-28 15:06, Michael S. Tsirkin wrote: >>> On Tue, Jul 28, 2015 at 02:46:20PM +0200, Paolo Bonzini wrote: On 28/07/2015 12:12, Benjamin Herrenschmidt wrote: >>> That is an ex

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Jan Kiszka
On 2015-07-28 18:36, Paolo Bonzini wrote: > On 28/07/2015 15:11, Jan Kiszka wrote: >> >> This doesn't matter much, since the only guests that implement an IOMMU >> in QEMU are (afaik) PPC and x86, and x86 does not yet promise any kind >> of stability. Hmm I think Jan (cc)

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 15:11, Jan Kiszka wrote: >>> >> >>> >> This doesn't matter much, since the only guests that implement an IOMMU >>> >> in QEMU are (afaik) PPC and x86, and x86 does not yet promise any kind >>> >> of stability. >> > >> > Hmm I think Jan (cc) said it was already used out there. > Yes

Re: [Xen-devel] [RFC PATCH v3.1 2/2] xsplice: Add hook for build_id

2015-07-28 Thread Konrad Rzeszutek Wilk
On July 28, 2015 11:51:00 AM EDT, Andrew Cooper wrote: >On 27/07/15 20:20, Konrad Rzeszutek Wilk wrote: >> diff --git a/xen/include/xen/compile.h.in >b/xen/include/xen/compile.h.in >> index 440ecb2..939685e 100644 >> --- a/xen/include/xen/compile.h.in >> +++ b/xen/include/xen/compile.h.in >> @@ -

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andrew Cooper
On 28/07/15 16:43, Andy Lutomirski wrote: > After forward-porting my virtio patches, I got this thing to run on Xen. After several tries, I got: [ 53.985707] [ cut here ] [ 53.986314] kernel BUG at arch/x86/xen/enlighten.c:496! [ 53.98667

Re: [Xen-devel] Xen master hangs

2015-07-28 Thread Doug Goldstein
On Tue, Jul 28, 2015 at 10:01 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Jul 28, 2015 at 09:30:59AM -0500, Doug Goldstein wrote: >> On Mon, Jul 27, 2015 at 4:11 PM, Doug Goldstein wrote: >> > On Mon, Jul 27, 2015 at 4:55 AM, Andrew Cooper >> > wrote: >> >> On 24/07/15 17:52, Doug Goldstein wrote

[Xen-devel] [PATCH for-4.6 v3] libxlu: properly free buffer in PCI related functions

2015-07-28 Thread Wei Liu
Free buffer in both success and failure paths. Signed-off-by: Wei Liu --- tools/libxl/libxlu_pci.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxlu_pci.c b/tools/libxl/libxlu_pci.c index 026413b..2cd793d 100644 --- a/tools/libxl/libxlu_pci.c +++ b

[Xen-devel] [PATCH for-4.6 v3] tools: fix inspired by Coverity scan

2015-07-28 Thread Wei Liu
Wei Liu (1): libxlu: properly free buffer in PCI related functions tools/libxl/libxlu_pci.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.1.4 ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-28 Thread Dario Faggioli
On Tue, 2015-07-28 at 17:11 +0200, Juergen Gross wrote: > On 07/28/2015 06:29 AM, Juergen Gross wrote: > > I'll make some performance tests on a big machine (4 sockets, 60 cores, > > 120 threads) regarding topology information: > > > > - bare metal > > - "random" topology (like today) > > - "simpl

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Andy Lutomirski
On Jul 28, 2015 6:11 AM, "Jan Kiszka" wrote: > > On 2015-07-28 15:06, Michael S. Tsirkin wrote: > > On Tue, Jul 28, 2015 at 02:46:20PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 28/07/2015 12:12, Benjamin Herrenschmidt wrote: > > That is an experimental feature (it's x-iommu), so it can cha

Re: [Xen-devel] [PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-07-28 Thread Julien Grall
Hi David, On 28/07/15 16:52, David Vrabel wrote: > On 28/07/15 16:02, Julien Grall wrote: >> >> +/* Pseudo-physical <-> DMA conversion */ >> +static inline unsigned long pfn_to_dfn(unsigned long pfn) > > Use BFN for bus frame number. This is the terminology that is used in > the (proposed) pv-io

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Boris Ostrovsky
On 07/28/2015 11:23 AM, Andrew Cooper wrote: On 28/07/15 15:50, Boris Ostrovsky wrote: On 07/28/2015 10:35 AM, Andrew Cooper wrote: On 28/07/15 15:05, Boris Ostrovsky wrote: On 07/28/2015 06:29 AM, Andrew Cooper wrote: After forward-porting my virtio patches, I got this thing to run on Xen.

Re: [Xen-devel] [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress

2015-07-28 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress"): > On 28/07/15 16:12, Ian Jackson wrote: > > What do you think about putting the inuse check in stream_continue ? > > That would work on the stream_read side but not

[Xen-devel] [PATCH RFC 0/3] Migration regressions with Xen.

2015-07-28 Thread Anthony PERARD
Hi, We've spotted several regression which prevent migration with Xen using the same version of QEMU or from a previous version of QEMU (tryied with 2.2). Regression have been introduce by at least: - df4b1024526cae3479da3492d6371fd4a7324a03 migration: create new section to store global state -

[Xen-devel] [PATCH RFC 2/3] migration: Fix global state with Xen.

2015-07-28 Thread Anthony PERARD
From: Anthony PERARD When doing migration via the QMP command xen_save_devices_state, the current runstate is not store into the global state section. Also the current runstate is not the one we want on the receiver side. During migration, the Xen toolstack paused QEMU before save the devices st

[Xen-devel] [PATCH RFC 1/3] migration: Fix regretion for xenfv machine.

2015-07-28 Thread Anthony PERARD
From: Anthony PERARD This fix migration from the same QEMU version and from previous QEMU version. >From the global state section, we don't need runstate with Xen. Right now, the way the Xen toolstack knows when QEMU is ready is when QEMU reach "running" runstate. The configuration sectin and t

[Xen-devel] [PATCH RFC 3/3] migration: Add configuration section to vmstate with xen.

2015-07-28 Thread Anthony PERARD
From: Anthony PERARD This adds the configuration section in the vmstate saved by xen_save_devices_state. Signed-off-by: Anthony PERARD --- migration/savevm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index 6071215..b3f605c 100644 --- a/mig

Re: [Xen-devel] [PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: > > +/* Pseudo-physical <-> DMA conversion */ > +static inline unsigned long pfn_to_dfn(unsigned long pfn) Use BFN for bus frame number. This is the terminology that is used in the (proposed) pv-iommu hypercall. David _

Re: [Xen-devel] [RFC PATCH v3.1 2/2] xsplice: Add hook for build_id

2015-07-28 Thread Andrew Cooper
On 27/07/15 20:20, Konrad Rzeszutek Wilk wrote: > diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in > index 440ecb2..939685e 100644 > --- a/xen/include/xen/compile.h.in > +++ b/xen/include/xen/compile.h.in > @@ -10,4 +10,5 @@ > #define XEN_EXTRAVERSION "@@extraversion@@"

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andy Lutomirski
On Jul 28, 2015 3:30 AM, "Andrew Cooper" wrote: > > On 28/07/15 04:16, Andy Lutomirski wrote: > > On Mon, Jul 27, 2015 at 7:20 PM, Andy Lutomirski > > wrote: > >> On Mon, Jul 27, 2015 at 9:18 AM, Boris Ostrovsky > >> wrote: > >>> On 07/27/2015 11:53 AM, Andy Lutomirski wrote: > On Mon, Jul

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Boris Ostrovsky
On 07/28/2015 11:15 AM, Konrad Rzeszutek Wilk wrote: On Tue, Jul 28, 2015 at 10:50:39AM -0400, Boris Ostrovsky wrote: On 07/28/2015 10:35 AM, Andrew Cooper wrote: On 28/07/15 15:05, Boris Ostrovsky wrote: On 07/28/2015 06:29 AM, Andrew Cooper wrote: After forward-porting my virtio patches, I

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Andrew Cooper
On 28/07/15 15:50, Boris Ostrovsky wrote: > On 07/28/2015 10:35 AM, Andrew Cooper wrote: >> On 28/07/15 15:05, Boris Ostrovsky wrote: >>> On 07/28/2015 06:29 AM, Andrew Cooper wrote: >> After forward-porting my virtio patches, I got this thing to run on >> Xen. After several tries, I got:

Re: [Xen-devel] [PATCHv2 05/10] xen/balloon: rationalize memory hotplug stats

2015-07-28 Thread Daniel Kiper
On Fri, Jul 24, 2015 at 12:47:43PM +0100, David Vrabel wrote: > The stats used for memory hotplug make no sense and are fiddled with > in odd ways. Remove them and introduce total_pages to track the total > number of pages (both populated and unpopulated) including those within > hotplugged region

Re: [Xen-devel] [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress

2015-07-28 Thread Andrew Cooper
On 28/07/15 16:12, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH v2 for-4.6 3/3] tools/libxl: Only continue > stream operations if the stream is still in progress"): >> Imagine a scenario whereby some error has occured and >> check_all_finished() has _abort()'ed the tasks, but the save he

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-28 Thread Dario Faggioli
On Tue, 2015-07-28 at 11:05 +0100, Wei Liu wrote: > On Fri, Jul 24, 2015 at 06:05:59PM +0200, Dario Faggioli wrote: > > BTW, I've also been grepping, and I'm not seeing XENMEM_get_vnumainfo > > being called anywhere either... Well, no wonder, we're seeing vNUMA > > setup issues! If I did check for

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

2015-07-28 Thread Konrad Rzeszutek Wilk
On Tue, Jul 28, 2015 at 10:50:39AM -0400, Boris Ostrovsky wrote: > On 07/28/2015 10:35 AM, Andrew Cooper wrote: > >On 28/07/15 15:05, Boris Ostrovsky wrote: > >>On 07/28/2015 06:29 AM, Andrew Cooper wrote: > >After forward-porting my virtio patches, I got this thing to run on > >Xen. After

Re: [Xen-devel] [OSSTEST PATCH 4/4] sg-run-job: Provide infrastructure for layers of nesting

2015-07-28 Thread Ian Jackson
Robert Hu writes ("Re: [OSSTEST PATCH 4/4] sg-run-job: Provide infrastructure for layers of nesting"): > On Tue, 2015-06-30 at 17:36 +0100, Ian Jackson wrote: > > + if {![llength nested_layers_hosts]} break > > The can-not-return issue roots here, [llength nested_layers_hosts] > returns 1, while

Re: [Xen-devel] [OSSTEST PATCH 3/4] sg-run-job: Break out per-host-prep and per-host-finish

2015-07-28 Thread Ian Jackson
Robert Hu writes ("Re: [OSSTEST PATCH 3/4] sg-run-job: Break out per-host-prep and per-host-finish"): > On Tue, 2015-06-30 at 17:36 +0100, Ian Jackson wrote: > > -per-host-ts . =(*) {ts-leak-check basis} > > +per-hosts-prep > > a trivial typo, I think 'per-host-prep' shal

Re: [Xen-devel] [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress

2015-07-28 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v2 for-4.6 3/3] tools/libxl: Only continue stream operations if the stream is still in progress"): > Imagine a scenario whereby some error has occured and > check_all_finished() has _abort()'ed the tasks, but the save helper was > already on the way out, signallin

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-28 Thread Juergen Gross
On 07/28/2015 06:29 AM, Juergen Gross wrote: On 07/27/2015 04:09 PM, Dario Faggioli wrote: On Fri, 2015-07-24 at 18:10 +0200, Juergen Gross wrote: On 07/24/2015 05:58 PM, Dario Faggioli wrote: So, just to check if I'm understanding is correct: you'd like to add an abstraction layer, in Linux

[Xen-devel] [PATCH 3/8] arm/xen: implement correctly pfn_to_mfn

2015-07-28 Thread Julien Grall
After the commit introducing convertion between DMA and guest address, all the callers of pfn_to_mfn are expecting to get a GFN (Guest Frame Number). On ARM, all the guests are auto-translated so the GFN is equal to the Linux PFN (Pseudo-physical Frame Number). The current implementation may retur

[Xen-devel] [PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

2015-07-28 Thread Julien Grall
The swiotlb is required when programming a DMA address on ARM when a device is not protected by an IOMMU. In this case, the DMA address should always be equal to the machine address. For DOM0 memory, Xen ensure it by have an identity mapping between the guest address and host address. However, whe

[Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Julien Grall
Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. Linux is using mistakenly MFN when GFN is meant, I suspect this is because the first support of Xen was for PV. This has brought some misimplementation of memory helpers on ARM a

  1   2   >