[Xen-devel] [PATCH v2 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-21 Thread Bob Liu
There is a bug when migrate from !feature-persistent host to feature-persistent host, because domU still thinks new host/backend doesn't support persistent. Dmesg like: backed has not unmapped grant: 839 backed has not unmapped grant: 773 backed has not unmapped grant: 773 backed has not unmapped g

[Xen-devel] [PATCH v2] xen-blkback: replace work_pending with work_busy in purge_persistent_gnt()

2015-07-21 Thread Bob Liu
The BUG_ON() in purge_persistent_gnt() will be triggered when previous purge work haven't finished. There is a work_pending() before this BUG_ON, but it doesn't account if the work is still currently running. Signed-off-by: Bob Liu --- Change in v2: * Replace with work_busy() --- drivers/block/

[Xen-devel] [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent

2015-07-21 Thread Bob Liu
We should consider info->feature_persistent when adding indriect page to list info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/b

Re: [Xen-devel] PCI Pass-through in Xen ARM - Draft 2.

2015-07-21 Thread Manish Jaggi
On Tuesday 14 July 2015 11:31 PM, Stefano Stabellini wrote: On Tue, 14 Jul 2015, Julien Grall wrote: Hi Stefano, On 14/07/2015 18:46, Stefano Stabellini wrote: Linux provides a function (pci_for_each_dma_alias) which will return a requester ID for a given PCI device. It appears that the BDF

Re: [Xen-devel] [PATCH v6 10/15] x86/altp2m: add remaining support routines.

2015-07-21 Thread Sahita, Ravi
>From: George Dunlap [mailto:george.dun...@citrix.com] >Sent: Tuesday, July 21, 2015 6:19 AM > >On 07/21/2015 12:58 AM, Ed White wrote: >> Add the remaining routines required to support enabling the alternate >> p2m functionality. >> >> Signed-off-by: Ed White >> >> Reviewed-by: Andrew Cooper >>

Re: [Xen-devel] [PATCH v6 05/15] x86/altp2m: basic data structures and support routines.

2015-07-21 Thread Sahita, Ravi
>From: George Dunlap [mailto:george.dun...@citrix.com] >Sent: Tuesday, July 21, 2015 5:47 AM > >On 07/21/2015 11:13 AM, Jan Beulich wrote: > On 21.07.15 at 01:58, wrote: >>> Add the basic data structures needed to support alternate p2m's and >>> the functions to initialise them and tear them d

Re: [Xen-devel] [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/22/2015 12:43 PM, Bob Liu wrote: > > On 07/21/2015 05:25 PM, Roger Pau Monné wrote: >> El 21/07/15 a les 5.30, Bob Liu ha escrit: >>> This BUG_ON() in blkif_free() is incorrect, because indirect page can be >>> added >>> to list info->indirect_pages in blkif_completion() no matter >>> fe

[Xen-devel] [xen-unstable test] 59795: tolerable FAIL

2015-07-21 Thread osstest service owner
flight 59795 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59795/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail in 59772 pass in 59795 test-amd64-i386-xl-qemut-wi

Re: [Xen-devel] [PATCH v2 03/23] x86: zero BSS using stosl instead of stosb

2015-07-21 Thread Jan Beulich
>>> Daniel Kiper 07/21/15 8:23 PM >>> >On Tue, Jul 21, 2015 at 03:37:48AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:28, wrote: >> >> ... because of ??? Nowadays - with X86_FEATURE_ERMS - rep stosb >> is expected to be faster than rep stosl. > >OK, I did not know about that. However, as I

Re: [Xen-devel] [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file

2015-07-21 Thread Jan Beulich
>>> Daniel Kiper 07/21/15 7:24 PM >>> >On Tue, Jul 21, 2015 at 03:35:07AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:28, wrote: >> >> Without any explanation (description) I'm inclined to say this makes >> things more fragile instead of improving the situation. As it looks >> like we inde

Re: [Xen-devel] [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/21/2015 05:25 PM, Roger Pau Monné wrote: > El 21/07/15 a les 5.30, Bob Liu ha escrit: >> This BUG_ON() in blkif_free() is incorrect, because indirect page can be >> added >> to list info->indirect_pages in blkif_completion() no matter >> feature_persistent >> is true or false. >> >> Signed

[Xen-devel] [PATCH] x86/psr: remove invalid cpu_to_socket call

2015-07-21 Thread Chao Peng
cpu_to_socket() can't give correct socket value in CPU_PREPARE notifier as at that time phys_proc_id has not yet been initialized (the value is its default 0 in this case) which is incorrect for sockets other than socket 0. cos_to_cbm now is pre-allocated in CPU_PREPARE notifier and then consumed

Re: [Xen-devel] race condition in xen-gntdev

2015-07-21 Thread Marek Marczykowski-Górecki
On Mon, Jun 29, 2015 at 04:50:10PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Jun 29, 2015 at 10:39:26AM -0400, Konrad Rzeszutek Wilk wrote: > > On Fri, Jun 26, 2015 at 03:28:24AM +0200, Marek Marczykowski-Górecki wrote: > > > On Mon, Jun 22, 2015 at 03:14:16PM -0400, Daniel De Graaf wrote:

[Xen-devel] [xen-4.4-testing test] 59794: tolerable FAIL - PUSHED

2015-07-21 Thread osstest service owner
flight 59794 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59794/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-winxpsp3 15 guest-localmigrate/x10 fail like 59510 test-amd64-i386-libvirt

[Xen-devel] [qemu-upstream-4.5-testing test] 59793: tolerable FAIL - PUSHED

2015-07-21 Thread osstest service owner
flight 59793 qemu-upstream-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59793/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail REGR. vs. 58384 test-amd64-i386-

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 7:04 PM, Boris Ostrovsky wrote: > > > On 07/21/2015 08:49 PM, Andrew Cooper wrote: >> >> On 22/07/2015 01:28, Andy Lutomirski wrote: >>> >>> On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper >>> wrote: On 22/07/2015 01:07, Andy Lutomirski wrote: > > On Tue,

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Boris Ostrovsky
On 07/21/2015 08:49 PM, Andrew Cooper wrote: On 22/07/2015 01:28, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper wrote: On 22/07/2015 01:07, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper wrote: On 21/07/2015 22:53, Boris Ostrovsky wrote: On

[Xen-devel] [v11][PATCH 13/16] libxl: construct e820 map with RDM information for HVM guest

2015-07-21 Thread Tiejun Chen
Here we'll construct a basic guest e820 table via XENMEM_set_memory_map. This table includes lowmem, highmem and RDMs if they exist, and hvmloader would need this info later. Note this guest e820 table would be same as before if the platform has no any RDM or we disable RDM (by default). CC: Ian

[Xen-devel] [v11][PATCH 14/16] xen/vtd: enable USB device assignment

2015-07-21 Thread Tiejun Chen
USB RMRR may conflict with guest BIOS region. In such case, identity mapping setup is simply skipped in previous implementation. Now we can handle this scenario cleanly with new policy mechanism so previous hack code can be removed now. CC: Yang Zhang CC: Kevin Tian Signed-off-by: Tiejun Chen A

[Xen-devel] [v11][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-21 Thread Tiejun Chen
This patch extends the existing hypercall to support rdm reservation policy. We return error or just throw out a warning message depending on whether the policy is "strict" or "relaxed" when reserving RDM regions in pfn space. Note in some special cases, e.g. add a device to hwdomain, and remove a

[Xen-devel] [v11][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Tiejun Chen
While building a VM, HVM domain builder provides struct hvm_info_table{} to help hvmloader. Currently it includes two fields to construct guest e820 table by hvmloader, low_mem_pgend and high_mem_pgend. So we should check them to fix any conflict with RDM. RMRR can reside in address space beyond 4

[Xen-devel] [v11][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-21 Thread Tiejun Chen
Now use the hypervisor-supplied memory map to build our final e820 table: * Add regions for BIOS ranges and other special mappings not in the hypervisor map * Add in the hypervisor supplied regions * Adjust the lowmem and highmem regions if we've had to relocate memory (adding a highmem region

[Xen-devel] [v11][PATCH 09/16] tools: extend xc_assign_device() to support rdm reservation policy

2015-07-21 Thread Tiejun Chen
This patch passes rdm reservation policy to xc_assign_device() so the policy is checked when assigning devices to a VM. Note this also bring some fallout to python usage of xc_assign_device(). CC: Ian Jackson CC: Stefano Stabellini CC: Ian Campbell CC: Wei Liu CC: David Scott Acked-by: Wei L

[Xen-devel] [v11][PATCH 01/16] xen: introduce XENMEM_reserved_device_memory_map

2015-07-21 Thread Tiejun Chen
From: Jan Beulich This is a prerequisite for punching holes into HVM and PVH guests' P2M to allow passing through devices that are associated with (on VT-d) RMRRs. CC: Jan Beulich CC: Yang Zhang CC: Kevin Tian Signed-off-by: Jan Beulich Signed-off-by: Tiejun Chen Acked-by: Kevin Tian --- v

[Xen-devel] [v11][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-21 Thread Tiejun Chen
Try to avoid placing PCI BARs over RMRRs: - If mmio_hole_size is not specified, and the existing MMIO range has RMRRs in it, and there is space to expand the hole in lowmem without moving more memory, then make the MMIO hole as large as possible. - When placing RMRRs, find the next RMRR highe

[Xen-devel] [v11][PATCH 05/16] hvmloader: get guest memory map into memory_map[]

2015-07-21 Thread Tiejun Chen
Now we get this map layout by call XENMEM_memory_map then save them into one global variable memory_map[]. It should include lowmem range, rdm range and highmem range. Note rdm range and highmem range may not exist in some cases. And here we need to check if any reserved memory conflicts with [RES

[Xen-devel] [v11][PATCH 16/16] tools: parse to enable new rdm policy parameters

2015-07-21 Thread Tiejun Chen
This patch parses to enable user configurable parameters to specify RDM resource and according policies which are defined previously, Global RDM parameter: rdm = "strategy=host,policy=strict/relaxed" Per-device RDM parameter: pci = [ 'sbdf, rdm_policy=strict/relaxed' ] Default per-device

[Xen-devel] [v11][PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr

2015-07-21 Thread Tiejun Chen
Currently we're intending to cover this kind of devices with shared RMRR simply since the case of shared RMRR is a rare case according to our previous experiences. But late we can group these devices which shared rmrr, and then allow all devices within a group to be assigned to same domain. CC: Ya

[Xen-devel] [v11][PATCH 12/16] tools: introduce a new parameter to set a predefined rdm boundary

2015-07-21 Thread Tiejun Chen
Previously we always fix that predefined boundary as 2G to handle conflict between memory and rdm, but now this predefined boundar can be changes with the parameter "rdm_mem_boundary" in .cfg file. CC: Ian Jackson CC: Stefano Stabellini CC: Ian Campbell CC: Wei Liu Acked-by: Wei Liu Acked-by:

[Xen-devel] [v11][PATCH 02/16] xen/vtd: create RMRR mapping

2015-07-21 Thread Tiejun Chen
RMRR reserved regions must be setup in the pfn space with an identity mapping to reported mfn. However existing code has problem to setup correct mapping when VT-d shares EPT page table, so lead to problem when assigning devices (e.g GPU) with RMRR reported. So instead, this patch aims to setup ide

[Xen-devel] [v11][PATCH 04/16] xen: enable XENMEM_memory_map in hvm

2015-07-21 Thread Tiejun Chen
This patch enables XENMEM_memory_map in hvm. So hvmloader can use it to setup the e820 mappings. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Tiejun Chen Reviewed-by: Tim Deegan Reviewed-by: Kevin Tian Acked-by: Jan Beulich Acked-by: George Dunlap --- v5 ~ v11: * Nothi

[Xen-devel] [v11][PATCH 00/16] Fix RMRR

2015-07-21 Thread Tiejun Chen
v11: * Rebase on staging * Patch #6: hvmloader/pci: Try to avoid placing BARs in RMRRs To find the lowest RMRR the _end_ of which is higher than base; Refine some code implementations; * Patch #7: hvmloader/e820: construct guest e820 table To check/sync memory_map.map[] before copy them i

[Xen-devel] [v11][PATCH 10/16] tools: introduce some new parameters to set rdm policy

2015-07-21 Thread Tiejun Chen
This patch introduces user configurable parameters to specify RDM resource and according policies, Global RDM parameter: rdm = "strategy=host,policy=strict/relaxed" Per-device RDM parameter: pci = [ 'sbdf, rdm_policy=strict/relaxed' ] Global RDM parameter, "strategy", allows user to speci

[Xen-devel] [v11][PATCH 08/16] tools/libxc: Expose new hypercall xc_reserved_device_memory_map

2015-07-21 Thread Tiejun Chen
We will introduce the hypercall xc_reserved_device_memory_map approach to libxc. This helps us get rdm entry info according to different parameters. If flag == PCI_DEV_RDM_ALL, all entries should be exposed. Or we just expose that rdm entry specific to a SBDF. CC: Ian Jackson CC: Stefano Stabelli

[Xen-devel] [xen-4.5-testing test] 59792: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59792 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59792/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 6 xen-boot fail REGR. vs. 59527 test-amd64-i386-x

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 5:49 PM, Andrew Cooper wrote: > On 22/07/2015 01:28, Andy Lutomirski wrote: >> On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper >> wrote: >>> On 22/07/2015 01:07, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper wrote: > On 21/07/2015 22:5

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andrew Cooper
On 22/07/2015 01:28, Andy Lutomirski wrote: > On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper > wrote: >> On 22/07/2015 01:07, Andy Lutomirski wrote: >>> On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper >>> wrote: On 21/07/2015 22:53, Boris Ostrovsky wrote: > On 07/21/2015 03:59 PM, Andy Lu

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 23:57, Ian Jackson wrote: Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): Sorry, I just ignore the line in brackets since I always think this kind of thing is often not a big deal, and next time I should pay more attention to the ().

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper wrote: > On 22/07/2015 01:07, Andy Lutomirski wrote: >> On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper >> wrote: >>> On 21/07/2015 22:53, Boris Ostrovsky wrote: On 07/21/2015 03:59 PM, Andy Lutomirski wrote: > --- a/arch/x86/include/asm/mmu_

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andrew Cooper
On 22/07/2015 01:07, Andy Lutomirski wrote: > On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper > wrote: >> On 21/07/2015 22:53, Boris Ostrovsky wrote: >>> On 07/21/2015 03:59 PM, Andy Lutomirski wrote: --- a/arch/x86/include/asm/mmu_context.h +++ b/arch/x86/include/asm/mmu_context.h @

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper wrote: > On 21/07/2015 22:53, Boris Ostrovsky wrote: >> On 07/21/2015 03:59 PM, Andy Lutomirski wrote: >>> --- a/arch/x86/include/asm/mmu_context.h >>> +++ b/arch/x86/include/asm/mmu_context.h >>> @@ -34,6 +34,44 @@ static inline void load_mm_cr4(stru

[Xen-devel] [qemu-mainline test] 59791: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59791 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/59791/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 12 guest-saverestore fail REGR. vs. 59059 test-amd64-i386-xl-

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andrew Cooper
On 21/07/2015 22:53, Boris Ostrovsky wrote: > On 07/21/2015 03:59 PM, Andy Lutomirski wrote: >> --- a/arch/x86/include/asm/mmu_context.h >> +++ b/arch/x86/include/asm/mmu_context.h >> @@ -34,6 +34,44 @@ static inline void load_mm_cr4(struct mm_struct >> *mm) {} >> #endif >> /* >> + * ldt_stru

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Boris Ostrovsky
On 07/21/2015 03:59 PM, Andy Lutomirski wrote: modify_ldt has questionable locking and does not synchronize threads. Improve it: redesign the locking and synchronize all threads' LDTs using an IPI on all modifications. This will dramatically slow down modify_ldt in multithreaded programs, but t

[Xen-devel] [linux-3.18 test] 59785: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59785 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 58581 Tests which are failin

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-21 Thread Boris Ostrovsky
On 07/20/2015 10:43 AM, Boris Ostrovsky wrote: On 07/20/2015 10:09 AM, Dario Faggioli wrote: On Fri, 2015-07-17 at 14:17 -0400, Boris Ostrovsky wrote: On 07/17/2015 03:27 AM, Dario Faggioli wrote: In the meanwhile, what should we do? Document this? How? "don't use vNUMA with PV guest in SMT en

[Xen-devel] altp2m: patch 07/15 and 11/15

2015-07-21 Thread Sahita, Ravi
Hi maintainers, While we are sorting through the last 2 to 3 patches that have the main open comments (patch 5,6,10/15), could you please ack patch 07/15 and 11/15 if you are ok with it - all previous comments on those have been addressed (this will allow us to focus on remaining opens). Sorry

[Xen-devel] [linux-linus test] 59789: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59789 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/59789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 5 kernel-build fail REGR. vs. 59254 build-amd64-pvops

Re: [Xen-devel] [PATCH v5 10/15] x86/altp2m: add remaining support routines.

2015-07-21 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Monday, July 20, 2015 11:38 PM > +void p2m_altp2m_propagate_change(struct domain *d, gfn_t gfn, + mfn_t mfn, unsigned int page_order, + p2m_type_t p2mt, p2

Re: [Xen-devel] [PATCH v2 03/23] x86: zero BSS using stosl instead of stosb

2015-07-21 Thread Daniel Kiper
On Tue, Jul 21, 2015 at 03:37:48AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:28, wrote: > > ... because of ??? Nowadays - with X86_FEATURE_ERMS - rep stosb > is expected to be faster than rep stosl. OK, I did not know about that. However, as I know this feature was introduced in 2012 with

Re: [Xen-devel] [PATCH v5 05/15] x86/altp2m: basic data structures and support routines.

2015-07-21 Thread Sahita, Ravi
>From: George Dunlap [mailto:george.dun...@eu.citrix.com] >Sent: Tuesday, July 14, 2015 8:57 AM > >On 07/14/2015 01:14 AM, Ed White wrote: >> Add the basic data structures needed to support alternate p2m's and >> the functions to initialise them and tear them down. >> >> Although Intel hardware can

Re: [Xen-devel] [PATCH OSSTEST v2 03/13] osstest migrate support check catch -> variables

2015-07-21 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH OSSTEST v2 03/13] osstest migrate support check catch -> variables"): > Do I need to change anything in this patch? I guess not? It's not very > clear to me. Ian C was asking whether the patch (which I wrote) was right, in a particular respect. I answered that it is c

[Xen-devel] [PATCH v3] xl: fix vcpus to vnode assignement in config file

2015-07-21 Thread Dario Faggioli
In fact, right now, the following (legitimate) configuration: vcpus = '4' vnuma = [ [ "pnode=0","size=512","vcpus=0,1","vdistances=10,20" ], [ "pnode=1","size=512","vcpus=2,3","vdistances=20,10" ] ] Produces the following error: # xl create /etc/xen/test.cfg Parsing config

Re: [Xen-devel] [PATCH OSSTEST v2 03/13] osstest migrate support check catch -> variables

2015-07-21 Thread Wei Liu
On Tue, Jul 21, 2015 at 05:32:25PM +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH OSSTEST v2 03/13] osstest migrate support > check catch -> variables"): > > On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: > > > @@ -300,7 +300,9 @@ proc run-job/test-pair {} { > > > proc test-guest

Re: [Xen-devel] [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file

2015-07-21 Thread Daniel Kiper
On Tue, Jul 21, 2015 at 03:35:07AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:28, wrote: > > Without any explanation (description) I'm inclined to say this makes > things more fragile instead of improving the situation. As it looks > like we indeed pointlessly copy .eh_frame, but I think th

Re: [Xen-devel] [PATCH OSSTEST v2 08/13] ts-libvirt-build: run libvirt test suite

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 17:22 +0100, Wei Liu wrote: > On Mon, Jul 13, 2015 at 12:25:35PM +0100, Ian Campbell wrote: > > On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: > > > We're interested in xlconfigtest. > > > > > > Signed-off-by: Wei Liu > > > Cc: Ian Campbell > > > Cc: Ian Jackson > > > [

Re: [Xen-devel] [PATCH OSSTEST v2 03/13] osstest migrate support check catch -> variables

2015-07-21 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH OSSTEST v2 03/13] osstest migrate support check catch -> variables"): > On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: > > @@ -300,7 +300,9 @@ proc run-job/test-pair {} { > > proc test-guest-migr {g} { > > -if {[catch { run-ts . = ts-migrate-support-check +

Re: [Xen-devel] [PATCH v2] xl: fix vcpus to vnode assignement in config file

2015-07-21 Thread Dario Faggioli
On Tue, 2015-07-21 at 15:13 +0100, Ian Campbell wrote: > On Mon, 2015-07-20 at 11:30 +0200, Dario Faggioli wrote: > > In fact, right now, if the "vcpus=" list (where the > > user specifies what vcpus should be part of a vnode) > > has multiple elements, things don't work. > > E.g., the following ex

Re: [Xen-devel] [PATCH OSSTEST v2 08/13] ts-libvirt-build: run libvirt test suite

2015-07-21 Thread Wei Liu
On Mon, Jul 13, 2015 at 12:25:35PM +0100, Ian Campbell wrote: > On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: > > We're interested in xlconfigtest. > > > > Signed-off-by: Wei Liu > > Cc: Ian Campbell > > Cc: Ian Jackson > > [...] > > + | tee ../libvirt-test-suite-log > > Should

Re: [Xen-devel] [PATCH OSSTEST v2 09/13] ts-debian-hvm-install: stub out libvirt + ovmf / rombios

2015-07-21 Thread Wei Liu
On Mon, Jul 13, 2015 at 12:27:30PM +0100, Ian Campbell wrote: > On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: > > Libvirt's configuration converter doesn't know how to deal with BIOS > > selection. The end result is it always use the default one (seabios). > > Stub out ovmf and rombios to avoid

Re: [Xen-devel] [PATCH for-4.6 3/3] xen: remove non-POSIX error codes

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 17:56, wrote: > --- a/xen/include/public/errno.h > +++ b/xen/include/public/errno.h > @@ -54,8 +54,6 @@ XEN_ERRNO(EDEADLK, 35) /* Resource deadlock would > occur */ > XEN_ERRNO(ENAMETOOLONG, 36) /* File name too long */ > XEN_ERRNO(ENOLCK,37) /* No recor

Re: [Xen-devel] [PATCH v2] x86/HVM: avoid pointer wraparound in bufioreq handling

2015-07-21 Thread Stefano Stabellini
On Thu, 18 Jun 2015, Jan Beulich wrote: > The number of slots per page being 511 (i.e. not a power of two) means > that the (32-bit) read and write indexes going beyond 2^32 will likely > disturb operation. Extend I/O req server creation so the caller can > indicate that it is using suitable atomic

Re: [Xen-devel] [PATCH OSSTEST v2 06/13] toolstack/libvirt: guest migrate, save and restore support

2015-07-21 Thread Wei Liu
On Mon, Jul 13, 2015 at 12:23:52PM +0100, Ian Campbell wrote: > On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: > > Perhaps the libvirt part of the check_for_command stuff ought to be > moved here? Otherwise we are claiming support before the code is > actually willing to try to do so. I move t

Re: [Xen-devel] [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code

2015-07-21 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code"): > On 21.07.15 at 17:56, wrote: > > PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace > > them with EINVAL and EOVERFLOW respectively. > > Considering that we use

Re: [Xen-devel] [PATCH for-4.6 2/3] xen: replace non-POSIX error codes

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 17:56, wrote: > Some DOMCTLs returned non-POSIX error codes, replace them with POSIX > compilant values instead. EBADRQC and EBADSLT are replaced by EINVAL, while > EUSERS is replaced with EOVERFLOW. Same here basically - I'd appreciate if we could use EINVAL only as a last res

Re: [Xen-devel] [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 17:56, wrote: > PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace > them with EINVAL and EOVERFLOW respectively. Considering that we use EINVAL for almost everything (well beyond parameter checking I'm afraid), I don't think using this value for somethin

[Xen-devel] [PATCH v3 2/2] xen: sched/cpupool: properly update affinity when removing a cpu from a cpupool

2015-07-21 Thread Dario Faggioli
And this time, do it right. In fact, a similar change was attempted in 93be8285a79c6 ("cpupools: update domU's node-affinity on the cpupool_unassign_cpu() path"). But that was buggy, and got reverted with 8395b67ab0b8a86. However, even though reverting was the right thing to do, it remains true th

[Xen-devel] [PATCH v3 1/2] xen: sched: reorganize cpu_disable_scheduler()

2015-07-21 Thread Dario Faggioli
The function is called both when we want to remove a cpu from a cpupool, and during cpu teardown, for suspend or shutdown. If, however, the boot cpu (cpu 0, most of the times) is not present in the default cpupool, during suspend or shutdown, Xen crashes like this: root@Zhaman:~# xl cpupool-cpu-

[Xen-devel] [PATCH v3 0/2] xen: sched/cpupool: more fixing of (corner?) cases

2015-07-21 Thread Dario Faggioli
v2, which is here: http://lists.xen.org/archives/html/xen-devel/2015-07/msg03540.html suffered from a "missing stg refresh" issue (or, at least, that's my best guess). Thanks Juergen for noticing and pointing that out, and sorry for that. This posting should be fine. Regards, Dario --- Dario F

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Ian Jackson writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid > conflicts with RDM"): > > Sorry, I just ignore the line in brackets since I always think this kind > > of thing is often

[Xen-devel] [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code

2015-07-21 Thread Roger Pau Monne
PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace them with EINVAL and EOVERFLOW respectively. Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu Cc: Jan Beulich Cc: Andrew Cooper --- tools/libxl/libxl_psr.c | 6 +++---

[Xen-devel] [PATCH for-4.6 3/3] xen: remove non-POSIX error codes

2015-07-21 Thread Roger Pau Monne
Xen was using some non-POSIX error codes that are removed in this patch. For future reference, the list of POSIX error codes has been obtained from: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html The error codes already present and defined as optional (XSR), have been left

[Xen-devel] [PATCH for-4.6 0/3] Get rid of non-POSIX error codes

2015-07-21 Thread Roger Pau Monne
This patch series gets rid of non-POSIX error codes in the hypervisor and the toolstack. This is needed for OS compatibility. I think the patch series is fairly small and non-intrusive, hence the for-4.6 tag. Thanks, Roger. ___ Xen-devel mailing list

[Xen-devel] [PATCH for-4.6 2/3] xen: replace non-POSIX error codes

2015-07-21 Thread Roger Pau Monne
Some DOMCTLs returned non-POSIX error codes, replace them with POSIX compilant values instead. EBADRQC and EBADSLT are replaced by EINVAL, while EUSERS is replaced with EOVERFLOW. Signed-off-by: Roger Pau Monné Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper --- Nothing in libxc or libxl s

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > Sorry, I just ignore the line in brackets since I always think this kind > of thing is often not a big deal, and next time I should pay more > attention to the (). But indeed, before I post this wh

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 23:09, Ian Jackson wrote: Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): +static void +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy) +{ +d_confi

Re: [Xen-devel] [PATCH v2 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-21 Thread Boris Ostrovsky
On 07/17/2015 01:52 PM, Boris Ostrovsky wrote: On 07/17/2015 12:43 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jul 17, 2015 at 11:36:29AM -0400, Boris Ostrovsky wrote: On 07/17/2015 11:21 AM, Konrad Rzeszutek Wilk wrote: On Thu, Jul 16, 2015 at 05:43:39PM -0400, Boris Ostrovsky wrote: Signed-off

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > Indeed, I'm not a fan to Xen tools so I can't picture what this real > scenario would happen. So if I'm misunderstanding what you mean, just > please correct me. Or if you still think its hard to e

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 15:36 +0100, Wei Liu wrote: > On Tue, Jul 21, 2015 at 03:27:26PM +0100, Ian Jackson wrote: > > Ian Campbell writes ("Re: [PATCH 1/5] xl: Command line: Adjust "Fix > > segfaults from `xl psr-cat-cbm-set`...""): > > > On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: > > >

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
Just to your example, libxl_domain_config cfg; cfg.stuff = blah; cfg.rdm.strategy = HOST; libxl_domain_create_new(&cfg, &domid); libxl_domain_destroy(domid); Here looks you mean d_config->rdms would be changed, right? Currently this shouldn't be allowed. But I think we need

Re: [Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 10:07 -0400, Brandon Perez wrote: > > I'm not sure that these patches are quite ready yet to be put > into > the Xen repo. That's ok, but even for an RFC (Request For Comments) please post them one patch per email in the manner of git send-email. You can use - -subjec

Re: [Xen-devel] [PATCH] build: use correct qemu path in systemd service file and init script

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 00:15 +0800, Ting-Wei Lan wrote: This all looks pretty good. One comment: > +if test "x$qemu_xen_path" = "x" || test "x$qemu_xen_path" = "xqemu"; > then : > + > +qemu_xen_path_service="$LIBEXEC_BIN/qemu-system-i386" It's a shame we have to repeat the "qemu-system-i386"

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > [Ian Jackson:] > > That is, an address would be reserved if it was reserved in any of the > > rdm regions implied by the config. > > Are you saying this point? > > "The union of two sets A and B is

Re: [Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 13:49 +0100, Wei Liu wrote: > On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: > > On 20/07/15 10:56, Wei Liu wrote: > > > On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: > > > > And three improvements to debugging. > > > > > > > > Note that there

Re: [Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 15:51 +0100, Ian Campbell wrote: > On Tue, 2015-07-21 at 13:49 +0100, Wei Liu wrote: > > On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: > > > On 20/07/15 10:56, Wei Liu wrote: > > > > On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: > > > > > And

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > +static void > +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, > + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy) > +{ > +d_config->num_rdms++; > +d_config->

Re: [Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Brandon Perez
On 07/21/2015 05:41 AM, Julien Grall wrote: On 21/07/2015 00:17, Brandon Perez wrote: Hello All, Hi Brandon, We use to send one mail by patch rather than sending them as an attachment of a single email. It's easier for reviewing the patches. You also need to add you Signed-off-by on each pa

Re: [Xen-devel] [PATCH v4 1/3] libxl: make libxl__strdup and libxl__strndup handle NULL

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 18:03 +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v4 1/3] libxl: make libxl__strdup and > libxl__strndup handle NULL"): > > Signed-off-by: Wei Liu > > Acked-by: Ian Jackson Applied. thanks. Ian. ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v4 3/3] libxl: call libxl_cpupoolinfo_{init, dispose} in numa_place_domain

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 18:03 +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v4 3/3] libxl: call > libxl_cpupoolinfo_{init,dispose} in numa_place_domain"): > > Call libxl_cpupoolinfo_init at the beginning. Change two returns > > to > > goto out so that libxl_cpupoolinfo_dispose is called in f

Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 13:32 +0100, Julien Grall wrote: > Hi Chris, > > On 17/07/15 21:48, Chris (Christopher) Brand wrote: > > nr_mods is set in add_boot_module() to the number of module > > array elements used. This function also ensures that nr_mods > > never exceeds MAX_MODULES (the size of the

Re: [Xen-devel] [PATCH] xen: arm: gic-v3: avoid \n in the middle of log messages

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 15:10 +0100, Julien Grall wrote: > Hi Ian, > > On 17/07/15 14:21, Ian Campbell wrote: > > These result in log messages such as: > > > > (XEN) d0v0: vGICD: RAZ on reserved register offset 0x0c > > (XEN) d0v0: vGICR: write r2 offset 0x000180 > > (XEN) not found<3>traps.c:

Re: [Xen-devel] [PATCH for-4.6 1/3] libxl: include sys/endian.h for FreeBSD

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 10:36 +0100, Wei Liu wrote: > On Mon, Jul 20, 2015 at 04:55:00PM +0200, Roger Pau Monne wrote: > > be64toh and friends are declared in sys/endian.h on FreeBSD, so > > include it > > as part of libxl_osdeps.h. > > > > Signed-off-by: Roger Pau Monné > > Cc: Ian Jackson > > C

Re: [Xen-devel] [PATCH for-4.6 3/3] hotplug/FreeBSD: fix xendriverdomain rc.d script

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 12:03 +0100, Wei Liu wrote: > On Mon, Jul 20, 2015 at 04:55:02PM +0200, Roger Pau Monne wrote: > > hotplugpath.sh by default is located in /usr/local/etc/xen/scripts > > on > > FreeBSD. Instead of hardcoding it's location use the XEN_SCRIPT_DIR > > variable > > like it's use

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Wei Liu
On Tue, Jul 21, 2015 at 03:27:26PM +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 1/5] xl: Command line: Adjust "Fix segfaults > from `xl psr-cat-cbm-set`...""): > > On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: > > > > Replying here in lieu of a 0/N: > > > > Is any subset

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`...""): > On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: > > Replying here in lieu of a 0/N: > > Is any subset of this aimed at 4.6? Yes, ideally, all of them. I think they are bugfixe

Re: [Xen-devel] [PATCH for 4.6] xen/tools: Widen the machine_irq in xc_domain_*bind_pt_irq_int

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 15:06 +0100, Julien Grall wrote: > The DOMCTLs {,un}bind_pt_irq are using uint32_t for the machine_irq > while the helper is using uint8_t. > > Currently on ARM, we are supporting SPIs whose irq number can go up > to > 1019 which doesn't fit in an uint8_t. The helpers > xc_

Re: [Xen-devel] [PATCH v2] xl: fix vcpus to vnode assignement in config file

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 11:30 +0200, Dario Faggioli wrote: > In fact, right now, if the "vcpus=" list (where the > user specifies what vcpus should be part of a vnode) > has multiple elements, things don't work. > E.g., the following examples all result in failure > to create the guest: What is the

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: Replying here in lieu of a 0/N: Is any subset of this aimed at 4.6? > This adjust commit a49077e5 "Fix segfaults from `xl psr-cat-cbm-set` > command line handling": > > * Do not use the constant `required_argument' here (we simply use 1 >

Re: [Xen-devel] [PATCH RFC] libxl: fix build with glibc < 2.9

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 15:30 +0100, Jan Beulich wrote: > htobe*() and be*toh() don't exist there. While replacing the 32-bit > ones with hton() and ntoh() would be possible, there wouldn't be an > obvious replacement for the 64-bit ones. Hence just take what current > glibc (2.21) has (assuming __bs

[Xen-devel] [qemu-upstream-unstable test] 59777: regressions - trouble: broken/fail/pass

2015-07-21 Thread osstest service owner
flight 59777 qemu-upstream-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59777/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 3 host-install(3) broken REGR. vs. 58880 test-amd64

  1   2   >