-} *resource, mem_resource, high_mem_resource, io_resource;
+} *resource, mem_resource, high_mem_resource, io_resource,
exp_mem_resource;
Despite having gone through description and the rest of the patch I
can't seem to be able to guess what "exp_mem" stands for.
Meaningful variable nam
flight 59509 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59509/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 14 guest-localmigrate.2
fail REGR. vs. 58958
>>> On 07.07.15 at 17:41, wrote:
> On Tue, 2015-07-07 at 16:14 +0100, Ian Jackson wrote:
>> Anthony PERARD writes ("[PATCH V3] libxl: Increase device model startup
> timeout to 1min."):
>> > On a busy host, QEMU may take more than 10s to load and start.
>> >
>> > This is likely due to a bug in L
> -Original Message-
> From: Wei Liu [mailto:wei.l...@citrix.com]
> Sent: Monday, July 13, 2015 7:01 PM
> To: Wu, Feng
> Cc: wei.l...@citrix.com; xen-devel@lists.xen.org; Jan Beulich
> (jbeul...@suse.com); andrew.coop...@citrix.com; George Dunlap; Tian, Kevin;
> Zhang, Yang Z; Wang, Yong
On 2015/7/13 18:15, Ian Campbell wrote:
On Mon, 2015-07-13 at 17:47 +0800, Chen, Tiejun wrote:
This approach looks like it should work, and I think given the point in
the release it would be acceptable for 4.6.
However long term I think it might make sense to try and reuse one of
the existing
Hi Dario,
- not enough benchmarks/performance figures: I'd like to have the
>latency numbers, e.g., from cyclictest, we've spoke many times with
>Meng, give our official blessing at using it
Considering t
he improved version Dagaen is working on should be able to improve the
efficiency
> -Original Message-
> From: Dario Faggioli [mailto:dario.faggi...@citrix.com]
> Sent: Friday, July 10, 2015 7:06 PM
> To: Jan Beulich
> Cc: Wu, Feng; andrew.coop...@citrix.com; George Dunlap; Tian, Kevin; Zhang,
> Yang Z; xen-devel; k...@xen.org
> Subject: Re: [Xen-devel] Fwd: [v3 14/15]
Now we can use that memory map to build our final
e820 table but it may need to reorder all e820
entries.
"it" being what? I'm afraid I can't really make sense of the second
half of the sentence...
I hope the following can work for you,
...
but finally we should sort them into an increasing o
В Mon, 13 Jul 2015 16:53:59 +0800
fu@linaro.org пишет:
> From: Fu Wei
>
> This patch adds the support of boot command on arm64 for XEN:
> xen_hypervisor
> xen_module
>
> Signed-off-by: Fu Wei
> ---
> util/grub.d/20_linux_xen.in | 14 +++---
> 1 file changed, 11 insertions(
flight 59505 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59505/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 11 guest-saverestore fail REGR.
vs. 59059
test-amd6
+{
+printk(XENLOG_G_ERR VTDPREFIX
+ " cannot assign %04x:%02x:%02x.%u"
+ " with shared RMRR for Dom%d.\n",
+ seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn),
+ d->domain_id);
+
On 2015/7/14 1:08, Ian Jackson wrote:
Ian Campbell writes ("Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new
rdm policy parameters"):
On Mon, 2015-07-13 at 17:55 +0800, Chen, Tiejun wrote:
So I can do this as you're expecting now, but seems our change would
make the code style very
Please work with maintainers to get those hvmloader patches acked or
reviewed.
I will do.
Note Jackson and Campbell also raised some comments to improve current
codes.
2. explain why it needs to be in this release (benefits).
RMRR mechanism was broken for a long time and this makes VM alw
flight 59508 xen-4.5-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59508/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-win7-amd64 14 guest-localmigrate.2 fail REGR. vs.
58867
Regressions wh
flight 59503 linux-3.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59503/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 30511
Tests which are failing
1. clarify the state of patch series / feature.
ReviewedAcked RMRR series v7
Y Y [v7][PATCH 01/16] xen: introduce
XENMEM_reserved_device_memory_map
Y Y [v7][PATCH 02/16] xen/vtd: create RMRR mapping
Y N [v7][PATCH 03/16] xen/p
From: Tamas K Lengyel
Working altp2m test-case. Extended the test tool to support singlestepping
to better highlight the core feature of altp2m view switching.
Signed-off-by: Tamas K Lengyel
Signed-off-by: Ed White
Reviewed-by: Razvan Cojocaru
---
tools/tests/xen-access/xen-access.c | 173 +
From: Ravi Sahita
Signed-off-by: Ravi Sahita
Acked-by: Daniel De Graaf
---
tools/flask/policy/policy/modules/xen/xen.if | 4 ++--
xen/arch/x86/hvm/hvm.c | 6 ++
xen/include/xsm/dummy.h | 12
xen/include/xsm/xsm.h
From: Tamas K Lengyel
Wrappers to issue altp2m hvmops.
Signed-off-by: Tamas K Lengyel
Signed-off-by: Ravi Sahita
Acked-by: Ian Campbell
---
tools/libxc/Makefile | 1 +
tools/libxc/include/xenctrl.h | 21
tools/libxc/xc_altp2m.c | 237 +++
The altp2mhvm and nestedhvm parameters are mutually
exclusive and cannot be set together.
Signed-off-by: Ed White
Reviewed-by: Andrew Cooper
Acked-by: Wei Liu
---
docs/man/xl.cfg.pod.5 | 12
tools/libxl/libxl.h | 6 ++
tools/libxl/libxl_create.c |
Signed-off-by: Ed White
---
xen/arch/x86/hvm/hvm.c | 142
xen/include/public/hvm/hvm_op.h | 82 +++
2 files changed, 224 insertions(+)
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index a9f4b1b..df6c6b6 100644
Add the remaining routines required to support enabling the alternate
p2m functionality.
Signed-off-by: Ed White
Reviewed-by: Andrew Cooper
---
xen/arch/x86/hvm/hvm.c | 58 +-
xen/arch/x86/mm/hap/Makefile | 1 +
xen/arch/x86/mm/hap/altp2m_hap.c | 98 ++
xen/arch/x
Add the basic data structures needed to support alternate p2m's and
the functions to initialise them and tear them down.
Although Intel hardware can handle 512 EPTP's per hardware thread
concurrently, only 10 per domain are supported in this patch for
performance reasons.
The iterator in hap_enab
From: Ravi Sahita
Signed-off-by: Ravi Sahita
---
xen/arch/x86/hvm/emulate.c | 19 +++--
xen/arch/x86/hvm/vmx/vmx.c | 38 ++
xen/arch/x86/x86_emulate/x86_emulate.c | 19 +++--
xen/arch/x86/x86_emulate/x86_emulate.h |
From: George Dunlap
The existing ept_set_entry() and ept_get_entry() routines are extended
to optionally set/get suppress_ve. Passing -1 will set suppress_ve on
new p2m entries, or retain suppress_ve flag on existing entries.
Signed-off-by: George Dunlap
Signed-off-by: Ravi Sahita
Reviewed-b
Add a flag to indicate that a memory event occurred in an alternate p2m
and a field containing the p2m index. Allow any event response to switch
to a different alternate p2m using the same flag and field.
Modify p2m_mem_access_check() to handle alternate p2m's.
Signed-off-by: Ed White
Acked-by:
Implement and hook up the code to enable VMX support of VMFUNC and #VE.
VMFUNC leaf 0 (EPTP switching) emulation is added in a later patch.
Signed-off-by: Ed White
Reviewed-by: Andrew Cooper
Acked-by: Jun Nakajima
---
xen/arch/x86/hvm/vmx/vmx.c | 138 +
As implemented here, only supported on platforms with VMX HAP.
By default this functionality is force-disabled, it can be enabled
by specifying altp2m=1 on the Xen command line.
Signed-off-by: Ed White
Reviewed-by: Andrew Cooper
---
docs/misc/xen-command-line.markdown | 7 +++
xen/arch/x8
This set of patches adds support to hvm domains for EPTP switching by creating
multiple copies of the host p2m (currently limited to 10 copies).
The primary use of this capability is expected to be in scenarios where access
to memory needs to be monitored and/or restricted below the level at which
Currently, neither is enabled globally but may be enabled on a per-VCPU
basis by the altp2m code.
Remove the check for EPTE bit 63 == zero in ept_split_super_page(), as
that bit is now hardware-defined.
Signed-off-by: Ed White
Reviewed-by: Andrew Cooper
Acked-by: George Dunlap
Acked-by: Jun N
From: Andrew Cooper
For use on codepaths which would need to use domain_pause() but might be in
the target domain's context. In the case that the target domain is in
context, all other vcpus are paused.
Signed-off-by: Andrew Cooper
---
xen/common/domain.c | 28
In preparation for selectively enabling #VE in a later patch, set
suppress #VE on all EPTE's.
Suppress #VE should always be the default condition for two reasons:
it is generally not safe to deliver #VE into a guest unless that guest
has been modified to receive it; and even then for most EPT viol
>-Original Message-
>From: Jan Beulich [mailto:jbeul...@suse.com]
>Sent: Monday, July 13, 2015 1:01 AM
>
On 10.07.15 at 23:48, wrote:
>>> From: Jan Beulich [mailto:jbeul...@suse.com]
>>>Sent: Thursday, July 09, 2015 6:30 AM
>>>
>> On 01.07.15 at 20:09, wrote:
---
xen
>-Original Message-
>From: Jan Beulich [mailto:jbeul...@suse.com]
>Sent: Monday, July 13, 2015 12:26 AM
>To: Sahita, Ravi
>Cc: Andrew Cooper; Wei Liu; George Dunlap; Ian Jackson; White, Edmund H;
>xen-devel@lists.xen.org; tleng...@novetta.com; Daniel De Graaf; Tim
>Deegan
>Subject: RE: [P
>-Original Message-
>From: Jan Beulich [mailto:jbeul...@suse.com]
>Sent: Monday, July 13, 2015 12:40 AM
>
On 10.07.15 at 21:30, wrote:
>>> From: Jan Beulich [mailto:jbeul...@suse.com]
>>>Sent: Thursday, July 09, 2015 6:01 AM
>> On 01.07.15 at 20:09, wrote:
@@ -232,6 +235,1
FYI, linux is currently broken by commit
a899418167264c7bac574b1a0f1b2c26c5b0995a. At least PV but I suspect HVM too.
I'll see what we can do tomorrow.
-boris
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
flight 59504 linux-next real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59504/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 6 xen-boot fail baseline
untested
test-amd64-amd64-xl-pv
Hi Boris,
On 13/07/2015 22:13, Boris Ostrovsky wrote:
On 07/09/2015 04:42 PM, Julien Grall wrote:
-
struct remap_data {
xen_pfn_t *fgmfn; /* foreign domain's gmfn */
+xen_pfn_t *efgmfn; /* pointer to the end of the fgmfn array */
It might be better to keep size of fgmfn array inst
Hi,
On 11/07/2015 11:21, Ian Campbell wrote:
On Sat, 2015-07-11 at 09:18 +0200, Julien Grall wrote:
As I explained in my reply to Jan I think this is underselling it a
little, since AIUI it should make it possible to boot Xen on ThunderX
and do useful things (like run guests).
Well, PCI are a
Hi,
On 13/07/2015 19:24, Stefano Stabellini wrote:
On Mon, 13 Jul 2015, Wei Liu wrote:
On Fri, Jul 10, 2015 at 04:16:07PM +0530, Vijay Kilari wrote:
Hi Wei,
I would like to have freeze exception for ITS feature on ARM64.
Design got freeze few weeks back and I have sent v4 version of patc
Hi,
On 10/07/2015 09:42, vijay.kil...@gmail.com wrote:
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index c41e82e..4f3801b 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
+static inline hw_irq_controller *get_host_hw_irq_controller(unsigned int irq)
+{
+if ( is_lpi(irq) )
+
flight 59502 linux-3.18 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59502/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-armhf-pvops 3 host-install(3) broken REGR. vs. 58581
test-amd64-amd64-xl-pv
On 07/09/2015 04:42 PM, Julien Grall wrote:
-
struct remap_data {
xen_pfn_t *fgmfn; /* foreign domain's gmfn */
+ xen_pfn_t *efgmfn; /* pointer to the end of the fgmfn array */
It might be better to keep size of fgmfn array instead.
+static int unmap_gfn(struct page *page, u
On 06/23/2015 12:11 PM, Vitaly Kuznetsov wrote:
Add new soft_reset vector to domain2 class, add it to create_domain
in the default policy.
Signed-off-by: Vitaly Kuznetsov
Acked-by: Daniel De Graaf
___
Xen-devel mailing list
Xen-devel@lists.xen.org
From: Elena Ufimtseva
In preparation for auxiliary RMRR data provided on Xen
command line, make RMRR adding a separate function.
Also free memory for rmrr device scope in error path.
Signed-off-by: Elena Ufimtseva
Reviewed-by: Konrad Rzeszutek Wilk
---
xen/drivers/passthrough/vtd/dmar.c | 126
From: Elena Ufimtseva
Release memory allocated for scope.devices dmar units on various
failure paths and when disabling dmar. Set device count after
sucessfull memory allocation, not before, in device scope parsing function.
Signed-off-by: Elena Ufimtseva
---
Changes in v10:
- mark patch v6 as
From: Elena Ufimtseva
On some platforms RMRR regions may be not specified
in ACPI and thus will not be mapped 1:1 in dom0. This
causes IO Page Faults and prevents dom0 from booting
in PVH mode.
New Xen command line option rmrr allows to specify
such devices and memory regions. These regions are a
From: Elena Ufimtseva
For sbdf's parsing in RMRR command line add __parse_pci with additional
parameter def_seg. __parse_pci will help to identify if segment was
found in string being parsed or default segment was used.
Make a wrapper parse_pci so the rest of the callers are not affected.
Signed
From: Elena Ufimtseva
In preperation for patch "iommu: add rmrr Xen command line option for
extra rmrrs" which will use it.
Signed-off-by: Elena Ufimtseva
---
xen/include/xen/pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 36e8cd3
From: Elena Ufimtseva
Add Xen command line option rmrr to specify RMRR
regions for devices that are not defined in ACPI thus
causing IO Page Fault while booting dom0 in PVH mode.
These additional regions will be
- Original Message -
From: jbeul...@suse.com
To: kevin.t...@intel.com, yang.z.zh...@intel.com
Cc: xen-devel@lists.xen.org, boris.ostrov...@oracle.com,
elena.ufimts...@oracle.com, konrad.w...@oracle.com, t...@xen.org
Sent: Monday, July 13, 2015 12:18:33 PM GMT -05:00 US/Canada Eastern
Subj
On 07/13/2015 11:53 AM, Jan Beulich wrote:
The new function's implementation, other than the original one of
XEN_SYSCTL_topologyinfo, didn't allow the caller to get what it needs
(if e.g. it's after the data for just one specific CPU) with just one
hypercall, without caring about the total number
On Mon, 13 Jul 2015, Julien Grall wrote:
> Hi Stefano,
>
> On 13/07/2015 18:32, Stefano Stabellini wrote:
> >
> > All these #ifdefs are a bit ugly. Couldn't we just build this code
> > always, even on arm32, relying on dt_match_node not to match in that
> > case?
>
> I'm not in favor of any ITS
Hi Stefano,
On 13/07/2015 19:13, Stefano Stabellini wrote:
On Fri, 10 Jul 2015, vijay.kil...@gmail.com wrote:
From: Vijaya Kumar K
Allocate and initialize irq descriptor for LPIs and
route LPIs to guest
Signed-off-by: Vijaya Kumar K
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
in
On 07/13/2015 08:32 PM, Lengyel, Tamas wrote:
>
>
> On Mon, Jul 13, 2015 at 1:14 PM, Razvan Cojocaru
> mailto:rcojoc...@bitdefender.com>> wrote:
>
> This patch adds support for memory-content hiding, by modifying the
> value returned by emulated instructions that read certain memory
>
On Mon, Jul 13, 2015 at 1:14 PM, Razvan Cojocaru
wrote:
> This patch adds support for memory-content hiding, by modifying the
> value returned by emulated instructions that read certain memory
> addresses that contain sensitive data. The patch only applies to
> cases where VM_FLAG_ACCESS_EMULATE
Hi Stefano,
On 13/07/2015 18:32, Stefano Stabellini wrote:
All these #ifdefs are a bit ugly. Couldn't we just build this code
always, even on arm32, relying on dt_match_node not to match in that
case?
I'm not in favor of any ITS code in the common code unless it's strictly
necessary.
In th
On Mon, 13 Jul 2015, Wei Liu wrote:
> On Fri, Jul 10, 2015 at 04:16:07PM +0530, Vijay Kilari wrote:
> > Hi Wei,
> >
> > I would like to have freeze exception for ITS feature on ARM64.
> > Design got freeze few weeks back and I have sent v4 version of patch series
> > today.
> >
> > This patch
Ian Campbell writes ("Re: [PATCH 4/9] libxl: dispose dominfo to avoid leaking
resource"):
> On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> > Add libxl_dominfo_dispose to one return path that doesn't have it.
> >
> > Signed-off-by: Wei Liu
>
> That return is a bit at odds with the generally
Ian Campbell writes ("Re: [PATCH 3/9] libxl: json string object can be NULL"):
> On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu
>
> Acked-by: Ian Campbell
>
> It occurs to me that since libxl__strdup can never return NULL due to
> allocation failure we could consid
Deny register writes if a vm_client subscribed to mov_to_msr or
control register write events forbids them. Currently supported for
MSR, CR0, CR3 and CR4 events.
Signed-off-by: Razvan Cojocaru
Acked-by: George Dunlap
Acked-by: Jan Beulich
Acked-by: Tamas K Lengyel
---
Changes since V4:
- Reb
This series addresses V4 reviews (patch 1/3), and has been
rebased to compile on top of Xen staging (which now includes
a few patches from Tamas that prevent V4 from compiling).
I've also moved x86 logic in patch 3/3 to x86 source files, this
seems to have gone unnoticed but would likely have not
This patch adds support for memory-content hiding, by modifying the
value returned by emulated instructions that read certain memory
addresses that contain sensitive data. The patch only applies to
cases where VM_FLAG_ACCESS_EMULATE has been set to a vm_event
response.
Signed-off-by: Razvan Cojoca
Wei Liu writes ("[PATCH v2 02/10] libxl: turn two malloc's to libxl__malloc"):
> One is to combine malloc + libxl__alloc_failed. The other is to avoid
> dereferencing NULL pointer in case of malloc failure.
The former fix is simply corredt.
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libx
Added support for a new class of vm_events: VM_EVENT_REASON_REQUEST,
sent via HVMOP_request_vm_event. The guest can request that a
generic vm_event (containing only the vm_event-filled guest registers
as information) be sent to userspace by setting up the correct
registers and doing a VMCALL. For e
On Fri, 10 Jul 2015, vijay.kil...@gmail.com wrote:
> From: Vijaya Kumar K
>
> Allocate and initialize irq descriptor for LPIs and
> route LPIs to guest
>
> Signed-off-by: Vijaya Kumar K
>
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index a5f66f6..8190a46 100644
> --- a/xen/arch/a
Ian Campbell writes ("Re: [PATCH 1/9] libxl: fix libxl__abs_path"):
> I rather dislike subjects of the form "fix $function", since it gives
> very little clue to someone reading the shortlog what is going on.
Yes.
> In this case I think "libxl: make libxl__abs_path correctly handle a
> NULL argum
Ian Campbell writes ("Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable
new rdm policy parameters"):
> On Mon, 2015-07-13 at 17:55 +0800, Chen, Tiejun wrote:
> > So I can do this as you're expecting now, but seems our change would
> > make the code style very inconsistent inside this funct
On Fri, 10 Jul 2015, vijay.kil...@gmail.com wrote:
> From: Vijaya Kumar K
>
> Initialize physical ITS driver from GIC v3 driver
> if LPIs are supported by hardware
>
> Signed-off-by: Vijaya Kumar K
> ---
> xen/arch/arm/gic-v3.c |7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git
On Fri, 10 Jul 2015, vijay.kil...@gmail.com wrote:
> From: Vijaya Kumar K
>
> Allocate and initialize irq descriptor for LPIs and
> route LPIs to guest
>
> Signed-off-by: Vijaya Kumar K
> ---
> v4: - Merge patch #16
> - Changed commit message
> ---
> xen/arch/arm/gic-v3.c |2 +-
Hello,
I would like to request a freeze exception for libxl migration v2.
v3 of the series was posted this morning, and review seems to indicate
that it is mostly on track. I hope to have v4 ready to post tomorrow,
and hope to have no further adjustments required.
On the testing side of things,
Ian Campbell writes ("[GIT-PULL OSSTEST] ap-fetch-version: Arrange for osstest
merges from upstream to be stable"):
> "ap-fetch-version: Arrange for osstest merges from upstream to be
> stable" has now passed the Cambridge push gate and done a couple of
> merges from upstream as well as some faile
Jan Beulich writes ("Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert
map_domain_page_global() to using mfn_t"):
> On 07.07.15 at 12:07, wrote:
> > Just like free(), these functions are not performing a read-only
> > operation on the destination pointer, therefore must not be performed on
On Fri, 10 Jul 2015, vijay.kil...@gmail.com wrote:
> From: Vijaya Kumar K
>
> Emulate LPI related changes to GICR registers
>
> Signed-off-by: Vijaya Kumar K
> ---
> v4: - Added LPI configuration table emulation
> - Rename function inline with vits
> - Copied guest lpi configuration tab
Coverity complains cpupool_info leaks a string in failure path. Instead
of fixing that path, we rely on the callers (two public APIs at the
moment) of cpupool_info correctly call libxl_cpupoolinfo_dispose in
their failure path to dispose of any resources.
That involves:
1. Call _init and _dispose
On Fri, 10 Jul 2015, vijay.kil...@gmail.com wrote:
> From: Vijaya Kumar K
>
> Parse host dt and generate ITS node for Dom0.
> ITS node resides inside GIC node so when GIC node
> is encountered look for ITS node.
>
> Signed-off-by: Vijaya Kumar K
> ---
> v4: - Generate only one ITS node for Dom0
Don't dereference NULL.
Also fixed a typo in error string while I was there.
Signed-off-by: Wei Liu
---
tools/libxl/xl_cmdimpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 607db4e..888f729 100644
--- a/tools/
On Mon, Jul 13, 2015 at 05:23:10PM +0100, Ian Campbell wrote:
> On Mon, 2015-07-13 at 17:10 +0100, Wei Liu wrote:
> > On Mon, Jul 13, 2015 at 11:07:31AM +0100, Ian Campbell wrote:
> > > On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> > > > Signed-off-by: Wei Liu
> > >
> > > Would an "if (rc)
Wei Liu (10):
libxl: make libxl__abs_path correctly handle NULL argument
libxl: turn two malloc's to libxl__malloc
libxl: json string object can be NULL
libxl: dispose dominfo to avoid leaking resource
libxl: localtime(3) can return NULL
libxl: qmp_init_handler can return NULL
xl: cor
Signed-off-by: Wei Liu
Acked-by: Ian Campbell
---
tools/libxl/libxl_x86.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c
index 8cd15ca..6be9b1b 100644
--- a/tools/libxl/libxl_x86.c
+++ b/tools/libxl/libxl_x86.c
@@ -311,6 +311,11 @@ int
Signed-off-by: Wei Liu
---
tools/libxl/xl_cmdimpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 888f729..8b4be72 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -2658,7 +2658,7 @@ static uint
Add libxl_dominfo_dispose to one return path that doesn't have it.
Signed-off-by: Wei Liu
Acked-by: Ian Campbell
---
tools/libxl/libxl_device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
index 2493972..3f8b555 100644
--- a/tools
Don't dereference extra_config if it's NULL. Don't leak extra_config in
the end.
Also fixed a typo in error string while I was there.
Signed-off-by: Wei Liu
---
tools/libxl/xl_cmdimpl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/lib
If s is NULL, just return NULL to avoid libxl__strdup dereferencing NULL
pointer.
Coverity-ID: 1198722
Signed-off-by: Wei Liu
Acked-by: Ian Campbell
---
tools/libxl/libxl_internal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_internal.c b/tools/lib
Signed-off-by: Wei Liu
Acked-by: Ian Campbell
---
tools/libxl/libxl_qmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index 6484f5e..965c507 100644
--- a/tools/libxl/libxl_qmp.c
+++ b/tools/libxl/libxl_qmp.c
@@ -694,6 +694,7 @@ libxl__qmp
One is to combine malloc + libxl__alloc_failed. The other is to avoid
dereferencing NULL pointer in case of malloc failure.
Signed-off-by: Wei Liu
Acked-by: Ian Campbell
---
tools/libxl/libxl_aoutils.c | 3 +--
tools/libxl/libxl_dm.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
Signed-off-by: Wei Liu
Acked-by: Ian Campbell
---
tools/libxl/libxl_json.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
index 346929a..652b3f4 100644
--- a/tools/libxl/libxl_json.c
+++ b/tools/libxl/libxl_json.c
On Mon, 2015-07-13 at 17:10 +0100, Wei Liu wrote:
> On Mon, Jul 13, 2015 at 11:07:31AM +0100, Ian Campbell wrote:
> > On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> > > Signed-off-by: Wei Liu
> >
> > Would an "if (rc) libxl_cpupoolinfo_dispose(info)" on the exit path be a
> > more robust alt
>>> On 02.07.15 at 16:02, wrote:
> This patch exposes xsaves/xgetbv/xsavec to hvm guest.
>
> Signed-off-by: Shuai Ruan
> ---
> tools/libxc/xc_cpuid_x86.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
> i
>>> On 07.07.15 at 17:17, wrote:
> From: Elena Ufimtseva
>
> Release memory allocated for scope.devices dmar units on various
> failure paths and when disabling dmar. Set device count after
> successful memory allocation, not before, in device scope parsing function.
>
> Signed-off-by: Elena Uf
On Mon, Jul 13, 2015 at 11:07:31AM +0100, Ian Campbell wrote:
> On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu
>
> Would an "if (rc) libxl_cpupoolinfo_dispose(info)" on the exit path be a
> more robust alternative? Might require the addition of a
> libxl_cpupoolinfo_
On Mon, 2015-07-13 at 16:53 +0100, Andrew Cooper wrote:
> I could see about doing something based on BITS_PER_LONG which doesn't
> have a visible ifdef, but is still ifdefary.
Given that it is the reason for the width differences in the old stream
using sizeof(unsigned long) wouldn't seem massivel
On 13/07/15 16:47, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH v3 21/28] tools/libxl: Infrastructure for
> writing a v2 stream"):
>> On 13/07/15 16:21, Ian Jackson wrote:
>>> Sadly this pattern is not correct. I don't think this initialisation
>>> ensures that the memory in hdr is all-
Andrew Cooper writes ("Re: [PATCH v3 18/28] tools/libxl: Infrastructure to
convert a legacy stream"):
> I could see about doing something based on BITS_PER_LONG which doesn't
> have a visible ifdef, but is still ifdefary.
I would much prefer that. Sorry to be awkward.
Thanks,
Ian.
Andrew Cooper writes ("[PATCH v3 28/28] tools/libxl: Drop all knowledge of
toolstack callbacks"):
> Libxl has now been fully adjusted not to need them.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-d
Jim Fehlig writes ("Re: [Xen-devel] [PATCH 0/9] libxl: poll: Avoid fd
deregistration race POLLNVAL"):
> Ian Jackson wrote:
> > The first three patches in this series fix a race which I think is the
> > cause of a bug reported by Jim Fehlig (thanks, Jim). They are IMO
> > backport candidates
On 13/07/15 16:44, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH v3 18/28] tools/libxl: Infrastructure to
> convert a legacy stream"):
>> On 13/07/15 15:45, Ian Jackson wrote:
> ...
>>> I'm afraid I don't understand why this script needs to be told the
>>> toolstack build bit width. (If
The new function's implementation, other than the original one of
XEN_SYSCTL_topologyinfo, didn't allow the caller to get what it needs
(if e.g. it's after the data for just one specific CPU) with just one
hypercall, without caring about the total number of CPUs in the system.
Signed-off-by: Jan B
Andrew Cooper writes ("Re: [PATCH v3 21/28] tools/libxl: Infrastructure for
writing a v2 stream"):
> On 13/07/15 16:21, Ian Jackson wrote:
> > Sadly this pattern is not correct. I don't think this initialisation
> > ensures that the memory in hdr is all-bits-0.
>
> It guarantees that all object
Andrew Cooper writes ("Re: [PATCH v3 19/28] tools/libxl: Convert a legacy
stream if needed"):
> On 13/07/15 15:51, Ian Jackson wrote:
> > This would be more obviously correct (or at least more obviously never
> > leak a carefd) if you set v2_carefd to NULL here, and asserted its
> > NULLness at th
1 - 100 of 292 matches
Mail list logo
