Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-10 Thread Julien Grall
Hi, On 10/07/2015 17:52, Ian Campbell wrote: On Fri, 2015-07-10 at 12:01 +0100, Jan Beulich wrote: On 10.07.15 at 12:46, wrote: I would like to have freeze exception for ITS feature on ARM64. Design got freeze few weeks back and I have sent v4 version of patch series today. This patches

Re: [Xen-devel] [PATCH v4 15/15] tools/xen-access: altp2m testcases

2015-07-10 Thread Razvan Cojocaru
On 07/10/2015 04:35 AM, Lengyel, Tamas wrote: > > @@ -546,6 +652,23 @@ int main(int argc, char *argv[]) > } > > break; > +case VM_EVENT_REASON_SINGLESTEP: > +printf("Singlestep: rip=%016"PRIx64", vcpu %d\n", > +

[Xen-devel] [PATCH v4 for Xen 4.6 2/4] libxc: enable per-VCPU parameter settings for RTDS scheduler

2015-07-10 Thread Chong Li
Add xc_sched_rtds_vcpu_get/set functions to interact with Xen to get/set a domain's per-VCPU parameters. Signed-off-by: Chong Li Signed-off-by: Meng Xu Signed-off-by: Sisu Xi --- CC: CC: CC: CC: CC: CC: --- tools/libxc/include/xenctrl.h | 9 +++ tools/libxc/xc_rt.c | 58

[Xen-devel] [PATCH v4 for Xen 4.6 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

2015-07-10 Thread Chong Li
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to support per-VCPU settings. Signed-off-by: Chong Li Signed-off-by: Meng Xu Signed-off-by: Sisu Xi --- Changes on PATCH v3: 1) Add sanity check on vcpuid 2) Add comments on per-domain and per-vcpu functions for libxl

[Xen-devel] [PATCH v4 for Xen 4.6 4/4] xl: enable per-VCPU parameter settings for RTDS scheduler

2015-07-10 Thread Chong Li
Change main_sched_rtds and related output functions to support per-VCPU settings. Signed-off-by: Chong Li Signed-off-by: Meng Xu Signed-off-by: Sisu Xi --- Changes on PATCH v3: 1) Support commands, e.g., "xl sched-rtds -d vm1" to output the default scheduling parameters CC: CC: CC: CC: C

[Xen-devel] [PATCH v4 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

2015-07-10 Thread Chong Li
Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls to independently get and set the scheduling parameters of each vCPU of a domain Signed-off-by: Chong Li Signed-off-by: Meng Xu Signed-off-by: Sisu Xi --- Changes on PATCH v3: 1) Remove struct xen_domctl_schedparam_t. 2) Change st

[Xen-devel] [PATCH v4 for Xen 4.6 0/4] Enable per-VCPU parameter settings for RTDS scheduler

2015-07-10 Thread Chong Li
[Goal] The current xl sched-rtds tool can only set the VCPUs of a domain to the same parameter although the scheduler supports VCPUs with different parameters. This patchset is to enable xl sched-rtds tool to configure the VCPUs of a domain with different parameters. This per-VCPU settings can

[Xen-devel] [linux-next test] 59366: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59366 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/59366/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 6 xen-boot fail REGR. vs. 59254 test-amd64-amd6

[Xen-devel] [linux-linus test] 59348: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59348 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/59348/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 59254 test

[Xen-devel] [libvirt test] 59350: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59350 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/59350/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-xsm 11 guest-start fail REGR. vs. 58842 Regressions which are reg

[Xen-devel] [ovmf test] 59370: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59370 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/59370/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 9 windows-installfail REGR. vs. 59302 Regressions which are regard

[Xen-devel] [linux-3.4 test] 59345: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59345 linux-3.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59345/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 5 kernel-build fail REGR. vs. 30511 test-amd64-amd64-xl-qem

[Xen-devel] [linux-3.18 test] 59319: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59319 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59319/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 58581 Tests which are failin

Re: [Xen-devel] Requesting for freeze exception for altp2m

2015-07-10 Thread Wei Liu
On Fri, Jul 10, 2015 at 08:58:33PM +, Sahita, Ravi wrote: > Hi Wei, > > I had already requested the freeze exception already for altp2m[0] - I'm > reposting that request with updates for v4 of patch series, and other updates: > > 1. clarify the state of patch series / feature. > > Reviewed

Re: [Xen-devel] [PATCH V2 1/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Samuel Thibault
Eric Shelton, le Fri 10 Jul 2015 18:14:32 -0400, a écrit : > -dm_config->b_info.max_memkb = 32 * 1024; > +dm_config->b_info.max_memkb = 28 * 1024 + > +max(guest_config->b_info.video_memkb, 4096); I'm actually wondering whether just using > +dm_config->b_info.max_memkb = 28 * 1

[Xen-devel] [PATCH v3 3/4] x86/pvh: Handle hypercalls for 32b PVH guests

2015-07-10 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- Changes in v3: * Defined compat_mmuext_op(). (XEN_GUEST_HANDLE_PARAM(mmuext_op_compat_t) is not defined in header files so I used 'void' type. I am not convinced this is the best solution) xen/arch/x86/hvm/hvm.c | 33 - 1 fil

[Xen-devel] [PATCH v3 2/4] x86/compat: Test both PV and PVH guests for compat mode

2015-07-10 Thread Boris Ostrovsky
Add is_pvh_32bit_domain() macro and use it alongside is_pv_32bit_domain() where necessary. Since PVH guests cannot change execution mode, has_32bit_shinfo is a good indicator of whether the guest is PVH and 32-bit. Signed-off-by: Boris Ostrovsky --- Changes in v3: * Defined is_pvh_32bit_domain()

[Xen-devel] [PATCH v3 1/4] x86/pvh: Set 32b PVH guest mode in XEN_DOMCTL_set_address_size

2015-07-10 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- Changes in v3: * Updated switch_native() not to call release_compat_l4() on PVH guests * hvm_set_mode() handles both 8 and 4 modes and returns -EOPNOTSUPP otherwise. Similar chages to vmx_set_mode() xen/arch/x86/domain.c | 27

[Xen-devel] [PATCH v3 4/4] libxc/x86/pvh: Allow creation of 32b PVH guests

2015-07-10 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky Acked-by: Ian Campbell --- tools/libxc/xc_dom_x86.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c index 6a04399..d0723f1 100644 --- a/tools/libxc/xc_dom_x86

[Xen-devel] [PATCH v3 0/4] 32-bit domU PVH support

2015-07-10 Thread Boris Ostrovsky
Initial 32-bit PVH support, dom0 will need more work. Changes in v3: * Swapped patches 1 and 2 * Added is_pvh_32bit_domain() macro * Dropped a few unnecessary tests for 32b mode * Added error for unsupported modes * Added changes to switch_native() similar to those in switch_compat() * Fully decla

[Xen-devel] [PATCH V2 1/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Eric Shelton
Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to the video adapter to avoid out of memory condition for QEMU. Signed-off-by: Eric Shelton --- tools/libxl/libxl_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libx

[Xen-devel] [PATCH V2 0/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Eric Shelton
I ran into crashes with qemu-traditional stub domain when 16 MB was assigned to the stdvga virtual video adapter. These were occurring due to an out of memory condition arising from stub domains having a fixed size of 32 MB, with half of that being demanded for video. Assuming the the original va

Re: [Xen-devel] [PATCH v4 12/15] x86/altp2m: Add altp2mhvm HVM domain parameter.

2015-07-10 Thread Sahita, Ravi
>From: dunl...@gmail.com [mailto:dunl...@gmail.com] On Behalf Of George >Dunlap >Sent: Friday, July 10, 2015 10:32 AM > >On Fri, Jul 10, 2015 at 1:52 AM, Ed White >wrote: >> The altp2mhvm and nestedhvm parameters are mutually exclusive and >> cannot be set together. >> >> Signed-off-by: Ed White

Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

2015-07-10 Thread Sahita, Ravi
>From: George Dunlap [mailto:george.dun...@eu.citrix.com] >Sent: Friday, July 10, 2015 9:35 AM > >On 07/09/2015 06:05 PM, Sahita, Ravi wrote: >>> And Tim, Andrew and I subsequently discussed this specific approach >>> in a phone meeting. >>> >>> Ed >> >> Here is a brief description of the approach

Re: [Xen-devel] [PATCH v4 11/15] x86/altp2m: define and implement alternate p2m HVMOP types.

2015-07-10 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Friday, July 10, 2015 3:01 AM > On 10.07.15 at 02:52, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -6443,6 +6443,144 @@ long do_hvm_op(unsigned long op, >XEN_GUEST_HANDLE_PARAM(void) arg) >> break; >

[Xen-devel] [xen-unstable test] 59311: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59311 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59311/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-rumpuserxen-amd64 15 rumpuserxen-demo-xenstorels/xenstorels.repeat fail REGR. vs.

Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

2015-07-10 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 09, 2015 6:30 AM > On 01.07.15 at 20:09, wrote: >> --- >> xen/arch/x86/hvm/Makefile| 1 + >> xen/arch/x86/hvm/altp2m.c| 92 >+ > >Wouldn't this better go into xen/arch/x86/

[Xen-devel] Requesting for freeze exception for altp2m

2015-07-10 Thread Sahita, Ravi
Hi Wei, I had already requested the freeze exception already for altp2m[0] - I'm reposting that request with updates for v4 of patch series, and other updates: 1. clarify the state of patch series / feature. ReviewedAcked altp2m series v4 Y N [PATCH v3 01/15] common/domain

Re: [Xen-devel] [RFC v3] xSplice design

2015-07-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 04:26:56PM -0400, Konrad Rzeszutek Wilk wrote: > Since RFC v2 > [http://lists.xen.org/archives/html/xen-devel/2015-05/msg02142.html] > - Ingested every review comment in. > > For those who prefer an diff of what changed between v2 and this > I am attaching an diff to help

Re: [Xen-devel] [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: > From: Arianna Avanzini > > This patch converts xen-blkfront driver to use the block multiqueue APIs. > Only one hardware queue is used now, so there is no performance change. > > The legacy non-mq code was deleted completely which is the

Re: [Xen-devel] Xen PV IOMMU interface draft C

2015-07-10 Thread Konrad Rzeszutek Wilk
> Xen PV IOMMU hypercall interface > > A two argument hypercall interface (do_iommu_op). > > ret_t do_iommu_op(XEN_GUEST_HANDLE_PARAM(void) arg, unsigned int count) > > First argument, guest handle pointer to array of `struct pv_iommu_op` > > Second argument,

Re: [Xen-devel] [PATCH v3 03/13] VMX: implement suppress #VE.

2015-07-10 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 09, 2015 6:01 AM > On 01.07.15 at 20:09, wrote: >> @@ -232,6 +235,15 @@ static int ept_set_middle_entry(struct p2m_domain >*p2m, ept_entry_t *ept_entry) >> /* Manually set A bit to avoid overhead of MMU having to write i

Re: [Xen-devel] [PATCH v4 03/15] VMX: implement suppress #VE.

2015-07-10 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Friday, July 10, 2015 2:10 AM > On 10.07.15 at 02:52, wrote: >> @@ -1134,6 +1151,13 @@ int ept_p2m_init(struct p2m_domain *p2m) >> p2m->flush_hardware_cached_dirty = ept_flush_pml_buffers; >> } >> >> +table = >> + map_doma

Re: [Xen-devel] [PATCH v2 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page

2015-07-10 Thread Konrad Rzeszutek Wilk
On Thu, Jul 09, 2015 at 09:42:21PM +0100, Julien Grall wrote: > When Linux is using 64K page granularity, every page will be slipt in > multiple non-contiguous 4K MFN (page granularity of Xen). But you don't care about that on the Linux layer I think? As in, is there an SWIOTLB that does PFN to M

Re: [Xen-devel] [PATCH RFC v1 05/13] libxc: introduce a domain loader for HVM guest firmware

2015-07-10 Thread Konrad Rzeszutek Wilk
. snip.. > +static elf_negerrnoval check_elf_kernel(struct xc_dom_image *dom, bool > verbose) why don't we want the verbose to be always true? > +{ > +if ( dom->kernel_blob == NULL ) > +{ > +if ( verbose ) > +xc_dom_panic(dom->xch, > + XC_INTER

Re: [Xen-devel] [PATCH v3 31/32] libxc: switch xc_dom_elfloader to be used with HVMlite domains

2015-07-10 Thread Konrad Rzeszutek Wilk
On Fri, Jul 03, 2015 at 01:35:09PM +0200, Roger Pau Monne wrote: > Allow xc_dom_elfloader to report a guest type as hvm-3.0-x86_32 if it's > running inside of a HVM container and has the PHYS32_ENTRY elfnote set. > > Signed-off-by: Roger Pau Monné > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc

Re: [Xen-devel] [PATCH v3 27/32] libxc: change the position of the special pages

2015-07-10 Thread Konrad Rzeszutek Wilk
On Fri, Jul 03, 2015 at 05:36:15PM +0200, Roger Pau Monné wrote: > El 03/07/15 a les 13.35, Roger Pau Monne ha escrit: > > Change the physical memory address of the special pages when there are no > > emulated devices. On HVM guests the special pages have always been reserved > > so that they end a

Re: [Xen-devel] [PATCH v3 29/32] libxc/xen: introduce HVM_PARAM_FIRST_FREE_PFN

2015-07-10 Thread Konrad Rzeszutek Wilk
On Fri, Jul 03, 2015 at 01:35:07PM +0200, Roger Pau Monne wrote: > This HVM parameter returns the first free pfn after all the special pages. Could you describe how the layout of PFNs is now for the HVM guests? Is there some document that outlines it? I know that for PV we do have it as part of

Re: [Xen-devel] [PATCH] xen/pvhvm: Support more than 32 VCPUs when migrating (v3).

2015-07-10 Thread Konrad Rzeszutek Wilk
On Fri, Jul 10, 2015 at 02:37:46PM -0400, Konrad Rzeszutek Wilk wrote: > When Xen migrates an HVM guest, by default its shared_info can > only hold up to 32 CPUs. As such the hypercall > VCPUOP_register_vcpu_info was introduced which allowed us to > setup per-page areas for VCPUs. This means we can

Re: [Xen-devel] [PATCH v2 11/22] xen/x86: allow disabling emulated devices for HVM guests

2015-07-10 Thread Konrad Rzeszutek Wilk
> Also, from a guest POV, how is the hw emulated local apic going to be > used? Are we going to route the interrupts from virtual devices > (netfront, blkfront) to the lapic? Or we just want it for the timer and > ditch the PV timer? Use the event channels for the PV. For PCIe devices (passthrough

Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

2015-07-10 Thread Konrad Rzeszutek Wilk
On Fri, Jul 03, 2015 at 01:34:45PM +0200, Roger Pau Monne wrote: > Add checks for ignored vcpu fields in HVM mode. HVM vCPUs (BSP and APs) are > always started in 32bit protected mode with paging disabled. This is kind of odd in the placement of the series. The next couple of patches deal with the

Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

2015-07-10 Thread Konrad Rzeszutek Wilk
On Fri, Jul 03, 2015 at 01:34:45PM +0200, Roger Pau Monne wrote: > Add checks for ignored vcpu fields in HVM mode. HVM vCPUs (BSP and APs) are > always started in 32bit protected mode with paging disabled. Please mention that only the HVM guests which use the VCPU_xx hypercalls are the ones that a

[Xen-devel] [PATCH] xen/pvhvm: Support more than 32 VCPUs when migrating (v3).

2015-07-10 Thread Konrad Rzeszutek Wilk
When Xen migrates an HVM guest, by default its shared_info can only hold up to 32 CPUs. As such the hypercall VCPUOP_register_vcpu_info was introduced which allowed us to setup per-page areas for VCPUs. This means we can boot PVHVM guest with more than 32 VCPUs. During migration the per-cpu structu

Re: [Xen-devel] [PATCH 0/9] xl/libxl: fix issues discovered by Coverity scan

2015-07-10 Thread Andrew Cooper
On 10/07/15 19:00, Wei Liu wrote: > Wei Liu (9): > libxl: fix libxl__abs_path > libxl: turn two malloc's to libxl__malloc > libxl: json string object can be NULL > libxl: dispose dominfo to avoid leaking resource > libxl: avoid leaking string in cpupool_info > libxl: localtime(3) can re

[Xen-devel] [PATCH 2/9] libxl: turn two malloc's to libxl__malloc

2015-07-10 Thread Wei Liu
One is to combine malloc + libxl__alloc_failed. The other is to avoid dereferencing NULL pointer in case of malloc failure. Signed-off-by: Wei Liu --- tools/libxl/libxl_aoutils.c | 3 +-- tools/libxl/libxl_dm.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/lib

[Xen-devel] [PATCH 6/9] libxl: localtime(3) can return NULL

2015-07-10 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl_x86.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c index 8cd15ca..6be9b1b 100644 --- a/tools/libxl/libxl_x86.c +++ b/tools/libxl/libxl_x86.c @@ -311,6 +311,11 @@ int libxl__arch_domain_crea

[Xen-devel] [PATCH 4/9] libxl: dispose dominfo to avoid leaking resource

2015-07-10 Thread Wei Liu
Add libxl_dominfo_dispose to one return path that doesn't have it. Signed-off-by: Wei Liu --- tools/libxl/libxl_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c index 2493972..3f8b555 100644 --- a/tools/libxl/libxl_device.c ++

[Xen-devel] [PATCH 0/9] xl/libxl: fix issues discovered by Coverity scan

2015-07-10 Thread Wei Liu
Wei Liu (9): libxl: fix libxl__abs_path libxl: turn two malloc's to libxl__malloc libxl: json string object can be NULL libxl: dispose dominfo to avoid leaking resource libxl: avoid leaking string in cpupool_info libxl: localtime(3) can return NULL libxl: qmp_init_handler can return N

[Xen-devel] [PATCH 5/9] libxl: avoid leaking string in cpupool_info

2015-07-10 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 38aff8d..4151dcb 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -740,8 +740,10 @@ static int cpupool_info(libxl__gc

Re: [Xen-devel] [PATCH v3 00/32] Introduce HVM without dm and new boot ABI

2015-07-10 Thread Konrad Rzeszutek Wilk
> > > I started briefly looking today but don't really have time to look into > > > it properly. I do think we want to use as much of the native/HVM code > > > as possible and avoid the PV path (the current Linux PVH code uses too > > > much of the PV entry point, IMO). > > > > I'm afraid I'm not

[Xen-devel] [PATCH 8/9] xl: fix main_cpupoolcreate

2015-07-10 Thread Wei Liu
Don't dereference extra_config if it's NULL. Don't leak extra_config in the end. Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 971209c..d44eb4b 100644 --- a/tools

[Xen-devel] [PATCH 7/9] libxl: qmp_init_handler can return NULL

2015-07-10 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl_qmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 6484f5e..965c507 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qmp.c @@ -694,6 +694,7 @@ libxl__qmp_handler *libxl__qmp_ini

[Xen-devel] [PATCH 9/9] xl: fix main_config_update

2015-07-10 Thread Wei Liu
Don't dereference NULL. Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index d44eb4b..631dbd1 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -5010

[Xen-devel] [PATCH 3/9] libxl: json string object can be NULL

2015-07-10 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl_json.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c index 346929a..652b3f4 100644 --- a/tools/libxl/libxl_json.c +++ b/tools/libxl/libxl_json.c @@ -433,8 +433,13 @@ int

[Xen-devel] [PATCH 1/9] libxl: fix libxl__abs_path

2015-07-10 Thread Wei Liu
If s is NULL, just return NULL to avoid libxl__strdup dereferencing NULL pointer. Signed-off-by: Wei Liu --- tools/libxl/libxl_internal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c index 42d548e..6402c1b 100

Re: [Xen-devel] [PATCH v3 00/32] Introduce HVM without dm and new boot ABI

2015-07-10 Thread Konrad Rzeszutek Wilk
On Fri, Jul 03, 2015 at 06:36:37PM +0200, Roger Pau Monné wrote: > El 03/07/15 a les 18.19, David Vrabel ha escrit: > > On 03/07/15 12:34, Roger Pau Monne wrote: > >> > >> And for the FreeBSD part: > > > > Have you thought at all about what the Linux support for this mode would > > look like? > >

Re: [Xen-devel] [PATCH v4 12/15] x86/altp2m: Add altp2mhvm HVM domain parameter.

2015-07-10 Thread George Dunlap
On Fri, Jul 10, 2015 at 1:52 AM, Ed White wrote: > The altp2mhvm and nestedhvm parameters are mutually > exclusive and cannot be set together. > > Signed-off-by: Ed White > > Reviewed-by: Andrew Cooper for the hypervisor > bits. > --- > docs/man/xl.cfg.pod.5 | 12 > tool

Re: [Xen-devel] [PATCH v4 10/15] x86/altp2m: add remaining support routines.

2015-07-10 Thread George Dunlap
On Fri, Jul 10, 2015 at 10:41 AM, Jan Beulich wrote: On 10.07.15 at 02:52, wrote: >> Add the remaining routines required to support enabling the alternate >> p2m functionality. > > So despite George's comments on v3 these are still all disconnected > from their users... I did try to make it

Re: [Xen-devel] [PATCH v4 08/15] x86/altp2m: add control of suppress_ve.

2015-07-10 Thread George Dunlap
On Fri, Jul 10, 2015 at 1:52 AM, Ed White wrote: > From: George Dunlap > > The existing ept_set_entry() and ept_get_entry() routines are extended > to optionally set/get suppress_ve. Passing -1 will set suppress_ve on > new p2m entries, or retain suppress_ve flag on existing entries. > > Signed-

Re: [Xen-devel] [PATCH v8 11/11] (lib)xl: soft reset support

2015-07-10 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:53PM +0200, Vitaly Kuznetsov wrote: > Use existing create/restore path to perform 'soft reset' for HVM domains. > Tear everything down, e.g. destroy domain's device model, remove the domain > from xenstore, save toolstack record and start over. > > Signed-off-by: Vita

Re: [Xen-devel] [PATCH v8 08/11] xen: arch-specific hooks for domain_soft_reset()

2015-07-10 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:50PM +0200, Vitaly Kuznetsov wrote: > x86-specific hook cleans up the pirq-emuirq mappings, destroys all ioreq > servers and and replaces the shared_info frame with an empty page to support > subsequent XENMAPSPACE_shared_info call. > > ARM-specific hook is a noop for

Re: [Xen-devel] [PATCH v8 09/11] libxc: support XEN_DOMCTL_soft_reset operation

2015-07-10 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:51PM +0200, Vitaly Kuznetsov wrote: > Introduce xc_domain_soft_reset() function supporting XEN_DOMCTL_soft_reset. > > Signed-off-by: Vitaly Kuznetsov Well, that is easy to review :-) Reviewed-by: Konrad Rzeszutek Wilk > --- > tools/libxc/include/xenctrl.h | 3 +++

Re: [Xen-devel] [PATCH v4 06/15] VMX/altp2m: add code to support EPTP switching and #VE.

2015-07-10 Thread George Dunlap
On Fri, Jul 10, 2015 at 1:52 AM, Ed White wrote: > Implement and hook up the code to enable VMX support of VMFUNC and #VE. > > VMFUNC leaf 0 (EPTP switching) emulation is added in a later patch. > > Signed-off-by: Ed White > > Reviewed-by: Andrew Cooper > Acked-by: Jun Nakajima > --- > xen/arc

Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

2015-07-10 Thread George Dunlap
On 07/09/2015 06:05 PM, Sahita, Ravi wrote: >> And Tim, Andrew and I subsequently discussed this specific approach in a >> phone meeting. >> >> Ed > > Here is a brief description of the approach that was taken - > > The altp2m design implements a set of p2m's that are derived from the host > p2

Re: [Xen-devel] [PATCH v8 06/11] xen: Introduce XEN_DOMCTL_soft_reset

2015-07-10 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:48PM +0200, Vitaly Kuznetsov wrote: > New domctl resets state for a domain allowing it to 'start over': register > vcpu_info, switch to FIFO ABI for event channels. Still active grants are > being logged to help debugging misbehaving backends. > > Signed-off-by: Vital

Re: [Xen-devel] [PATCH v8 05/11] xen: grant_table: implement grant_table_warn_active_grants()

2015-07-10 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote: > Log first 10 active grants of a domain. This function is going to be used > for soft reset, active grants on this path usually mean misbehaving backends > refusing to release their mappings on shutdown. Is there an particular reas

Re: [Xen-devel] [PATCH v8 04/11] xen: evtchn: make evtchn_reset() ready for soft reset

2015-07-10 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:46PM +0200, Vitaly Kuznetsov wrote: > We need to close all event channel so the domain performing soft reset > will be able to open them back. > > Signed-off-by: Vitaly Kuznetsov > --- > xen/common/event_channel.c | 38 +++--- > xen/i

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 16:16 +0530, Vijay Kilari wrote: > I would like to have freeze exception for ITS feature on ARM64. > Design got freeze few weeks back and I have sent v4 version of patch series > today. Thanks, I've been through v4 and it is certainly much improved over v3. There are som

[Xen-devel] [PATCH v2] x86/hvm: add support for broadcast of buffered ioreqs...

2015-07-10 Thread Paul Durrant
...and make RTC timeoffset ioreqs use it. Without this patch RTC timeoffset updates go nowhere and Xen complains with a (non-rate-limited) printk. Signed-off-by: Paul Durrant Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper --- v2: - Add (g)printk back in as requested by Jan. It will be emi

Re: [Xen-devel] [PATCH v3 3/4] Convert map_domain_page() to use the new mfn_t type

2015-07-10 Thread Ian Campbell
On Thu, 2015-07-09 at 15:54 +0100, Ben Catterall wrote: > xen/arch/arm/domain_build.c | 2 +- > xen/arch/arm/kernel.c | 2 +- > xen/arch/arm/mm.c | 12 +- > xen/arch/arm/p2m.c| 4 ++-- > xen/arch/arm/traps

Re: [Xen-devel] [PATCH v3] x86: correct socket_cpumask allocation

2015-07-10 Thread Dario Faggioli
On Fri, 2015-07-10 at 16:25 +0100, Jan Beulich wrote: > >>> On 10.07.15 at 17:13, wrote: > > cpu_down() > > stop_machine_run(take_cpu_down, ...) > > notifier_call_chain(&cpu_chain, CPU_DYING, ...) > > __cpu_disable() > > remove_siblinginfo() > > __cpu_die() > > notifier_call_cha

Re: [Xen-devel] [PATCH 1/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Samuel Thibault
Eric Shelton, le Fri 10 Jul 2015 11:36:02 -0400, a écrit : > Allocate additional memory to the stub domain for qemu-traditional if > more than 4 MB is assigned to the video adapter to avoid out of memory > condition for QEMU. > > Signed-off-by: Eric Shelton Acked-by: Samuel Thibault > --- > t

Re: [Xen-devel] [PATCH 0/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Samuel Thibault
Eric Shelton, le Fri 10 Jul 2015 11:36:01 -0400, a écrit : > Assuming the the original value of 32 MB was based on having a 4 MB > video adapter, In my memory that was the case, yes. Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org http://list

Re: [Xen-devel] [PATCH] xen: release lock occasionally during ballooning

2015-07-10 Thread Boris Ostrovsky
On 07/10/2015 10:42 AM, Juergen Gross wrote: When dom0 is being ballooned balloon_process() will hold the balloon mutex until it is finished. This will block e.g. creation of new domains as the device backends for the new domain need some autoballooned pages for the ring buffers. Avoid this by r

Re: [Xen-devel] [PATCH] x86/hvm: add support for broadcast of buffered ioreqs...

2015-07-10 Thread Jan Beulich
>>> On 10.07.15 at 17:42, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 10 July 2015 16:39 >> To: Paul Durrant >> Cc: Andrew Cooper; xen-devel@lists.xen.org; Keir (Xen.org) >> Subject: Re: [PATCH] x86/hvm: add support for broadcast of buffered >> io

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 12:01 +0100, Jan Beulich wrote: > >>> On 10.07.15 at 12:46, wrote: > > I would like to have freeze exception for ITS feature on ARM64. > > Design got freeze few weeks back and I have sent v4 version of patch series > > today. > > > > This patches will not impact any gene

Re: [Xen-devel] [PATCH 1/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Ian Jackson
Eric Shelton writes ("[PATCH 1/1] libxl: set stub domain size based on VRAM size"): > Allocate additional memory to the stub domain for qemu-traditional if > more than 4 MB is assigned to the video adapter to avoid out of memory > condition for QEMU. > dm_config->b_info.max_vcpus = 1; >

Re: [Xen-devel] [PATCH v4 17/17] xen/arm: ITS: Add pci devices in ThunderX

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > ITS initialization required for all PCI devices in > ThunderX platform are done by calling from specific > mapping function. > > This patch can be reverted once XEN PCI passthrough > framework for arm64 i

Re: [Xen-devel] [PATCH v4 15/17] xen/arm: ITS: Map ITS translation space

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > ITS translation space contains GITS_TRANSLATOR > register which is written by device to raise > LPI. This space needs to mapped to every domain > address space for all physical ITS available, > so that dev

Re: [Xen-devel] [PATCH] x86/hvm: add support for broadcast of buffered ioreqs...

2015-07-10 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 10 July 2015 16:39 > To: Paul Durrant > Cc: Andrew Cooper; xen-devel@lists.xen.org; Keir (Xen.org) > Subject: Re: [PATCH] x86/hvm: add support for broadcast of buffered > ioreqs... > > >>> On 10.07.15 at 15:45, wr

[Xen-devel] [qemu-mainline test] 59307: regressions - FAIL

2015-07-10 Thread osstest service owner
flight 59307 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/59307/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 11 guest-saverestore fail REGR. vs. 59059 test-amd64-am

Re: [Xen-devel] [PATCH v4 14/17] xen/arm: ITS: Add domain specific ITS initialization

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: > +void vgic_its_init(void) > +{ > +if ( gic_lpi_supported() ) > +its_lpi_init(gic_nr_id_bits()); Ah, here is some code which tries to only enable this stuff when it is needed. I think for the time being this also needs

Re: [Xen-devel] [PATCH] MAINTAINERS: support for xen-access and email change

2015-07-10 Thread Jan Beulich
>>> On 10.07.15 at 17:29, wrote: > Add tools/tests/xen-acess to the supported list under VM EVENT/MEM ACCESS. > Also, changing my e-mail to the preferred one, as it is in many of the > headers > already. > > Signed-off-by: Tamas K Lengyel It looks slightly odd to me that you sign off with you

Re: [Xen-devel] [PATCH] x86/hvm: add support for broadcast of buffered ioreqs...

2015-07-10 Thread Jan Beulich
>>> On 10.07.15 at 15:45, wrote: > --- a/xen/arch/x86/hvm/io.c > +++ b/xen/arch/x86/hvm/io.c > @@ -60,8 +60,7 @@ void send_timeoffset_req(unsigned long timeoff) > if ( timeoff == 0 ) > return; > > -if ( !hvm_buffered_io_send(&p) ) > -printk("Unsuccessful timeoffset upda

[Xen-devel] [PATCH 0/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Eric Shelton
I ran into crashes with qemu-traditional stub domain when 16 MB was assigned to the stdvga virtual video adapter. These were occurring due to an out of memory condition arising from stub domains having a fixed size of 32 MB, with half of that being demanded for video. Assuming the the original va

[Xen-devel] [PATCH 1/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Eric Shelton
Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to the video adapter to avoid out of memory condition for QEMU. Signed-off-by: Eric Shelton --- tools/libxl/libxl_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/libxl_dm.c b/t

Re: [Xen-devel] [PATCH v3] x86: correct socket_cpumask allocation

2015-07-10 Thread Dario Faggioli
On Fri, 2015-07-10 at 16:13 +0100, Jan Beulich wrote: > >>> On 10.07.15 at 16:57, wrote: > > ... > > (XEN) Preparing system for ACPI S5 state. > > (XEN) Disabling non-boot CPUs ... > > (XEN) Broke affinity for irq 9 > > (XEN) cpu=1 cpu_to_socket=4294967295 > > (XEN) [ Xen-4.6-unstable x86_

Re: [Xen-devel] [PATCH v4 12/17] xen/arm: ITS: Initialize LPI irq descriptors and route

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: > diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c > index 3ebadcf..92d2be9 100644 > --- a/xen/arch/arm/gic.c > +++ b/xen/arch/arm/gic.c > @@ -68,11 +68,18 @@ enum gic_version gic_hw_version(void) > return gic_hw_ops->info->hw

[Xen-devel] [PATCH] MAINTAINERS: support for xen-access and email change

2015-07-10 Thread Tamas K Lengyel
Add tools/tests/xen-acess to the supported list under VM EVENT/MEM ACCESS. Also, changing my e-mail to the preferred one, as it is in many of the headers already. Signed-off-by: Tamas K Lengyel Acked-by: Razvan Cojocaru --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

Re: [Xen-devel] [PATCH v3] x86: correct socket_cpumask allocation

2015-07-10 Thread Jan Beulich
>>> On 10.07.15 at 17:13, wrote: On 10.07.15 at 16:57, wrote: >> I added this printk: >> >> printk(" cpu=%u cpu_to_socket=%u\n", cpu, socket); >> >> Right before this chunk of code, in cpu_smpboot_free(): >> >> if ( cpumask_empty(socket_cpumask[socket]) ) >> { >> xfree(so

Re: [Xen-devel] [PATCH v3] x86: correct socket_cpumask allocation

2015-07-10 Thread Jan Beulich
>>> On 10.07.15 at 16:57, wrote: > I added this printk: > > printk(" cpu=%u cpu_to_socket=%u\n", cpu, socket); > > Right before this chunk of code, in cpu_smpboot_free(): > > if ( cpumask_empty(socket_cpumask[socket]) ) > { > xfree(socket_cpumask[socket]); > socket_cpum

Re: [Xen-devel] [PATCH v4 11/17] xen/arm: ITS: Add GICR register emulation

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: > [...] > +int vits_unmap_lpi_prop(struct vcpu *v) Why is this function called "unmap"? > +/* Register mmio handlers for this region */ > +register_mmio_handler(v->domain, &vgic_gits_lpi_mmio_handler, > +

Re: [Xen-devel] [v7][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-10 Thread George Dunlap
On 07/10/2015 04:01 PM, Jan Beulich wrote: On 10.07.15 at 15:26, wrote: >> I also said that if we went with anything other than STRICT that we'd >> need to check to make sure that the domain really was the hardware >> domain before proceeding, in case the assumption that pdev->domain == >> ha

Re: [Xen-devel] [v7][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-10 Thread Jan Beulich
>>> On 10.07.15 at 15:26, wrote: > I also said that if we went with anything other than STRICT that we'd > need to check to make sure that the domain really was the hardware > domain before proceeding, in case the assumption that pdev->domain == > hardware_domain ever changed. (Perhaps with an AS

Re: [Xen-devel] [PATCH v3] x86: correct socket_cpumask allocation

2015-07-10 Thread Dario Faggioli
On Fri, 2015-07-10 at 15:47 +0100, Andrew Cooper wrote: > On 10/07/15 15:29, Dario Faggioli wrote: > > (XEN) Xen call trace: > > (XEN)[] cpu_smpboot_free+0x2b/0x255 > > (XEN)[] cpu_smpboot_callback+0x317/0x327 > > (XEN)[] notifier_call_chain+0x67/0x87 > > (XEN)[] cpu_down+0xd9/0x12

Re: [Xen-devel] [v7][PATCH 00/16] Fix RMRR

2015-07-10 Thread Jan Beulich
>>> On 10.07.15 at 16:50, wrote: > On Thu, Jul 9, 2015 at 6:33 AM, Tiejun Chen wrote: >> v7: > > It looks like most of the libxl/libxc patches have been acked. It > seems to me that most of the hypervisor patches (1-3, 14-15) are > either ready to go in or pretty close. > > The main thing I th

Re: [Xen-devel] [PATCH v4 09/17] xen/arm: ITS: Add GITS registers emulation

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: > +case GITS_CWRITER: > +if ( dabt.size == DABT_BYTE ) goto bad_width; > +/* XXX: Validate val */ > +vits_spin_lock(vits); > +vits->cmd_write = *r & 0xfffe0; > +if ( !(vits->ctrl & GITS_CTLR

Re: [Xen-devel] [PATCH OSSTEST 10/12] make-flight: debian hvm tests with libvirt

2015-07-10 Thread Wei Liu
On Wed, Mar 11, 2015 at 04:36:38PM +, Ian Campbell wrote: > On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > > I know you've made ts-debian-hvm-install DTRT but this is going to > result in a load of jobs which go through all the effort of regrooving > the box and installing Xen etc, only t

Re: [Xen-devel] [PATCH OSSTEST 09/12] ts-debian-hvm-install: stub out libvirt + ovmf / rombios

2015-07-10 Thread Wei Liu
On Wed, Mar 11, 2015 at 04:34:43PM +, Ian Campbell wrote: > On Mon, 2015-02-09 at 11:10 +, Wei Liu wrote: > > Libvirt's configuration converter doesn't know how to deal with BIOS > > selection. The end result is it always use the default one (seabios). > > Even with qemu-trad? Does it not

Re: [Xen-devel] [PATCH v4 08/17] xen/arm: ITS: Add APIs to add and assign device

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Add APIs to add devices to RB-tree, assign and remove > devices to domain. > > Signed-off-by: Vijaya Kumar K > --- > v4: - Introduced helper to populate its_device struct > - Fixed freeing of its_dev

  1   2   3   >