Re: [Xen-devel] [PATCH 1/3] xen/vt-d: need barriers to workaround CLFLUSH

2015-05-05 Thread Chen, Tiejun
On 2015/5/5 17:24, Jan Beulich wrote: On 05.05.15 at 04:45, wrote: Does this work for everyone? Please first of all explain why the interfaces in asm/flushtlb.h can't be used here (at least when flushing entire pages). Because - as I also don't understand any reason we didn't use this previ

[Xen-devel] How to probe io related operation in dom0 kernel?

2015-05-05 Thread Xuehan Xu
-- Forwarded message -- From: "Xuehan Xu" Date: May 4, 2015 2:35 PM Subject: How to probe io related operation in dom0 kernel? To: Cc: Hi, everyone Recently, I tested the disk io latency on dom0 by running the following instruction: dd if=/dev/zero of=test_file oflag=direct

[Xen-devel] [v2][PATCH] xen/apic: refactor error_interrupt

2015-05-05 Thread Tiejun Chen
Just make this readable while debugging. Signed-off-by: Tiejun Chen --- v2: * Tried to refine code according to comments. xen/arch/x86/apic.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c index 321

Re: [Xen-devel] [PATCH v4 3/3] xen/iommu: arm: Use p2m_ipa_bits as stage2 input size

2015-05-05 Thread Edgar E. Iglesias
On Tue, May 05, 2015 at 03:30:10PM +0100, Julien Grall wrote: > On 05/05/15 14:59, Ian Campbell wrote: > > On Tue, 2015-05-05 at 14:48 +0100, Julien Grall wrote: > >>> Do we need to also check that we are configuring the same number of > >>> levels of PT etc, or is that already handled? > >> > >> T

[Xen-devel] [PATCH v5 3/3] xen/iommu: arm: Use p2m_ipa_bits as stage2 input size

2015-05-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The Stage2 input-size must match what the CPU uses because the SMMU and the CPU share page-tables. Test that the SMMU supports the P2M IPA bit size, use it if supported or bail out if not. Reviewed-by: Julien Grall Signed-off-by: Edgar E. Iglesias --- xen/drivers/pa

[Xen-devel] [PATCH v5 2/3] xen/arm: Add p2m_ipa_bits

2015-05-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Export p2m_ipa_bits holding the bit size of IPAs used in p2m tables. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/p2m.c| 3 +++ xen/include/asm-arm/p2m.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index

[Xen-devel] [PATCH v5 1/3] xen/arm: Re-order iommu_setup to after setup_virt_paging

2015-05-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This is needed to allow the paging setup to probe for IPA bit sizes to be used in p2m tables prior to iommu setup. Acked-by: Ian Campbell Reviewed-by: Julien Grall Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Xen-devel] [PATCH v5 0/3] Set SMMU s2 input-size based on p2m tables

2015-05-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This is a fix for the issue I'm seeing on ZynqMP with missmatched setup of the SMMU and the shared p2m page-tables with the CPU. This implements a global p2m_ipa_bits cap for S2 input-size as discussed in the previous RFC. Best regards, Edgar Changelog: v4 -> v5:

[Xen-devel] [PATCH v2] config: generate Paths-$SUBSYSTEM.mk

2015-05-05 Thread Wei Liu
... so that we can run ./configure in each subsystem. Make inclusion of Paths-*.mk mandatory. Skip generating a global Paths.mk since it's of no use anymore. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Acked-by: Ian Campbell --- v2: update .gitignore, delete Paths-*.mk in distclea

Re: [Xen-devel] [PATCH v4 2/3] xen/arm: Add p2m_ipa_bits

2015-05-05 Thread Edgar E. Iglesias
On Tue, May 05, 2015 at 02:23:23PM +0100, Ian Campbell wrote: > On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Export p2m_ipa_bits holding the bit size of IPAs used in p2m tables. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > xen/arch/a

Re: [Xen-devel] [PATCH v4 0/3] Set SMMU s2 input-size based on p2m tables

2015-05-05 Thread Edgar E. Iglesias
On Tue, May 05, 2015 at 02:17:47PM +0100, Ian Campbell wrote: > On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Hi, > > > > This is a fix for the issue I'm seeing on ZynqMP with missmatched > > setup of the SMMU and the shared p2m page-tables wit

Re: [Xen-devel] [PATCH v6 1/6] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-05-05 Thread Xu, Quan
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, May 05, 2015 10:29 PM > To: Xu, Quan; stefano.stabell...@eu.citrix.com; stef...@linux.vnet.ibm.com > Cc: qemu-de...@nongnu.org; wei.l...@citrix.com; dgde...@tycho.nsa.gov; > xen-devel@lists.xen.org > Subje

Re: [Xen-devel] [Embedded-pv-devel] Renaming Xen Project Hackathons

2015-05-05 Thread Dario Faggioli
On Tue, 2015-05-05 at 17:38 +0100, Lars Kurth wrote: > > The current proposal is to Rename the Xen Project Hackathons to either > a) Xen Project Architecture & Design Summit, > b) or Xen Project Design Summit > > > A number of people voted already for b) > on http://lists.xenproject.org/archive

Re: [Xen-devel] (release) versioning

2015-05-05 Thread Dario Faggioli
On Tue, 2015-05-05 at 18:05 +0100, Andrew Cooper wrote: > On 05/05/15 16:54, Jan Beulich wrote: > > All, > > > > on the hackathon we also discussed possibly changing the versioning > > of Xen. The main rationale for the proposal is that (just like in many > > other software projects) version number

Re: [Xen-devel] [PATCH v6 13/14] tools: add tools support for Intel CAT

2015-05-05 Thread Dario Faggioli
On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote: > This is the xc/xl changes to support Intel Cache Allocation > Technology(CAT). > > 'xl psr-hwinfo' is updated to show CAT info and two new commands > for CAT are introduced: > - xl psr-cat-cbm-set [-s socket] > Set cache capacity bitmasks(C

Re: [Xen-devel] [PATCH v6 13/14] tools: add tools support for Intel CAT

2015-05-05 Thread Dario Faggioli
On Tue, 2015-05-05 at 13:52 +0100, Ian Campbell wrote: > On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote: > > @@ -1495,10 +1495,20 @@ for any of these monitoring types. > > > > =over 4 > > > > -=item B > > +=item B [I] > > > > Show CMT hardware information. > > > > +B > > + > > +=over

[Xen-devel] [OSSTEST PATCH 0/2] Drop some irrelevant tests

2015-05-05 Thread Ian Jackson
[OSSTEST PATCH 1/2] make-flight: Drop unspecified-qemu tests [OSSTEST PATCH 2/2] make-flight: Drop qemut tests in qemuu branches I intend to force push these along with the cs-bisection-step performance fixes etc., as soon as the opportunity arises.

[Xen-devel] [OSSTEST PATCH 1/2] make-flight: Drop unspecified-qemu tests

2015-05-05 Thread Ian Jackson
The default since 4.3 onwards is qemuu only, and we do not expect it to change. Signed-off-by: Ian Jackson --- make-flight |7 +++ 1 file changed, 7 insertions(+) diff --git a/make-flight b/make-flight index 70c1900..cfe96dd 100755 --- a/make-flight +++ b/make-flight @@ -388,6 +388,13 @

[Xen-devel] [OSSTEST PATCH 2/2] make-flight: Drop qemut tests in qemuu branches

2015-05-05 Thread Ian Jackson
Signed-off-by: Ian Jackson --- make-flight |4 1 file changed, 4 insertions(+) diff --git a/make-flight b/make-flight index cfe96dd..6ac902e 100755 --- a/make-flight +++ b/make-flight @@ -399,6 +399,10 @@ test_matrix_do_one () { ;; -qemut) qemuu_runvar=device_

Re: [Xen-devel] [PATCH] OSSTEST: introduce a raisin build test

2015-05-05 Thread Stefano Stabellini
On Tue, 5 May 2015, Ian Campbell wrote: > On Fri, 2015-04-24 at 16:46 +0100, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini > > This looks like a good start, a few comments below. > > > diff --git a/ap-common b/ap-common > > index 64749e3..985eeec 100644 > > --- a/ap-common > >

Re: [Xen-devel] [PATCH] OSSTEST: introduce a raisin build test

2015-05-05 Thread Stefano Stabellini
On Tue, 5 May 2015, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH] OSSTEST: introduce a raisin build > test"): > > I agree that revisions should be passed to ts-raisin-build by osstest, > > as Ian suggested. AFAICT that should be enough to meet all your > > criteria. > > You also ne

Re: [Xen-devel] [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests

2015-05-05 Thread Boris Ostrovsky
On 05/05/2015 01:25 PM, David Vrabel wrote: On 04/05/15 16:02, Boris Ostrovsky wrote: --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -1760,6 +1760,9 @@ static struct notifier_block xen_hvm_cpu_notifier = { static void __init xen_hvm_guest_init(void) { + if (xen_pv

Re: [Xen-devel] (release) versioning

2015-05-05 Thread Andrew Cooper
On 05/05/15 16:54, Jan Beulich wrote: > All, > > on the hackathon we also discussed possibly changing the versioning > of Xen. The main rationale for the proposal is that (just like in many > other software projects) version numbers (in particular the major > one) currently don't really convey much

Re: [Xen-devel] [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests

2015-05-05 Thread David Vrabel
On 04/05/15 16:02, Boris Ostrovsky wrote: > > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1760,6 +1760,9 @@ static struct notifier_block xen_hvm_cpu_notifier = { > > static void __init xen_hvm_guest_init(void) > { > + if (xen_pv_domain()) > + return; >

Re: [Xen-devel] [PATCH 0/6] x86: reduce paravirtualized spinlock overhead

2015-05-05 Thread Jeremy Fitzhardinge
On 05/03/2015 10:55 PM, Juergen Gross wrote: > I did a small measurement of the pure locking functions on bare metal > without and with my patches. > > spin_lock() for the first time (lock and code not in cache) dropped from > about 600 to 500 cycles. > > spin_unlock() for first time dropped from 1

Re: [Xen-devel] [PATCH] OSSTEST: introduce a raisin build test

2015-05-05 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH] OSSTEST: introduce a raisin build test"): > I agree that revisions should be passed to ts-raisin-build by osstest, > as Ian suggested. AFAICT that should be enough to meet all your > criteria. You also need to call store_revision for all the trees involved,

Re: [Xen-devel] [PATCH] OSSTEST: introduce a raisin build test

2015-05-05 Thread Stefano Stabellini
On Tue, 5 May 2015, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH] OSSTEST: introduce a raisin build test"): > > On Fri, 2015-04-24 at 16:46 +0100, Stefano Stabellini wrote: > > > Signed-off-by: Stefano Stabellini > > > > This looks like a good start, a few comments below. > ... > > You s

Re: [Xen-devel] [PATCH v4 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

2015-05-05 Thread Andrew Cooper
On 05/05/15 16:47, Paul Durrant wrote: > There are actually very few HVM parameters that a guest needs to read > and even fewer that a guest needs to write. Use white-lists to specify > those parameters and also ensre that, by default, newly introduced > parameters are not accessible. > > Signed-of

Re: [Xen-devel] [PATCH] xen/arm: p2m: Restrict preemption check in apply_p2m_changes

2015-05-05 Thread Julien Grall
Hi Konrad, On 05/05/15 16:50, Konrad Rzeszutek Wilk wrote: >> --- >> xen/arch/arm/p2m.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >> index 65efa94..59dd23a 100644 >> --- a/xen/arch/arm/p2m.c >> +++ b/xen/arch/arm/p2m.c >

Re: [Xen-devel] Xen/arm: Virtual ITS command queue handling

2015-05-05 Thread Julien Grall
On 05/05/15 17:09, Vijay Kilari wrote: > On Tue, May 5, 2015 at 7:39 PM, Julien Grall wrote: >> On 05/05/15 13:14, Vijay Kilari wrote: >>> Proposal 2: >>> >>> Here when guest writes command to vITS queue and updates CWRITER registers, >>> it is trapped in XEN and below steps are f

[Xen-devel] Renaming Xen Project Hackathons

2015-05-05 Thread Lars Kurth
Hi all, one piece of feedback we got at the last and this Hackathon, was that the name for the event is really misleading. Although some Hacking goes on, in reality the event is really more of an Architecture, Design and Deployment Summit. There was some discussion about this topic last year, (

[Xen-devel] [PATCH v4 0/3] x86/hvm: HVMOP_get/set_param improvements

2015-05-05 Thread Paul Durrant
The following 3 patches re-structure the code implementing HVMOP_set_param and HVMOP_get_param. Patch #1 gives each operation its own function Patch #2 splits out checks for getting/setting non-reflexive params and setting params with change-once semantics, as well as the XSM check into separate

Re: [Xen-devel] [PATCH 1/3] xen/vt-d: need barriers to workaround CLFLUSH

2015-05-05 Thread Boris Ostrovsky
On 05/05/2015 11:58 AM, Jan Beulich wrote: On 05.05.15 at 17:46, wrote: On 05/04/2015 05:14 AM, Andrew Cooper wrote: On 04/05/2015 09:52, Jan Beulich wrote: On 04.05.15 at 04:16, wrote: --- a/xen/drivers/passthrough/vtd/x86/vtd.c +++ b/xen/drivers/passthrough/vtd/x86/vtd.c @@ -56,7 +56,9 @@

Re: [Xen-devel] [PATCH V2] xen/arm64: Use virtual address when setting up early_printk fixmap

2015-05-05 Thread Ian Campbell
On Fri, 2015-04-17 at 19:39 +0800, Chen Baozi wrote: > > > > Acked-by: Ian Campbell > > > > If it is confirmed that I got the correct meaning in the first one I can > > fix both on commit. > > Yes, please. Thanks. Done and pushed, thanks. ___ Xen-

[Xen-devel] [PATCH v4 1/3] x86/hvm: give HVMOP_set_param and HVMOP_get_param their own functions

2015-05-05 Thread Paul Durrant
The level of switch nesting in those ops is getting unreadable. Giving them their own functions does introduce some code duplication in the the pre-op checks but the overall result is easier to follow. This patch is code movement (including style fixes). There is no functional change. Signed-off-

[Xen-devel] [PATCH v4 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

2015-05-05 Thread Paul Durrant
There are actually very few HVM parameters that a guest needs to read and even fewer that a guest needs to write. Use white-lists to specify those parameters and also ensre that, by default, newly introduced parameters are not accessible. Signed-off-by: Paul Durrant Cc: Keir Fraser Cc: Jan Beuli

[Xen-devel] [PATCH v4 2/3] x86/hvm: introduce functions for HVMOP_get/set_param allowance checks

2015-05-05 Thread Paul Durrant
Some parameters can only (validly) be set once. Some should not be set by a guest for its own domain, and others must not be set since they require the domain to be paused. Consolidate these checks, along with the XSM check, in a new hvm_allow_set_param() function for clarity. Also, introduce hvm_

Re: [Xen-devel] Xen/arm: Virtual ITS command queue handling

2015-05-05 Thread Vijay Kilari
On Tue, May 5, 2015 at 7:39 PM, Julien Grall wrote: > On 05/05/15 13:14, Vijay Kilari wrote: >> Hi, >> > > Hi Vijay, > >>As discussed, here is the design doc/txt. > > I will comment on the proposal 2 as it seems to be the preferred one > assuming you are able to find why it's slow. > >> Propos

Re: [Xen-devel] [PATCH 1/3] xen/vt-d: need barriers to workaround CLFLUSH

2015-05-05 Thread Jan Beulich
>>> On 05.05.15 at 17:46, wrote: > On 05/04/2015 05:14 AM, Andrew Cooper wrote: >> On 04/05/2015 09:52, Jan Beulich wrote: >> On 04.05.15 at 04:16, wrote: --- a/xen/drivers/passthrough/vtd/x86/vtd.c +++ b/xen/drivers/passthrough/vtd/x86/vtd.c @@ -56,7 +56,9 @@ unsigned int get_

Re: [Xen-devel] Xen/arm: Virtual ITS command queue handling

2015-05-05 Thread Vijay Kilari
On Tue, May 5, 2015 at 7:21 PM, Stefano Stabellini wrote: > On Tue, 5 May 2015, Vijay Kilari wrote: >> Proposal 2: >> >> Here when guest writes command to vITS queue and updates CWRITER registers, >> it is trapped in XEN and below steps are followed to process ITS command >> >> -

[Xen-devel] (release) versioning

2015-05-05 Thread Jan Beulich
All, on the hackathon we also discussed possibly changing the versioning of Xen. The main rationale for the proposal is that (just like in many other software projects) version numbers (in particular the major one) currently don't really convey much information. The proposal is to take gcc's new v

Re: [Xen-devel] [PATCH] xen/arm: p2m: Restrict preemption check in apply_p2m_changes

2015-05-05 Thread Konrad Rzeszutek Wilk
On Tue, May 05, 2015 at 04:02:09PM +0100, Julien Grall wrote: > The commit 569fb6c "xen/arm: Data abort exception (R/W) mem_access > events" makes apply_p2m_changes to call hypercall_preempt_check for any > operation rather than for relinquish. > > The function hypercall_preempt_check call local_e

Re: [Xen-devel] [PATCH 1/3] xen/vt-d: need barriers to workaround CLFLUSH

2015-05-05 Thread Boris Ostrovsky
On 05/04/2015 05:14 AM, Andrew Cooper wrote: On 04/05/2015 09:52, Jan Beulich wrote: On 04.05.15 at 04:16, wrote: --- a/xen/drivers/passthrough/vtd/x86/vtd.c +++ b/xen/drivers/passthrough/vtd/x86/vtd.c @@ -56,7 +56,9 @@ unsigned int get_cache_line_size(void) void cacheline_flush(char * ad

Re: [Xen-devel] stable release cadence

2015-05-05 Thread Lars Kurth
> On 5 May 2015, at 16:44, Jan Beulich wrote: > > All, > > on the hackathon we discussed this topic. With the rate of changes > going into the stable trees not being as high anymore as a few > years ago, we settled on trying to stick to a 4 month release > cycle going forward. +1 Lars _

[Xen-devel] stable release cadence

2015-05-05 Thread Jan Beulich
All, on the hackathon we discussed this topic. With the rate of changes going into the stable trees not being as high anymore as a few years ago, we settled on trying to stick to a 4 month release cycle going forward. Of course, issues like the currently severely lagging osstest can always lead to

Re: [Xen-devel] [PATCH] xen/arm: p2m: Restrict preemption check in apply_p2m_changes

2015-05-05 Thread Ian Campbell
On Tue, 2015-05-05 at 16:02 +0100, Julien Grall wrote: > The commit 569fb6c "xen/arm: Data abort exception (R/W) mem_access > events" makes apply_p2m_changes to call hypercall_preempt_check for any > operation rather than for relinquish. > > The function hypercall_preempt_check call local_events_n

Re: [Xen-devel] [PATCH OSSTEST v5 04/24] Debian: refactor code to add preseed commands to the preseed file

2015-05-05 Thread Ian Campbell
On Tue, 2015-05-05 at 10:57 +0100, Ian Campbell wrote: > I did some testing of v6 over the weekend and fixed a couple of minor > regressions which I caused to test-*-debianhvm-*. A final test is > running now so I hope to post v6 either this afternoon or tomorrow AM. Unfortunately that test showed

Re: [Xen-devel] Xen-unstable-staging: Xen BUG at iommu_map.c:455

2015-05-05 Thread Jan Beulich
>>> On 05.05.15 at 17:17, wrote: > At 16:10 +0100 on 05 May (1430842206), Jan Beulich wrote: >> From what I >> can tell (and assuming other code works correctly) the fact that >> arch_iommu_populate_page_table() sets d->need_iommu to -1 >> first thing should make sure that any subsequent changes t

Re: [Xen-devel] [libvirt] [PATCH] libxl: support soundhw for hvm domains

2015-05-05 Thread Jim Fehlig
Michal Privoznik wrote: > On 04.05.2015 22:35, Jim Fehlig wrote: > >> The xend driver and the parsing/formating code in src/xenconfig >> have long supported soundhw. Add support in the libxl driver too. >> >> Signed-off-by: Jim Fehlig >> --- >> >> This patch continues the tradition of silently

Re: [Xen-devel] [PATCH V2] xen/arm64: Use virtual address when setting up early_printk fixmap

2015-05-05 Thread Julien Grall
Hi Ian, On 07/04/15 12:24, Chen Baozi wrote: > We have already had the boot pagetable when reaching the point > of early_printk fixmap setup. Thus there is no longer necessary > to calculate physical address of xen_fixmap. > > Signed-off-by: Chen Baozi This patch has been fully ack and Chen agr

Re: [Xen-devel] Xen-unstable-staging: Xen BUG at iommu_map.c:455

2015-05-05 Thread Tim Deegan
At 16:10 +0100 on 05 May (1430842206), Jan Beulich wrote: > >>> On 16.04.15 at 11:28, wrote: > > At 22:35 +0100 on 11 Apr (1428791713), Andrew Cooper wrote: > >> I am not certain that it is the correct way to fix the issue, nor that > >> the ioreq server code is the only way to trigger it. There

Re: [Xen-devel] [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

2015-05-05 Thread Jan Beulich
>>> On 05.05.15 at 16:43, wrote: > On 05/05/15 15:29, Jan Beulich wrote: > On 05.05.15 at 16:09, wrote: From: Andrew Cooper [mailto:andrew.coop...@citrix.com] Sent: 05 May 2015 11:54 On 05/05/15 11:25, Paul Durrant wrote: > @@ -5657,21 +5664,11 @@ static int hvm_allow_set_p

Re: [Xen-devel] Xen-unstable-staging: Xen BUG at iommu_map.c:455

2015-05-05 Thread Jan Beulich
>>> On 16.04.15 at 11:28, wrote: > At 22:35 +0100 on 11 Apr (1428791713), Andrew Cooper wrote: >> I am not certain that it is the correct way to fix the issue, nor that >> the ioreq server code is the only way to trigger it. There are several >> ways to shoot a gfn mapping from the guests physmap

[Xen-devel] [PATCH] xen/arm: p2m: Restrict preemption check in apply_p2m_changes

2015-05-05 Thread Julien Grall
The commit 569fb6c "xen/arm: Data abort exception (R/W) mem_access events" makes apply_p2m_changes to call hypercall_preempt_check for any operation rather than for relinquish. The function hypercall_preempt_check call local_events_need_delivery which rely on the current VCPU is not an idle VCPU.

Re: [Xen-devel] [PATCH v2 1/2] Introduce configure option --with-system-qemu-traditional

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-16 at 12:24 +0100, Stefano Stabellini wrote: > Introduce a configure option to disable the in-tree qemu-traditional > build and use an externally provided qemu-dm binary. The option is very > similar to the existing --with-system-qemu-xen. This overlaps a bit with the existing --wi

Re: [Xen-devel] [PATCH] OSSTEST: introduce a raisin build test

2015-05-05 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH] OSSTEST: introduce a raisin build test"): > On Fri, 2015-04-24 at 16:46 +0100, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini > > This looks like a good start, a few comments below. ... > You should also call store_revision() for each git repo wh

Re: [Xen-devel] [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

2015-05-05 Thread Andrew Cooper
On 05/05/15 15:29, Jan Beulich wrote: On 05.05.15 at 16:09, wrote: >>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >>> Sent: 05 May 2015 11:54 >>> On 05/05/15 11:25, Paul Durrant wrote: @@ -5657,21 +5664,11 @@ static int hvm_allow_set_param(struct domain >>> *d, case

Re: [Xen-devel] [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

2015-05-05 Thread Andrew Cooper
On 05/05/15 15:09, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 05 May 2015 11:54 >> To: Paul Durrant; xen-de...@lists.xenproject.org >> Cc: Keir (Xen.org); Jan Beulich >> Subject: Re: [PATCH v3 3/3] x86/hvm: Use white-lists fo

Re: [Xen-devel] [PATCH] xen/arm: Make local_events_need_delivery working with idle VPCU

2015-05-05 Thread Julien Grall
On 05/05/15 13:29, Ian Campbell wrote: > On Tue, 2015-05-05 at 13:00 +0100, Julien Grall wrote: >>> I'm inclined to just go with this patch for now, unless Stefano is >>> nacking it. >> >> This patch seem to turn into a workaround, would it be better to move >> check idle_check in apply_p2m_check?

Re: [Xen-devel] [PATCH v4 3/3] xen/iommu: arm: Use p2m_ipa_bits as stage2 input size

2015-05-05 Thread Julien Grall
On 05/05/15 14:59, Ian Campbell wrote: > On Tue, 2015-05-05 at 14:48 +0100, Julien Grall wrote: >>> Do we need to also check that we are configuring the same number of >>> levels of PT etc, or is that already handled? >> >> The SMMU only care about the number of IPA bits. > > What ensures that the

Re: [Xen-devel] [PATCH v6 1/6] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-05-05 Thread Eric Blake
On 05/04/2015 01:22 AM, Quan Xu wrote: > Signed-off-by: Quan Xu > > --Changes in v6: > -Remove stray insertion. > --- > configure| 14 ++ > hmp.c| 2 ++ > qapi-schema.json | 16 ++-- > qemu-options.hx | 13 +++-- > tpm.c| 7

Re: [Xen-devel] Xen/arm: Virtual ITS command queue handling

2015-05-05 Thread Julien Grall
On 05/05/15 13:14, Vijay Kilari wrote: > Hi, > Hi Vijay, >As discussed, here is the design doc/txt. I will comment on the proposal 2 as it seems to be the preferred one assuming you are able to find why it's slow. > Proposal 2: > > Here when guest writes command to vITS qu

Re: [Xen-devel] [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

2015-05-05 Thread Jan Beulich
>>> On 05.05.15 at 16:09, wrote: >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 05 May 2015 11:54 >> On 05/05/15 11:25, Paul Durrant wrote: >> > @@ -5657,21 +5664,11 @@ static int hvm_allow_set_param(struct domain >> *d, >> > case HVM_PARAM_IDENT_PT: >> > case HVM_PAR

Re: [Xen-devel] Next Document Day Moved to Wednesday, May 6

2015-05-05 Thread Russ Pavlicek
Reminder: Our Document Day is tomorrow! Theme for this month: "No-Can-Do Without a HowTo" We've got a lot of good information in the documentation, but it isn't always in a form that will help someone use a particular feature for the first time. Or, the information is present, but it might need t

Re: [Xen-devel] [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests

2015-05-05 Thread Boris Ostrovsky
On 05/05/2015 09:51 AM, Andy Lutomirski wrote: On Mon, May 4, 2015 at 8:02 AM, Boris Ostrovsky wrote: Commit 61f01dd941ba ("x86_64, asm: Work around AMD SYSRET SS descriptor attribute issue") makes AMD processors set SS to __KERNEL_DS in __switch_to() to deal with cases when SS is NULL. This b

Re: [Xen-devel] [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest accessibility checks

2015-05-05 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 05 May 2015 11:54 > To: Paul Durrant; xen-de...@lists.xenproject.org > Cc: Keir (Xen.org); Jan Beulich > Subject: Re: [PATCH v3 3/3] x86/hvm: Use white-lists for HVM param guest > accessibility checks > >

Re: [Xen-devel] [PATCH v10 00/15] Migration v2 (libxc)

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-23 at 12:48 +0100, Andrew Cooper wrote: > Presented here is v10 of the Migration v2 series (libxc subset), which is able > to function when transparently inserted under an unmodified xl/libxl. I've applied the v11 branch with my minor comments addressed which you provided privately

Re: [Xen-devel] [PATCH v4 4/5] vscsiif.h: add some notes about xenstore layout

2015-05-05 Thread Wei Liu
On Fri, Apr 17, 2015 at 08:30:59AM +, Olaf Hering wrote: > Signed-off-by: Olaf Hering > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser > Cc: Tim Deegan > --- > xen/include/public/io/vscsiif.h | 68 > + > 1 file changed, 68

Re: [Xen-devel] [PATCH v4 3/3] xen/iommu: arm: Use p2m_ipa_bits as stage2 input size

2015-05-05 Thread Ian Campbell
On Tue, 2015-05-05 at 14:48 +0100, Julien Grall wrote: > > Do we need to also check that we are configuring the same number of > > levels of PT etc, or is that already handled? > > The SMMU only care about the number of IPA bits. What ensures that the starting level of the SMMU matches the starti

Re: [Xen-devel] [PATCHv4 5/8] xen: use ticket locks for spin locks

2015-05-05 Thread David Vrabel
On 05/05/15 14:56, Ian Campbell wrote: > On Thu, 2015-04-30 at 16:33 +0100, David Vrabel wrote: >> >> void _spin_lock_irq(spinlock_t *lock) >> { >> -LOCK_PROFILE_VAR; >> - >> ASSERT(local_irq_is_enabled()); >> local_irq_disable(); >> -check_lock(&lock->debug); >> -while (

Re: [Xen-devel] [PATCHv4 5/8] xen: use ticket locks for spin locks

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-30 at 16:33 +0100, David Vrabel wrote: > > void _spin_lock_irq(spinlock_t *lock) > { > -LOCK_PROFILE_VAR; > - > ASSERT(local_irq_is_enabled()); > local_irq_disable(); > -check_lock(&lock->debug); > -while ( unlikely(!_raw_spin_trylock(&lock->raw)) ) > -

Re: [Xen-devel] [PATCH v2 0/4] raisin: introduce tests

2015-05-05 Thread Stefano Stabellini
On Tue, 5 May 2015, Ian Campbell wrote: > On Fri, 2015-05-01 at 16:48 +0100, Stefano Stabellini wrote: > > Hi all, > > > > this patch series introduces a framework to execute simple unit and > > functional tests in raisin. It can be used by developers to validate > > their changes before submittin

Re: [Xen-devel] [PATCH v4 3/5] libxl: add support for vscsi

2015-05-05 Thread Wei Liu
On Fri, Apr 17, 2015 at 08:30:58AM +, Olaf Hering wrote: > Port pvscsi support from xend to libxl: > > vscsi=['pdev,vdev{,options}'] > xl scsi-attach > xl scsi-detach > xl scsi-list > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei

Re: [Xen-devel] Xen/arm: Virtual ITS command queue handling

2015-05-05 Thread Julien Grall
On 05/05/15 14:51, Stefano Stabellini wrote: >> - With this irq/LPI descriptor we can identify the domain/vITS. >> - Info of all the ongoing ITS requests(put in pITS Queue) of this domain is >> stored in ITS command status array (called its_requests). This is >> managed per vITS. >> >> 1) Trap of

Re: [Xen-devel] [PATCHv4 4/8] arm: provide add_sized()

2015-05-05 Thread Tim Deegan
At 14:49 +0100 on 05 May (1430837355), Ian Campbell wrote: > On Thu, 2015-04-30 at 16:33 +0100, David Vrabel wrote: > > add_sized(ptr, inc) adds inc to the value at ptr using only the correct > > size of loads and stores for the type of *ptr. The add is /not/ atomic. > > atomic.h is an odd place

Re: [Xen-devel] [PATCH V3] xen: arm: X-Gene Storm check GIC DIST address for EOI quirk

2015-05-05 Thread Julien Grall
Hi Pranav, On 29/04/15 10:38, Pranavkumar Sawargaonkar wrote: > In old X-Gene Storm firmware and DT, secure mode addresses have been > mentioned in GICv2 node. In this case maintenance interrupt is used > instead of EOI HW method. > > This patch checks the GIC Distributor Base Address to enable E

Re: [Xen-devel] Xen/arm: Virtual ITS command queue handling

2015-05-05 Thread Stefano Stabellini
On Tue, 5 May 2015, Vijay Kilari wrote: > Proposal 2: > > Here when guest writes command to vITS queue and updates CWRITER registers, > it is trapped in XEN and below steps are followed to process ITS command > > - Dom0 creates a ITS completion device with device id (00:00.1) and

Re: [Xen-devel] [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests

2015-05-05 Thread Andy Lutomirski
On Mon, May 4, 2015 at 8:02 AM, Boris Ostrovsky wrote: > Commit 61f01dd941ba ("x86_64, asm: Work around AMD SYSRET SS descriptor > attribute issue") makes AMD processors set SS to __KERNEL_DS in > __switch_to() to deal with cases when SS is NULL. > > This breaks Xen PV guests who do not want to lo

Re: [Xen-devel] [PATCHv4 6/8] x86, arm: remove asm/spinlock.h from all architectures

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-30 at 16:33 +0100, David Vrabel wrote: > Now that all architecture use a common ticket lock implementation for > spinlocks, remove the architecture specific byte lock implementations. > > Signed-off-by: David Vrabel > Reviewed-by: Tim Deegan > Acked-by: Jan Beulich Acked-by: Ia

Re: [Xen-devel] [PATCHv4 4/8] arm: provide add_sized()

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-30 at 16:33 +0100, David Vrabel wrote: > add_sized(ptr, inc) adds inc to the value at ptr using only the correct > size of loads and stores for the type of *ptr. The add is /not/ atomic. atomic.h is an odd place for it then ;-) But given you use the infrastructure I can't suggest

Re: [Xen-devel] [PATCH v4 3/3] xen/iommu: arm: Use p2m_ipa_bits as stage2 input size

2015-05-05 Thread Julien Grall
Hi Ian, On 05/05/15 14:24, Ian Campbell wrote: > On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: >> From: "Edgar E. Iglesias" >> >> The Stage2 input-size must match what the CPU uses because >> the SMMU and the CPU share page-tables. >> >> Test that the SMMU supports the P2M IPA bit s

Re: [Xen-devel] [PATCH v4 0/3] Set SMMU s2 input-size based on p2m tables

2015-05-05 Thread Julien Grall
Hi Ian, On 05/05/15 14:17, Ian Campbell wrote: > On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: >> From: "Edgar E. Iglesias" >> >> Hi, >> >> This is a fix for the issue I'm seeing on ZynqMP with missmatched >> setup of the SMMU and the shared p2m page-tables with the CPU. > > Lookin

Re: [Xen-devel] [PATCH v4 3/3] xen/iommu: arm: Use p2m_ipa_bits as stage2 input size

2015-05-05 Thread Ian Campbell
On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > The Stage2 input-size must match what the CPU uses because > the SMMU and the CPU share page-tables. > > Test that the SMMU supports the P2M IPA bit size, use it if > supported or bail out if not. > > Si

Re: [Xen-devel] [PATCH v10 14/15] docs: libxc migration stream specification

2015-05-05 Thread Ian Campbell
On Tue, 2015-05-05 at 14:04 +0100, Andrew Cooper wrote: > On 05/05/15 14:03, Ian Campbell wrote: > > On Thu, 2015-04-23 at 12:48 +0100, Andrew Cooper wrote: > >> From: David Vrabel > >> > >> Add the specification for a new migration stream format. The document > >> includes all the details but to

Re: [Xen-devel] [PATCH v4 2/3] xen/arm: Add p2m_ipa_bits

2015-05-05 Thread Ian Campbell
On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Export p2m_ipa_bits holding the bit size of IPAs used in p2m tables. > > Signed-off-by: Edgar E. Iglesias > --- > xen/arch/arm/p2m.c| 5 + > xen/include/asm-arm/p2m.h | 3 +++ > 2 files chan

Re: [Xen-devel] [PATCH v4 1/3] xen/arm: Re-order iommu_setup to after setup_virt_paging

2015-05-05 Thread Ian Campbell
On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > This is needed to allow the paging setup to probe for > IPA bit sizes to be used in p2m tables prior to iommu setup. > > Reviewed-by: Julien Grall > Signed-off-by: Edgar E. Iglesias This seems like a m

Re: [Xen-devel] [PATCH v4 0/3] Set SMMU s2 input-size based on p2m tables

2015-05-05 Thread Ian Campbell
On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > This is a fix for the issue I'm seeing on ZynqMP with missmatched > setup of the SMMU and the shared p2m page-tables with the CPU. Looking back at previous conversations it seems like your SMMU h

Re: [Xen-devel] Xen 4.6 Development Update (three months reminder)

2015-05-05 Thread Yu, Zhang
Thank you, Wei. On 5/5/2015 5:12 PM, Wei Liu wrote: On Mon, May 04, 2015 at 08:51:56PM +0800, Yu, Zhang wrote: Hi Wei, Thanks for your reply. On 5/4/2015 5:44 PM, Wei Liu wrote: (Thanks for trimming the CC list before hand) On Mon, May 04, 2015 at 02:05:49PM +0800, Yu, Zhang wrote: Hi Wei,

Re: [Xen-devel] [PATCH v10 14/15] docs: libxc migration stream specification

2015-05-05 Thread Andrew Cooper
On 05/05/15 14:03, Ian Campbell wrote: > On Thu, 2015-04-23 at 12:48 +0100, Andrew Cooper wrote: >> From: David Vrabel >> >> Add the specification for a new migration stream format. The document >> includes all the details but to summarize: >> >> The existing (legacy) format is dependant on the w

Re: [Xen-devel] [PATCH v10 14/15] docs: libxc migration stream specification

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-23 at 12:48 +0100, Andrew Cooper wrote: > From: David Vrabel > > Add the specification for a new migration stream format. The document > includes all the details but to summarize: > > The existing (legacy) format is dependant on the word size of the > toolstack. This prevents d

Re: [Xen-devel] [PATCH v10 09/15] tools/libxc: x86 PV restore code

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-23 at 12:48 +0100, Andrew Cooper wrote: > + * Set a pfn as populated, expanding the tracking structures if needed. To > + * avoid realloc()ing too excessivly, the size increased to the nearest power "excessively". Otherwise: Acked-by: Ian Campbell

Re: [Xen-devel] [PATCH v10 02/15] libxc/progress: Extend the progress interface

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-23 at 12:48 +0100, Andrew Cooper wrote: > Progress information is logged via a different logger to regular libxc log > messages, and currently can only express a range. However, not everything > which needs reporting as progress comes with a range. Extend the interface to > allow

Re: [Xen-devel] [PATCH v6 14/14] docs: add xl-psr.markdown

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote: > +Maximum RMID and supported monitor types in the system can be obtained by: > + > +`xl psr-cmt-hwinfo` I think this is now `xl psr-hwinfo --cmt` ? > +For example, assuming a system with 8 portions and 3 domains: > + > + * A CBM of 0xff for ev

Re: [Xen-devel] [PATCH v6 13/14] tools: add tools support for Intel CAT

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote: > This is the xc/xl changes to support Intel Cache Allocation > Technology(CAT). > > 'xl psr-hwinfo' is updated to show CAT info and two new commands > for CAT are introduced: > - xl psr-cat-cbm-set [-s socket] > Set cache capacity bitmasks(C

Re: [Xen-devel] [PATCH v6 12/14] tools/libxl: introduce some socket helpers

2015-05-05 Thread Ian Campbell
On Tue, 2015-05-05 at 13:43 +0100, Ian Campbell wrote: > On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote: > > Add libxl_socket_bitmap_alloc() to allow allocating a socket specific > > libxl_bitmap (as it is for cpu/node bitmap). > > > > Internal function libxl__count_physical_sockets() is intro

Re: [Xen-devel] [PATCH v6 12/14] tools/libxl: introduce some socket helpers

2015-05-05 Thread Ian Campbell
On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote: > Add libxl_socket_bitmap_alloc() to allow allocating a socket specific > libxl_bitmap (as it is for cpu/node bitmap). > > Internal function libxl__count_physical_sockets() is introduced together > to get the socket count when the size of bitmap

[Xen-devel] [ovmf test] 53015: regressions - FAIL

2015-05-05 Thread osstest service user
flight 53015 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/53015/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 13 guest-localmigrate fail REGR. vs. 52776 test-amd64-amd64-xl-qemut-de

Re: [Xen-devel] [PATCHv7 3/3] gnttab: use per-VCPU maptrack free lists

2015-05-05 Thread Jan Beulich
>>> On 30.04.15 at 15:28, wrote: > From: Malcolm Crossley > > Performance analysis of aggregate network throughput with many VMs > shows that performance is signficantly limited by contention on the > maptrack lock when obtaining/releasing maptrack handles from the free > list. > > Instead of a

Re: [Xen-devel] [PATCH] xen/arm: Make local_events_need_delivery working with idle VPCU

2015-05-05 Thread Ian Campbell
On Tue, 2015-05-05 at 13:00 +0100, Julien Grall wrote: > > I'm inclined to just go with this patch for now, unless Stefano is > > nacking it. > > This patch seem to turn into a workaround, would it be better to move > check idle_check in apply_p2m_check? > > I will prepare a follow-up to avoid pr

Re: [Xen-devel] [PATCH V3] xen: arm: X-Gene Storm check GIC DIST address for EOI quirk

2015-05-05 Thread Ian Campbell
On Wed, 2015-04-29 at 15:08 +0530, Pranavkumar Sawargaonkar wrote: > In old X-Gene Storm firmware and DT, secure mode addresses have been > mentioned in GICv2 node. In this case maintenance interrupt is used > instead of EOI HW method. > > This patch checks the GIC Distributor Base Address to enab

  1   2   >