On 05/05/15 15:29, Jan Beulich wrote: >>>> On 05.05.15 at 16:09, <paul.durr...@citrix.com> wrote: >>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >>> Sent: 05 May 2015 11:54 >>> On 05/05/15 11:25, Paul Durrant wrote: >>>> @@ -5657,21 +5664,11 @@ static int hvm_allow_set_param(struct domain >>> *d, >>>> case HVM_PARAM_IDENT_PT: >>>> case HVM_PARAM_DM_DOMAIN: >>>> case HVM_PARAM_ACPI_S_STATE: >>> I think you can safely elide the above cases into default. All that >>> matters in this case is that none of the whitelisted parameters need to >>> pause the domain. >>> >> I think you and Jan differ there, unless I misunderstood Jan. > Right, I specifically asked for these to be retained. It's just that > the comment preceding them is not visible from the patch > context, so that purpose isn't obvious here.
I would question its usefulness as documentation, given that its position in the code is now removed from the actual implementation. However, I am not sufficiently fussed to block an otherwise-good change. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
