[Xen-devel] [linux-3.10 test] 35908: regressions - FAIL

2015-03-06 Thread xen . org
flight 35908 linux-3.10 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35908/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-winxpsp3 7 windows-install fail REGR. vs. 26303 Tests which are failin

[Xen-devel] Outreachy (OPW) Mentors: Please update your project ideas

2015-03-06 Thread Russ Pavlicek
Xen Project has two slots in the upcoming Round 10 of Outreachy (the new name for OPW). All prospective mentors need to update their project ideas soon on the page: http://wiki.xenproject.org/wiki/Outreach_Program_Projects Applicants have to create initial patches and file their applications by M

[Xen-devel] [linux-3.16 test] 35902: regressions - FAIL

2015-03-06 Thread xen . org
flight 35902 linux-3.16 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 15 guest-localmigrate/x10fail REGR. vs. 34167 test-amd64-i386-pair

[Xen-devel] [PATCH v4 0/2] flask: Handle policy load failures properly

2015-03-06 Thread Daniel De Graaf
Chagnes from v3: - Moved documentation to xen-command-line.markdown Changes from v2: - Add "flask=" parameter and split off cleanup patch [PATCH 1/2] flask: clean up initialization and #defines [PATCH 2/2] flask: create unified "flask=" boot parameter __

[Xen-devel] [PATCH 2/2] flask: create unified "flask=" boot parameter

2015-03-06 Thread Daniel De Graaf
This unifies the flask_enforcing and flask_enabled boot parameters into a single parameter with additional states. Defined options are: force - require policy to be loaded at boot time and enforce it late - bootloader policy is not used; later loadpolicy is enforcing permissive - a missing or

[Xen-devel] [PATCH 1/2] flask: clean up initialization and #defines

2015-03-06 Thread Daniel De Graaf
This removes the FLASK_DEVELOP and FLASK_BOOTPARAM configuration parameters which have never been settable by users. Disabling the FLASK_DEVELOP configuration option has not produced a compiling hypervisor for some time, and the FLASK_BOOTPARAM option will be replaced with a more flexible boot par

[Xen-devel] [PATCH V13 6/7] xen/arm: Enable mem_access on ARM

2015-03-06 Thread Tamas K Lengyel
Signed-off-by: Tamas K Lengyel --- config/arm32.mk | 1 + config/arm64.mk | 1 + 2 files changed, 2 insertions(+) diff --git a/config/arm32.mk b/config/arm32.mk index 268ca9c..cd97e42 100644 --- a/config/arm32.mk +++ b/config/arm32.mk @@ -14,6 +14,7 @@ HAS_EXYNOS4210 := y HAS_OMAP := y HAS_SCI

[Xen-devel] [PATCH V13 5/7] xen/arm: Instruction prefetch abort (X) mem_event handling

2015-03-06 Thread Tamas K Lengyel
Add missing structure definition for iabt and update the trap handling mechanism to only inject the exception if the mem_access checker decides to do so. Signed-off-by: Tamas K Lengyel Acked-by: Ian Campbell Reviewed-by: Julien Grall --- v10: - Minor comment fix for describing s1ptw. v8: - Rev

[Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-06 Thread Tamas K Lengyel
This patch enables to store, set, check and deliver LPAE R/W mem_events. As the LPAE PTE's lack enough available software programmable bits, we store the permissions in a Radix tree. The tree is only looked at if mem_access_enabled is turned on. Signed-off-by: Tamas K Lengyel --- v12: - Move the

[Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-06 Thread Tamas K Lengyel
Add necessary changes for page table construction routines to pass the default access information. We store the p2m_access_t info in a Radix tree as the PTE lacks enough software programmable bits. Signed-off-by: Tamas K Lengyel --- v13: - Rename access_in_use to mem_access_enabled. - Define

[Xen-devel] [PATCH V13 0/7] Mem_access for ARM

2015-03-06 Thread Tamas K Lengyel
The ARM virtualization extension provides 2-stage paging, a similar mechanisms to Intel's EPT, which can be used to trace the memory accesses performed by the guest systems. This series sets up the necessary infrastructure in the ARM code to deliver the event on R/W/X traps. Finally, we turn on the

[Xen-devel] [PATCH V13 2/7] xen/arm: Implement domain_get_maximum_gpfn

2015-03-06 Thread Tamas K Lengyel
From: Julien Grall The function domain_get_maximum_gpfn is returning the maximum gpfn ever mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose. We use this in xenaccess as to avoid the user attempting to set page permissions on pages which don't exist for the domain, as a

[Xen-devel] [PATCH V13 3/7] xen/arm: Allow hypervisor access to mem_access protected pages

2015-03-06 Thread Tamas K Lengyel
The guestcopy helpers use the MMU to verify that the given guest has read/write access to a given page during hypercalls. As we may have custom mem_access permissions set on these pages, we do a software-based type checking in case the MMU based approach failed, but only if mem_access_enabled is se

[Xen-devel] [PATCH V13 7/7] tools/libxc: Allocate magic page for mem access on ARM

2015-03-06 Thread Tamas K Lengyel
Signed-off-by: Tamas K Lengyel Reviewed-by: Julien Grall Acked-by: Stefano Stabellini --- tools/libxc/xc_dom_arm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c index c7feca7..aaf835c 100644 --- a/tools/libxc/xc_dom_

[Xen-devel] [ovmf test] 35899: tolerable FAIL - PUSHED

2015-03-06 Thread xen . org
flight 35899 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35899/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-libvirt 13 guest-destroy fail REGR. vs. 35825 test-amd64-i386-pair17 guest-

Re: [Xen-devel] [PATCH 1/9] docs: RTDS is a valid alternative as a scheduler for a cpupool

2015-03-06 Thread Meng Xu
2015-03-06 12:20 GMT-05:00 Dario Faggioli : > so update the relevant manpage and the example file. > > Signed-off-by: Dario Faggioli > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Wei Liu > Cc: Juergen Gross > Cc: Meng Xu > --- > docs/man/xlcpupool.cfg.pod.5 |4 +++

[Xen-devel] [PATCH v2 6/6] tools/libxl: Adjust datacopiers POLLHUP handling when the fd is also readable

2015-03-06 Thread Andrew Cooper
POLLHUP|POLLIN is a valid revent to receive when there is readable data in a pipe, but the writable fd has been closed. This occurs in migration v2 when the legacy conversion process (which transforms the data inline) completes and exits successfully. In the case that there is data to read, suppr

[Xen-devel] [PATCH v2 3/6] tools/libxl: Avoid overrunning static buffer with prefixdata

2015-03-06 Thread Andrew Cooper
From: Ross Lagerwall An individual datacopier_buf contains a static buffer of 1000 bytes. Attempting to add prefixdata of more than 1000 bytes would overrun the buffer and cause heap corruption. Instead, split the prefixdata and chain together multiple datacopier buffers. This allows for an arbi

[Xen-devel] [PATCH v2 5/6] tools/libxl: Extend datacopier to support reading into a buffer

2015-03-06 Thread Andrew Cooper
From: Ross Lagerwall Currently a datacopier may source its data from an fd or local buffer, but its destination must be an fd. For migration v2, libxl needs to read from the migration stream into a local buffer. Implement a "read into local buffer" mode, invoked when readbuf is set and writefd

[Xen-devel] [PATCH v2 1/6] tools/libxl: Introduce min and max macros

2015-03-06 Thread Andrew Cooper
This is the same set used by libxc. Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- v2: Don't use reserved identifiers in min_t/max_t --- tools/libxl/libxl_internal.h | 16 1 file changed, 16 insertions(+) diff --git a/tools/libxl/libxl_inter

[Xen-devel] [PATCH v2 4/6] tools/libxl: Allow limiting amount copied by datacopier

2015-03-06 Thread Andrew Cooper
From: Ross Lagerwall Currently, a datacopier will unconditionally read until EOF on its read fd. For migration v2, libxl needs to read records of a specific length out of the migration stream, without reading any further data. Introduce a parameter, maxread, which may be used to stop the dataco

[Xen-devel] [PATCH v2 0/6] tools/libxl: Improvements to libxl__datacopier

2015-03-06 Thread Andrew Cooper
To support migration v2, we need far more flexibility out of the datacopier. This series adds the ability to read from an fd into a local buffer and to copy a specific number of bytes rather than to EOF. It also contains bugfixes related to writing from a local buffer, and POLLHUP handling. Chan

[Xen-devel] [PATCH v2 2/6] tools/libxl: Update datacopier to support sending data only

2015-03-06 Thread Andrew Cooper
From: Wen Congyang Currently, starting a datacopier requires a valid read and write fd, but this is a problem when purely sending data from a local buffer to a writable fd. The prefixdata mechanism already exists and works for inserting data from a local buffer ahead of reading from the read fd.

Re: [Xen-devel] [PATCH 2/2] flask: create unified "flask=" boot parameter

2015-03-06 Thread Daniel De Graaf
On 03/06/2015 07:22 AM, Wei Liu wrote: On Tue, Mar 03, 2015 at 12:00:19PM -0500, Daniel De Graaf wrote: [...] diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1 index 6b89ba8..48b8f98 100644 --- a/docs/man/xl.pod.1 +++ b/docs/man/xl.pod.1 @@ -1441,8 +1441,8 @@ Determine if the FLASK security mod

Re: [Xen-devel] [patch] xen/mce: fix up xen_late_init_mcelog() error handling

2015-03-06 Thread Konrad Rzeszutek Wilk
On Thu, Mar 05, 2015 at 02:24:17PM +0300, Dan Carpenter wrote: > Static checkers complain about the missing call to misc_deregister() if > bind_virq_for_mce() fails. > > Also I reversed the tests so that we do error handling instead of > success handling. That way we just have a series of functio

Re: [Xen-devel] RFC: xen config changes v4

2015-03-06 Thread Roger Pau Monné
El 06/03/15 a les 19.08, Luis R. Rodriguez ha escrit: > On Fri, Mar 06, 2015 at 01:02:03PM -0500, Konrad Rzeszutek Wilk wrote: >> The distro is Red Hat. > > Why would Red Hat enable Linux Xen backend drivers without dom0? Driver domains? That's the only reason to have backends in a non-dom0 kerne

Re: [Xen-devel] [PATCH 2/4] libxl_wait_for_memory_target: wait as long as dom0 is making progress

2015-03-06 Thread Jim Fehlig
Stefano Stabellini wrote: > Decrement wait_secs only if dom0 is making no progress toward reaching > the balloon target, otherwise loop again for free. > > Signed-off-by: Stefano Stabellini > Tested-by: Mike Latimer > --- > tools/libxl/libxl.c | 29 ++--- > tools/l

Re: [Xen-devel] RFC: xen config changes v4

2015-03-06 Thread Luis R. Rodriguez
On Fri, Mar 06, 2015 at 01:02:03PM -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 06, 2015 at 09:17:36AM -0800, Luis R. Rodriguez wrote: > > Hey Konrad, just a friendly reminder, the backend question for GPL > > kernels interests me specially in light of recent events. > > GPL kernels? Aren't a

Re: [Xen-devel] RFC: xen config changes v4

2015-03-06 Thread Konrad Rzeszutek Wilk
On Fri, Mar 06, 2015 at 09:17:36AM -0800, Luis R. Rodriguez wrote: > Hey Konrad, just a friendly reminder, the backend question for GPL > kernels interests me specially in light of recent events. GPL kernels? Aren't all Linux kernels GPL? > > On Mon, Mar 2, 2015 at 12:39 PM, Luis R. Rodriguez w

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Jim Fehlig
Stefano Stabellini wrote: > On Fri, 6 Mar 2015, Ian Campbell wrote: > >> This is missing my point. >> >> We need to consider the case of a modified libvirt with the old, broken, >> libxl too. >> > > For that case, we might want to make sure that the new timeout passed to > libxl_wait_for_me

Re: [Xen-devel] [PATCHv6 2/3] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-06 Thread David Vrabel
On 06/03/15 17:51, Stefano Stabellini wrote: > On Fri, 6 Mar 2015, David Vrabel wrote: >> Auto-translated physmap guests (arm, arm64 and x86 PVHVM/PVH) map and >> unmap foreign GFNs using the same method (updating the physmap). >> Unify the two arm and x86 implementations into one commont one. >> >

[Xen-devel] [libvirt test] 35907: regressions - FAIL

2015-03-06 Thread xen . org
flight 35907 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35907/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt 12 guest-start.2 fail REGR. vs. 35524 Tests which did not succe

Re: [Xen-devel] [PATCHv6 2/3] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-06 Thread Stefano Stabellini
On Fri, 6 Mar 2015, David Vrabel wrote: > Auto-translated physmap guests (arm, arm64 and x86 PVHVM/PVH) map and > unmap foreign GFNs using the same method (updating the physmap). > Unify the two arm and x86 implementations into one commont one. > > Note that on arm and arm64, the correct error cod

[Xen-devel] [qemu-mainline test] 35893: tolerable FAIL - PUSHED

2015-03-06 Thread xen . org
flight 35893 qemu-mainline real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35893/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 12 guest-start.2 fail REGR. vs. 35572 test-amd64-i386-pair

Re: [Xen-devel] [PATCHv6 2/3] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-06 Thread David Vrabel
On 06/03/15 15:51, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 06, 2015 at 12:58:34PM +, David Vrabel wrote: >> >> --- /dev/null >> +++ b/drivers/xen/xlate_mmu.c >> @@ -0,0 +1,133 @@ >> +/* >> + * MMU operations common to all auto-translated physmap guests. >> + * >> + * Copyright (C) 2015 Citr

Re: [Xen-devel] GSoC 2015 - Not accepted ... but some mentoring organisations which have several Xen related projects in them are

2015-03-06 Thread Russell Pavlicek
I reached out to the GSoC people to get information on why we were not accepted. The response is not surprising: Carol writes: "We had to make a lot of hard decisions with our GSoC organizations this year, and unfortunately yours was one of them. We focused a lot on trying to make space and ac

Re: [Xen-devel] [PATCH RFC V2 4/5] xl: add pvusb commands

2015-03-06 Thread George Dunlap
On Mon, Jan 19, 2015 at 8:28 AM, Chunyan Liu wrote: > Add pvusb commands. > > To attach a usb device to guest through pvusb, one could follow > following example: > > #xl usb-ctrl-attach test_vm version=1 num_ports=8 This doesn't allow you to specify controller name or devid. I was looking at t

[Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-06 Thread Dario Faggioli
with the rest of the file, where we return 1 on 0, rather than using libxl error codes. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu Cc: Juergen Gross --- tools/libxl/xl_cmdimpl.c | 69 -- 1 f

[Xen-devel] [PATCH 6/9] xl: enable using ranges of pCPUs when manipulating cpupools

2015-03-06 Thread Dario Faggioli
in fact, right now, xl sub-commands 'cpupool-cpu-add' and 'cpupool-cpu-remove' only accept the specification of one pCPU to be added or removed to/from a cpupool. With this change, they can deal with ranges, like "4-8", or "node:1,12-18,^14". The syntax is exactly the same one that is supported by

[Xen-devel] [PATCH 7/9] xl: enable using ranges of pCPUs when creating cpupools

2015-03-06 Thread Dario Faggioli
instead of just list of single pCPUs or NUMA node IDs, as it happens right now. On the other hand, after this change, strings containing pCPUs and NUMA node ranges is supported. The syntax is the same one supported by the "cpus" and "cpus_soft" config switch, i.e., "4-8" or "node:1,12-18,^14". Th

[Xen-devel] [PATCH 1/9] docs: RTDS is a valid alternative as a scheduler for a cpupool

2015-03-06 Thread Dario Faggioli
so update the relevant manpage and the example file. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu Cc: Juergen Gross Cc: Meng Xu --- docs/man/xlcpupool.cfg.pod.5 |4 tools/examples/cpupool |2 +- 2 files changed, 5 inse

[Xen-devel] [PATCH 5/9] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap()

2015-03-06 Thread Dario Faggioli
To add (removes) to (from) a cpupool all the pCPUs corresponding to the bits that are set in the passed bitmap. This is convenient and useful in order to implement, in xl, the possibility of specifying ranges of pCPUs to be added (removed) to (from) a cpupool, in the relevant commands. While ther

[Xen-devel] [PATCH 4/9] xl: add -c/--cpupool option to `xl list'

2015-03-06 Thread Dario Faggioli
which, if provided, makes the command print a column with the name of the cpupool of the listed domain(s). Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu Cc: Juergen Gross --- docs/man/xl.pod.1 |4 tools/libxl/xl_cmdimpl.c

[Xen-devel] [PATCH v2 3/4] freemem: remove call to libxl_wait_for_free_memory

2015-03-06 Thread Stefano Stabellini
Now that libxl_wait_for_memory_target is capable of waiting until dom0 reaches its target, we can remove the other wait function call: libxl_wait_for_free_memory. No need to wait twice. Once dom0 has met its target, simply loop again and recalculate free_memkb. Signed-off-by: Stefano Stabellini R

[Xen-devel] [PATCH 9/9] xl: use libxl_cpupoolinfo_list_free() in main_cpupoolnumasplit

2015-03-06 Thread Dario Faggioli
instead manually free the elements of the list, which is exactly the purpose of the said function. Trade also a couple of 'return'-s with 'goto out'-s, which is more in line with libxl usage paradigm. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: We

[Xen-devel] [PATCH 3/9] xl: turn some int local variable into bool

2015-03-06 Thread Dario Faggioli
more specifically, the ones used as argument presence flags in `xl list'. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu --- tools/libxl/xl_cmdimpl.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/

[Xen-devel] [PATCH 2/9] docs: fix `xl list' manpage entry

2015-03-06 Thread Dario Faggioli
as it was not covering the '-n' option, which is present since d743a223 ("xl: add node-affinity to the output of `xl list`"). Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu --- docs/man/xl.pod.1 |4 1 file changed, 4 insertions(+)

[Xen-devel] [PATCH 0/9] Some (not only) cpupool related fixes and improvements

2015-03-06 Thread Dario Faggioli
Hi everyone, The main goal of this series is making it possible to specify ranges of pCPUs when manipulating (creating, adding/removing pCPUs) cpupools. Something like this: xl cpupool-cpu-remove Pool-node0 6-10 while, right now, only single pCPU IDs can be specified, which means that, to achie

[Xen-devel] [PATCH v2 1/4] Revert "libxl: Wait for ballooning if free memory is increasing"

2015-03-06 Thread Stefano Stabellini
This reverts commit 2563bca11544361dc2afa5e20b5663e10a0715cb. Reviewed-by: Mike Latimer Tested-by: Mike Latimer --- tools/libxl/xl_cmdimpl.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index e41f633

[Xen-devel] [PATCH v2 4/4] libxl_wait_for_memory_target: wait for 2 sec at a time

2015-03-06 Thread Stefano Stabellini
Use a 2 sec sleep time in the loop to allow the guest to release a decent amount of memory in an iteration (empirical tests show ballooning speed to be 512MB/sec or recent boxes). Signed-off-by: Stefano Stabellini Reviewed-by: Mike Latimer Tested-by: Mike Latimer --- tools/libxl/libxl.c |4

[Xen-devel] [PATCH v2 2/4] libxl_wait_for_memory_target: wait as long as dom0 is making progress

2015-03-06 Thread Stefano Stabellini
Decrement wait_secs only if dom0 is making no progress toward reaching the balloon target, otherwise loop again for free. Signed-off-by: Stefano Stabellini Reviewed-by: Mike Latimer Tested-by: Mike Latimer --- tools/libxl/libxl.c | 29 ++--- tools/libxl/libxl.h

Re: [Xen-devel] RFC: xen config changes v4

2015-03-06 Thread Luis R. Rodriguez
Hey Konrad, just a friendly reminder, the backend question for GPL kernels interests me specially in light of recent events. On Mon, Mar 2, 2015 at 12:39 PM, Luis R. Rodriguez wrote: > On Fri, Feb 27, 2015 at 10:27 AM, Konrad Rzeszutek Wilk > wrote: >> There was another reason. Some distros remo

[Xen-devel] [PATCH v2 0/4] fix freemem loop

2015-03-06 Thread Stefano Stabellini
Hi all, this patch series fixes the freemem loop on machines with very large amount of memory, where the current wait time is not enough. In order to be able to handle arbitrarly large amount of ram, we implement in libxl_wait_for_memory_target a policy of waiting until dom0 is making progress.

Re: [Xen-devel] [PATCH v2] sched: credit2: respect per-vcpu hard affinity

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 15:18 +, George Dunlap wrote: > On 03/03/2015 03:15 AM, Dario Faggioli wrote: > > On Sun, 2015-02-08 at 17:45 -1000, Justin T. Weaver wrote: > >> /* > >> + * Use this to avoid having too many cpumask_t structs on the stack > >> + */ > >> +static cpumask_t **cpumask = NUL

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 04:11:53PM +, Wei Liu wrote: > On Fri, Mar 06, 2015 at 02:30:27PM +, Ian Jackson wrote: > > Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number > > when parsing values"): > > > Ack. This is how it looks like now. The changes are > > > > > >

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 02:30:27PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number > when parsing values"): > > Ack. This is how it looks like now. The changes are > > > > 1. Use YYLTYPE instead of line and column. > > This is better but wh

Re: [Xen-devel] [PATCH RFC V2 3/5] libxl: add pvusb API

2015-03-06 Thread George Dunlap
On Mon, Jan 19, 2015 at 8:28 AM, Chunyan Liu wrote: > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h > index 0a123f1..2e89244 100644 > --- a/tools/libxl/libxl.h > +++ b/tools/libxl/libxl.h > +int libxl_intf_to_device_usb(libxl_ctx *ctx, uint32_t domid, > +char

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 04:25:54PM +0100, Olaf Hering wrote: > On Fri, Mar 06, Wei Liu wrote: > > > I think you need to fix some overly long lines. I won't mention them > > individually inline. > > Some are just copy&paste from other places. I will check what can be > trimmed. > > > Regarding al

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-06 Thread Luis R. Rodriguez
On Fri, Mar 06, 2015 at 11:02:50AM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 04, 2015 at 05:47:03PM -0800, Luis R. Rodriguez wrote: > > On Wed, Mar 4, 2015 at 6:36 AM, Andrey Ryabinin > > wrote: > > > On 03/03/2015 07:02 PM, Konrad Rzeszutek Wilk wrote: > > >> If it is like that - then ju

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-06 Thread Konrad Rzeszutek Wilk
On Wed, Mar 04, 2015 at 05:47:03PM -0800, Luis R. Rodriguez wrote: > On Wed, Mar 4, 2015 at 6:36 AM, Andrey Ryabinin > wrote: > > On 03/03/2015 07:02 PM, Konrad Rzeszutek Wilk wrote: > >> If it is like that - then just using what had to be implemented > >> for the stack protection as a template o

Re: [Xen-devel] [PATCHv6 2/3] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-06 Thread Konrad Rzeszutek Wilk
On Fri, Mar 06, 2015 at 12:58:34PM +, David Vrabel wrote: > Auto-translated physmap guests (arm, arm64 and x86 PVHVM/PVH) map and > unmap foreign GFNs using the same method (updating the physmap). > Unify the two arm and x86 implementations into one commont one. > > Note that on arm and arm64,

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 14:57 +, George Dunlap wrote: > On 03/06/2015 01:31 PM, Dario Faggioli wrote: > > It's also exactly my point. In fact, in this case, adding something like > > what you're suggesting to the comment seems to me to be aimed at making > > the reader able to understand the cod

Re: [Xen-devel] [PATCH 1/5 v2] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Andrew Cooper
On 06/03/2015 09:19, Jan Beulich wrote: > ... by introducing a "dom0_nodes" option augmenting the "dom0_mem" and > "dom0_max_vcpus" ones. > > Note that this gives meaning to MEMF_exact_node specified alone (i.e. > implicitly combined with NUMA_NO_NODE): In such a case any node inside > the domain's

Re: [Xen-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-06 Thread Konrad Rzeszutek Wilk
On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote: > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that Could you also include in the cover letter an URL link to the latest discussion on this? Thank you. > a machine

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > I think you need to fix some overly long lines. I won't mention them > individually inline. Some are just copy&paste from other places. I will check what can be trimmed. > Regarding all the parsing stuffs, you haven't defined vscsispec so I > cannot review it. Yo

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 04:11:20PM +0100, Olaf Hering wrote: > On Fri, Mar 06, Wei Liu wrote: > > > On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > > > +== TODO === > > > + > > > +How to do live migration? > > > + - pdev will likely be evaluated again on the target host if it came f

Re: [Xen-devel] [PATCH v5] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW-IOMMU.

2015-03-06 Thread Konrad Rzeszutek Wilk
. snip.. > Format: { ,force,,} is suitable I think. > And fixing "force" is follow the code design previously in > setup_io_tlb_npages. It is a bug. It should have been smart enough to deal with the 'force' being in any order. If you are willing to make a patch to fix this - either folded into

Re: [Xen-devel] [PATCH v2] sched: credit2: respect per-vcpu hard affinity

2015-03-06 Thread George Dunlap
On 03/03/2015 03:15 AM, Dario Faggioli wrote: > On Sun, 2015-02-08 at 17:45 -1000, Justin T. Weaver wrote: >> From: "Justin T. Weaver" >> >> by making sure that vcpus only run on the pcpu(s) they are allowed to >> run on based on their hard affinity cpu masks. >> > Ok, here I am reviewing this, at

Re: [Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > On Fri, Mar 06, 2015 at 10:45:54AM +0100, Olaf Hering wrote: > [...] > > ~/backend/console/$DOMID/$DEVID/* [] > > > > A PV console backend. Described in [console.txt](console.txt) > > @@ -403,6 +412,7 @@ ifb device used by Remus to buffer network output fr

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread George Dunlap
On 03/06/2015 01:31 PM, Dario Faggioli wrote: > On Fri, 2015-03-06 at 11:38 +, George Dunlap wrote: >> On 03/06/2015 11:12 AM, Dario Faggioli wrote: > >>> --- >>> Hard affinity balancing is always necessary and must never be skipped. >>> Soft affinity balancing is only useful if it, potentiall

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > > +== TODO === > > + > > +How to do live migration? > > + - pdev will likely be evaluated again on the target host if it came from > > + domU.cfg. But what about pdev from 'xl scsi-attach pdev vdev'?

Re: [Xen-devel] [PATCH v3] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 13:29 +, Jan Beulich wrote: > As pointed out in the discussion of the patch at > http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html > generalizing the conditions here means code elsewhere doesn't need to > take into consideration internals of how lo

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Wei Liu
This is a very big patch, I've only skimmed it so far. I think you need to fix some overly long lines. I won't mention them individually inline. Regarding all the parsing stuffs, you haven't defined vscsispec so I cannot review it. You might want to look at docs/misc/xl-disk-configuration.txt. I

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number when parsing values"): > Ack. This is how it looks like now. The changes are > > 1. Use YYLTYPE instead of line and column. This is better but why not have YYLTYPE inside XLU_ConfigValue ? > 2. Handle empty rule inside

[Xen-devel] [qemu-upstream-unstable test] 35890: regressions - FAIL

2015-03-06 Thread xen . org
flight 35890 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35890/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rhel6hvm-amd 6 leak-check/basis(6) running in 34247 [st=running!] test-a

Re: [Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 10:45:54AM +0100, Olaf Hering wrote: [...] > ~/backend/console/$DOMID/$DEVID/* [] > > A PV console backend. Described in [console.txt](console.txt) > @@ -403,6 +412,7 @@ ifb device used by Remus to buffer network output from > the associated vif. > [KBDIF]: > htt

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > Signed-off-by: Olaf Hering > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser > Cc: Tim Deegan > --- > docs/misc/pvscsi.txt | 188 > +++ > 1 file changed, 188

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 13:32 +, Jan Beulich wrote: > >>> On 06.03.15 at 14:23, wrote: > > Which means that, yes, this part of the condition must loose the '!', or > > have the arguments of the call to cpumask_subset() switched. I > > personally prefer the former: > > > > return !cpumask_su

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 14:23, wrote: > Which means that, yes, this part of the condition must loose the '!', or > have the arguments of the call to cpumask_subset() switched. I > personally prefer the former: > > return !cpumask_subset(cpupool_online_cpumask(vc->domain->cpupool), >

[Xen-devel] [PATCH v3] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
As pointed out in the discussion of the patch at http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html generalizing the conditions here means code elsewhere doesn't need to take into consideration internals of how load balancing in the credit scheduler works. Signed-off-by: Ja

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 11:38 +, George Dunlap wrote: > On 03/06/2015 11:12 AM, Dario Faggioli wrote: > > --- > > Hard affinity balancing is always necessary and must never be skipped. > > Soft affinity balancing is only useful if it, potentially, makes a > > difference. > > > > In more details

Re: [Xen-devel] [PATCH 1/5] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 12:33, wrote: > I'll now apply your patch and see whether that changes thing (seems > unlikely, though). So with the change done that George pointed out is needed via his comment change request the anomaly is gone. I have to admit though that I can't see why that inversion caus

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 12:00 +, George Dunlap wrote: > >> On 03/06/2015 10:16 AM, Jan Beulich wrote: > >>> Hmm, not sure. And I keep being confused whether soft means > >>> "allow" and hard means "prefer" or the other way around. > >>> > >> "hard" means allow (or not allow) > >> "soft" means p

Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines

2015-03-06 Thread David Vrabel
On 26/02/15 05:52, Juergen Gross wrote: > Using the pvops kernel a NULL pointer dereference was detected on a > large machine (144 processors) when booting as dom0 in > evtchn_fifo_unmask() during assignment of a pirq. > > The event channel in question was the first to need a new entry in > event_

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 13:00, wrote: > On 03/06/2015 11:44 AM, Jan Beulich wrote: > On 06.03.15 at 12:32, wrote: >>> On 03/06/2015 10:16 AM, Jan Beulich wrote: >>> On 06.03.15 at 10:53, wrote: > On 03/06/2015 07:36 AM, Jan Beulich wrote: >> As pointed out in the discussion of the pat

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-03-06 Thread Wei Liu
Sorry for the late reply. On Thu, Feb 26, 2015 at 04:49:21PM -0700, Jim Fehlig wrote: > Wei Liu wrote: > > On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote: > > > >> At minimum, libvirt will populate the pdev_path, vdev, backend, and > >> format fields. If backend and format (which, i

[Xen-devel] [PATCHv6 3/3] xen/privcmd: improve performance of MMAPBATCH_V2

2015-03-06 Thread David Vrabel
Make the IOCTL_PRIVCMD_MMAPBATCH_V2 (and older V1 version) map multiple frames at a time rather than one at a time, despite the pages being non-consecutive GFNs. xen_remap_foreign_mfn_array() is added which maps an array of GFNs (instead of a consecutive range of GFNs). Migrate times are signific

[Xen-devel] [PATCHv6 1/3] arm: make __get_user() work for 8 byte values

2015-03-06 Thread David Vrabel
get_user(), __put_user(), and put_user() all worked with 8-byte values but __get_user() did not. Signed-off-by: David Vrabel --- Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/include/asm/uaccess.h | 32 1 file changed, 32 insertions(+)

[Xen-devel] [PATCHv6 0/3] xen: improve migration performance

2015-03-06 Thread David Vrabel
This series signficantly improves the performance of migration by speeding up privcmd's MMAPBATCH_V2 ioctl (for PV toolstack domains). Changes in v6: - unify PVH and ARM foreign mapping. - more fixes and refactoring than I can count. David ___ Xen-dev

Re: [Xen-devel] [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: > On 2015/3/6 17:08, Tiejun Chen wrote: > >Although we already have 'gfx_passthru' in b_info, this doesn' suffice > >after we want to handle IGD specifically. Now we define a new field of > >type, gfx_passthru_kind, to indicate we're try

[Xen-devel] [PATCHv6 2/3] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-06 Thread David Vrabel
Auto-translated physmap guests (arm, arm64 and x86 PVHVM/PVH) map and unmap foreign GFNs using the same method (updating the physmap). Unify the two arm and x86 implementations into one commont one. Note that on arm and arm64, the correct error code will be returned (instead of always -EFAULT) and

Re: [Xen-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn' suffice > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually > this means we ca

Re: [Xen-devel] [PATCH v3] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-06 Thread Juergen Gross
On 03/06/2015 09:34 PM, Tao Chen wrote: Add the {xen-pvscsi: } prefix in pr_fmt and remove DPRINTK, then replace all DPRINTK with pr_debug. Also fixed up some comments just as eliminate redundant whitespace and format the code. These will make the code easier to read. Signed-off-by: Tao Chen

Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend

2015-03-06 Thread Austin S Hemmelgarn
On 2015-03-04 09:09, Juergen Gross wrote: The main question whether it is worth to consider this alternative is the performance aspect. Does anyone have an idea which USB devices would typically be used via pvusb? I'd suspect memory sticks and USB disks and perhaps webcams being the most performa

Re: [Xen-devel] [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Joe Perches
On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote: > #ifdef pr_fmt > #undef pr_fmt > #endif > #define pr_fmt(fmt) "xen-pvscsi: " fmt No, just use add #define pr_fmt(fmt) "xen-pvscsi: " fmt before the first #include. The #ifdef/#undef/#endif isn't necessary. > Then replace all DPRINTK with p

Re: [Xen-devel] [PATCH] libxc: use xc_dom_panic when decompressor is not supported

2015-03-06 Thread Andrew Cooper
On 06/03/2015 11:33, Wei Liu wrote: > State explicitly that specific decompressor is not supported by libxc. > Without this change, libxc error message only says the provided kernel > is invalid, which is misleading. > > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson > Cc: svenvan..

Re: [Xen-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:22PM +0800, Tiejun Chen wrote: > While working with qemu, IGD is a specific device in the case of pass through > so we need to identify that to handle more later. Here we define a table to > record all IGD types currently we can support. Also we need to introduce two >

[Xen-devel] [PATCH v3] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-06 Thread Tao Chen
Add the {xen-pvscsi: } prefix in pr_fmt and remove DPRINTK, then replace all DPRINTK with pr_debug. Also fixed up some comments just as eliminate redundant whitespace and format the code. These will make the code easier to read. Signed-off-by: Tao Chen --- drivers/xen/xen-scsiback.c | 72 +

Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines

2015-03-06 Thread Juergen Gross
Ping? On 02/26/2015 06:52 AM, Juergen Gross wrote: Using the pvops kernel a NULL pointer dereference was detected on a large machine (144 processors) when booting as dom0 in evtchn_fifo_unmask() during assignment of a pirq. The event channel in question was the first to need a new entry in even

Re: [Xen-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote: > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that > a machine option, "-machine xxx,igd-passthru=on". This need > to bring a change on tool side. > > After a discu

  1   2   >