[Xen-devel] [xen-4.3-testing test] 35226: trouble: blocked/broken/fail/pass

2015-02-23 Thread xen . org
flight 35226 xen-4.3-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35226/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 3 host-install(3) broken REGR. vs. 341

Re: [Xen-devel] [PATCH 12/13] xen: if p2m list located in to be remapped region delay remapping

2015-02-23 Thread Juergen Gross
On 02/19/2015 06:44 PM, David Vrabel wrote: On 18/02/2015 06:52, Juergen Gross wrote: With adapting the memory layout of dom0 to that of the host care must be taken not to remap the initial p2m list supported by the hypervisor. "...supplied by the hypervisor" ? Yes, of course. If the p2m

Re: [Xen-devel] [PATCH 10/13] xen: check pre-allocated page tables for conflict with memory map

2015-02-23 Thread Juergen Gross
On 02/19/2015 06:37 PM, David Vrabel wrote: On 18/02/2015 06:52, Juergen Gross wrote: Check whether the page tables built by the domain builder are at memory addresses which are in conflict with the target memory map. If this is the case just panic instead of running into problems later. Aga

Re: [Xen-devel] [PATCH 06/13] xen: detect pre-allocated memory interfering with e820 map

2015-02-23 Thread Juergen Gross
On 02/19/2015 07:07 PM, David Vrabel wrote: On 18/02/2015 06:51, Juergen Gross wrote: Currently especially for dom0 guest memory with guest pfns not matching host areas populated with RAM are remapped to areas which are RAM native as well. This is done to be able to use identity mappings (pfn ==

[Xen-devel] [ovmf test] 35182: regressions - FAIL

2015-02-23 Thread xen . org
flight 35182 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35182/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 5 xen-boot fail REGR. vs. 33686 test-amd64-i386-pair 17 gu

[Xen-devel] [qemu-upstream-unstable test] 35087: regressions - trouble: blocked/broken/fail/pass

2015-02-23 Thread xen . org
flight 35087 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35087/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvops 3 host-install(3) broken REGR. vs. 33488 build-armh

Re: [Xen-devel] [PATCH v3 24/24] xl: Add new option dtdev

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/2015 14:45, Ian Campbell wrote: +is the absolute path in the device tree. Can it be an alias? Right now, no. But I can change it if you think it's useful. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.o

Re: [Xen-devel] [PATCH v2 3/3] xen/arm: Skip parsing psci-0.2 from host device tree

2015-02-23 Thread Julien Grall
I think the title of the commit message is misleading. I gave the impression that we don't want to parse the PSCI-0.2 for Xen, which is obviously wrong. A better title would be: "Don't pass the PSCI-0.2 node to the DOM0" On 23/02/2015 17:52, Ian Campbell wrote: On Wed, 2015-02-18 at 17:49 +0

Re: [Xen-devel] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-23 Thread Ard Biesheuvel
On 18 February 2015 at 08:37, Ard Biesheuvel wrote: > On 17 February 2015 at 18:40, Jordan Justen wrote: >> Ard, >> >> For the subject, I think >> MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16 >> would be better. >> > > OK > >> Acked-by: Jordan Justen >> > > Thanks > >> Thanks

Re: [Xen-devel] [PATCH] tools/hotplug: Don't ever kill xenstored

2015-02-23 Thread Andrew Cooper
On 23/02/15 16:19, Wei Liu wrote: > On Mon, Feb 23, 2015 at 09:18:49AM +, Ross Lagerwall wrote: >> Don't kill xenstored as part of the usual service shutdown process to >> prevent hangs on shutdown where the kernel tries to unplug a VIF >> after xenstored has exited. >> >> Signed-off-by: Ross L

Re: [Xen-devel] [PATCH v3 18/24] xen/passthrough: iommu_deassign_device_dt: By default reassign device to nobody

2015-02-23 Thread Julien Grall
On 23/02/15 16:47, Jan Beulich wrote: On 23.02.15 at 17:37, wrote: >> On 23/02/15 15:39, Ian Campbell wrote: >>> On Mon, 2015-02-23 at 10:20 +, Jan Beulich wrote: >>> On 23.02.15 at 11:10, wrote: > Right now, there is no possibility to reset a platform device in the > kernel

Re: [Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-23 Thread Boris Ostrovsky
On 02/23/2015 11:44 AM, Ian Campbell wrote: On Mon, 2015-02-09 at 15:04 -0500, Boris Ostrovsky wrote: What is the rationale for this change? libxl is not the right place to handle hypervisor-specific details like buffer management (most, if not all, of other services that libxl provides push

Re: [Xen-devel] [PATCH v3 15/24] xen/dts: Provide an helper to get a DT node from a path provided by a guest

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 16:01 +, Julien Grall wrote: > Hi Ian, > > On 23/02/15 15:30, Ian Campbell wrote: > > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > > > >> +/* This limit is used by the hypercalls to restrict the size of the path > >> */ > >> +#define DEVICE_TREE_MAX_PATHLEN

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-02-23 Thread Daniel De Graaf
On 02/20/2015 12:17 PM, Ian Campbell wrote: On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: TODO: Update the commit message A device node is described by a path. It will be used to retrieved the node in the device tree and assign the related device to the domain. Only device protected b

Re: [Xen-devel] [PATCH v3 18/24] xen/passthrough: iommu_deassign_device_dt: By default reassign device to nobody

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 16:39, wrote: > On Mon, 2015-02-23 at 10:20 +, Jan Beulich wrote: >> >>> On 23.02.15 at 11:10, wrote: >> > Hi Jan, >> > >> > On 23/02/2015 09:40, Jan Beulich wrote: >> > On 20.02.15 at 18:04, wrote: >> >>> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: >>

Re: [Xen-devel] [PATCH v9 05/13] xen: Add vmware_port support

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 17:03, wrote: > On 02/23/15 10:05, Jan Beulich wrote: > On 17.02.15 at 00:05, wrote: >>> This includes adding is_vmware_port_enabled >>> >>> This is a new domain_create() flag, DOMCRF_vmware_port. It is >>> passed to domctl as XEN_DOMCTL_CDF_vmware_port. >> >> As indicate

Re: [Xen-devel] [PATCH v3 17/24] xen/passthrough: arm: release earlier the DT devices assigned to a guest

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 16:33, wrote: > On Mon, 2015-02-23 at 09:37 +, Jan Beulich wrote: >> >>> On 20.02.15 at 18:46, wrote: >> > On 20/02/15 17:03, Ian Campbell wrote: >> >> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: >> >> >> >> Subject: "release the DT devices assigned to a guest e

Re: [Xen-devel] [PATCH] xen/arm: Implement dynamic allocation of irq descriptors

2015-02-23 Thread Julien Grall
On 23/02/15 16:09, Vijay Kilari wrote: > On Mon, Feb 23, 2015 at 9:10 PM, Julien Grall wrote: >> Hello Vijay, >> >> On 23/02/15 13:04, Vijay Kilari wrote: >>> On Thu, Feb 19, 2015 at 7:33 PM, Julien Grall >>> wrote: On 19/02/15 07:17, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K

Re: [Xen-devel] [PATCH] tools/hotplug: Don't ever kill xenstored

2015-02-23 Thread Wei Liu
On Mon, Feb 23, 2015 at 09:18:49AM +, Ross Lagerwall wrote: > Don't kill xenstored as part of the usual service shutdown process to > prevent hangs on shutdown where the kernel tries to unplug a VIF > after xenstored has exited. > > Signed-off-by: Ross Lagerwall Do you run xendomains service

Re: [Xen-devel] [PATCH v9 3/3] tools, docs: add total/local memory bandwith monitoring

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-13 at 13:09 +, Wei Liu wrote: > On Mon, Feb 02, 2015 at 04:06:09PM +0800, Chao Peng wrote: > > +#ifdef LIBXL_HAVE_PSR_MBM > > +int libxl_psr_cmt_type_supported(libxl_ctx *ctx, libxl_psr_cmt_type type); > > +int libxl_psr_cmt_get_mem_bandwidth_sample(libxl_ctx *ctx, > > +

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 16:46, wrote: > On Mon, 2015-02-23 at 15:27 +, Jan Beulich wrote: >> >>> On 23.02.15 at 16:02, wrote: >> > Is the reason for the scan being of segment 0 only is that it is the one >> > which lives at the legacy PCI CFG addresses (or those magic I/O ports)? >> >> Right - i

Re: [Xen-devel] [PATCH v3 13/24] xen/arm: Implement hypercall PHYSDEVOP_{, un}map_pirq

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 16:53, wrote: > Hi Ian, > > On 23/02/15 15:28, Ian Campbell wrote: >> On Mon, 2015-02-23 at 09:33 +, Jan Beulich wrote: >> On 20.02.15 at 17:53, wrote: Jan, do you have any feeling for how this is going to play out on x86 with the vapic stuff? >>> >>> The vap

Re: [Xen-devel] [PATCH] x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests

2015-02-23 Thread Boris Ostrovsky
On 02/23/2015 11:09 AM, Andy Lutomirski wrote: On Mon, Feb 23, 2015 at 8:01 AM, Boris Ostrovsky wrote: Commit 1e02ce4cccdc ("x86: Store a per-cpu shadow copy of CR4") introduced CR4 shadows. These shadows are initialized in early boot code. The commit missed initialization for 64-bit PV(H) gu

Re: [Xen-devel] [PATCH v3 13/24] xen/arm: Implement hypercall PHYSDEVOP_{, un}map_pirq

2015-02-23 Thread Julien Grall
On 23/02/15 16:04, Ian Campbell wrote: > On Mon, 2015-02-23 at 15:53 +, Julien Grall wrote: >> Hi Ian, >> >> On 23/02/15 15:28, Ian Campbell wrote: >>> On Mon, 2015-02-23 at 09:33 +, Jan Beulich wrote: >>> On 20.02.15 at 17:53, wrote: > Jan, do you have any feeling for how this is

[Xen-devel] [PATCH] xsm/flask: Handle policy load failures properly

2015-02-23 Thread Daniel De Graaf
When the hypervisor is booted with an XSM policy containing an error (such as a mismatched permission value), this error is mostly ignored during boot. This causes FLASK to suspend security policy enforcement until a policy is loaded, effectively allowing all access. This patch adds a call to pan

Re: [Xen-devel] [PATCH] xen/xsm: Generate the permission in a spec-compliant way

2015-02-23 Thread Daniel De Graaf
On 02/23/2015 10:04 AM, Julien Grall wrote: Hi Daniel, On 20/02/15 23:01, Daniel De Graaf wrote: On 02/20/2015 10:58 AM, Julien Grall wrote: Each class can contains 32 permisions which are encoded on a word (one bit per permission). Currently the awk script will generate an hexadecimal value

Re: [Xen-devel] [PATCH v3 13/24] xen/arm: Implement hypercall PHYSDEVOP_{, un}map_pirq

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 15:53 +, Julien Grall wrote: > Hi Ian, > > On 23/02/15 15:28, Ian Campbell wrote: > > On Mon, 2015-02-23 at 09:33 +, Jan Beulich wrote: > > On 20.02.15 at 17:53, wrote: > >>> Jan, do you have any feeling for how this is going to play out on x86 > >>> with the vap

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 15:54 +, Julien Grall wrote: > On 23/02/15 15:52, Ian Campbell wrote: > > On Mon, 2015-02-23 at 15:47 +, Julien Grall wrote: > >> Hi Ian, > >> > >> On 23/02/15 15:20, Ian Campbell wrote: > >>> On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: > The priority i

Re: [Xen-devel] [PATCH] x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests

2015-02-23 Thread Andy Lutomirski
On Mon, Feb 23, 2015 at 8:01 AM, Boris Ostrovsky wrote: > Commit 1e02ce4cccdc ("x86: Store a per-cpu shadow copy of CR4") > introduced CR4 shadows. > > These shadows are initialized in early boot code. The commit missed > initialization for 64-bit PV(H) guests that this patch adds. Whoops, worry.

Re: [Xen-devel] [PATCH] xen/arm: Implement dynamic allocation of irq descriptors

2015-02-23 Thread Vijay Kilari
Hi Julien, On Mon, Feb 23, 2015 at 9:10 PM, Julien Grall wrote: > Hello Vijay, > > On 23/02/15 13:04, Vijay Kilari wrote: >> On Thu, Feb 19, 2015 at 7:33 PM, Julien Grall >> wrote: >>> On 19/02/15 07:17, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K For arm memory for 1024

[Xen-devel] [PATCH] x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests

2015-02-23 Thread Boris Ostrovsky
Commit 1e02ce4cccdc ("x86: Store a per-cpu shadow copy of CR4") introduced CR4 shadows. These shadows are initialized in early boot code. The commit missed initialization for 64-bit PV(H) guests that this patch adds. Signed-off-by: Boris Ostrovsky --- arch/x86/xen/enlighten.c |1 + 1 files

Re: [Xen-devel] [PATCH v3 13/24] xen/arm: Implement hypercall PHYSDEVOP_{, un}map_pirq

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 15:51 +, Julien Grall wrote: > On 20/02/15 16:53, Ian Campbell wrote: > > Are we absolutely 100% sure that we will never ever want to map hardware > > IRQs to guests on ARMs using pirq-type event channels? Because that is > > what we are essentially ruling out here. > >

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:31, Ian Campbell wrote: > On Fri, 2015-02-20 at 17:45 +, Julien Grall wrote: >> On 20/02/15 16:58, Ian Campbell wrote: >>> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: This new function will correctly initialize the IOMMU page table for the current do

Re: [Xen-devel] [PATCH v9 05/13] xen: Add vmware_port support

2015-02-23 Thread Don Slutz
On 02/23/15 10:05, Jan Beulich wrote: On 17.02.15 at 00:05, wrote: >> This includes adding is_vmware_port_enabled >> >> This is a new domain_create() flag, DOMCRF_vmware_port. It is >> passed to domctl as XEN_DOMCTL_CDF_vmware_port. > > As indicated before, I don't think this is a good use

Re: [Xen-devel] [PATCH v3 15/24] xen/dts: Provide an helper to get a DT node from a path provided by a guest

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:30, Ian Campbell wrote: > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> +/* This limit is used by the hypercalls to restrict the size of the path */ >> +#define DEVICE_TREE_MAX_PATHLEN 1024 > > Is this something you've made up or derived from the DT spec/ePAP

Re: [Xen-devel] [PATCH v3 01/24] xen: Extend DOMCTL createdomain to support arch configuration

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 15:48 +, Andrew Cooper wrote: > GIC version and SPIs should absolutely be part of the migration stream. > They are domain architectural state. Of course, the question is where. They could be part of the Xen hvmsave blob for the GIC (i.e. along with the other GIC archite

Re: [Xen-devel] [PATCH v3 14/24] xen/dts: Use unsigned int for MMIO and IRQ index

2015-02-23 Thread Julien Grall
Hi Ian, On 20/02/15 16:55, Ian Campbell wrote: > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: >> There is no reason to use signed integer for an index. > > Did you check for now pointless "if ( uthing < 0 ) which a picky > compiler might whinge about? I just checked and we don't have a

Re: [Xen-devel] [RFC] [Design] Better XL support of RTDS scheduler for Xen 4.6

2015-02-23 Thread Wei Liu
Not an expert on scheduler, so bear with me if my questions / comments are stupid. On Sat, Feb 21, 2015 at 10:51:59AM -0500, Meng Xu wrote: > Hi all, > > This is for Xen 4.6: Enabling XL to set the parameters of each > individual VCPU of a domain for RTDS scheduler. > > [Goal] > Right now, xl sc

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Julien Grall
On 23/02/15 15:52, Ian Campbell wrote: > On Mon, 2015-02-23 at 15:47 +, Julien Grall wrote: >> Hi Ian, >> >> On 23/02/15 15:20, Ian Campbell wrote: >>> On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: The priority is controlled by route_irq_to_guest and set statically using GIC_

Re: [Xen-devel] [PATCH v3 13/24] xen/arm: Implement hypercall PHYSDEVOP_{, un}map_pirq

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:28, Ian Campbell wrote: > On Mon, 2015-02-23 at 09:33 +, Jan Beulich wrote: > On 20.02.15 at 17:53, wrote: >>> Jan, do you have any feeling for how this is going to play out on x86 >>> with the vapic stuff? >> >> The vapic logic shouldn't require any physdevop invol

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 15:47 +, Julien Grall wrote: > Hi Ian, > > On 23/02/15 15:20, Ian Campbell wrote: > > On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: > >> The priority is controlled by route_irq_to_guest and set statically > >> using GIC_PRI_IRQ. > >> > >> If we decide to hardcode

Re: [Xen-devel] [PATCH v3 13/24] xen/arm: Implement hypercall PHYSDEVOP_{, un}map_pirq

2015-02-23 Thread Julien Grall
Hi Ian, On 20/02/15 16:53, Ian Campbell wrote: > On Thu, 2015-01-29 at 12:33 +, Stefano Stabellini wrote: >> On Thu, 29 Jan 2015, Julien Grall wrote: >>> On 29/01/15 12:17, Stefano Stabellini wrote: On Wed, 28 Jan 2015, Julien Grall wrote: > Hi Stefano, > > On 28/01/15 18:52,

Re: [Xen-devel] [PATCH v3 12/24] xen/arm: Release IRQ routed to a domain when it's destroying

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:25, Ian Campbell wrote: > On Fri, 2015-02-20 at 17:41 +, Julien Grall wrote: > +/* TODO: Handle eviction from LRs. For now, deny remove if the IRQ + * is inflight and not disabled. >>> >>> If we are ungracefully killing a guest doesn't this risk ending

Re: [Xen-devel] [PATCH v3 01/24] xen: Extend DOMCTL createdomain to support arch configuration

2015-02-23 Thread Andrew Cooper
On 20/02/15 15:15, Ian Campbell wrote: > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: >> On ARM the virtual GIC may differ between each guest (emulated GIC version, >> number of SPIs...). Those informations are already known at the domain >> creation > "This information is already known

Re: [Xen-devel] [PATCH v3 11/24] xen/arm: Let the toolstack configure the number of SPIs

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:22, Ian Campbell wrote: > On Fri, 2015-02-20 at 17:29 +, Julien Grall wrote: >> On 20/02/15 16:08, Ian Campbell wrote: >>> On Wed, 2015-01-28 at 18:26 +, Stefano Stabellini wrote: >>> > +int spi = irq - 32; unsigned int >>> >>> and underflow? >>

Re: [Xen-devel] NUMA_BALANCING and Xen PV guest regression in 3.20-rc0

2015-02-23 Thread Mel Gorman
On Mon, Feb 23, 2015 at 03:13:48PM +, Dario Faggioli wrote: > Hi everyone, > > On Thu, 2015-02-19 at 17:01 +, Mel Gorman wrote: > > On Thu, Feb 19, 2015 at 01:06:53PM +, David Vrabel wrote: > > > I cannot think of a reason why this would fail for NUMA balancing on bare > > metal. The

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:20, Ian Campbell wrote: > On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: >> The priority is controlled by route_irq_to_guest and set statically >> using GIC_PRI_IRQ. >> >> If we decide to hardcoded the priority here, we should drop the >> parameter on gic_route_irq_g

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 15:27 +, Jan Beulich wrote: > >>> On 23.02.15 at 16:02, wrote: > > On Mon, 2015-02-23 at 14:45 +, Jan Beulich wrote: > >> In which case the Dom0 OS doing so would need to communicate > >> its decisions to the hypervisor, as you suggest further down. > > > > So more c

Re: [Xen-devel] [PATCH v3 07/24] xen/arm: Introduce xen, passthrough property

2015-02-23 Thread Julien Grall
On 23/02/15 15:15, Ian Campbell wrote: > On Fri, 2015-02-20 at 17:03 +, Julien Grall wrote: >> On 20/02/15 15:42, Ian Campbell wrote: >>> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: @@ -919,8 +943,14 @@ static int make_timer_node(const struct domain *d, void *fdt,

Re: [Xen-devel] [RFC PATCH] xentop: add support for qdisks

2015-02-23 Thread Felipe Franciosi
Hi Charles, It's good to see that someone else is tackling this problem. We have a similar problem in XenServer; tapdisk3 is a user space backend (just like qemu-qdisk) and therefore libxenstat is unable to pick up any statistics from it. In that way, "xentop" also doesn't display any stats for

Re: [Xen-devel] [PATCH v3 07/24] xen/arm: Introduce xen, passthrough property

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:12, Ian Campbell wrote: > On Fri, 2015-02-20 at 17:01 +, Julien Grall wrote: diff --git a/docs/misc/arm/device-tree/passthrough.txt b/docs/misc/arm/device-tree/passthrough.txt new file mode 100644 index 000..04645b3 --- /dev/null +++ b/

Re: [Xen-devel] [PATCH] xen/arm: Implement dynamic allocation of irq descriptors

2015-02-23 Thread Julien Grall
Hello Vijay, On 23/02/15 13:04, Vijay Kilari wrote: > On Thu, Feb 19, 2015 at 7:33 PM, Julien Grall wrote: >> On 19/02/15 07:17, vijay.kil...@gmail.com wrote: >>> From: Vijaya Kumar K >>> >>> For arm memory for 1024 irq descriptors are allocated >>> statically irrespective of number of interrupt

Re: [Xen-devel] [PATCH v3 18/24] xen/passthrough: iommu_deassign_device_dt: By default reassign device to nobody

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 10:20 +, Jan Beulich wrote: > >>> On 23.02.15 at 11:10, wrote: > > Hi Jan, > > > > On 23/02/2015 09:40, Jan Beulich wrote: > > On 20.02.15 at 18:04, wrote: > >>> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > Currently, when the device is deassigned f

Re: [Xen-devel] [PATCH v3 18/24] xen/passthrough: iommu_deassign_device_dt: By default reassign device to nobody

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 10:10 +, Julien Grall wrote: > > On 20/02/2015 17:04, Ian Campbell wrote: > > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> Currently, when the device is deassigned from a domain, we directly > >> reassign > >> to DOM0. > >> > >> As the device may not have

Re: [Xen-devel] [PATCH v3 17/24] xen/passthrough: arm: release earlier the DT devices assigned to a guest

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 09:37 +, Jan Beulich wrote: > >>> On 20.02.15 at 18:46, wrote: > > On 20/02/15 17:03, Ian Campbell wrote: > >> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> > >> Subject: "release the DT devices assigned to a guest earlier" > >> > >>> The toolstack may not

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:45 +, Julien Grall wrote: > On 20/02/15 16:58, Ian Campbell wrote: > > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> This new function will correctly initialize the IOMMU page table for the > >> current domain. > >> > >> Also use it in iommu_assign_dt_devi

Re: [Xen-devel] [PATCH v3 15/24] xen/dts: Provide an helper to get a DT node from a path provided by a guest

2015-02-23 Thread Ian Campbell
On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > +/* This limit is used by the hypercalls to restrict the size of the path */ > +#define DEVICE_TREE_MAX_PATHLEN 1024 Is this something you've made up or derived from the DT spec/ePAPR etc? Apart from this the patch seems fine, clarifying t

Re: [Xen-devel] [PATCH v3 15/24] xen/dts: Provide an helper to get a DT node from a path provided by a guest

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:43 +, Julien Grall wrote: > On 20/02/15 16:56, Ian Campbell wrote: > > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> Signed-off-by: Julien Grall > > > > Is this function still needed in the new model which doesn't do > > automatic mappings etc? > > It's

Re: [Xen-devel] [PATCH v3 13/24] xen/arm: Implement hypercall PHYSDEVOP_{, un}map_pirq

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 09:33 +, Jan Beulich wrote: > >>> On 20.02.15 at 17:53, wrote: > > Jan, do you have any feeling for how this is going to play out on x86 > > with the vapic stuff? > > The vapic logic shouldn't require any physdevop involvement, so if > I read right what you propose (not

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 16:02, wrote: > On Mon, 2015-02-23 at 14:45 +, Jan Beulich wrote: >> In which case the Dom0 OS doing so would need to communicate >> its decisions to the hypervisor, as you suggest further down. > > So more concretely something like: > #define PHYSDEVOP_pci_host_bri

Re: [Xen-devel] [PATCH v3 12/24] xen/arm: Release IRQ routed to a domain when it's destroying

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:41 +, Julien Grall wrote: > >> +/* TODO: Handle eviction from LRs. For now, deny remove if the IRQ > >> + * is inflight and not disabled. > > > > If we are ungracefully killing a guest doesn't this risk ending up with > > an undestroyable domain? i.e. if the g

Re: [Xen-devel] [PATCH v3 11/24] xen/arm: Let the toolstack configure the number of SPIs

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:29 +, Julien Grall wrote: > On 20/02/15 16:08, Ian Campbell wrote: > > On Wed, 2015-01-28 at 18:26 +, Stefano Stabellini wrote: > > > >>> +int spi = irq - 32; > >> > >> unsigned int > > > > and underflow? > > No because there is a check (irq < 32) before

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: > Hi Ian, > > On 20/02/15 16:07, Ian Campbell wrote: > > More importantly: We have (hopefully) guaranteed elsewhere that an PPI > > or SGI can never make it here, I take it. If that's the case then either > > the comment should say that, or mo

Re: [Xen-devel] [PATCH v4 23/29] Ovmf/Xen: port XenBusDxe to other architectures

2015-02-23 Thread Anthony PERARD
On Thu, Feb 12, 2015 at 07:19:15PM +0800, Ard Biesheuvel wrote: > This patch updates XenBusDxe to use the 16-bit compare and exchange > function that was introduced for this purpose to the > BaseSynchronizationLib. It also provides a new generic implementation > of TestAndClearBit () using the same

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-23 Thread Wei Liu
On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote: > Wei Liu wrote: > > On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote: > > > >> Wei Liu writes ("[PATCH 3/3] libxl: libxl__device_from_disk should > >> retrieve backend from xenstore"): > >> > >>> ... if backend is not

Re: [Xen-devel] [PATCH v3 07/24] xen/arm: Introduce xen, passthrough property

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:03 +, Julien Grall wrote: > On 20/02/15 15:42, Ian Campbell wrote: > > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> @@ -919,8 +943,14 @@ static int make_timer_node(const struct domain *d, > >> void *fdt, > >> return res; > >> } > >> > >> -/* Map

Re: [Xen-devel] [PATCH v3 07/24] xen/arm: Introduce xen, passthrough property

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:01 +, Julien Grall wrote: > >> diff --git a/docs/misc/arm/device-tree/passthrough.txt > >> b/docs/misc/arm/device-tree/passthrough.txt > >> new file mode 100644 > >> index 000..04645b3 > >> --- /dev/null > >> +++ b/docs/misc/arm/device-tree/passthrough.txt > >> @@

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Julien Grall
On 23/02/15 11:50, Manish Jaggi wrote: > > On 23/02/15 4:44 pm, Julien Grall wrote: >> >> >> On 23/02/2015 10:59, Manish Jaggi wrote: >>> >>> On 20/02/15 8:09 pm, Ian Campbell wrote: On Fri, 2015-02-20 at 19:44 +0530, Manish Jaggi wrote: >> Another option might be a new hypercall (assumin

Re: [Xen-devel] [PATCH] x86/numa: Adjust datatypes for node and pxm

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 15:53, wrote: > On 02/23/2015 09:47 AM, Jan Beulich wrote: > On 23.02.15 at 15:42, wrote: >>> On 02/23/2015 04:57 AM, Jan Beulich wrote: >>> On 21.02.15 at 19:14, wrote: > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -21,44 +21,55 @@ >

Re: [Xen-devel] [PATCH v3 01/24] xen: Extend DOMCTL createdomain to support arch configuration

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 16:09 +, Julien Grall wrote: > Hi Ian, > > On 20/02/15 15:15, Ian Campbell wrote: > > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> On ARM the virtual GIC may differ between each guest (emulated GIC version, > >> number of SPIs...). Those informations are al

Re: [Xen-devel] NUMA_BALANCING and Xen PV guest regression in 3.20-rc0

2015-02-23 Thread Dario Faggioli
Hi everyone, On Thu, 2015-02-19 at 17:01 +, Mel Gorman wrote: > On Thu, Feb 19, 2015 at 01:06:53PM +, David Vrabel wrote: > I cannot think of a reason why this would fail for NUMA balancing on bare > metal. The PAGE_NONE protection clears the present bit on p[te|md]_modify > so the expect

Re: [Xen-devel] [PATCH v9 06/13] xen: Add ring 3 vmware_port support

2015-02-23 Thread Jan Beulich
>>> On 17.02.15 at 00:05, wrote: > Enable no-fault of pio in x86_emulate for VMware port ??? > @@ -393,6 +393,11 @@ struct x86_emulate_ops > enum x86_segment seg, > unsigned long offset, > struct x86_emulate_ctxt *ctxt); > + > +/* vmport_check */ > +int (*vmpor

Re: [Xen-devel] [PATCH] xen/xsm: Generate the permission in a spec-compliant way

2015-02-23 Thread Julien Grall
Hi Daniel, On 20/02/15 23:01, Daniel De Graaf wrote: > On 02/20/2015 10:58 AM, Julien Grall wrote: >> Each class can contains 32 permisions which are encoded on a word (one >> bit per permission). >> >> Currently the awk script will generate an hexadecimal value for each >> permission. This may re

Re: [Xen-devel] [PATCH v9 05/13] xen: Add vmware_port support

2015-02-23 Thread Jan Beulich
>>> On 17.02.15 at 00:05, wrote: > This includes adding is_vmware_port_enabled > > This is a new domain_create() flag, DOMCRF_vmware_port. It is > passed to domctl as XEN_DOMCTL_CDF_vmware_port. As indicated before, I don't think this is a good use case for a domain creation flag. Some of the o

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 14:45 +, Jan Beulich wrote: > >>> On 23.02.15 at 15:33, wrote: > > On Mon, 2015-02-23 at 14:07 +, Jan Beulich wrote: > >> >>> On 23.02.15 at 13:45, wrote: > >> > In which case might we be at liberty to specify that on ARM+Device Tree > >> > systems (i.e. those where

Re: [Xen-devel] [PATCH] x86/numa: Adjust datatypes for node and pxm

2015-02-23 Thread Boris Ostrovsky
On 02/23/2015 09:47 AM, Jan Beulich wrote: On 23.02.15 at 15:42, wrote: On 02/23/2015 04:57 AM, Jan Beulich wrote: On 21.02.15 at 19:14, wrote: --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -21,44 +21,55 @@ #include #include +#define MAX_PXM 255 Perhaps better (MAX_N

Re: [Xen-devel] [RFC] More efficient RTDS scheduler for Xen 4.6

2015-02-23 Thread Dario Faggioli
On Sun, 2015-02-22 at 00:31 -0500, Dagaen Golomb wrote: > Hello everyone, > Hello, > I'd like to solicit comments on improvements to the RTDS scheduler for > Xen 4.6. > My first comment is that I'm happy that you guys are working on this! :-) > [Motivation] > > This change will increase the eff

Re: [Xen-devel] [PATCH] x86/numa: Adjust datatypes for node and pxm

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 15:42, wrote: > On 02/23/2015 04:57 AM, Jan Beulich wrote: > On 21.02.15 at 19:14, wrote: >>> --- a/xen/arch/x86/srat.c >>> +++ b/xen/arch/x86/srat.c >>> @@ -21,44 +21,55 @@ >>> #include >>> #include >>> >>> +#define MAX_PXM 255 >> Perhaps better (MAX_NUMNODES -

Re: [Xen-devel] [PATCH v3 24/24] xl: Add new option dtdev

2015-02-23 Thread Ian Campbell
On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > The option "dtdev" will be used to passthrough a non-PCI device described > in the device tree to a guest. > > Signed-off-by: Julien Grall > Cc: Ian Jackson > Cc: Wei Liu > > --- > Changes in v2: > - libxl_device_dt has been

Re: [Xen-devel] [PATCH v3 24/24] xl: Add new option dtdev

2015-02-23 Thread Ian Campbell
On Thu, 2015-01-29 at 15:06 +, Stefano Stabellini wrote: > I don't think it is necessary to have two separate patches, but let's > see what the libxl maintainers have to say. For large changes having the split between introducing libxl side and then using it can be useful, but this change is s

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 15:33, wrote: > On Mon, 2015-02-23 at 14:07 +, Jan Beulich wrote: >> >>> On 23.02.15 at 13:45, wrote: >> > In which case might we be at liberty to specify that on ARM+Device Tree >> > systems (i.e. those where the f/w tables don't give an enumeration) >> > there is a 1:1 ma

Re: [Xen-devel] [PATCH v3 23/24] libxl: Add support for non-PCI passthrough

2015-02-23 Thread Ian Campbell
On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index 5651110..c10fd2f 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl Need a new LIBXL_HAVE here. Perhaps combined into an umbrella one

Re: [Xen-devel] [PATCH] x86/numa: Adjust datatypes for node and pxm

2015-02-23 Thread Boris Ostrovsky
On 02/23/2015 04:57 AM, Jan Beulich wrote: On 21.02.15 at 19:14, wrote: Use u8-sized node IDs and unsigned PXMs consistently throughout code (and introduce nodeid_t type). Signed-off-by: Boris Ostrovsky I think the description should call out areas not covered, like the node encoding in the

Re: [Xen-devel] [PATCH v3 23/24] libxl: Add support for non-PCI passthrough

2015-02-23 Thread Ian Campbell
On Thu, 2015-01-29 at 13:51 +, Julien Grall wrote: > On 29/01/15 12:31, Stefano Stabellini wrote: > > On Thu, 29 Jan 2015, Julien Grall wrote: > >> Hi Stefano, > >> > >> On 29/01/15 11:12, Stefano Stabellini wrote: > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > >>

Re: [Xen-devel] [PATCH v3 22/24] tools/libxl: arm: Use an higher value for the GIC phandle

2015-02-23 Thread Ian Campbell
On Thu, 2015-01-29 at 13:48 +, Julien Grall wrote: > On 29/01/15 12:28, Stefano Stabellini wrote: > > On Thu, 29 Jan 2015, Julien Grall wrote: > >> On 29/01/15 11:07, Stefano Stabellini wrote: > >>> On Tue, 13 Jan 2015, Julien Grall wrote: > The partial device tree may contains phandle. Th

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 14:07 +, Jan Beulich wrote: > >>> On 23.02.15 at 13:45, wrote: > > On Mon, 2015-02-23 at 08:43 +, Jan Beulich wrote: > >> >>> On 20.02.15 at 18:33, wrote: > >> > On Fri, 2015-02-20 at 15:15 +, Jan Beulich wrote: > >> >> > That's the issue we are trying to resolve

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 13:45, wrote: > On Mon, 2015-02-23 at 08:43 +, Jan Beulich wrote: >> >>> On 20.02.15 at 18:33, wrote: >> > On Fri, 2015-02-20 at 15:15 +, Jan Beulich wrote: >> >> > That's the issue we are trying to resolve, with device tree there is no >> >> > explicit segment ID, so w

Re: [Xen-devel] [PATCH] correct mis-conversion set_bit() -> __cpumask_set_cpu() by 4aaca0e9cd

2015-02-23 Thread Jan Beulich
>>> On 23.02.15 at 13:01, wrote: > On 23/02/15 11:06, Jan Beulich wrote: >> I have no idea how I came to use __cpumask_set_cpu() there, the >> conversion should have been set_bit() -> __set_bit(). The wrong >> construct results in problems on systems with relatively few CPUs. >> >> Reported-by: Sa

Re: [Xen-devel] [PATCH v2] complete conversion set_bit() -> __cpumask_set_cpu() by 4aaca0e9cd

2015-02-23 Thread Andrew Cooper
On 23/02/15 13:47, Jan Beulich wrote: > While converting to __cpumask_set_cpu() was correct, the first argument > passed should have been corrected to be "cpu" instead of "nr" at once. > The wrong construct results in problems on systems with relatively few > CPUs. > > Reported-by: Sander Eikelenbo

[Xen-devel] [PATCH v2] complete conversion set_bit() -> __cpumask_set_cpu() by 4aaca0e9cd

2015-02-23 Thread Jan Beulich
While converting to __cpumask_set_cpu() was correct, the first argument passed should have been corrected to be "cpu" instead of "nr" at once. The wrong construct results in problems on systems with relatively few CPUs. Reported-by: Sander Eikelenboom Signed-off-by: Jan Beulich --- v2: As Andrew

[Xen-devel] [libvirt test] 35192: regressions - trouble: blocked/broken/fail/pass

2015-02-23 Thread xen . org
flight 35192 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35192/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 3 host-install(3) broken REGR. vs. 34580 test-amd64-amd64-libvirt

Re: [Xen-devel] [PATCH] xen/arm: Implement dynamic allocation of irq descriptors

2015-02-23 Thread Vijay Kilari
On Thu, Feb 19, 2015 at 7:33 PM, Julien Grall wrote: > On 19/02/15 07:17, vijay.kil...@gmail.com wrote: >> From: Vijaya Kumar K >> >> For arm memory for 1024 irq descriptors are allocated >> statically irrespective of number of interrupt supported >> by the platform. >> >> With this patch, irq de

Re: [Xen-devel] [PATCH v3 11/13] xen/iommu: smmu: Introduce automatic stream-id-masking

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 10:52 +, Julien Grall wrote: > > On 23/02/2015 10:42, Ian Campbell wrote: > >> On a side note, we consider this platform deprecated we should either > >> drop the code from Xen or write on the wiki that we don't fully support > >> it anymore. > > > > It's all about degree

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 08:43 +, Jan Beulich wrote: > >>> On 20.02.15 at 18:33, wrote: > > On Fri, 2015-02-20 at 15:15 +, Jan Beulich wrote: > >> > That's the issue we are trying to resolve, with device tree there is no > >> > explicit segment ID, so we have an essentially unindexed set of P

Re: [Xen-devel] [PATCH v3 21/24] tools/(lib)xl: Add partial device tree support for ARM

2015-02-23 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH v3 21/24] tools/(lib)xl: Add partial device tree support for ARM"): > Is this facility supposed to take untrusted or partially-trusted > partial device trees ? Also, is libfdt intended (and safe) for use with untrusted fdt blobs ? Ian. ___

Re: [Xen-devel] [xen-unstable test] 34925: regressions - trouble: broken/fail/pass

2015-02-23 Thread Ian Jackson
xen.org writes ("[xen-unstable test] 34925: regressions - trouble: broken/fail/pass"): > flight 34925 xen-unstable real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/34925/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run:

[Xen-devel] [xen-unstable test] 34925: regressions - trouble: broken/fail/pass

2015-02-23 Thread xen . org
flight 34925 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34925/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-rumpuserxen-amd64 5 xen-bootfail REGR. vs. 34629 test-amd64-amd64-xl-

Re: [Xen-devel] [PATCH v3 21/24] tools/(lib)xl: Add partial device tree support for ARM

2015-02-23 Thread Ian Jackson
Julien Grall writes ("[PATCH v3 21/24] tools/(lib)xl: Add partial device tree support for ARM"): > Let the user to pass additional nodes to the guest device tree. For this > purpose, everything in the node /passthrough from the partial device tree \ will > be copied into the guest device tree. Pl

Re: [Xen-devel] [PATCH] correct mis-conversion set_bit() -> __cpumask_set_cpu() by 4aaca0e9cd

2015-02-23 Thread Andrew Cooper
On 23/02/15 11:06, Jan Beulich wrote: > I have no idea how I came to use __cpumask_set_cpu() there, the > conversion should have been set_bit() -> __set_bit(). The wrong > construct results in problems on systems with relatively few CPUs. > > Reported-by: Sander Eikelenboom > Signed-off-by: Jan Be

Re: [Xen-devel] RFC: [PATCH 1/3] Enhance platform support for PCI

2015-02-23 Thread Manish Jaggi
On 23/02/15 4:44 pm, Julien Grall wrote: On 23/02/2015 10:59, Manish Jaggi wrote: On 20/02/15 8:09 pm, Ian Campbell wrote: On Fri, 2015-02-20 at 19:44 +0530, Manish Jaggi wrote: Another option might be a new hypercall (assuming one doesn't already exist) to register a PCI bus which would t

  1   2   >