Re: [Wireshark-dev] ?????? ?????? ?????? how to display a packet in the packet_view?

2014-02-25 Thread Guy Harris
On Feb 24, 2014, at 7:10 PM, "??" <237825...@qq.com> wrote: > up is a snapshot of packet view. > I want know where does the value of each column stored,such as Time,Source? > do they stored in the edt->pi(epan_dissect->packet_info) or > edt->pi->cinfo(column_info)? Some are in edt->pi,

[Wireshark-dev] Building wireshark with Qt 5.2 on MacOSX

2014-02-25 Thread Hadriel Kaplan
Howdy, Has anyone gotten Wireshark to build with Qt 5.2.1 on MacOSX Mavericks? If so, what magic pixie dust did you use to make it find the QDialog and QFrame header files, when Qt 5.2 does not apparently install them? (yes, I've google'd to no avail) Using the macosx-setup.sh script I've gotte

Re: [Wireshark-dev] Regarding customizing tshark summary display

2014-02-25 Thread Joerg Mayer
On Mon, Feb 24, 2014 at 04:47:09PM +0530, Venkatachalam S wrote: > I'm writing a custom dissector for my internal project. I'm having a frame > in the following format. > > 32 byte data + eth_hdr + payload > > So, there is a 32 byte internal header attached to every packet. All the > packets comi

Re: [Wireshark-dev] Heuristic check of T.125 dissector

2014-02-25 Thread ronnie sahlberg
Wireshark has lots of reverse engineered protocols. So that should not stop you. For example, the whole CIFS/SMB family of protocols used to be reverse engineered, eventhough now in later times the documentation to those protocols are now available so errors in the decoding can be fixed. If the

Re: [Wireshark-dev] Heuristic check of T.125 dissector

2014-02-25 Thread Thomas Wiens
> Without knowing the protocol, I'd say there's almost always room for > improvement. Open a bug with a sample capture and see if someone can > figure out how to strengthen the check. Ok, thanks. I will open a bug request then. > ps. you mentioned your dissector is hosted on sourceforge; woul

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Jan 28, 2014 at 02:51:19PM +0100, Joerg Mayer wrote: > On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: > > It is in the upper right corner. > > The links are pretty small. You are not the first who missed them. :-) > > Can you please provide the URL? If the URL is > https://

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 12:13 PM, Joerg Mayer wrote: > On Tue, Jan 28, 2014 at 02:51:19PM +0100, Joerg Mayer wrote: >> On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: >> > It is in the upper right corner. >> > The links are pretty small. You are not the first who missed them. :-) >>

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Gerald Combs
On 2/25/14 9:20 AM, Evan Huus wrote: > On Tue, Feb 25, 2014 at 12:13 PM, Joerg Mayer wrote: >> On Tue, Jan 28, 2014 at 02:51:19PM +0100, Joerg Mayer wrote: >>> On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: It is in the upper right corner. The links are pretty small. You

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: > I haven't found anything obvious in the server logs that would explain > the error, unfortunately. > > Since you were able to add your SSH key, does > > ssh your.usern...@code.wireshark.org:29418 gerrit --help I had to use ssh jma..

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: >> I haven't found anything obvious in the server logs that would explain >> the error, unfortunately. >> >> Since you were able to add your SSH key, does >> >> ssh your.usern...@cod

Re: [Wireshark-dev] [Wireshark-commits] master 75015e4: Can't register in a non-existent dissector table.

2014-02-25 Thread Evan Huus
Sorry, this was my mistake. I got it into my head that I'd landed the smb-direct dissector for some reason, when I clearly hadn't. That kind of day, I guess. On Tue, Feb 25, 2014 at 2:55 PM, Wireshark code review wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 01:48:22PM -0500, Evan Huus wrote: > On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: > > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: > >> I haven't found anything obvious in the server logs that would explain > >> the error, unfortunately. > >> > >> Si

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 4:57 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 01:48:22PM -0500, Evan Huus wrote: >> On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: >> > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: >> >> I haven't found anything obvious in the server logs that

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Pascal Quantin
2014-02-25 22:57 GMT+01:00 Joerg Mayer : > On Tue, Feb 25, 2014 at 01:48:22PM -0500, Evan Huus wrote: > > On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: > > > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: > > >> I haven't found anything obvious in the server logs that would e

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Hadriel Kaplan
On Feb 25, 2014, at 4:57 PM, Joerg Mayer wrote: > I just did that, and received the following message during push: > jmayer@egg:~/work/wireshark/git/ui/qt(master)> git push I believe you're supposed to do 'git review branchname', which does the 'git push' for you and probably appends the "bran

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Gerald Combs
On 2/25/14 10:39 AM, Joerg Mayer wrote: > > Once I've finished cloning the repo (somehow it's not my day: git clone > is an atomic operation and I'm behind an unstable Wireless connection), > how do I proceed? Is there a wiki page that I can follow to set all > the required and recommented git vari

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 02:26:52PM -0800, Gerald Combs wrote: > On 2/25/14 10:39 AM, Joerg Mayer wrote: > > > > Once I've finished cloning the repo (somehow it's not my day: git clone > > is an atomic operation and I'm behind an unstable Wireless connection), > > how do I proceed? Is there a wiki p

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote: > It sets up so that "git review" does the correct push, as well as > setting the gerrit topic to the current branch name (if different from > "master") and a few other conveniences. So there's no particular > reason to set up git push. Thi

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 5:42 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote: >> It sets up so that "git review" does the correct push, as well as >> setting the gerrit topic to the current branch name (if different from >> "master") and a few other conveniences.

Re: [Wireshark-dev] Change in wireshark[master]: The about dialog window was too small, causing "extra" lineb...

2014-02-25 Thread Joerg Mayer
a) Is there a reason why the reply to address is not set to something everyone can see? The way this is setup up right now means that technical discussion happens between private mail addresses and thus knowledge gets lost. On Tue, Feb 25, 2014 at 10:39:42PM +, Alexis La Goutte (Code Rev

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Gerald Combs
On 2/25/14 2:42 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote: >> It sets up so that "git review" does the correct push, as well as >> setting the gerrit topic to the current branch name (if different from >> "master") and a few other conveniences. So there's no

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 03:02:24PM -0800, Gerald Combs wrote: > You should be able to run something like > > ssh code.wireshark.org gerrit review --submit --code-review +2 \ > > > although I haven't tried it myself. OK, a few attempts later I've done this successfully with the following com

[Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Joerg Mayer
Hello, I've just documented the workflow I used to update the NEWS file. Please let me know what I missed and if you have ideas for improvement. Thanks Jörg jmayer@egg:~/work/wireshark/git(master)> git branch newsupdate jmayer@egg:~/work/wireshark/git(master)> git checkout newsupdate Switched

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Hadriel Kaplan
On Feb 25, 2014, at 7:06 PM, Joerg Mayer wrote: > jmayer@egg:~/work/wireshark/git(master)> git branch newsupdate > jmayer@egg:~/work/wireshark/git(master)> git checkout newsupdate > Switched to branch 'newsupdate' % git checkout -b newsupdate would have created the branch and checked it out at

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 7:50 PM, Hadriel Kaplan wrote: > > On Feb 25, 2014, at 7:06 PM, Joerg Mayer wrote: > >> jmayer@egg:~/work/wireshark/git(master)> git branch newsupdate >> jmayer@egg:~/work/wireshark/git(master)> git checkout newsupdate >> Switched to branch 'newsupdate' > > % git checkout

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Bill Meier
On 2/25/2014 7:50 PM, Hadriel Kaplan wrote: On Feb 25, 2014, at 7:06 PM, Joerg Mayer wrote: gerrit jmayer@egg:~/work/wireshark/git(master)> git branch newsupdate jmayer@egg:~/work/wireshark/git(master)> git checkout newsupdate Switched to branch 'newsupdate' % git checkout -b newsupdate wo

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Hadriel Kaplan
On Feb 25, 2014, at 8:14 PM, Evan Huus wrote: > We also have the developer guide ([1] and friends). Ideally this > information would only live in one place, though there doesn't seem to > be a consensus as to where that is (wiki, README, developer guide). > > [1] https://www.wireshark.org/docs/

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 8:39 PM, Hadriel Kaplan wrote: > > On Feb 25, 2014, at 8:14 PM, Evan Huus wrote: > >> We also have the developer guide ([1] and friends). Ideally this >> information would only live in one place, though there doesn't seem to >> be a consensus as to where that is (wiki, REA

[Wireshark-dev] Coverity Build Log

2014-02-25 Thread Evan Huus
The coverity build is failing again, but it's not at all clear to me from reading the public log what the problem is. Anybody know where to get more detailed information on the problem? Evan http://buildbot.wireshark.org/trunk/builders/Clang%20Code%20Analysis/builds/2603/steps/cov-build/logs/std

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Hadriel Kaplan
On Feb 25, 2014, at 8:44 PM, Evan Huus wrote: > I'm all for consolidating the above information - we just need to > decide which of the many places to consolidate *to*. We've been > playing musical chairs every few months moving things around from A to > B, B to C, and C to A, but never actually

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 8:57 PM, Hadriel Kaplan wrote: > > On Feb 25, 2014, at 8:44 PM, Evan Huus wrote: > >> I'm all for consolidating the above information - we just need to >> decide which of the many places to consolidate *to*. We've been >> playing musical chairs every few months moving thin

Re: [Wireshark-dev] Change in wireshark[master]: The about dialog window was too small, causing "extra" lineb...

2014-02-25 Thread Alexis La Goutte
On Tue, Feb 25, 2014 at 11:53 PM, Joerg Mayer wrote: > a) Is there a reason why the reply to address is not set to something > everyone >can see? The way this is setup up right now means that technical > discussion >happens between private mail addresses and thus knowledge gets lost. > >

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-25 Thread Alexis La Goutte
On Wed, Feb 26, 2014 at 3:08 AM, Evan Huus wrote: > On Tue, Feb 25, 2014 at 8:57 PM, Hadriel Kaplan > wrote: > > > > On Feb 25, 2014, at 8:44 PM, Evan Huus wrote: > > > >> I'm all for consolidating the above information - we just need to > >> decide which of the many places to consolidate *to*.