Re: [Wireshark-dev] BCD Decoding

2013-12-17 Thread Pascal Quantin
Le 18 déc. 2013 à 00:55, Evan Huus a écrit : > On Tue, Dec 17, 2013 at 6:13 PM, Pascal Quantin > wrote: >> Hi Even, >> >> in 3GPP world BCD encoding starts with the least significant nibble. That's >> why tvb_bcd_dig_to_wmwm_packet_str() behaves like this. Changing it to >> decode the most sig

[Wireshark-dev] Coding style and example dissector

2013-12-17 Thread Michael Lum
Could someone please write a coding style section for the new dissectors and perhaps point to the best example dissector. The example would match the coding style and use, preferably, a majority of the API. I would then code EXACTLY to that standard. Currently, many of the dissectors I have su

Re: [Wireshark-dev] BCD Decoding

2013-12-17 Thread Evan Huus
On Tue, Dec 17, 2013 at 6:13 PM, Pascal Quantin wrote: > Hi Even, > > in 3GPP world BCD encoding starts with the least significant nibble. That's > why tvb_bcd_dig_to_wmwm_packet_str() behaves like this. Changing it to > decode the most significant nibble first would break all the dissectors > cur

Re: [Wireshark-dev] BCD Decoding

2013-12-17 Thread Pascal Quantin
Hi Even, in 3GPP world BCD encoding starts with the least significant nibble. That's why tvb_bcd_dig_to_wmwm_packet_str() behaves like this. Changing it to decode the most significant nibble first would break all the dissectors currently using this function. The "stop condition" for the most signi

[Wireshark-dev] BCD Decoding

2013-12-17 Thread Evan Huus
Alexis's ASAN build recently caught an error in tvb_bcd_dig_to_wmem_packet_str in which it appears that if the least significant nibble of the decoded byte is 0xf then we read one element past the end of the 14-element digit array. If the most significant nibble is 0xf we treat that as a stop cond

Re: [Wireshark-dev] OSX 10.9 build procedures for latest source

2013-12-17 Thread Dirk Jagdmann
> What is the easiest way to build Wireshark 1.10.3 on OSX 10.9 Mavericks? > I’ve tried macports and native build with no real luck - I keep getting > tripped up by dependencies. Any suggestions about the best way to build a > custom copy of Wireshark from source? I have not used OsX 10.9 yet

Re: [Wireshark-dev] [Wireshark-commits] rev 53531: /trunk/ /trunk/epan/dissectors/: packet-x11.c x11-declarations.h x11-enum.h x11-extension-errors.h x11-extension-implementation.h x11-glx-render-enum

2013-12-17 Thread Bill Meier
On 11/23/2013 8:32 PM, morr...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=53531 User: morriss Date: 2013/11/24 01:32 AM Log: Some patches from Peter Harris to make it possible to build the X11 dissector again (and some various other improvements):

Re: [Wireshark-dev] OID/BER memory oddness

2013-12-17 Thread Evan Huus
On Sun, Dec 15, 2013 at 2:20 PM, Ed Beroset wrote: > Ed Beroset wrote: >> >> Evan Huus wrote: >>> >>> >>> The part that's confusing me is that somehow >>> actx->external.direct_reference seems to be getting a pointer to this >>> stale ep-allocated buffer, but I can't find anywhere in the call stac

Re: [Wireshark-dev] Error while installing wireshark 1.10.3

2013-12-17 Thread Jeff Morriss
On 12/12/13 03:47, Vishnu Bhatt wrote: Hello, Thanks for the help. Now it is getting installed without set_cap error (after changing %global setcap_dumpcap to 0) but now if I start Wireshark, it is not present in the machine. Wireshark is not getting installed in /usr/bin and if I type where

Re: [Wireshark-dev] Error while installing wireshark 1.10.3

2013-12-17 Thread Jeff Morriss
On 12/12/13 14:09, Guy Harris wrote: On Dec 12, 2013, at 9:15 AM, "Maynard, Chris" wrote: This was a topic brought up by Tomas Kukosa some years ago: http://www.wireshark.org/lists/wireshark-dev/200809/msg00081.html The only objection I saw was Jeff Morriss's I think the point of RPM pa

[Wireshark-dev] Wireshark 1.8.12 is now available

2013-12-17 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark 1.8.12. __ What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis

[Wireshark-dev] Wireshark 1.10.4 is now available

2013-12-17 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark 1.10.4. __ What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis

Re: [Wireshark-dev] Error while installing wireshark 1.10.3

2013-12-17 Thread Jeff Morriss
On 12/13/13 06:32, Vishnu Bhatt wrote: Hello, Thanks for the help. After replacing the Wireshark.spec.in file from 1.8.6 to 1.10.3, my system was able to locate Wireshark. Actually in 1.10.3, Wireshark.spec.in does not keep the wireshark exe by default at /usr/bin, instead it installs them to t

[Wireshark-dev] Should existing use of 'LL' and 'ULL' when specifying a constant be fixed ?

2013-12-17 Thread Bill Meier
README.developer says: When specifying an integral constant that doesn't fit in 32 bits, don't use "LL" at the end of the constant - not all compilers use "LL" for that. Instead, put the constant in a call to the "G_GINT64_CONSTANT()" macro, e.g. G_GINT64_CONSTANT(11644473600U) rather

[Wireshark-dev] OSX 10.9 build procedures for latest source

2013-12-17 Thread steven harris
Hi! What is the easiest way to build Wireshark 1.10.3 on OSX 10.9 Mavericks? I’ve tried macports and native build with no real luck - I keep getting tripped up by dependencies. Any suggestions about the best way to build a custom copy of Wireshark from source? Thanks! Steve

Re: [Wireshark-dev] [Wireshark-commits] rev 54161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

2013-12-17 Thread Martin Mathieson
Sorry, I will try to get this today (by either finishing off the work or #if 0'ing out what isn't being used yet). Martin On Tue, Dec 17, 2013 at 6:22 AM, Kaul wrote: > Still no go: > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9568 : Compilation > failure: packet-pdcp-lte.c:1211:12: er