Alexis's ASAN build recently caught an error in tvb_bcd_dig_to_wmem_packet_str in which it appears that if the least significant nibble of the decoded byte is 0xf then we read one element past the end of the 14-element digit array.
If the most significant nibble is 0xf we treat that as a stop condition. Is the correct approach to treat a least significant nibble of 0xf as a stop condition also? While in the neighbourhood - shouldn't we be decoding the more significant nibble first, not second? Wiki states that most BCD implementations are big-endian... Cheers, Evan ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
