Re: [Wireshark-dev] Bug? TPKT length invalid? DIFF

2007-01-25 Thread Wiese, Hendrik
> Are you sure your TPKT has the proper endian-ness? > > Is wireshark detecting the proper endianness for your platform? Well, to be honest, I'm not really sure. How can I verify this? > > packet-tpkt.c:193: data_len = g_htons(tvb_get_ntohs(tvb, > offset + 2)); > > From a code readability st

Re: [Wireshark-dev] Q about new Help ! Manual Pages feature

2007-01-25 Thread Bill Meier
> > Bill Meier wrote: > > 1. When I select > > > > Help ! Manual Pages ! Wireshark I get a "Copy" pop-up box saying "Select > > the place where you want to copy wireshark.html". > > > > If I hit cancel the wireshark man page displays in Firefox. > > If I hit 'copy' the file is copied but does n

Re: [Wireshark-dev] Wireshark w/ MSVC++ 2005 EE fails to capture

2007-01-25 Thread Stephen Fisher
On Thu, Jan 25, 2007 at 10:53:32PM +0100, Ulf Lamping wrote: > Stephen Fisher wrote: > > When I run MSVC++ and attach to the process to debug before it > > crashes, it fails on line 650 of gui_utils.c. The line is within > > pipe_timer_cb() and says: > > > > handle = (HANDLE) _get_osfhandle

Re: [Wireshark-dev] Wireshark w/ MSVC++ 2005 EE fails to capture

2007-01-25 Thread Ulf Lamping
Stephen Fisher wrote: > First of all, thanks to Ulf for making Wireshark compile on MSVC++ 2005 > Express Edition so I can try it out without buying the compiler. > > I'm having problems when I run Wireshark built with this compiler > though. I'm running it out of the c:\wireshark\wireshark-gtk2

[Wireshark-dev] Wireshark w/ MSVC++ 2005 EE fails to capture

2007-01-25 Thread Stephen Fisher
First of all, thanks to Ulf for making Wireshark compile on MSVC++ 2005 Express Edition so I can try it out without buying the compiler. I'm having problems when I run Wireshark built with this compiler though. I'm running it out of the c:\wireshark\wireshark-gtk2\ directory. When I start a c

Re: [Wireshark-dev] Win32 build error

2007-01-25 Thread Ulf Lamping
Giorgio Tino wrote: > Hi, > I'm trying to rebuild wireshark (r.20554) and this is what I get: > > help_dlg.c(49) : fatal error C1083: Cannot open include file: 'htmlhelp.h': > No such file or directory > > In general, follow http://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html In

Re: [Wireshark-dev] Wireshark Windows build Problem

2007-01-25 Thread Ulf Lamping
Richard Robinson wrote: > > Hi, > > I have tried building the windows version of wireshark which all goes > smoothly, except when I try to run Wireshark I get the following Error > message when I try to run Wireshark.exe (Runtime error R6034) which is > improper invocation of the C runtime libra

[Wireshark-dev] Wireshark Windows build Problem

2007-01-25 Thread Richard Robinson
Hi, I have tried building the windows version of wireshark which all goes smoothly, except when I try to run Wireshark I get the following Error message when I try to run Wireshark.exe (Runtime error R6034) which is improper invocation of the C runtime library. if someone could make some suggestio

Re: [Wireshark-dev] 802.11 whdrs array needed?

2007-01-25 Thread Guy Harris
Gerald Combs wrote: > The 802.11 dissector has the following code: > > wlan_hdr *volatile whdr; > static wlan_hdr whdrs[4]; > > whdr= &whdrs[0]; > > It looks like whdrs[1] through whdrs[3] are never used. Should the code > be modified to rotate through each member of whdrs, similar to the

[Wireshark-dev] 802.11 whdrs array needed?

2007-01-25 Thread Gerald Combs
The 802.11 dissector has the following code: wlan_hdr *volatile whdr; static wlan_hdr whdrs[4]; whdr= &whdrs[0]; It looks like whdrs[1] through whdrs[3] are never used. Should the code be modified to rotate through each member of whdrs, similar to the fmtbuf arrays in strutil.c? _

Re: [Wireshark-dev] Tshark0994 memory question

2007-01-25 Thread rmkml
Hi, Im switched to wireshark 0.99.5pre1, and I have same memory pb, Thx for help Rmkml On Sun, 14 Jan 2007, Guy Harris wrote: > Date: Sun, 14 Jan 2007 02:08:18 -0800 > From: Guy Harris <[EMAIL PROTECTED]> > Reply-To: Developer support list for Wireshark > To: Developer support list for Wireshar

Re: [Wireshark-dev] [Wireshark-commits] rev 20546: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

2007-01-25 Thread Gerald Combs
Joerg Mayer wrote: > Gerald, > > On Wed, Jan 24, 2007 at 07:22:15PM +, [EMAIL PROTECTED] wrote: >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20546 >> >> Directory: /trunk/epan/dissectors/ >> ChangesPath Action >> +104 -104 packet-ieee80211.c

Re: [Wireshark-dev] Bug? TPKT length invalid? DIFF

2007-01-25 Thread Charles Lepple
On 1/25/07, Wiese, Hendrik <[EMAIL PROTECTED]> wrote: > Hi there, > > I think, I've found a bug: the length of a TPKT header evaluated later > is swapped by tvb_get_ntohs() (Wireshark 0.99.6 > /epan/dissectors/packet-tpkt.c:193). It only works for us if we re-swap > it with g_htons() just after fet

[Wireshark-dev] Bug? TPKT length invalid? DIFF

2007-01-25 Thread Wiese, Hendrik
Hi there, I think, I've found a bug: the length of a TPKT header evaluated later is swapped by tvb_get_ntohs() (Wireshark 0.99.6 /epan/dissectors/packet-tpkt.c:193). It only works for us if we re-swap it with g_htons() just after fetching it from the tvb: packet-tpkt.c:193: data_len = g_htons(tv

[Wireshark-dev] [Patch] SCSI persistent reserve out

2007-01-25 Thread Patrick vd Lageweg
Hi, The PERSISTENT REVERVE OUT dissectors uses the table of the PERSISTENT REVERVE IN command to decode the Service Action field which is obviously not correct. This patch fixes the problem. Patrick Index: packet-scsi.c ===

Re: [Wireshark-dev] How to modify hf_register_info hf[] ?

2007-01-25 Thread Jan Kokott
Hi, I tried to alter the hf[] field which is 0 / 2 / 8 Byte by using a switch/case after initializing hf_register_info hf[] = {...} in the proto_register_zigbee. hf[14].hfinfo.type = FT_UINT16; But that doesn´t effect the array at all. At the Moment the dissector could detect if the field is pr

[Wireshark-dev] Dissector for Cisco ITP packet logging facility

2007-01-25 Thread Abhik Sarkar
Hello All, This probably doesn't qualify as a "dissector", but this has been very useful for me since I wrote it a couple of days back and I thought it might be useful for someone else too... First an introduction in the form of a quote from the Cisco ITP manual... The ITP Packet Logging facil

Re: [Wireshark-dev] Win32: get rid of the xy.def files?!?

2007-01-25 Thread Lars Roland
Guy Harris schrieb: > On Jan 24, 2007, at 9:14 AM, Ulf Lamping wrote: > >> Any objections against this (in my eyes cleaner) solution? > > Somebody asked about this in 2004: > > http://www.wireshark.org/lists/ethereal-dev/200405/msg06091.html > > but I'm not sure why, given the answer: >

Re: [Wireshark-dev] What is "View/Display Filter Macros" in the menu?!?

2007-01-25 Thread Guy Harris
Douglas Pratley wrote: > May I suggest that a section is added to the Developers Guide and / or > Readme.developer that just points out that the documentation source _is_ > part of the Wireshark source and can be found in /docbook and built > according to the instructions in the readme there. And t

[Wireshark-dev] Win32 build error

2007-01-25 Thread Giorgio Tino
Hi, I'm trying to rebuild wireshark (r.20554) and this is what I get: help_dlg.c(49) : fatal error C1083: Cannot open include file: 'htmlhelp.h': No such file or directory Thanks, Giorgio! - Original Message - From: "Joerg Mayer" <[EMAIL PROTECTED]> To: "Developer support list for Wire

Re: [Wireshark-dev] Warn Dissector bug, protocol TFTP, in packet 1: packet-tftp.c:199: failed assertion "conversation"

2007-01-25 Thread Joerg Mayer
On Thu, Jan 25, 2007 at 09:29:19AM +0100, Florian Lohoff wrote: > i have a packet (attached cap) which triggers the above warning. This is > a Wireshark 0.99.4 (Debian Package). Thanks for the report. I wrote that code and after looking at the trace I have an idea what mistake I made. I hope to fi

[Wireshark-dev] Dissecting TPKT?

2007-01-25 Thread Wiese, Hendrik
Hello, How do I dissect TPKT encapsulated packages? Is there any kind of documentation aside from the RFC? What I've done already is check if it is a TPKT package (is_tpkt...) and if it isn't (returned length == -1) I call the protocol specific dissector function directly. If it _is_ a TPKT pack

Re: [Wireshark-dev] [Wireshark-commits] rev 20546: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

2007-01-25 Thread Joerg Mayer
Gerald, On Wed, Jan 24, 2007 at 07:22:15PM +, [EMAIL PROTECTED] wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20546 > > Directory: /trunk/epan/dissectors/ > ChangesPath Action > +104 -104 packet-ieee80211.cModified There seems to be a

[Wireshark-dev] Dissecting Objects

2007-01-25 Thread David Dugoujon
Hi all, I am writing a plugin for several protocols (Tier2 architecture) that share common object types. I have to analyse these objects before I can determine their size. I would like to know what is the best method to dissect these objects. * Do I need to write another dissectors for these obj

[Wireshark-dev] Warn Dissector bug, protocol TFTP, in packet 1: packet-tftp.c:199: failed assertion "conversation"

2007-01-25 Thread Florian Lohoff
Hi, i have a packet (attached cap) which triggers the above warning. This is a Wireshark 0.99.4 (Debian Package). Flo -- Florian Lohoff [EMAIL PROTECTED] +49-171-2280134 Those who would give up a little freedom to get a little security shall soon h

Re: [Wireshark-dev] What is "View/Display Filter Macros" in the menu?!?

2007-01-25 Thread Douglas Pratley
May I suggest that a section is added to the Developers Guide and / or Readme.developer that just points out that the documentation source _is_ part of the Wireshark source and can be found in /docbook and built according to the instructions in the readme there. And that people are expected to upda