[webkit-changes] [295400] trunk/Source/WTF/wtf/CrossThreadCopier.h

2022-06-08 Thread ddkilzer
Title: [295400] trunk/Source/WTF/wtf/CrossThreadCopier.h Revision 295400 Author ddkil...@apple.com Date 2022-06-08 16:26:55 -0700 (Wed, 08 Jun 2022) Log Message WTF::CrossThreadCopierBase::copy() should use std::forward Reviewed by Darin Adler. * Source/WTF/wtf/CrossThreadCopier.h: (W

[webkit-changes] [295409] trunk/Source/WebGPU/WebGPU/ShaderModule.mm

2022-06-08 Thread ddkilzer
Title: [295409] trunk/Source/WebGPU/WebGPU/ShaderModule.mm Revision 295409 Author ddkil...@apple.com Date 2022-06-08 21:55:57 -0700 (Wed, 08 Jun 2022) Log Message WebGPU::ShaderModule::convertCheckResult() should use std::forward Reviewed by Darin Adler. * Source/WebGPU/WebGPU/ShaderM

[webkit-changes] [221097] trunk/Source/JavaScriptCore

2017-08-23 Thread ddkilzer
Title: [221097] trunk/Source/_javascript_Core Revision 221097 Author ddkil...@apple.com Date 2017-08-23 13:14:37 -0700 (Wed, 23 Aug 2017) Log Message Fix -Wcast-qual warnings in _javascript_Core with new clang compiler Reviewed by Mark Lam. * API/ObjCCallbackFunction.mm: (JSC::objCCal

[webkit-changes] [221152] trunk/Source/WebCore

2017-08-24 Thread ddkilzer
Title: [221152] trunk/Source/WebCore Revision 221152 Author ddkil...@apple.com Date 2017-08-24 11:35:39 -0700 (Thu, 24 Aug 2017) Log Message Fix -Wcast-qual and -Wunused-lambda-capture warnings in WebCore with new clang compiler Reviewed by Alex Christensen. Fix -Wunused-lambda-captur

[webkit-changes] [221215] trunk/Source/WebKit

2017-08-25 Thread ddkilzer
Title: [221215] trunk/Source/WebKit Revision 221215 Author ddkil...@apple.com Date 2017-08-25 16:59:35 -0700 (Fri, 25 Aug 2017) Log Message Fix -Wunused-lambda-capture warnings in WebKit with new clang compiler Reviewed by Alex Christensen. * NetworkProcess/cache/CacheStorageEngine.cp

[webkit-changes] [226938] trunk/Tools

2018-01-13 Thread ddkilzer
Title: [226938] trunk/Tools Revision 226938 Author ddkil...@apple.com Date 2018-01-13 12:38:04 -0800 (Sat, 13 Jan 2018) Log Message check-webkit-style: false positive for [whitespace/braces] with os_log format string Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (c

[webkit-changes] [227233] trunk/Source/JavaScriptCore

2018-01-19 Thread ddkilzer
Title: [227233] trunk/Source/_javascript_Core Revision 227233 Author ddkil...@apple.com Date 2018-01-19 13:48:25 -0800 (Fri, 19 Jan 2018) Log Message oss-fuzz jsc build is broken: StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found Rubber-stamped by JF Bastien. * CMakeL

[webkit-changes] [227427] trunk/Tools

2018-01-23 Thread ddkilzer
Title: [227427] trunk/Tools Revision 227427 Author ddkil...@apple.com Date 2018-01-23 11:31:04 -0800 (Tue, 23 Jan 2018) Log Message Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage https://bugs.webkit.org/show_bug.cgi?id

[webkit-changes] [227453] trunk/Source/JavaScriptCore

2018-01-23 Thread ddkilzer
Title: [227453] trunk/Source/_javascript_Core Revision 227453 Author ddkil...@apple.com Date 2018-01-23 15:19:02 -0800 (Tue, 23 Jan 2018) Log Message Follow-up for: oss-fuzz jsc build is broken: StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found Address feedback for th

[webkit-changes] [227532] trunk/Tools

2018-01-24 Thread ddkilzer
Title: [227532] trunk/Tools Revision 227532 Author ddkil...@apple.com Date 2018-01-24 10:11:13 -0800 (Wed, 24 Jan 2018) Log Message check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C Reviewed by Tim Horton. *

[webkit-changes] [227990] trunk/Source/WebKit

2018-02-01 Thread ddkilzer
Title: [227990] trunk/Source/WebKit Revision 227990 Author ddkil...@apple.com Date 2018-02-01 16:40:31 -0800 (Thu, 01 Feb 2018) Log Message REGRESSION (r222824): UI process crashes in WebKit::WebBackForwardList::backItem const Reviewed by Alex Christensen. * UIProcess/WebBackForwardLi

[webkit-changes] [240001] trunk/Source/ThirdParty/ANGLE

2019-01-15 Thread ddkilzer
Title: [240001] trunk/Source/ThirdParty/ANGLE Revision 240001 Author ddkil...@apple.com Date 2019-01-15 13:47:51 -0800 (Tue, 15 Jan 2019) Log Message clang-tidy: Fix unnecessary copy of for loop variables in ANGLE Reviewed by Alex Christensen. Fix unwanted copying of loop variables by

[webkit-changes] [240005] trunk/Source/WebCore

2019-01-15 Thread ddkilzer
Title: [240005] trunk/Source/WebCore Revision 240005 Author ddkil...@apple.com Date 2019-01-15 14:13:33 -0800 (Tue, 15 Jan 2019) Log Message Let Xcode have its way with the WebCore project * WebCore.xcodeproj/project.pbxproj: - Change the lastKnownFileType for *.gperf and *.idl files fro

[webkit-changes] [240004] trunk/Source/ThirdParty/libwebrtc

2019-01-15 Thread ddkilzer
Title: [240004] trunk/Source/ThirdParty/libwebrtc Revision 240004 Author ddkil...@apple.com Date 2019-01-15 14:13:30 -0800 (Tue, 15 Jan 2019) Log Message REGRESSION (r239510): Remove duplicate copy of srtpsession.cc from 'webrtcpcrtc' target in Xcode project Fixes the following Xcode war

[webkit-changes] [240053] trunk/Source/ThirdParty/libwebrtc

2019-01-16 Thread ddkilzer
Title: [240053] trunk/Source/ThirdParty/libwebrtc Revision 240053 Author ddkil...@apple.com Date 2019-01-16 14:44:54 -0800 (Wed, 16 Jan 2019) Log Message clang-tidy: Fix unnecessary copy/ref churn of for loop variables in libwebrtc Reviewed by Youenn Fablet. Fix unwanted copying/ref ch

[webkit-changes] [240168] trunk

2019-01-18 Thread ddkilzer
Title: [240168] trunk Revision 240168 Author ddkil...@apple.com Date 2019-01-18 12:41:58 -0800 (Fri, 18 Jan 2019) Log Message Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h} Reviewed by Alex Christensen. Source/WebCore: This does the followi

[webkit-changes] [240169] trunk/Source/WebCore

2019-01-18 Thread ddkilzer
Title: [240169] trunk/Source/WebCore Revision 240169 Author ddkil...@apple.com Date 2019-01-18 13:16:33 -0800 (Fri, 18 Jan 2019) Log Message Follow-up: Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h} * editing/cocoa/DictionaryLookup.mm: (-[Web

[webkit-changes] [240184] trunk/Source/WebCore/PAL

2019-01-18 Thread ddkilzer
Title: [240184] trunk/Source/WebCore/PAL Revision 240184 Author ddkil...@apple.com Date 2019-01-18 15:44:31 -0800 (Fri, 18 Jan 2019) Log Message Follow-up: Override the session configuration for cookieAcceptPolicy Discussed with John Wilander. * pal/spi/cf/CFNetworkSPI.h: Declare new

[webkit-changes] [240186] trunk/Source/JavaScriptCore

2019-01-18 Thread ddkilzer
Title: [240186] trunk/Source/_javascript_Core Revision 240186 Author ddkil...@apple.com Date 2019-01-18 16:08:21 -0800 (Fri, 18 Jan 2019) Log Message Follow-up: Gigacages should start allocations from a slide * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::caged): Add UNUSED_P

[webkit-changes] [240197] trunk/Source/WebKit

2019-01-18 Thread ddkilzer
Title: [240197] trunk/Source/WebKit Revision 240197 Author ddkil...@apple.com Date 2019-01-18 21:28:24 -0800 (Fri, 18 Jan 2019) Log Message [WebKit] Change Xcode folders to map to folders on disk * WebKit.xcodeproj/project.pbxproj: Update these folders: - Shared/Authentication - Shared/A

[webkit-changes] [240196] trunk/Source/WebCore/PAL

2019-01-18 Thread ddkilzer
Title: [240196] trunk/Source/WebCore/PAL Revision 240196 Author ddkil...@apple.com Date 2019-01-18 21:28:11 -0800 (Fri, 18 Jan 2019) Log Message [PAL] Change Xcode folders to map to folders on disk Found by tidy-Xcode-project-file script (see Bug 188754). * PAL.xcodeproj/project.pbxproj

[webkit-changes] [240202] trunk/Source/WebKit

2019-01-19 Thread ddkilzer
Title: [240202] trunk/Source/WebKit Revision 240202 Author ddkil...@apple.com Date 2019-01-19 09:38:36 -0800 (Sat, 19 Jan 2019) Log Message Sort WebKit Xcode project file * WebKit.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit.xcodepr

[webkit-changes] [240203] trunk/Source/WebKit

2019-01-19 Thread ddkilzer
Title: [240203] trunk/Source/WebKit Revision 240203 Author ddkil...@apple.com Date 2019-01-19 09:38:40 -0800 (Sat, 19 Jan 2019) Log Message Follow-up: iOS: Updating input mode should update the software keyboard * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::focusedElementDidChang

[webkit-changes] [240235] trunk

2019-01-21 Thread ddkilzer
Title: [240235] trunk Revision 240235 Author ddkil...@apple.com Date 2019-01-21 09:22:36 -0800 (Mon, 21 Jan 2019) Log Message Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h} Reviewed by Alex Christensen. Source/WebCore: * platform/cocoa/Vide

[webkit-changes] [240236] trunk/Source/WebCore/PAL

2019-01-21 Thread ddkilzer
Title: [240236] trunk/Source/WebCore/PAL Revision 240236 Author ddkil...@apple.com Date 2019-01-21 10:05:16 -0800 (Mon, 21 Jan 2019) Log Message Sort PAL Xcode project file * PAL.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/PAL.x

[webkit-changes] [240238] trunk/Source/WebCore

2019-01-21 Thread ddkilzer
Title: [240238] trunk/Source/WebCore Revision 240238 Author ddkil...@apple.com Date 2019-01-21 11:23:01 -0800 (Mon, 21 Jan 2019) Log Message REGRESSION (r240201): Add a POINTER_EVENTS feature flag https://bugs.webkit.org/show_bug.cgi?id=193577 * dom/ios/PointerEventIOS.cpp: Add ENABLE(P

[webkit-changes] [240239] trunk/Source/WebCore

2019-01-21 Thread ddkilzer
Title: [240239] trunk/Source/WebCore Revision 240239 Author ddkil...@apple.com Date 2019-01-21 11:51:59 -0800 (Mon, 21 Jan 2019) Log Message REGRESSION (r240237): Revert changes to WebCore Xcode project * WebCore.xcodeproj/project.pbxproj: Revert changes that were fixed in r240135. Dari

[webkit-changes] [240256] trunk/Source/WebCore

2019-01-22 Thread ddkilzer
Title: [240256] trunk/Source/WebCore Revision 240256 Author ddkil...@apple.com Date 2019-01-22 10:15:00 -0800 (Tue, 22 Jan 2019) Log Message Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests Reviewed by Dean Jackson. * platform/graphics/gpu/

[webkit-changes] [240272] trunk/Source

2019-01-22 Thread ddkilzer
Title: [240272] trunk/Source Revision 240272 Author ddkil...@apple.com Date 2019-01-22 12:12:37 -0800 (Tue, 22 Jan 2019) Log Message Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h} Reviewed by Alex Christensen. - Moves QuickLookSoftLink.{h,

[webkit-changes] [240275] trunk/Source/WebKit

2019-01-22 Thread ddkilzer
Title: [240275] trunk/Source/WebKit Revision 240275 Author ddkil...@apple.com Date 2019-01-22 12:49:55 -0800 (Tue, 22 Jan 2019) Log Message C strings in ClientCertificateAuthenticationXPCConstants.h are duplicated Reviewed by Alex Christensen. * Shared/Authentication/cocoa/Authenticat

[webkit-changes] [240299] trunk/Tools

2019-01-22 Thread ddkilzer
Title: [240299] trunk/Tools Revision 240299 Author ddkil...@apple.com Date 2019-01-22 14:51:19 -0800 (Tue, 22 Jan 2019) Log Message check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/sty

[webkit-changes] [240332] trunk/Source

2019-01-23 Thread ddkilzer
Title: [240332] trunk/Source Revision 240332 Author ddkil...@apple.com Date 2019-01-23 03:58:15 -0800 (Wed, 23 Jan 2019) Log Message Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h} Reviewed by Tim Horton. Source/WebCore/PAL: * pal/cf/CoreMediaSoftL

[webkit-changes] [240335] trunk/Source/JavaScriptCore

2019-01-23 Thread ddkilzer
Title: [240335] trunk/Source/_javascript_Core Revision 240335 Author ddkil...@apple.com Date 2019-01-23 07:40:55 -0800 (Wed, 23 Jan 2019) Log Message [JSC] Duplicate global variables: JSC::opcodeLengths Reviewed by Mark Lam. * bytecode/Opcode.cpp: (JSC::opcodeLengths): Move array impl

[webkit-changes] [240345] trunk/Source/WebCore

2019-01-23 Thread ddkilzer
Title: [240345] trunk/Source/WebCore Revision 240345 Author ddkil...@apple.com Date 2019-01-23 10:39:37 -0800 (Wed, 23 Jan 2019) Log Message REGRESSION (r240292): Attempt to fix WinCairo build * platform/network/curl/CurlResourceHandleDelegate.cpp: (WebCore::handleCookieHeaders): Remove

[webkit-changes] [240402] trunk/Tools

2019-01-23 Thread ddkilzer
Title: [240402] trunk/Tools Revision 240402 Author ddkil...@apple.com Date 2019-01-23 18:47:53 -0800 (Wed, 23 Jan 2019) Log Message check-webkit-style should warn when using soft-linking macros in a header Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (check_langua

[webkit-changes] [240429] trunk/Source/WTF

2019-01-24 Thread ddkilzer
Title: [240429] trunk/Source/WTF Revision 240429 Author ddkil...@apple.com Date 2019-01-24 02:39:14 -0800 (Thu, 24 Jan 2019) Log Message Duplicate global variables: WTF::asciiCaseFoldTable Reviewed by Michael Catanzaro. * WTF.xcodeproj/project.pbxproj: * wtf/CMakeLists.txt: - Add ASCI

[webkit-changes] [240430] trunk/Source/WebCore/PAL

2019-01-24 Thread ddkilzer
Title: [240430] trunk/Source/WebCore/PAL Revision 240430 Author ddkil...@apple.com Date 2019-01-24 02:59:47 -0800 (Thu, 24 Jan 2019) Log Message Follow-up #2: Override the session configuration for cookieAcceptPolicy * pal/spi/cf/CFNetworkSPI.h: Protect Objective-C code using defined(_

[webkit-changes] [240494] trunk/Source

2019-01-25 Thread ddkilzer
Title: [240494] trunk/Source Revision 240494 Author ddkil...@apple.com Date 2019-01-25 12:24:14 -0800 (Fri, 25 Jan 2019) Log Message Move soft-linking of Lookup.framework out of LookupSPI.h Reviewed by Tim Horton. Source/WebCore: * editing/cocoa/DictionaryLookup.mm: - Remove unused he

[webkit-changes] [240889] trunk/Source

2019-02-01 Thread ddkilzer
Title: [240889] trunk/Source Revision 240889 Author ddkil...@apple.com Date 2019-02-01 16:45:51 -0800 (Fri, 01 Feb 2019) Log Message Move soft-linking of TelephonyUtilities.framework out of TUCallSPI.h Reviewed by Alex Christensen. Source/WebCore/PAL: * PAL.xcodeproj/project.pbxproj:

[webkit-changes] [240896] trunk/Source/WTF

2019-02-02 Thread ddkilzer
Title: [240896] trunk/Source/WTF Revision 240896 Author ddkil...@apple.com Date 2019-02-02 10:35:42 -0800 (Sat, 02 Feb 2019) Log Message Leak of WTF::StringImpl under SymbolImpl::createNullSymbol() (48 bytes) in com.apple.WebKit.WebContent running layout tests Reviewed by Keith Miller.

[webkit-changes] [240900] trunk/Tools

2019-02-02 Thread ddkilzer
Title: [240900] trunk/Tools Revision 240900 Author ddkil...@apple.com Date 2019-02-02 12:20:36 -0800 (Sat, 02 Feb 2019) Log Message Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator Reviewed by Alexey Proskuryakov. * WebKitTestRu

[webkit-changes] [240961] trunk/Source/ThirdParty/libwebrtc

2019-02-04 Thread ddkilzer
Title: [240961] trunk/Source/ThirdParty/libwebrtc Revision 240961 Author ddkil...@apple.com Date 2019-02-04 19:24:54 -0800 (Mon, 04 Feb 2019) Log Message vp8e_mr_alloc_mem() leaks LOWER_RES_FRAME_INFO if second memory allocation fails Reviewed by Youenn Fablet. * Source/third_party/lib

[webkit-changes] [241031] trunk/LayoutTests

2019-02-06 Thread ddkilzer
Title: [241031] trunk/LayoutTests Revision 241031 Author ddkil...@apple.com Date 2019-02-06 10:59:01 -0800 (Wed, 06 Feb 2019) Log Message Revert part of r241015 that skipped all WebGL tests * TestExpectations: Revert unintended change to skip all WebGL tests. Modified Paths trunk/Layou

[webkit-changes] [241034] trunk/Tools

2019-02-06 Thread ddkilzer
Title: [241034] trunk/Tools Revision 241034 Author ddkil...@apple.com Date 2019-02-06 11:32:31 -0800 (Wed, 06 Feb 2019) Log Message WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef Reviewed by Alexey Proskuryakov. * WebKitTestRunner/InjectedBundle/InjectedBundlePag

[webkit-changes] [225903] trunk/Source/JavaScriptCore

2017-12-14 Thread ddkilzer
Title: [225903] trunk/Source/_javascript_Core Revision 225903 Author ddkil...@apple.com Date 2017-12-14 07:36:31 -0800 (Thu, 14 Dec 2017) Log Message REGRESSION (r225887): Build broke due to missing includes in InferredValue.h * runtime/InferredValue.h: Attempt to fix build by adding mi

[webkit-changes] [225905] trunk/Source/JavaScriptCore

2017-12-14 Thread ddkilzer
Title: [225905] trunk/Source/_javascript_Core Revision 225905 Author ddkil...@apple.com Date 2017-12-14 09:03:56 -0800 (Thu, 14 Dec 2017) Log Message REGRESSION (r225799/r225887): Remove duplicate entries for JSCPoisonedPtr.h in Xcode project Fixes the following warning during builds:

[webkit-changes] [225957] trunk/Tools

2017-12-14 Thread ddkilzer
Title: [225957] trunk/Tools Revision 225957 Author ddkil...@apple.com Date 2017-12-14 19:26:27 -0800 (Thu, 14 Dec 2017) Log Message check-webkit-style: Stop warning about underscores in webrtc source Reviewed by Joseph Pecoraro. * Scripts/webkitpy/style/checker.py: (_PATH_RULES_SPECIFI

[webkit-changes] [225958] trunk/Source

2017-12-14 Thread ddkilzer
Title: [225958] trunk/Source Revision 225958 Author ddkil...@apple.com Date 2017-12-14 20:19:29 -0800 (Thu, 14 Dec 2017) Log Message Enable -Wstrict-prototypes for WebKit Rubber-stamped by Joseph Pecoraro. Source/bmalloc: * Configurations/Base.xcconfig: (CLANG_WARN_STRICT_PROTOTYPES)

[webkit-changes] [225962] trunk/Source/WebCore/PAL

2017-12-14 Thread ddkilzer
Title: [225962] trunk/Source/WebCore/PAL Revision 225962 Author ddkil...@apple.com Date 2017-12-14 21:22:36 -0800 (Thu, 14 Dec 2017) Log Message Fix 32-bit build: Enable -Wstrict-prototypes for WebKit * pal/spi/mac/QuickDrawSPI.h: (NewRgn): Add 'void' to C function declaration. (PenNor

[webkit-changes] [226034] trunk/Source/WebKitLegacy/mac

2017-12-18 Thread ddkilzer
Title: [226034] trunk/Source/WebKitLegacy/mac Revision 226034 Author ddkil...@apple.com Date 2017-12-18 05:43:15 -0800 (Mon, 18 Dec 2017) Log Message BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future Attempt to fix the following warnings: AppKit instance var

[webkit-changes] [226290] trunk/Source/WebKit

2017-12-24 Thread ddkilzer
Title: [226290] trunk/Source/WebKit Revision 226290 Author ddkil...@apple.com Date 2017-12-24 11:07:12 -0800 (Sun, 24 Dec 2017) Log Message REGRESSION (r224313): Fix build warning when compiling WebKit.xcassets Reviewed by Dan Bernstein. Fixes the following build warning: Opensour

[webkit-changes] [226387] trunk/Source/WebKit

2018-01-03 Thread ddkilzer
Title: [226387] trunk/Source/WebKit Revision 226387 Author ddkil...@apple.com Date 2018-01-03 20:18:53 -0800 (Wed, 03 Jan 2018) Log Message com.apple.WebKit.Networking crash in com.apple.Foundation: -[__NSOperationInternal _start:] Reviewed by Alex Christensen. * NetworkProcess/cocoa/

[webkit-changes] [226391] trunk/Source/WebKit

2018-01-03 Thread ddkilzer
Title: [226391] trunk/Source/WebKit Revision 226391 Author ddkil...@apple.com Date 2018-01-03 21:23:54 -0800 (Wed, 03 Jan 2018) Log Message REGRESSION (r212929): WKSnapshotConfiguration may leak an NSNumber when deallocated Reviewed by Joseph Pecoraro. * UIProcess/API/Cocoa/WKSnapshotC

[webkit-changes] [226483] trunk/Source

2018-01-05 Thread ddkilzer
Title: [226483] trunk/Source Revision 226483 Author ddkil...@apple.com Date 2018-01-05 19:19:57 -0800 (Fri, 05 Jan 2018) Log Message Re-enable -Wcast-qual in WebCore for Apple ports Reviewed by Joseph Pecoraro. Source/WebCore: * Configurations/Base.xcconfig: (WARNING_CFLAGS): Remove

[webkit-changes] [226503] trunk/Source/WebKitLegacy/mac

2018-01-08 Thread ddkilzer
Title: [226503] trunk/Source/WebKitLegacy/mac Revision 226503 Author ddkil...@apple.com Date 2018-01-08 01:22:49 -0800 (Mon, 08 Jan 2018) Log Message Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (Web

[webkit-changes] [226506] trunk/Source/ThirdParty/libwebrtc

2018-01-08 Thread ddkilzer
Title: [226506] trunk/Source/ThirdParty/libwebrtc Revision 226506 Author ddkil...@apple.com Date 2018-01-08 03:33:14 -0800 (Mon, 08 Jan 2018) Log Message libwebrtc: Fix 'ld: warning: cannot export hidden symbol' messages Reviewed by Youenn Fablet. * Configurations/libwebrtc.iOS.exp: *

[webkit-changes] [226529] trunk/Source/WebKitLegacy/mac

2018-01-08 Thread ddkilzer
Title: [226529] trunk/Source/WebKitLegacy/mac Revision 226529 Author ddkil...@apple.com Date 2018-01-08 13:02:06 -0800 (Mon, 08 Jan 2018) Log Message Fix check-webkit-style issues with WebNSDataExtras.mm Reviewed by Alex Christensen. * Misc/WebNSDataExtras.mm: (-[NSString _web_capitali

[webkit-changes] [226673] trunk/Source/JavaScriptCore

2018-01-09 Thread ddkilzer
Title: [226673] trunk/Source/_javascript_Core Revision 226673 Author ddkil...@apple.com Date 2018-01-09 19:04:35 -0800 (Tue, 09 Jan 2018) Log Message REGRESSION (r226667): CodeBlocks should be in IsoSubspaces Fixes the following build error: heap/Heap.cpp:2708:10: error: lambda cap

[webkit-changes] [234580] trunk/Source/JavaScriptCore

2018-08-04 Thread ddkilzer
Title: [234580] trunk/Source/_javascript_Core Revision 234580 Author ddkil...@apple.com Date 2018-08-04 13:07:13 -0700 (Sat, 04 Aug 2018) Log Message REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable Reviewed by Yusuke Suzuki. * run

[webkit-changes] [234690] trunk/Source/ThirdParty/libwebrtc

2018-08-08 Thread ddkilzer
Title: [234690] trunk/Source/ThirdParty/libwebrtc Revision 234690 Author ddkil...@apple.com Date 2018-08-08 05:07:33 -0700 (Wed, 08 Aug 2018) Log Message [libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable Reviewed by Eric Carlson. * So

[webkit-changes] [234781] trunk/Source/WebKit

2018-08-10 Thread ddkilzer
Title: [234781] trunk/Source/WebKit Revision 234781 Author ddkil...@apple.com Date 2018-08-10 19:55:23 -0700 (Fri, 10 Aug 2018) Log Message [Cocoa] WebKit::PlatformPopupMenuData should use member initialization Reviewed by Joseph Pecoraro. * Shared/PlatformPopupMenuData.cpp: (WebKit::

[webkit-changes] [234980] trunk/Source/WTF

2018-08-17 Thread ddkilzer
Title: [234980] trunk/Source/WTF Revision 234980 Author ddkil...@apple.com Date 2018-08-17 06:04:17 -0700 (Fri, 17 Aug 2018) Log Message WTF's internal std::optional implementation should release assert on all bad accesses Reviewed by Ryosuke Niwa. * wtf/Assertions.h: (RELEASE_ASSERT_U

[webkit-changes] [235015] trunk/Source/WebCore

2018-08-18 Thread ddkilzer
Title: [235015] trunk/Source/WebCore Revision 235015 Author ddkil...@apple.com Date 2018-08-18 20:28:59 -0700 (Sat, 18 Aug 2018) Log Message Let Xcode have its way with the WebCore project * WebCore.xcodeproj/project.pbxproj: - Let Xcode sort recently added resources by unique ID. - Manu

[webkit-changes] [235016] trunk/Source/WebKit

2018-08-19 Thread ddkilzer
Title: [235016] trunk/Source/WebKit Revision 235016 Author ddkil...@apple.com Date 2018-08-19 08:16:50 -0700 (Sun, 19 Aug 2018) Log Message REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames() Reviewed by Dan Bernstein. * NetworkProcess/cocoa/

[webkit-changes] [235091] trunk/Source/WebCore

2018-08-20 Thread ddkilzer
Title: [235091] trunk/Source/WebCore Revision 235091 Author ddkil...@apple.com Date 2018-08-20 12:51:03 -0700 (Mon, 20 Aug 2018) Log Message REGRESSION (r235015): Xcode changes `mainGroup` name when updating WebCore project file * WebCore.xcodeproj/project.pbxproj: - Change `name` to "We

[webkit-changes] [235092] trunk/Source/WebCore

2018-08-20 Thread ddkilzer
Title: [235092] trunk/Source/WebCore Revision 235092 Author ddkil...@apple.com Date 2018-08-20 13:04:08 -0700 (Mon, 20 Aug 2018) Log Message REGRESSION (r223192): Remove invalid `path` for Modules/geolocation/ios folder * WebCore.xcodeproj/project.pbxproj: Remove invalid `path` setting f

[webkit-changes] [235136] trunk/Tools

2018-08-21 Thread ddkilzer
Title: [235136] trunk/Tools Revision 235136 Author ddkil...@apple.com Date 2018-08-21 14:08:23 -0700 (Tue, 21 Aug 2018) Log Message sort-Xcode-project-file: top-level files and folders are sorted unintentionally when `mainGroup` has no name Reviewed by Andy Estes. * Scripts/sort-Xcode-

[webkit-changes] [235164] trunk/Source/WebCore

2018-08-22 Thread ddkilzer
Title: [235164] trunk/Source/WebCore Revision 235164 Author ddkil...@apple.com Date 2018-08-22 03:37:12 -0700 (Wed, 22 Aug 2018) Log Message Remove stale file references in WebCore Xcode project I manually removed these using Xcode and verified that there was a commit that removed the or

[webkit-changes] [235190] trunk

2018-08-22 Thread ddkilzer
Title: [235190] trunk Revision 235190 Author ddkil...@apple.com Date 2018-08-22 12:33:46 -0700 (Wed, 22 Aug 2018) Log Message Move files in WebCore project to match Xcode folder structure Reviewed by Tim Horton. Source/WebCore: * Scripts/LocalizableStrings.pm: Renamed from Source/WebC

[webkit-changes] [235439] trunk/Tools

2018-08-28 Thread ddkilzer
Title: [235439] trunk/Tools Revision 235439 Author ddkil...@apple.com Date 2018-08-28 14:02:34 -0700 (Tue, 28 Aug 2018) Log Message Fix incorrect use of `sourceTree = "";` for built products and frameworks in Xcode projects Found by tidy-Xcode-project-file script (see Bug 188754). * Dum

[webkit-changes] [235443] trunk/Source/ThirdParty/ANGLE

2018-08-28 Thread ddkilzer
Title: [235443] trunk/Source/ThirdParty/ANGLE Revision 235443 Author ddkil...@apple.com Date 2018-08-28 15:13:27 -0700 (Tue, 28 Aug 2018) Log Message Move PMurHash.{cpp,h} into 'src' folder to match path on disk * ANGLE.xcodeproj/project.pbxproj: (src/common/third_party/smhasher/src): Ad

[webkit-changes] [235455] trunk/Source/ThirdParty/libwebrtc

2018-08-28 Thread ddkilzer
Title: [235455] trunk/Source/ThirdParty/libwebrtc Revision 235455 Author ddkil...@apple.com Date 2018-08-28 21:06:53 -0700 (Tue, 28 Aug 2018) Log Message [libwebrtc] Remove references to Source/webrtc/modules/audio_coding/codecs/isac/main/source/fft.h Found by tidy-Xcode-project-file scr

[webkit-changes] [235462] trunk

2018-08-29 Thread ddkilzer
Title: [235462] trunk Revision 235462 Author ddkil...@apple.com Date 2018-08-29 09:25:15 -0700 (Wed, 29 Aug 2018) Log Message Remove empty directories from from svn.webkit.org repository Source/ThirdParty/ANGLE: * src/angle.xcodeproj: Removed. * src/common/third_party/numerics: Removed

[webkit-changes] [235473] trunk/Source/WTF

2018-08-29 Thread ddkilzer
Title: [235473] trunk/Source/WTF Revision 235473 Author ddkil...@apple.com Date 2018-08-29 12:24:39 -0700 (Wed, 29 Aug 2018) Log Message Rename wtf/text/mac/StringMac.mm to wtf/text/cococa/StringCococa.mm Reviewed by Sam Weinig. Includes a drive-by fix for a webkit-style warning:

[webkit-changes] [235542] trunk/Source/WebCore

2018-08-31 Thread ddkilzer
Title: [235542] trunk/Source/WebCore Revision 235542 Author ddkil...@apple.com Date 2018-08-31 03:19:43 -0700 (Fri, 31 Aug 2018) Log Message REGRESSION (r235190): Fix name of WebAudioBufferList.{cpp,h} in Xcode project * WebCore.xcodeproj/project.pbxproj: - Add the 'name' parameter to th

[webkit-changes] [235546] trunk/Tools

2018-08-31 Thread ddkilzer
Title: [235546] trunk/Tools Revision 235546 Author ddkil...@apple.com Date 2018-08-31 03:54:22 -0700 (Fri, 31 Aug 2018) Log Message WebKitLauncher: Move WebKitLauncher.entitlements into Configurations directory This makes the Configurations folder in the Xcode project match what's in the

[webkit-changes] [235545] trunk/Tools

2018-08-31 Thread ddkilzer
Title: [235545] trunk/Tools Revision 235545 Author ddkil...@apple.com Date 2018-08-31 03:54:16 -0700 (Fri, 31 Aug 2018) Log Message WebKitLauncher: Fix build failures * WebKitLauncher/Configurations/Base.xcconfig: (ARCHS): Use $(ARCHS_STANDARD_32_64_BIT). (MACOSX_DEPLOYMENT_TARGET): Upda

[webkit-changes] [235547] trunk/Source/WTF

2018-08-31 Thread ddkilzer
Title: [235547] trunk/Source/WTF Revision 235547 Author ddkil...@apple.com Date 2018-08-31 04:47:51 -0700 (Fri, 31 Aug 2018) Log Message REGRESSION (r226407): Remove unused BlockStack.h Reviewed by Yusuke Suzuki. * WTF.xcodeproj/project.pbxproj: Remove references to BlockStack.h. * wtf

[webkit-changes] [235663] trunk/Source/WebKitLegacy

2018-09-05 Thread ddkilzer
Title: [235663] trunk/Source/WebKitLegacy Revision 235663 Author ddkil...@apple.com Date 2018-09-05 04:46:43 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r235585): WebDownloadInternal.h is missing from WebKitLegacy Xcode project Found using tidy-Xcode-project-file (see Bug 188754).

[webkit-changes] [235664] trunk/Tools

2018-09-05 Thread ddkilzer
Title: [235664] trunk/Tools Revision 235664 Author ddkil...@apple.com Date 2018-09-05 05:09:21 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r184033): ContentExtensionTester folder is missing in ContentExtensionTester Xcode project Found using `tidy-Xcode-project-file --missing` (see

[webkit-changes] [235665] trunk/Tools

2018-09-05 Thread ddkilzer
Title: [235665] trunk/Tools Revision 235665 Author ddkil...@apple.com Date 2018-09-05 05:31:31 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r160736): Bundle folder is missing in MiniBrowser Xcode project Found using `tidy-Xcode-project-file --missing` (see Bug 188754). Folder fix wa

[webkit-changes] [235666] trunk/Source/JavaScriptCore

2018-09-05 Thread ddkilzer
Title: [235666] trunk/Source/_javascript_Core Revision 235666 Author ddkil...@apple.com Date 2018-09-05 07:19:18 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r235419): DFGCFG.h is missing from _javascript_Core Xcode project Found using `tidy-Xcode-project-file --missing` (see Bug 188

[webkit-changes] [235672] trunk/Tools

2018-09-05 Thread ddkilzer
Title: [235672] trunk/Tools Revision 235672 Author ddkil...@apple.com Date 2018-09-05 09:49:38 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r209470): EditingHistory folder is missing in EditingHistory Xcode project Found using `tidy-Xcode-project-file --missing` (see Bug 188754). Fi

[webkit-changes] [235688] trunk/Source/WebKit

2018-09-05 Thread ddkilzer
Title: [235688] trunk/Source/WebKit Revision 235688 Author ddkil...@apple.com Date 2018-09-05 14:15:24 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r235006): Let Xcode have its way with the WebKit project * WebKit.xcodeproj/project.pbxproj: Let Xcode remove empty settings. Modified

[webkit-changes] [235687] trunk/Source/WebKit

2018-09-05 Thread ddkilzer
Title: [235687] trunk/Source/WebKit Revision 235687 Author ddkil...@apple.com Date 2018-09-05 14:15:21 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r110214): Remove deleted WebProcess/Fullscreen/mac folder from WebKit Xcode project Found using `tidy-Xcode-project-file --missing` (see

[webkit-changes] [235708] trunk/Source/WebKit

2018-09-05 Thread ddkilzer
Title: [235708] trunk/Source/WebKit Revision 235708 Author ddkil...@apple.com Date 2018-09-05 14:57:25 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r143543): PluginProcess/EntryPoint/XPCService/PluginService is missing in WebKit Xcode project Found using `tidy-Xcode-project-file --mi

[webkit-changes] [235709] trunk/Source/WebKit

2018-09-05 Thread ddkilzer
Title: [235709] trunk/Source/WebKit Revision 235709 Author ddkil...@apple.com Date 2018-09-05 14:57:28 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r204222): UIProces/Gamepad/mac is missing in WebKit Xcode project Found using `tidy-Xcode-project-file --missing` (see Bug 188754). Fixe

[webkit-changes] [235710] trunk/Source/WebKit

2018-09-05 Thread ddkilzer
Title: [235710] trunk/Source/WebKit Revision 235710 Author ddkil...@apple.com Date 2018-09-05 14:57:32 -0700 (Wed, 05 Sep 2018) Log Message REGRESSION (r235489): WKSharingServicePickerDelegate.mm accidentally added back to Sources in WebKit project * WebKit.xcodeproj/project.pbxproj: (WK

[webkit-changes] [235733] trunk/Tools

2018-09-06 Thread ddkilzer
Title: [235733] trunk/Tools Revision 235733 Author ddkil...@apple.com Date 2018-09-06 05:38:47 -0700 (Thu, 06 Sep 2018) Log Message svn-create-patch fails when svn mv is used on directory trees Reviewed by Daniel Bates. * Scripts/VCSUtils.pm: Export parseSvnDiffStartLine() for svn-crea

[webkit-changes] [235967] trunk/Source/JavaScriptCore

2018-09-12 Thread ddkilzer
Title: [235967] trunk/Source/_javascript_Core Revision 235967 Author ddkil...@apple.com Date 2018-09-12 21:32:41 -0700 (Wed, 12 Sep 2018) Log Message Let Xcode have its way with the _javascript_Core project * _javascript_Core.xcodeproj/project.pbxproj: Modified Paths trunk/Source/_java

[webkit-changes] [235972] trunk/Source/JavaScriptCore

2018-09-13 Thread ddkilzer
Title: [235972] trunk/Source/_javascript_Core Revision 235972 Author ddkil...@apple.com Date 2018-09-13 06:39:55 -0700 (Thu, 13 Sep 2018) Log Message Move _javascript_Core files to match Xcode project hierarchy Reviewed by Filip Pizlo. * API/JSAPIValueWrapper.cpp: Rename from Source/_j

[webkit-changes] [236007] trunk/Source/WebCore

2018-09-14 Thread ddkilzer
Title: [236007] trunk/Source/WebCore Revision 236007 Author ddkil...@apple.com Date 2018-09-14 09:38:19 -0700 (Fri, 14 Sep 2018) Log Message REGRESSION (r235954): Fix build failure on watchOS Reviewed by Geoffrey Garen. Remove `using WebCore::IndexedDB::KeyType;` from Source/WebCore/Mo

[webkit-changes] [236209] trunk/Source/WebCore

2018-09-19 Thread ddkilzer
Title: [236209] trunk/Source/WebCore Revision 236209 Author ddkil...@apple.com Date 2018-09-19 09:22:49 -0700 (Wed, 19 Sep 2018) Log Message WebCoreNSURLSession leaks an NSString (_sessionDescription) in -dealloc Reviewed by Joseph Pecoraro. * platform/network/cocoa/WebCoreNSURLSessio

[webkit-changes] [231058] trunk/Source/WebCore

2018-04-26 Thread ddkilzer
Title: [231058] trunk/Source/WebCore Revision 231058 Author ddkil...@apple.com Date 2018-04-26 11:22:03 -0700 (Thu, 26 Apr 2018) Log Message Make WAKScrollView delegate a weak property Reviewed by Simon Fraser. * platform/ios/wak/WAKScrollView.h: - Remove `delegate` instance variable

[webkit-changes] [231130] trunk/Source

2018-04-27 Thread ddkilzer
Title: [231130] trunk/Source Revision 231130 Author ddkil...@apple.com Date 2018-04-27 22:53:03 -0700 (Fri, 27 Apr 2018) Log Message Add logging when SpringBoard enables WebThread Reviewed by Daniel Bates. Source/WebCore: * platform/RuntimeApplicationChecks.h: (WebCore::IOSApplicatio

[webkit-changes] [231796] trunk/Source/WebCore

2018-05-15 Thread ddkilzer
Title: [231796] trunk/Source/WebCore Revision 231796 Author ddkil...@apple.com Date 2018-05-15 03:24:24 -0700 (Tue, 15 May 2018) Log Message Fix -Wreturn-std-move warnings in WebKit found by new clang compiler Reviewed by Youenn Fablet. Fix warnings like the following: In file inc

[webkit-changes] [231806] trunk/Tools

2018-05-15 Thread ddkilzer
Title: [231806] trunk/Tools Revision 231806 Author ddkil...@apple.com Date 2018-05-15 09:44:58 -0700 (Tue, 15 May 2018) Log Message TestWebKitAPI: Fix warnings found by new clang compiler Reviewed by Michael Catanzaro. * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: (TestWebKitAPI::TEST): * Te

[webkit-changes] [231940] trunk/Source/WebCore

2018-05-17 Thread ddkilzer
Title: [231940] trunk/Source/WebCore Revision 231940 Author ddkil...@apple.com Date 2018-05-17 20:29:19 -0700 (Thu, 17 May 2018) Log Message Lazily create WebCore::Timer for WebCore::Image Reviewed by Simon Fraser. Not every image is an animated image, so lazily creating m_animationSta

[webkit-changes] [232139] trunk/Source/WebCore

2018-05-23 Thread ddkilzer
Title: [232139] trunk/Source/WebCore Revision 232139 Author ddkil...@apple.com Date 2018-05-23 17:50:16 -0700 (Wed, 23 May 2018) Log Message Don't create the SubimageCache just to clear an image from it Reviewed by Said Abou-Hallawa. To fix this we make SubimageCacheWithTimer::clearIma

[webkit-changes] [232187] trunk/Source

2018-05-25 Thread ddkilzer
Title: [232187] trunk/Source Revision 232187 Author ddkil...@apple.com Date 2018-05-25 07:19:58 -0700 (Fri, 25 May 2018) Log Message Fix issues with -dealloc methods found by clang static analyzer Reviewed by Joseph Pecoraro. Source/_javascript_Core: * API/JSValue.mm: (-[JSValue deall

  1   2   3   4   5   6   7   8   9   10   >