Title: [227990] trunk/Source/WebKit
Revision
227990
Author
ddkil...@apple.com
Date
2018-02-01 16:40:31 -0800 (Thu, 01 Feb 2018)

Log Message

REGRESSION (r222824): UI process crashes in WebKit::WebBackForwardList::backItem const
<https://webkit.org/b/182409>
<rdar://problem/35495094>

Reviewed by Alex Christensen.

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::goToItem): Fix typo so the for loop
actually checks each value in m_entries.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (227989 => 227990)


--- trunk/Source/WebKit/ChangeLog	2018-02-02 00:25:12 UTC (rev 227989)
+++ trunk/Source/WebKit/ChangeLog	2018-02-02 00:40:31 UTC (rev 227990)
@@ -1,3 +1,15 @@
+2018-02-01  David Kilzer  <ddkil...@apple.com>
+
+        REGRESSION (r222824): UI process crashes in WebKit::WebBackForwardList::backItem const
+        <https://webkit.org/b/182409>
+        <rdar://problem/35495094>
+
+        Reviewed by Alex Christensen.
+
+        * UIProcess/WebBackForwardList.cpp:
+        (WebKit::WebBackForwardList::goToItem): Fix typo so the for loop
+        actually checks each value in m_entries.
+
 2018-02-01  Youenn Fablet  <you...@apple.com>
 
         Delay service worker process creation until actually needed by SWServer

Modified: trunk/Source/WebKit/UIProcess/WebBackForwardList.cpp (227989 => 227990)


--- trunk/Source/WebKit/UIProcess/WebBackForwardList.cpp	2018-02-02 00:25:12 UTC (rev 227989)
+++ trunk/Source/WebKit/UIProcess/WebBackForwardList.cpp	2018-02-02 00:40:31 UTC (rev 227990)
@@ -199,7 +199,7 @@
         m_entries.remove(m_currentIndex);
         targetIndex = notFound;
         for (size_t i = 0; i < m_entries.size(); ++i) {
-            if (m_entries[0].ptr() == &item) {
+            if (m_entries[i].ptr() == &item) {
                 targetIndex = i;
                 break;
             }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to