Title: [225958] trunk/Source
Revision
225958
Author
ddkil...@apple.com
Date
2017-12-14 20:19:29 -0800 (Thu, 14 Dec 2017)

Log Message

Enable -Wstrict-prototypes for WebKit
<https://webkit.org/b/180757>
<rdar://problem/36024132>

Rubber-stamped by Joseph Pecoraro.

Source/bmalloc:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/_javascript_Core:

* API/tests/CompareAndSwapTest.h:
(testCompareAndSwap): Add 'void' to C function declaration.
* API/tests/ExecutionTimeLimitTest.h:
(testExecutionTimeLimit): Ditto.
* API/tests/FunctionOverridesTest.h:
(testFunctionOverrides): Ditto.
* API/tests/GlobalContextWithFinalizerTest.h:
(testGlobalContextWithFinalizer): Ditto.
* API/tests/JSONParseTest.h:
(testJSONParse): Ditto.
* API/tests/MultithreadedMultiVMExecutionTest.h:
(startMultithreadedMultiVMExecutionTest): Ditto.
(finalizeMultithreadedMultiVMExecutionTest): Ditto.
* API/tests/PingPongStackOverflowTest.h:
(testPingPongStackOverflow): Ditto.
* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:
(WARNING_CFLAGS): Add semicolon.
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/ThirdParty/libwebrtc:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
* Source/third_party/usrsctp/usrsctplib/usrsctplib/user_socket.c:
(wakeup_one): Modernize function argument declarations.
(getsockaddr): Ditto.
* Source/webrtc/common_audio/signal_processing/include/signal_processing_library.h:
(WebRtcSpl_Init): Add 'void' to C function declaration.
* Source/webrtc/common_audio/vad/include/webrtc_vad.h:
(WebRtcVad_Create): Ditto.
* Source/webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h:
(WebRtcIsacfix_InitTransform): Ditto.
* Source/webrtc/modules/audio_processing/agc/legacy/gain_control.h:
(WebRtcAgc_Create): Ditto.
* Source/webrtc/modules/audio_processing/ns/noise_suppression.h:
(WebRtcNs_Create): Ditto.
(WebRtcNs_num_freq): Ditto.
* Source/webrtc/modules/audio_processing/ns/noise_suppression_x.h:
(WebRtcNsx_Create): Ditto.
(WebRtcNsx_num_freq): Ditto.

Source/WebCore:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/WebCore/PAL:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/WebInspectorUI:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/WebKit:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
* Platform/spi/ios/UIKitSPI.h:
(_UIDragInteractionDefaultLiftDelay): Add 'void' to C function declaration.
(UIKeyboardEnabledInputModesAllowOneToManyShortcuts): Ditto.

Source/WebKitLegacy/mac:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.

Source/WTF:

* Configurations/Base.xcconfig:
(CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
* wtf/Assertions.h:
(WTFReportBacktrace): Add 'void' to C function declaration.
(WTFCrashHookFunction): Add 'void' to C function pointer declaration.
(WTFInstallReportBacktraceOnCrashHook): Add 'void' to C function declaration.
(WTFIsDebuggerAttached): Ditto.
(WTFCrash): Ditto.
(WTFCrashWithSecurityImplication): Ditto.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/tests/CompareAndSwapTest.h (225957 => 225958)


--- trunk/Source/_javascript_Core/API/tests/CompareAndSwapTest.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/API/tests/CompareAndSwapTest.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -30,7 +30,7 @@
 #endif
 
 /* Regression test for webkit.org/b/142513 */
-void testCompareAndSwap();
+void testCompareAndSwap(void);
 
 #ifdef __cplusplus
 } /* extern "C" */

Modified: trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.h (225957 => 225958)


--- trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -30,7 +30,7 @@
 #endif
 
 /* Returns 1 if failures were encountered.  Else, returns 0. */
-int testExecutionTimeLimit();
+int testExecutionTimeLimit(void);
 
 #ifdef __cplusplus
 } /* extern "C" */

Modified: trunk/Source/_javascript_Core/API/tests/FunctionOverridesTest.h (225957 => 225958)


--- trunk/Source/_javascript_Core/API/tests/FunctionOverridesTest.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/API/tests/FunctionOverridesTest.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -30,7 +30,7 @@
 #endif
 
 /* Returns 1 if failures were encountered.  Else, returns 0. */
-int testFunctionOverrides();
+int testFunctionOverrides(void);
 
 #ifdef __cplusplus
 } /* extern "C" */

Modified: trunk/Source/_javascript_Core/API/tests/GlobalContextWithFinalizerTest.h (225957 => 225958)


--- trunk/Source/_javascript_Core/API/tests/GlobalContextWithFinalizerTest.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/API/tests/GlobalContextWithFinalizerTest.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -32,7 +32,7 @@
 #endif
 
 /* Returns 1 if failures were encountered.  Else, returns 0. */
-int testGlobalContextWithFinalizer();
+int testGlobalContextWithFinalizer(void);
     
 #ifdef __cplusplus
 } /* extern "C" */

Modified: trunk/Source/_javascript_Core/API/tests/JSONParseTest.h (225957 => 225958)


--- trunk/Source/_javascript_Core/API/tests/JSONParseTest.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/API/tests/JSONParseTest.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -29,7 +29,7 @@
 extern "C" {
 #endif
     
-int testJSONParse();
+int testJSONParse(void);
     
 #ifdef __cplusplus
 } /* extern "C" */

Modified: trunk/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.h (225957 => 225958)


--- trunk/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -29,10 +29,10 @@
 extern "C" {
 #endif
 
-extern void startMultithreadedMultiVMExecutionTest();
+extern void startMultithreadedMultiVMExecutionTest(void);
 
 /* Returns 1 if failures were encountered.  Else, returns 0. */
-extern int finalizeMultithreadedMultiVMExecutionTest();
+extern int finalizeMultithreadedMultiVMExecutionTest(void);
 
 #ifdef __cplusplus
 } /* extern "C" */

Modified: trunk/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.h (225957 => 225958)


--- trunk/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -29,7 +29,7 @@
 extern "C" {
 #endif
 
-int testPingPongStackOverflow();
+int testPingPongStackOverflow(void);
 
 #ifdef __cplusplus
 } /* extern "C" */

Modified: trunk/Source/_javascript_Core/ChangeLog (225957 => 225958)


--- trunk/Source/_javascript_Core/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,29 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * API/tests/CompareAndSwapTest.h:
+        (testCompareAndSwap): Add 'void' to C function declaration.
+        * API/tests/ExecutionTimeLimitTest.h:
+        (testExecutionTimeLimit): Ditto.
+        * API/tests/FunctionOverridesTest.h:
+        (testFunctionOverrides): Ditto.
+        * API/tests/GlobalContextWithFinalizerTest.h:
+        (testGlobalContextWithFinalizer): Ditto.
+        * API/tests/JSONParseTest.h:
+        (testJSONParse): Ditto.
+        * API/tests/MultithreadedMultiVMExecutionTest.h:
+        (startMultithreadedMultiVMExecutionTest): Ditto.
+        (finalizeMultithreadedMultiVMExecutionTest): Ditto.
+        * API/tests/PingPongStackOverflowTest.h:
+        (testPingPongStackOverflow): Ditto.
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-12-14  Yusuke Suzuki  <utatane....@gmail.com>
 
         [DFG] Reduce register pressure of WeakMapGet to be used for 32bit

Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -43,6 +43,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_SUSPICIOUS_MOVE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (225957 => 225958)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,14 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-12-06  Dean Jackson  <d...@apple.com>
 
         Update ANGLE's changes.diff

Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -18,6 +18,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 DEAD_CODE_STRIPPING = YES;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;

Modified: trunk/Source/ThirdParty/ChangeLog (225957 => 225958)


--- trunk/Source/ThirdParty/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,15 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * gtest/xcode/Config/General.xcconfig:
+        (WARNING_CFLAGS): Add semicolon.
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-10-05  Frederic Wang  <fw...@igalia.com>
 
         Remove WOFF2 from Source/ThirdParty.

Modified: trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig (225957 => 225958)


--- trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -27,12 +27,13 @@
 PREBINDING = NO
 
 // Strictest warning policy
-WARNING_CFLAGS = -Wall -Werror -Wendif-labels -Wnewline-eof -Wno-sign-compare -Wshadow
+WARNING_CFLAGS = -Wall -Werror -Wendif-labels -Wnewline-eof -Wno-sign-compare -Wshadow;
 CLANG_WARN_BOOL_CONVERSION = YES;
 CLANG_WARN_CONSTANT_CONVERSION = YES;
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 ENABLE_STRICT_OBJC_MSGSEND = YES;
 GCC_WARN_64_TO_32_BIT_CONVERSION = YES;

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,31 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+        * Source/third_party/usrsctp/usrsctplib/usrsctplib/user_socket.c:
+        (wakeup_one): Modernize function argument declarations.
+        (getsockaddr): Ditto.
+        * Source/webrtc/common_audio/signal_processing/include/signal_processing_library.h:
+        (WebRtcSpl_Init): Add 'void' to C function declaration.
+        * Source/webrtc/common_audio/vad/include/webrtc_vad.h:
+        (WebRtcVad_Create): Ditto.
+        * Source/webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h:
+        (WebRtcIsacfix_InitTransform): Ditto.
+        * Source/webrtc/modules/audio_processing/agc/legacy/gain_control.h:
+        (WebRtcAgc_Create): Ditto.
+        * Source/webrtc/modules/audio_processing/ns/noise_suppression.h:
+        (WebRtcNs_Create): Ditto.
+        (WebRtcNs_num_freq): Ditto.
+        * Source/webrtc/modules/audio_processing/ns/noise_suppression_x.h:
+        (WebRtcNsx_Create): Ditto.
+        (WebRtcNsx_num_freq): Ditto.
+
 2017-12-11  Youenn Fablet  <you...@apple.com>
 
         Use VCP H264 encoder for platforms supporting it

Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -17,6 +17,7 @@
 CLANG_WARN_INT_CONVERSION = YES;
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 DEAD_CODE_STRIPPING = YES;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;

Modified: trunk/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/user_socket.c (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/user_socket.c	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/user_socket.c	2017-12-15 04:19:29 UTC (rev 225958)
@@ -396,8 +396,7 @@
  * swapped out.
  */
 void
-wakeup_one(ident)
-	void *ident;
+wakeup_one(void *ident)
 {
 	/* __Userspace__ Check: We are using accept_cond for wakeup_one.
 	  It seems that wakeup_one is only called within
@@ -683,10 +682,7 @@
 
 /* Source: src/sys/kern/uipc_syscalls.c */
 int
-getsockaddr(namp, uaddr, len)
-	struct sockaddr **namp;
-	caddr_t uaddr;
-	size_t len;
+getsockaddr(struct sockaddr **namp, caddr_t uaddr, size_t len)
 {
 	struct sockaddr *sa;
 	int error;

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/signal_processing/include/signal_processing_library.h (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/signal_processing/include/signal_processing_library.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/signal_processing/include/signal_processing_library.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -110,7 +110,7 @@
 // C code will be assigned.
 // Note that this function MUST be called in any application that uses SPL
 // functions.
-void WebRtcSpl_Init();
+void WebRtcSpl_Init(void);
 
 int16_t WebRtcSpl_GetScalingSquare(int16_t* in_vector,
                                    size_t in_vector_length,

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/vad/include/webrtc_vad.h (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/vad/include/webrtc_vad.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/vad/include/webrtc_vad.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -27,7 +27,7 @@
 #endif
 
 // Creates an instance to the VAD structure.
-VadInst* WebRtcVad_Create();
+VadInst* WebRtcVad_Create(void);
 
 // Frees the dynamic memory of a specified VAD instance.
 //

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -67,7 +67,7 @@
 
 /* transform functions */
 
-void WebRtcIsacfix_InitTransform();
+void WebRtcIsacfix_InitTransform(void);
 
 typedef void (*Time2Spec)(int16_t* inre1Q9,
                           int16_t* inre2Q9,

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/agc/legacy/gain_control.h (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/agc/legacy/gain_control.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/agc/legacy/gain_control.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -208,7 +208,7 @@
  * This function creates and returns an AGC instance, which will contain the
  * state information for one (duplex) channel.
  */
-void* WebRtcAgc_Create();
+void* WebRtcAgc_Create(void);
 
 /*
  * This function frees the AGC instance created at the beginning.

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/ns/noise_suppression.h (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/ns/noise_suppression.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/ns/noise_suppression.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -24,7 +24,7 @@
 /*
  * This function creates an instance of the floating point Noise Suppression.
  */
-NsHandle* WebRtcNs_Create();
+NsHandle* WebRtcNs_Create(void);
 
 /*
  * This function frees the dynamic memory of a specified noise suppression
@@ -126,7 +126,7 @@
  *
  * Return value         : Number of frequency bins.
  */
-size_t WebRtcNs_num_freq();
+size_t WebRtcNs_num_freq(void);
 
 #ifdef __cplusplus
 }

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/ns/noise_suppression_x.h (225957 => 225958)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/ns/noise_suppression_x.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/ns/noise_suppression_x.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -24,7 +24,7 @@
 /*
  * This function creates an instance of the fixed point Noise Suppression.
  */
-NsxHandle* WebRtcNsx_Create();
+NsxHandle* WebRtcNsx_Create(void);
 
 /*
  * This function frees the dynamic memory of a specified Noise Suppression
@@ -104,7 +104,7 @@
  *
  * Return value         : Number of frequency bins.
  */
-size_t WebRtcNsx_num_freq();
+size_t WebRtcNsx_num_freq(void);
 
 #ifdef __cplusplus
 }

Modified: trunk/Source/WTF/ChangeLog (225957 => 225958)


--- trunk/Source/WTF/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WTF/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,21 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+        * wtf/Assertions.h:
+        (WTFReportBacktrace): Add 'void' to C function declaration.
+        (WTFCrashHookFunction): Add 'void' to C function pointer declaration.
+        (WTFInstallReportBacktraceOnCrashHook): Add 'void' to C function declaration.
+        (WTFIsDebuggerAttached): Ditto.
+        (WTFCrash): Ditto.
+        (WTFCrashWithSecurityImplication): Ditto.
+
 2017-12-14  Yusuke Suzuki  <utatane....@gmail.com>
 
         Drop Thread::tryCreate

Modified: trunk/Source/WTF/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/WTF/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WTF/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -43,6 +43,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_SUSPICIOUS_MOVE = YES;
 CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

Modified: trunk/Source/WTF/wtf/Assertions.h (225957 => 225958)


--- trunk/Source/WTF/wtf/Assertions.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WTF/wtf/Assertions.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -197,14 +197,14 @@
 WTF_EXPORT_PRIVATE bool WTFWillLogWithLevel(WTFLogChannel*, WTFLogLevel);
 
 WTF_EXPORT_PRIVATE void WTFGetBacktrace(void** stack, int* size);
-WTF_EXPORT_PRIVATE void WTFReportBacktrace();
+WTF_EXPORT_PRIVATE void WTFReportBacktrace(void);
 WTF_EXPORT_PRIVATE void WTFPrintBacktrace(void** stack, int size);
 
-typedef void (*WTFCrashHookFunction)();
+typedef void (*WTFCrashHookFunction)(void);
 WTF_EXPORT_PRIVATE void WTFSetCrashHook(WTFCrashHookFunction);
-WTF_EXPORT_PRIVATE void WTFInstallReportBacktraceOnCrashHook();
+WTF_EXPORT_PRIVATE void WTFInstallReportBacktraceOnCrashHook(void);
 
-WTF_EXPORT_PRIVATE bool WTFIsDebuggerAttached();
+WTF_EXPORT_PRIVATE bool WTFIsDebuggerAttached(void);
 
 #if ASAN_ENABLED
 #define WTFBreakpointTrap()  __builtin_trap()
@@ -234,13 +234,13 @@
 
 #endif // !defined(CRASH)
 
-WTF_EXPORT_PRIVATE NO_RETURN_DUE_TO_CRASH void WTFCrash();
+WTF_EXPORT_PRIVATE NO_RETURN_DUE_TO_CRASH void WTFCrash(void);
 
 #ifndef CRASH_WITH_SECURITY_IMPLICATION
 #define CRASH_WITH_SECURITY_IMPLICATION() WTFCrashWithSecurityImplication()
 #endif
 
-WTF_EXPORT_PRIVATE NO_RETURN_DUE_TO_CRASH void WTFCrashWithSecurityImplication();
+WTF_EXPORT_PRIVATE NO_RETURN_DUE_TO_CRASH void WTFCrashWithSecurityImplication(void);
 
 #ifdef __cplusplus
 }

Modified: trunk/Source/WebCore/ChangeLog (225957 => 225958)


--- trunk/Source/WebCore/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebCore/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,14 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-12-14  Youenn Fablet  <you...@apple.com>
 
         srflx and relay ICE candidates lack raddr (rel-addr) and rport (rel-port) attributes if getUserMedia access has not been granted

Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/WebCore/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -43,6 +43,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_SUSPICIOUS_MOVE = YES;
 CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

Modified: trunk/Source/WebCore/PAL/ChangeLog (225957 => 225958)


--- trunk/Source/WebCore/PAL/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,14 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-12-11  Joseph Pecoraro  <pecor...@apple.com>
 
         Unreviewed build fix after r225766.

Modified: trunk/Source/WebCore/PAL/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/WebCore/PAL/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebCore/PAL/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -43,6 +43,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_SUSPICIOUS_MOVE = YES;
 CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

Modified: trunk/Source/WebInspectorUI/ChangeLog (225957 => 225958)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,14 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-12-14  Brian Burg  <bb...@apple.com>
 
         Web Inspector: InspectorTest.evaluateInPage should unwrap primitive values by default

Modified: trunk/Source/WebInspectorUI/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -24,6 +24,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 ENABLE_STRICT_OBJC_MSGSEND = YES;

Modified: trunk/Source/WebKit/ChangeLog (225957 => 225958)


--- trunk/Source/WebKit/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebKit/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,17 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+        * Platform/spi/ios/UIKitSPI.h:
+        (_UIDragInteractionDefaultLiftDelay): Add 'void' to C function declaration.
+        (UIKeyboardEnabledInputModesAllowOneToManyShortcuts): Ditto.
+
 2017-12-14  Alex Christensen  <achristen...@webkit.org>
 
         Serialize WebsitePoliciesData instead of WebsitePolicies

Modified: trunk/Source/WebKit/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/WebKit/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebKit/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -43,6 +43,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_SUSPICIOUS_MOVE = YES;
 CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (225957 => 225958)


--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2017-12-15 04:19:29 UTC (rev 225958)
@@ -874,7 +874,7 @@
 
 WTF_EXTERN_C_BEGIN
 
-NSTimeInterval _UIDragInteractionDefaultLiftDelay();
+NSTimeInterval _UIDragInteractionDefaultLiftDelay(void);
 CGFloat UIRoundToScreenScale(CGFloat value, UIScreen *);
 
 WTF_EXTERN_C_END
@@ -976,7 +976,7 @@
 
 WTF_EXTERN_C_BEGIN
 
-BOOL UIKeyboardEnabledInputModesAllowOneToManyShortcuts();
+BOOL UIKeyboardEnabledInputModesAllowOneToManyShortcuts(void);
 BOOL UIKeyboardEnabledInputModesAllowChineseTransliterationForText(NSString *);
 BOOL UIKeyboardCurrentInputModeAllowsChineseOrJapaneseReanalysisForText(NSString *);
 

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (225957 => 225958)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,14 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-12-14  John Wilander  <wilan...@apple.com>
 
         Storage Access API: Implement frame-specific access in the document.cookie layer

Modified: trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -43,6 +43,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_SUSPICIOUS_MOVE = YES;
 CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

Modified: trunk/Source/bmalloc/ChangeLog (225957 => 225958)


--- trunk/Source/bmalloc/ChangeLog	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/bmalloc/ChangeLog	2017-12-15 04:19:29 UTC (rev 225958)
@@ -1,3 +1,14 @@
+2017-12-14  David Kilzer  <ddkil...@apple.com>
+
+        Enable -Wstrict-prototypes for WebKit
+        <https://webkit.org/b/180757>
+        <rdar://problem/36024132>
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        * Configurations/Base.xcconfig:
+        (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
+
 2017-12-14  Saam Barati  <sbar...@apple.com>
 
         logVMFailure should not simulate crash on iOS

Modified: trunk/Source/bmalloc/Configurations/Base.xcconfig (225957 => 225958)


--- trunk/Source/bmalloc/Configurations/Base.xcconfig	2017-12-15 03:26:27 UTC (rev 225957)
+++ trunk/Source/bmalloc/Configurations/Base.xcconfig	2017-12-15 04:19:29 UTC (rev 225958)
@@ -43,6 +43,7 @@
 CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
 CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_STRICT_PROTOTYPES = YES;
 CLANG_WARN_SUSPICIOUS_MOVE = YES;
 CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to