Re: Review Request 38785: Remove dep on Impl::getNextHashId()

2015-09-30 Thread Ali Lown
> On Sept. 30, 2015, 10:11 p.m., Ali Lown wrote: > > LGTM. Committed as bdb8f24e1cbcb3e5b1c98199c86632cabd2c8d84. - Ali --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38785/#review101168 ---

Re: Review Request 38785: Remove dep on Impl::getNextHashId()

2015-09-30 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38785/#review101168 --- Ship it! LGTM. - Ali Lown On Sept. 29, 2015, 12:03 p.m., Martin

Re: Review Request 38785: Remove dep on Impl::getNextHashId()

2015-09-26 Thread Martin Letis
> On Sept. 26, 2015, 10:52 a.m., Ali Lown wrote: > > Changes LGTM. > > > > What do you mean by 'latest' GWT jars? Do you mean built from master > > (11a0d2e), or built from the 2.7.0 tag? > > I think we should commit this change at the same time as updating the GWT > > jars stored in third_par

Re: Review Request 38785: Remove dep on Impl::getNextHashId()

2015-09-26 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38785/#review100748 --- Changes LGTM. What do you mean by 'latest' GWT jars? Do you mean b