> On Sept. 30, 2015, 10:11 p.m., Ali Lown wrote: > > LGTM.
Committed as bdb8f24e1cbcb3e5b1c98199c86632cabd2c8d84. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38785/#review101168 ----------------------------------------------------------- On Sept. 29, 2015, 12:03 p.m., Martin Letis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38785/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 12:03 p.m.) > > > Review request for wave, Ali Lown and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > As of > https://gwt.googlesource.com/gwt/+/6d27b4615004569c68c7bbf2b3d04a6c942cd493 > the method is no longer available. > > Calling Object#hashCode() should "Just Work (TM)" both for jso and java, as > the 'emul' implementation both before and after dankurka's change default to > the previous implementation in JsIdentity{Map,Set}. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/common/util/JsIdentityMap.java d321b1e > src/org/waveprotocol/wave/client/common/util/JsIdentitySet.java 9f7f6e1 > > Diff: https://reviews.apache.org/r/38785/diff/ > > > Testing > ------- > > ant compile compile-gwt works with latest GWT jars > > > Thanks, > > Martin Letis > >
