> On Sept. 26, 2015, 10:52 a.m., Ali Lown wrote: > > Changes LGTM. > > > > What do you mean by 'latest' GWT jars? Do you mean built from master > > (11a0d2e), or built from the 2.7.0 tag? > > I think we should commit this change at the same time as updating the GWT > > jars stored in third_party/.
Sorry, I should have clarified: with 'latest' I mean built from master (11a0d2e). The Impl::getNextHashId() method was removed after 2.7.0 so the current code works fine up to 2.7.0. This change is backwards compatible so I don't think it's necessary to update the third_party libs as part of this change. In a followup, I'm planning to send a change to update the libs to GWT 2.7.0. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38785/#review100748 ----------------------------------------------------------- On Sept. 26, 2015, 9:17 a.m., Martin Letis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38785/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2015, 9:17 a.m.) > > > Review request for wave and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > As of > https://gwt.googlesource.com/gwt/+/6d27b4615004569c68c7bbf2b3d04a6c942cd493 > the method is no longer available. > > Calling Object#hashCode() should "Just Work (TM)" both for jso and java, as > the 'emul' implementation both before and after dankurka's change default to > the previous implementation in JsIdentity{Map,Set}. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/common/util/JsIdentityMap.java d321b1e > src/org/waveprotocol/wave/client/common/util/JsIdentitySet.java 9f7f6e1 > > Diff: https://reviews.apache.org/r/38785/diff/ > > > Testing > ------- > > ant compile compile-gwt works with latest GWT jars > > > Thanks, > > Martin Letis > >
