Re: Review Request 17943: Inbox filter by date range

2014-06-28 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/#review46942 --- Sorry, I am late to the party. I am not sure we want to implement it

Re: Review Request 17943: Inbox filter by date range

2014-04-25 Thread Pablo Ojanguren
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/ --- (Updated April 25, 2014, 2:46 p.m.) Review request for wave. Changes ---

Re: Review Request 17943: Inbox filter by date range

2014-04-23 Thread Vicente J. Ruiz Jurado
> On April 21, 2014, 10:40 a.m., Vicente J. Ruiz Jurado wrote: > > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.ui.xml, > > line 81 > > > > > > Is this checkbox really needed? Seems to me very str

Re: Review Request 17943: Inbox filter by date range

2014-04-21 Thread Pablo Ojanguren
> On April 21, 2014, 10:40 a.m., Vicente J. Ruiz Jurado wrote: > > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.ui.xml, > > line 81 > > > > > > Is this checkbox really needed? Seems to me very str

Re: Review Request 17943: Inbox filter by date range

2014-04-21 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/#review40875 --- src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.

Re: Review Request 17943: Inbox filter by date range

2014-04-21 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/#review40872 --- Ship it! LGTM. - Ali Lown On April 16, 2014, 7:54 a.m., Pablo Oj

Re: Review Request 17943: Inbox filter by date range

2014-04-16 Thread Pablo Ojanguren
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/ --- (Updated April 16, 2014, 7:54 a.m.) Review request for wave. Changes ---

Re: Review Request 17943: Inbox filter by date range

2014-03-09 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/#review36607 --- Thanks for this patch. Could you just tidy up these comments, then i

Re: Review Request 17943: Inbox filter by date range

2014-02-11 Thread Pablo Ojanguren
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/ --- (Updated Feb. 11, 2014, 11:58 a.m.) Review request for wave. Bugs: WAVE-408