----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/#review36607 -----------------------------------------------------------
Thanks for this patch. Could you just tidy up these comments, then it can be committed to the codebase. src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java <https://reviews.apache.org/r/17943/#comment67658> Can we get rid of these "skip" comments here? src/org/waveprotocol/box/webclient/search/SearchFilterDialog.css <https://reviews.apache.org/r/17943/#comment67661> Wrong header. Please use the "Licensed to the ASF" one. src/org/waveprotocol/box/webclient/search/SearchFilterDialog.css <https://reviews.apache.org/r/17943/#comment67659> Please tidy up the whitespace issues here... src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.java <https://reviews.apache.org/r/17943/#comment67660> "TODO (pablojan): " is the standard format in the codebase. - Ali Lown On Feb. 11, 2014, 11:58 a.m., Pablo Ojanguren wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17943/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 11:58 a.m.) > > > Review request for wave. > > > Bugs: WAVE-408 > https://issues.apache.org/jira/browse/WAVE-408 > > > Repository: wave > > > Description > ------- > > - Server part: added new operators to the search query string to indicate a > date range to filter a wave search. > > From:yyyyMMdd Select wavelets with a later date value. > > To:yyyyMMdd Select wavelets with an earlier or equal date > value. > > Usedate:[createdate|lastmoddate] > Date field for filtering. > > > - Client part: added a dialog box to select dates, participants and creator. > It's opened clicking a new buttom in the search panel. > > > Diffs > ----- > > src/org/waveprotocol/box/server/waveserver/QueryHelper.java c108e5b > src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java > 3c69816 > src/org/waveprotocol/box/server/waveserver/TokenQueryType.java 6546350 > src/org/waveprotocol/box/webclient/search/Search.css d0b0a94 > src/org/waveprotocol/box/webclient/search/SearchFilterDialog.css > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchFilterDialogView.java > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.java > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.ui.xml > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchPanelResourceLoader.java > 1784708 > src/org/waveprotocol/box/webclient/search/SearchWidget.java 076aa4b > src/org/waveprotocol/box/webclient/search/SearchWidget.ui.xml f929f70 > src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages.java > 490b839 > > Diff: https://reviews.apache.org/r/17943/diff/ > > > Testing > ------- > > Manual test: tested different ranges of dates ensuring that only right waves > were selected. > > > Thanks, > > Pablo Ojanguren > >
