> On April 21, 2014, 10:40 a.m., Vicente J. Ruiz Jurado wrote: > > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.ui.xml, > > line 81 > > <https://reviews.apache.org/r/17943/diff/2/?file=560792#file560792line81> > > > > Is this checkbox really needed? Seems to me very strange from a > > usability point of view. "With" and "Author" fields do not need this kind > > of "checkbox". > > Pablo Ojanguren wrote: > It's true, it is not the best solution, but it has been just an initial > approach. Indeed, code it's ready to search by the last mod date too, so we > can add this new field in the dialog. If you have any suggestion I will be > happy to implement it.
My proposal is just to remove this checkbox. I think is less code to maintain, and more easy to understand. Look how gmail is: http://homes.ourproject.org/~vjrj/otros/gmail-filter.png We can also remove it later... - Vicente J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17943/#review40875 ----------------------------------------------------------- On April 16, 2014, 7:54 a.m., Pablo Ojanguren wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17943/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 7:54 a.m.) > > > Review request for wave. > > > Bugs: WAVE-408 > https://issues.apache.org/jira/browse/WAVE-408 > > > Repository: wave > > > Description > ------- > > - Server part: added new operators to the search query string to indicate a > date range to filter a wave search. > > From:yyyyMMdd Select wavelets with a later date value. > > To:yyyyMMdd Select wavelets with an earlier or equal date > value. > > Usedate:[createdate|lastmoddate] > Date field for filtering. > > > - Client part: added a dialog box to select dates, participants and creator. > It's opened clicking a new buttom in the search panel. > > > Diffs > ----- > > src/org/waveprotocol/box/server/waveserver/QueryHelper.java > c108e5bf6ec31d69f229ddf0408f0ea405ed14bb > src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java > 3c698164fa509b20d753934ed0d24ccd5595cbc1 > src/org/waveprotocol/box/server/waveserver/TokenQueryType.java > 654635041067339a09e695910778ad1444e43ce5 > src/org/waveprotocol/box/webclient/search/Search.css > d0b0a94661d350b240f6bca37468cc84fcb98739 > src/org/waveprotocol/box/webclient/search/SearchFilterDialog.css > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchFilterDialogView.java > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.java > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.ui.xml > PRE-CREATION > src/org/waveprotocol/box/webclient/search/SearchPanelResourceLoader.java > 178470832ba0246ed9c34892af615fb3d1c85d30 > src/org/waveprotocol/box/webclient/search/SearchWidget.java > 076aa4b571dedf86e93c190802c81359cba847b5 > src/org/waveprotocol/box/webclient/search/SearchWidget.ui.xml > f929f709d618cf19d95a99a1d3c5961d984dc6ac > src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages.java > 490b8397c2532b243a30e7277cf634c05fc8c7e6 > > Diff: https://reviews.apache.org/r/17943/diff/ > > > Testing > ------- > > Manual test: tested different ranges of dates ensuring that only right waves > were selected. > > > Thanks, > > Pablo Ojanguren > >
