Re: Review Request: Line-through editor shortcut

2013-06-14 Thread Vicente J. Ruiz Jurado
> On June 13, 2013, 12:42 p.m., Vicente J. Ruiz Jurado wrote: > > If nobody has more comments, I'll commit in short. Commited as r1492997 - Vicente J. --- This is an automatically generated e-mail. To reply, visit: https://reviews.apach

Re: Review Request: Line-through editor shortcut

2013-06-13 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/#review21854 --- If nobody has more comments, I'll commit in short. - Vicente J. Ruiz

Re: Review Request: Line-through editor shortcut

2013-04-15 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/ --- (Updated April 15, 2013, 11:38 a.m.) Review request for wave, Michael MacFadden,

Re: Review Request: Line-through editor shortcut

2013-04-06 Thread Vicente J. Ruiz Jurado
> On March 20, 2013, 12:34 p.m., Vicente J. Ruiz Jurado wrote: > > Minor change. If anybody don't have nothing to comment, I'll commit this in > > few days. Comment by Patrick Coleman: > The description mentions "Alt-shift-5", but it seems like you've switched > it to Ctrl-Shift-5? > Note that

Re: Review Request: Line-through editor shortcut

2013-04-06 Thread Vicente J. Ruiz Jurado
El 20/03/13 13:55, Patrick Coleman escribió: > The description mentions "Alt-shift-5", but it seems like you've switched > it to Ctrl-Shift-5? > Note that docs on mac has Alt-shift-5, but also the other styling options > (bold, italic, ...) are all OPTION_ rather than CTRL_ (so macs can use the > c

Re: Review Request: Line-through editor shortcut

2013-04-06 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/ --- (Updated April 6, 2013, 9:20 p.m.) Review request for wave, Michael MacFadden, Y

Re: Review Request: Line-through editor shortcut

2013-03-20 Thread Patrick Coleman
The description mentions "Alt-shift-5", but it seems like you've switched it to Ctrl-Shift-5? Note that docs on mac has Alt-shift-5, but also the other styling options (bold, italic, ...) are all OPTION_ rather than CTRL_ (so macs can use the command key). As this is a simple style shortcut, it's

Re: Review Request: Line-through editor shortcut

2013-03-20 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/#review18150 --- Minor change. If anybody don't have nothing to comment, I'll commit t

Re: Review Request: Line-through editor shortcut

2013-03-14 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/ --- (Updated March 14, 2013, 1:30 p.m.) Review request for wave, Michael MacFadden,

Re: Review Request: Line-through editor shortcut

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/#review12642 --- Hmm, strange, but it doesn't work for me for some reason. I tried ctr

Re: Review Request: Line-through editor shortcut

2012-10-11 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/#review12340 --- Ship it! LGTM. - Ali Lown On Oct. 11, 2012, 6:03 p.m., Vicente J.

Re: Review Request: Line-through editor shortcut

2012-10-11 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/ --- (Updated Oct. 11, 2012, 6:03 p.m.) Review request for wave, Michael MacFadden, Y