El 20/03/13 13:55, Patrick Coleman escribió: > The description mentions "Alt-shift-5", but it seems like you've switched > it to Ctrl-Shift-5? > Note that docs on mac has Alt-shift-5, but also the other styling options > (bold, italic, ...) are all OPTION_ rather than CTRL_ (so macs can use the > command key). > > As this is a simple style shortcut, it's probably worth putting it in > EditorImpl with the others, just for simplicity, e.g: > https://gitorious.org/kune/wave/blobs/2981c4603988f263c8116cb09bdeabd854c51b73/src/org/waveprotocol/wave/client/editor/EditorImpl.java#line703
I added your comment in the review, thanks indeed: https://reviews.apache.org/r/7548/ I'll propose a new patch in short. BR,