> On March 20, 2013, 12:34 p.m., Vicente J. Ruiz Jurado wrote: > > Minor change. If anybody don't have nothing to comment, I'll commit this in > > few days.
Comment by Patrick Coleman: > The description mentions "Alt-shift-5", but it seems like you've switched > it to Ctrl-Shift-5? > Note that docs on mac has Alt-shift-5, but also the other styling options > (bold, italic, ...) are all OPTION_ rather than CTRL_ (so macs can use the > command key). > As this is a simple style shortcut, it's probably worth putting it in > EditorImpl with the others, just for simplicity, e.g: > https://gitorious.org/kune/wave/blobs/2981c4603988f263c8116cb09bdeabd854c51b73/src/org/waveprotocol/wave/client/editor/EditorImpl.java#line703 I'll propose a new patch in short. BR, - Vicente J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/#review18150 ----------------------------------------------------------- On April 6, 2013, 9:20 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7548/ > ----------------------------------------------------------- > > (Updated April 6, 2013, 9:20 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, Ali Lown, and > Patrick Coleman. > > > Description > ------- > > This patch add the Alt-Shift-5 shortcut to line-through style (similar to > google docs). > > > Diffs > ----- > > src/org/waveprotocol/wave/client/common/util/EventWrapper.java 408ac14 > src/org/waveprotocol/wave/client/common/util/KeyCombo.java ce571fe > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > dfefff5 > > Diff: https://reviews.apache.org/r/7548/diff/ > > > Testing > ------- > > ant waveharness-hosted simple tests > > > Thanks, > > Vicente J. Ruiz Jurado > >
