Re: [vpp-dev] Mac Address Api Changes

2017-11-06 Thread Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco)
. If VPP supports 8-byte l2 addresses, could we at least have: u8 l2_address[l2_address_length]; ? Regards, Marek From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Mohsin Kazmi (sykazmi) Sent: 9 października 2017 19:06 To: vpp-dev Subject: [vpp-dev] Mac

Re: [vpp-dev] Mac Address Api Changes

2017-10-11 Thread Dave Wallace
+1 On 10/11/2017 03:49 AM, Neale Ranns (nranns) wrote: +1 *From: * on behalf of Jon Loeliger *Date: *Tuesday, 10 October 2017 at 22:55 *To: *"John Lo (loj)" *Cc: *vpp-dev *Subject: *Re: [vpp-dev] Mac Address Api Changes On Tue, Oct 10, 2017 at 2:41 P

Re: [vpp-dev] Mac Address Api Changes

2017-10-11 Thread Neale Ranns (nranns)
+1 From: on behalf of Jon Loeliger Date: Tuesday, 10 October 2017 at 22:55 To: "John Lo (loj)" Cc: vpp-dev Subject: Re: [vpp-dev] Mac Address Api Changes On Tue, Oct 10, 2017 at 2:41 PM, John Lo (loj) mailto:l...@cisco.com>> wrote: The two APIs affected are the older ones in

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread Jon Loeliger
On Tue, Oct 10, 2017 at 2:41 PM, John Lo (loj) wrote: > The two APIs affected are the older ones in L2FIB which use “u64 mac” > instead of “u8 mac[6]” to pass MAC addresses: > > ·L2fib_add_del > > ·L2_fib_table_details > > > > I believe it is a good change to reduce confusion wrt

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread Luke, Chris
+1 Sounds good to me From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of John Lo (loj) Sent: Tuesday, October 10, 2017 15:42 To: Jerome Tollet (jtollet) ; Mohsin Kazmi (sykazmi) ; vpp-dev Subject: Re: [vpp-dev] Mac Address Api Changes The two APIs affected are

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread John Lo (loj)
-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jerome Tollet (jtollet) Sent: Tuesday, October 10, 2017 3:10 PM To: Mohsin Kazmi (sykazmi) ; vpp-dev Subject: Re: [vpp-dev] Mac Address Api Changes +1, it would be nice to harmonize those API calls. Jerome De : mailto:vpp-dev

Re: [vpp-dev] Mac Address Api Changes

2017-10-10 Thread Jerome Tollet (jtollet)
+1, it would be nice to harmonize those API calls. Jerome De : au nom de Mohsin Kazmi Date : lundi 9 octobre 2017 à 19:06 À : vpp-dev Objet : [vpp-dev] Mac Address Api Changes Hello,​ I am writing regarding a proposal to change API messages related to l2fib mac address. In vpp/src

[vpp-dev] Mac Address Api Changes

2017-10-09 Thread Mohsin Kazmi (sykazmi)
Hello,? I am writing regarding a proposal to change API messages related to l2fib mac address. In vpp/src/vnet/l2/l2.api file, currently two API messages related to l2fib uses u64 for mac address instead of u8 mac[6]. While rest of VPP API calls use array of six bytes to store mac address.