Hi,
there might be one more API that needs update:
define sw_interface_details
{
[…]
/* Layer 2 address, if applicable */
u32 l2_address_length;
u8 l2_address[8];
[…]
}
VPP allows to specify MAC address (e.g. for TAP interfaces).
As u8 mac[6], but interface dump allows extended addresses.
If VPP supports 8-byte l2 addresses, could we at least have:
u8 l2_address[l2_address_length];
?
Regards,
Marek
From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On
Behalf Of Mohsin Kazmi (sykazmi)
Sent: 9 października 2017 19:06
To: vpp-dev <vpp-dev@lists.fd.io>
Subject: [vpp-dev] Mac Address Api Changes
Hello,
I am writing regarding a proposal to change API messages related to l2fib mac
address.
In vpp/src/vnet/l2/l2.api file, currently two API messages related to l2fib
uses u64 for mac address instead of u8 mac[6]. While rest of VPP API calls use
array of six bytes to store mac address.
As u64 to store mac address is inconsistent with rest of VPP and may create
conversion troubles to interpret to/from u8 mac[6].
The proposal is to change those API messages definitions to use standard u8
mac[6] to store mac address. But this change may impact the users of VPP API
and they will need to update their code.
That said, Please let the community know if there is any specific objection or
opinion to above proposal.
Thanks,
Mohsin
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
