The two APIs affected are the older ones in L2FIB which use “u64 mac” instead of “u8 mac[6]” to pass MAC addresses:
· L2fib_add_del · L2_fib_table_details I believe it is a good change to reduce confusion wrt how 6-byte MAC is stored in u64 with big/little endian hosts. The change would also require updates to user programs of these APIs, which we believe should be minimal. If we don’t get strong objections within a week, we will assume the change is acceptable and allow this API change in the master branch. It won’t affect 17.10 release. Regards, John From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jerome Tollet (jtollet) Sent: Tuesday, October 10, 2017 3:10 PM To: Mohsin Kazmi (sykazmi) <syka...@cisco.com>; vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] Mac Address Api Changes +1, it would be nice to harmonize those API calls. Jerome De : <vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io>> au nom de Mohsin Kazmi <syka...@cisco.com<mailto:syka...@cisco.com>> Date : lundi 9 octobre 2017 à 19:06 À : vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Objet : [vpp-dev] Mac Address Api Changes Hello, I am writing regarding a proposal to change API messages related to l2fib mac address. In vpp/src/vnet/l2/l2.api file, currently two API messages related to l2fib uses u64 for mac address instead of u8 mac[6]. While rest of VPP API calls use array of six bytes to store mac address. As u64 to store mac address is inconsistent with rest of VPP and may create conversion troubles to interpret to/from u8 mac[6]. The proposal is to change those API messages definitions to use standard u8 mac[6] to store mac address. But this change may impact the users of VPP API and they will need to update their code. That said, Please let the community know if there is any specific objection or opinion to above proposal. Thanks, Mohsin
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
