Re: dkim plugins warnings

2007-02-19 Thread Mark Martinec
Bill Landry writes, > Mark, your patches for DKIM.pm and DkSignature.pm took care of the issue > I was seeing with GMail DomainKey signatures, since they were missing > the "q=dns" tag. Below is a similar patch to Mail/DKIM/DkSignature.pm, this time to handle missing 'a' tags in DomainKeys signatu

Re: dkim plugins warnings

2007-02-15 Thread Bill Landry
Mark Martinec wrote the following on 2/15/2007 3:37 AM -0800: Raul Dias writes: I have being getting a lot of this in my logs: [snip] Below is my patch, please apply it to Mail::DKIM files DkSignature.pm and Verifier.pm and see if it fixes the warnings you are seeing. Mark, your patches f

Re: dkim plugins warnings

2007-02-15 Thread Mark Martinec
> ok, the warnings are gone. There is only one missing ; in the patch > Missing ; here, right? Right. -+ : "invalid domain in d tag" ++ : "invalid domain in d tag"; If you want, you may apply also my patch to Plugin::DKIM.pm. Fixes two minor problems and

Re: dkim plugins warnings

2007-02-15 Thread Raul Dias
On Thu, 2007-02-15 at 12:37 +0100, Mark Martinec wrote: [...] > Below is my patch, please apply it to Mail::DKIM files > DkSignature.pm and Verifier.pm and see if it fixes the warnings > you are seeing. ok, the warnings are gone. There is only one missing ; in the patch (below). > > AFAIS, it i

Re: dkim plugins warnings

2007-02-15 Thread Justin Mason
Daryl C. W. O'Shea writes: > Justin Mason wrote: > > Daryl C. W. O'Shea writes: > >> I thought you voted for letting Mail::DKIM spew whatever it wanted. :) > >> > >> http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5095#c3 > >> > >> Probably not a bad idea since it may encourage people to upg

Re: dkim plugins warnings

2007-02-15 Thread Mark Martinec
Justin, > well, it may be easy for us to not produce the invalid input > that's causing this one... No, in that particular case it was Mail::DKIM that was overreacting. Mark

Re: dkim plugins warnings

2007-02-15 Thread Mark Martinec
> http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5095#c3 Btw, that particular check and message was removed from Mail::DKIM: -- VERSION 0.20 -- 2006-10-24: Jason Long <[EMAIL PROTECTED]> * lib/Mail/DKIM/MessageParser.pm: removed problematic check for "control characters" > Probably no

Re: dkim plugins warnings

2007-02-15 Thread Daryl C. W. O'Shea
Justin Mason wrote: Daryl C. W. O'Shea writes: I thought you voted for letting Mail::DKIM spew whatever it wanted. :) http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5095#c3 Probably not a bad idea since it may encourage people to upgrade to newer versions of Mail::DKIM that fix whateve

Re: dkim plugins warnings

2007-02-15 Thread Justin Mason
Daryl C. W. O'Shea writes: > I thought you voted for letting Mail::DKIM spew whatever it wanted. :) > > http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5095#c3 > > Probably not a bad idea since it may encourage people to upgrade to > newer versions of Mail::DKIM that fix whatever is being

Re: dkim plugins warnings

2007-02-15 Thread Daryl C. W. O'Shea
I thought you voted for letting Mail::DKIM spew whatever it wanted. :) http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5095#c3 Probably not a bad idea since it may encourage people to upgrade to newer versions of Mail::DKIM that fix whatever is being spewed about. Daryl Justin Mason

Re: dkim plugins warnings

2007-02-15 Thread Mark Martinec
Raul Dias writes: > I have being getting a lot of this in my logs: > > Feb 14 21:55:13 s spamd[7249]: dkim: invalid DKIM-Signature: invalid > (unsupported protocol) > at /usr/lib/perl5/site_perl/5.8.0/Mail/SpamAssassin/Plugin/DKIM.pm > line 339 > > Is this something I should worry about? I belie

Re: dkim plugins warnings

2007-02-15 Thread Justin Mason
Can you capture a message that causes this, and open a bug on the bugzilla? I haven't seen that before. (Even if it's harmless, the warning message is ugly.) --j. Raul Dias writes: > I have being getting a lot of this in my logs: > > Feb 14 21:55:13 s spamd[7249]: dkim: invalid DKIM-Signature

Re: dkim plugins warnings

2007-02-14 Thread Benny Pedersen
On Thu, February 15, 2007 03:21, Raul Dias wrote: > I have being getting a lot of this in my logs: > Feb 14 21:55:13 s spamd[7249]: dkim: invalid DKIM-Signature: invalid > (unsupported protocol) > at /usr/lib/perl5/site_perl/5.8.0/Mail/SpamAssassin/Plugin/DKIM.pm line > 339, line 390 you have th