On Thu, 2007-02-15 at 12:37 +0100, Mark Martinec wrote:
[...]
> Below is my patch, please apply it to Mail::DKIM files
> DkSignature.pm and Verifier.pm and see if it fixes the warnings
> you are seeing.
ok, the warnings are gone. There is only one missing ; in the patch
(below).
> > AFAIS, it is related to broken DK implementation on the sender,
> > shouldnt this be reflect as some score instead of a warning?
>
> Can't say. A general policy of SA is to add score points only
> when some item is an indicator of spam, not just because it
> violates some standard.
I was thinking more about flaging the error than necessary adding high
score, like 0.01.
> - unless ($signature->domain)
> + unless ($signature->domain ne '')
> {
> # no domain specified
> - $self->{signature_reject_reason} = "missing d= parameter";
> + $self->{signature_reject_reason} =
> + !defined($signature->domain) ? "missing d tag"
> + : "invalid domain in d tag"
Missing ; here, right?
> return 0;
> }
-Raul Dias
