Re: Trove maps

2010-05-05 Thread Avinash Lakshman
Well it wasn't used for any critical operations. So there is no way to have figured what impact it did or did not have. Avinash On Tue, May 4, 2010 at 7:49 PM, Cagatay Kavukcuoglu wrote: > Did removing Trove collections have a noticeable effect on performance > or memory use at the time? > > On

Re: Trove maps

2010-05-04 Thread Cagatay Kavukcuoglu
Did removing Trove collections have a noticeable effect on performance or memory use at the time? On Tuesday, May 4, 2010, Avinash Lakshman wrote: > Hahaha, Jeff - I remember scampering to remove those references to the Trove > maps, I think around 2 years ago. > Avinash > > On Tue, May 4, 2010

Re: Trove maps

2010-05-04 Thread Prashant Malik
;) ya I it was painful On Tue, May 4, 2010 at 10:53 AM, Avinash Lakshman < avinash.laksh...@gmail.com> wrote: > Hahaha, Jeff - I remember scampering to remove those references to the > Trove maps, I think around 2 years ago. > > Avinash > > > On Tue, May 4, 2010 at 2:34 AM, Jeff Hammerbacher wrot

Re: Trove maps

2010-05-04 Thread Avinash Lakshman
Hahaha, Jeff - I remember scampering to remove those references to the Trove maps, I think around 2 years ago. Avinash On Tue, May 4, 2010 at 2:34 AM, Jeff Hammerbacher wrote: > Hey, > > History repeating itself a bit, here: one delay in getting Cassandra into > the open source world was removin

Re: Trove maps

2010-05-04 Thread Paul Brown
We went through this with Ode w.r.t. Hibernate. Note that Ode still ships with Hibernate support there, just not with Hibernate libraries in the distribution or with a strong dependence on Hibernate. So, if you made Trove maps optional and provided an adapter, you'd be OK. You just can't bun

Re: Trove maps

2010-05-04 Thread Joe Stump
On May 4, 2010, at 6:24 PM, Tatu Saloranta wrote: > But of course Apache can impose their own, however misguided silly > rules on projects under their umbrella. :-) I smell an -ac'esque patch to Cassandra brewing. ;) --Joe

Re: Trove maps

2010-05-04 Thread Tatu Saloranta
Oh boy... that stupid, stupid bickering about true nature of LGPL. Both Apache Foundation and FSF appeared like little kids arguing over whose dad is stronger (this was few years back, when it was discussed whether LGPL components could be used for Apache License projects) Almost made me explicitly

Re: Trove maps

2010-05-04 Thread Boris Shulman
LGPL ia listed as a part of a forbidden licenses for apache projects (see Excluded Licenses in http://www.apache.org/legal/3party.html)... On Tue, May 4, 2010 at 12:34 PM, Jeff Hammerbacher wrote: > Hey, > > History repeating itself a bit, here: one delay in getting Cassandra into > the open sour

Re: Trove maps

2010-05-04 Thread Jeff Hammerbacher
Hey, History repeating itself a bit, here: one delay in getting Cassandra into the open source world was removing its use of the Trove collections library, as the license (LGPL) is not compatible with the Apache 2.0 license. Later, Jeff On Sat, Apr 24, 2010 at 11:28 PM, Tatu Saloranta wrote: >

Re: Trove maps

2010-04-24 Thread Tatu Saloranta
On Sat, Apr 24, 2010 at 6:27 AM, Carlos Sanchez wrote: > There are forEach methods in  that would allow you to travel the > keys/values/entries w/o creating the extra object (entries) Ok. So if change was made, it'd make sense to ensure those were used for traversal. Thanks! -+ Tatu +-

RE: Trove maps

2010-04-24 Thread Carlos Sanchez
There are forEach methods in that would allow you to travel the keys/values/entries w/o creating the extra object (entries) From: Tatu Saloranta [tsalora...@gmail.com] Sent: Friday, April 23, 2010 11:58 PM To: user@cassandra.apache.org Subject: Re: Trove

Re: Trove maps

2010-04-23 Thread Tatu Saloranta
On Fri, Apr 23, 2010 at 1:22 PM, Carlos Sanchez wrote: > I will try to modify the code... what I like about Trove is that even for > regular maps (non primitive) there are no Entry objects created so there are > much less references to be gced This could help, but how is iteration then handled?

RE: Trove maps

2010-04-23 Thread Mark Jones
Subject: Re: Trove maps According to their license page, it is LGPL. On Fri, Apr 23, 2010 at 4:25 PM, Avinash Lakshman mailto:avinash.laksh...@gmail.com>> wrote: I think the GPL license of Trove prevents us from using it in Cassadra. But yes for all its maps it uses Open Addressing which is muc

Re: Trove maps

2010-04-23 Thread Eric Hauser
According to their license page, it is LGPL. On Fri, Apr 23, 2010 at 4:25 PM, Avinash Lakshman < avinash.laksh...@gmail.com> wrote: > I think the GPL license of Trove prevents us from using it in Cassadra. But > yes for all its maps it uses Open Addressing which is much more memory > efficient t

Re: Trove maps

2010-04-23 Thread Avinash Lakshman
I think the GPL license of Trove prevents us from using it in Cassadra. But yes for all its maps it uses Open Addressing which is much more memory efficient than linear chaining that is employed in the JDK. Avinash On Fri, Apr 23, 2010 at 1:22 PM, Carlos Sanchez < carlos.sanc...@riskmetrics.com>

Re: Trove maps

2010-04-23 Thread Carlos Sanchez
I will try to modify the code... what I like about Trove is that even for regular maps (non primitive) there are no Entry objects created so there are much less references to be gced On Apr 23, 2010, at 2:55 PM, Jonathan Ellis wrote: > From what I have seen Trove is only a win when you are doin

Re: Trove maps

2010-04-23 Thread Jonathan Ellis
>From what I have seen Trove is only a win when you are doing Maps of primitives, which is mostly not what we use in Cassandra. (The one exception I can think of is a map of int -> columnfamilies in CommitLogHeader. You're welcome to experiment and see if using Trove there or elsewhere makes a me