I'm trying to enable verified boot on an mpc8309, but the first step of
simply enabling CONFIG_FIT_SIGNATURE causes this:
[2020-02-07 17:23:34.342] U-Boot 2020.01-00037-g6e82ca3d2e (Feb 07 2020
- 17:23:16 +0100)
[2020-02-07 17:23:34.379]
[2020-02-07 17:23:34.379] Error binding driver 'mpc83xx_cpu'
On 07/02/2020 17.30, Rasmus Villemoes wrote:
> I'm trying to enable verified boot on an mpc8309, but the first step of
> simply enabling CONFIG_FIT_SIGNATURE causes this:
Well, more precisely, CONFIG_RSA causes that - I tried disabling
CONFIG_FIT_SIGNATURE but kept CONFIG_RSA, and the
On 07/02/2020 17.50, Rasmus Villemoes wrote:
> On 07/02/2020 17.30, Rasmus Villemoes wrote:
>> I'm trying to enable verified boot on an mpc8309, but the first step of
>> simply enabling CONFIG_FIT_SIGNATURE causes this:
>
> Well, more precisely, CONFIG_RSA cause
ds fdt_add_pubkey useful as is), but I thought I might as well send
it out for early comments.
Rasmus Villemoes (3):
test_vboot.py: remove extraneous -k option to fit_check_sign
tools: add fdt_add_pubkey
test_vboot.py: include test of fdt_add_pubkey tool
test/py/tests/test_vboot.p
Signed-off-by: Rasmus Villemoes
---
test/py/tests/test_vboot.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
index 9c41ee56b1..3dd8e3cb66 100644
--- a/test/py/tests/test_vboot.py
+++ b/test/py/tests/test_vboot.py
Signed-off-by: Rasmus Villemoes
---
test/py/tests/test_vboot.py | 8
1 file changed, 8 insertions(+)
diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
index 3dd8e3cb66..799c28cc2c 100644
--- a/test/py/tests/test_vboot.py
+++ b/test/py/tests/test_vboot.py
@@ -182,6
to be
supplied on the command line.
Signed-off-by: Rasmus Villemoes
---
tools/.gitignore | 1 +
tools/Makefile | 3 ++
tools/fdt_add_pubkey.c | 96 ++
3 files changed, 100 insertions(+)
create mode 100644 tools/fdt_add_pubkey.c
diff --git a/
On 11/02/2020 10.54, Alex Kiernan wrote:
> On Tue, Feb 11, 2020 at 9:49 AM Rasmus Villemoes
> wrote:
>>
>> Having to use the -K option to mkimage to populate U-Boot's .dtb with the
>> public key while signing the kernel FIT image is often a little
>> awkwar
On 28/01/2020 13.04, Rasmus Villemoes wrote:
> Rasmus Villemoes (2):
> gpio: mpc8xxx: don't modify gpdat when setting gpio as input
> gpio: mpc8xxx: don't do RMW on gpdat register when setting value
>
> drivers/gpio/mpc8xxx_gpio.c | 41 ++
On 06/02/2020 05.14, Y.b. Lu wrote:
>> -Original Message-
>> From: Peng Fan
>> Sent: Wednesday, February 5, 2020 3:08 PM
>> To: Rasmus Villemoes ; u-boot@lists.denx.de;
>> Y.b. Lu
>> Cc: Mario Six
>> Subject: RE: [PATCH] mmc: fsl_esdhc: ac
h/1219513/
[2] https://patchwork.ozlabs.org/cover/1218170/
Klaus H. Sorensen (1):
gpio/mpc83xx_spisel_boot.c: gpio driver for SPISEL_BOOT signal
Rasmus Villemoes (4):
gazerbeam: add clocks property to SPI node
mpc8xxx_spi: put max_cs to use
mpc8xxx_spi: always use 8-bit characters, don't read or wr
venient to present it to the
spi driver that way. The alternative it to teach mpc8xxx_spi to handle
the SPISEL_BOOT signal itself (that is how it's done in the linux
kernel, see commit 69b921acae8a)
Signed-off-by: Klaus H. Sorensen
Signed-off-by: Rasmus Villemoes
---
.../gpio/fsl,mpc83xx-
-by: Rasmus Villemoes
---
drivers/spi/mpc8xxx_spi.c | 64 ---
1 file changed, 53 insertions(+), 11 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 8ef2451411..1bde31ad34 100644
--- a/drivers/spi/mpc8xxx_spi.c
+++ b/drivers/
Prepare for supporting setting different speeds in mpc8xxx_spi.c.
Signed-off-by: Rasmus Villemoes
---
arch/powerpc/dts/gdsys/mpc8308.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/dts/gdsys/mpc8308.dtsi
b/arch/powerpc/dts/gdsys/mpc8308.dtsi
index 23e7403d91
r device tree used "cs-gpios"
rather than "gpios", so gpio_request_list_by_name() had returned 0.
That would have been a lot easier to figure out if the chip select
index was sanity checked, so rename max_cs to cs_count, and reject a
xfer with a too large cs index.
Signed-off-
le it ends being
more work for the CPU, we're mostly bounded by the speed of the SPI
bus, and we avoid writing to the mode register in every loop.
Based on work by Klaus H. Sørensen.
Cc: Klaus H. Sorensen
Signed-off-by: Rasmus Villemoes
---
drivers/spi/mpc8xxx_spi.c | 80
On 05/02/2020 18.59, Simon Glass wrote:
> Hi Rasmus,
>
>> This has been lightly tested in the sandbox. I'll add some proper unit
>> tests, update the help texts and try to handle the Kconfig issue if
>> this is something that might be accepted.
>>
On 11/02/2020 17.30, Wolfgang Denk wrote:
> Dear Rasmus Villemoes,
>
> In message <20200205010812.20373-1-rasmus.villem...@prevas.dk> you wrote:
>> Currently, there's no way to fetch the value of an environment
>> variable whose name is stored in some other var
On 11/02/2020 22.20, Rasmus Villemoes wrote:
> On 11/02/2020 17.30, Wolfgang Denk wrote:
>>> This forces some scripts to needlessly duplicate logic and hardcode
>>> assumptions. For example, in an A/B scheme with three variables
>>>
>>> BOOT_ORDER # Either
On 15/09/2020 08.20, Thirupathaiah Annapureddy wrote:
>
> On 9/7/2020 11:15 PM, Rasmus Villemoes wrote:
>> On 02/09/2020 09.58, Rasmus Villemoes wrote:
>>> On 01/09/2020 22.48, Thirupathaiah Annapureddy wrote:
>>>> Anti rollback protection is required when there
On 15/09/2020 07.22, Thirupathaiah Annapureddy wrote:
> Hi Rasmus,
>
>>
>>> This RFC introduces a proposal to add anti-rollback protection for
>>> FIT images. This protection feature prevents U-Boot from accepting
>>> an image if it has ever successfully loaded an image with a larger
>>> anti-roll
On 16/09/2020 07.04, Heiko Schocher wrote:
> Hello Mario, Tom,
>
> added Tom to cc ...
>
> Am 08.09.2020 um 07:59 schrieb Heiko Schocher:
>> Hi Mario,
>>
>> Am 17.08.2020 um 07:23 schrieb Heiko Schocher:
>>> Hello Mario,
>>>
>>> Am 27.05.2020 um 14:43 schrieb Heiko Schocher:
This patch
On 06/05/2020 10.47, Rasmus Villemoes wrote:
> As preparation for the next patch, use a local variable to represent
> the sector size. No functional change.
>
ping
> Signed-off-by: Rasmus Villemoes
> ---
> env/sf.c | 22 --
> 1 file changed, 12 insert
On 06/05/2020 10.47, Rasmus Villemoes wrote:
> This is roughly the U-Boot side equivalent to commit
> e282c422e0 (tools: fw_env: use erasesize from MEMGETINFO ioctl). The
> motivation is the case where one has a board with several revisions,
> where the SPI flashes have different
On 04/06/2020 12.31, Stefan Roese wrote:
> On 04.06.20 11:30, Rasmus Villemoes wrote:
>> Calling WATCHDOG_RESET for each and every cache line is overkill.
>>
>> In our case, the kernel image is a little over 7MB, and the almost
>> 50 calls of WATCHDOG_RESET() a
with this change, and I have also tested
that removing the GPIOD_ACTIVE_LOW from the request and updating our
DT as
- gpios = <&spisel 0 0>;
+ gpios = <&spisel 0 GPIO_ACTIVE_LOW>;
still works.
Signed-off-by: Rasmus Villemoes
---
dr
Fix build failure, it used to get this implicitly through common.h
until f7ae49fc4f (common: Drop log.h from common header).
Signed-off-by: Rasmus Villemoes
---
drivers/gpio/mpc83xx_spisel_boot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/mpc83xx_spisel_boot.c
b/drivers
On 17/09/2020 06.24, Heiko Schocher wrote:
> Hello Rasmus,
>
> Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes:
>>
>> We have a mpc8309-based board, currently using a U-Boot based on
>> v2020.04. If you have a git tree I can pull these patches from I'll try
Hi Heiko
I'm struggling somewhat with getting our mpc8309-derived board converted
to DM_ETH. I just get
Net: No ethernet found.
where I used to get
Net: UEC0, UEC1, UEC2
and there's no errors or other diagnostics printed (I've also tried
adding #define DEBUG 1 to the .c files under drivers
On 20/05/2020 00.12, Rasmus Villemoes wrote:
> On 20/03/2020 11.14, Rasmus Villemoes wrote:
>> I have a board for which doing "sf erase 0x10 0x8"
>> consistently causes the external watchdog circuit to reset the
>> board. Make sure to pet the watchdog
On 23/09/2020 07.02, Heiko Schocher wrote:
> Hi Rasmus,
>
> Am 22.09.2020 um 16:34 schrieb Rasmus Villemoes:
>> The board already used OF_CONTROL, so I've tried extending the
>> device-tree based partly on you changes for the km boards, partly from
>> our linux de
On 24/09/2020 12.54, Wolfgang Denk wrote:
> Dear Rasmus,
>
> In message <125344f4-2b69-1c7a-0f5a-6d27ab312...@prevas.dk> you wrote:
>>>
>>> On our newer boards with the 4K erase size, saving the environment now
>>> takes 0.080 seconds instead of 0.53 seconds, which directly translates
>>> to that
On 24/09/2020 13.35, Mike Looijmans wrote:
>>> Automatically writing the environment on every boot is always a
>>> really bad idea. Never ever do that.
>>
>> Well, there's really no other place on this piece of hardware to
>> implement a boot counter/slot selection. Sure, we could use another part
could just say
f a b c
instead of
call f a b c
However, that behaviour should be controlled by a separate config
knob, and can be added later if anyone actually wants it.
Signed-off-by: Rasmus Villemoes
---
cmd/Kconfig | 8 +
common/cli_hush.c | 75 +++
.
No functional change.
Signed-off-by: Rasmus Villemoes
---
common/cli_hush.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index 5b1f119074..072b871f1e 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
by that name and do it as "call". But that change of
behaviour, I think, requires a separate opt-in config knob, and can be
done later if someone actually wants that.
Rasmus Villemoes (3):
cli_hush.c: refactor handle_dollar() to prepare for cmd_call
cli_hush.c: add "call"
This is primarily to add a test of the new "call" command, but we
might as well add some very basic tests as well.
Signed-off-by: Rasmus Villemoes
---
configs/sandbox64_defconfig | 1 +
configs/sandbox_defconfig | 1 +
include/test/suites.h | 1 +
test/cmd/Makefile
On 25/09/2020 13.52, Heinrich Schuchardt wrote:
> On 25.09.20 13:19, Rasmus Villemoes wrote:
>> This adds a way to call a "function" defined in the environment with
>> arguments. I.e., whereas
>>
>> run foo
>>
>> requires one to set the (shell
On 25/09/2020 13.19, Rasmus Villemoes wrote:
> Currently, the only way to emulate functions with arguments in the
> busybox shell is by doing "foo=arg1; bar=arg2; run func" and having
I have no idea why I always end up writing "busybox shell" when I mean
"U-Boot sh
On 25/09/2020 15.09, Wolfgang Denk wrote:
> Dear Heinrich Schuchardt,
>
> In message <4b00225d-d960-4a14-9aec-110f7...@gmx.de> you wrote:
>>
>> Further we cannot first introduce a command call and then eliminate it
>> due to backward compatibility. We should decide on the final version
>> befo
On 25/09/2020 15.38, Heinrich Schuchardt wrote:
> On 25.09.20 15:09, Wolfgang Denk wrote:
>> Dear Heinrich Schuchardt,
>>
>> In message <4b00225d-d960-4a14-9aec-110f7...@gmx.de> you wrote:
>>>
>>> Further we cannot first introduce a command call and then eliminate it
>>> due to backward compati
/free pair in .prove/.remove. It's mostly
mechanical using coccinelle, but WDYT?
Rasmus Villemoes (3):
mdio-uclass.c: support fixed-link subnodes
dm_qe_uec.c: fix indentation in uec_set_mac_if_mode()
uec.h: fix COFIG_DM typo
drivers/net/qe/dm_qe_uec.c | 4 ++--
drivers/net/qe/uec
handle(np, "phy-handle", 0);
...
}
phy = of_phy_connect(dev, phy_np, hndlr, 0, iface);
And U-Boot's phy_connect() does have support for fixed-link
subnodes. Calling phy_connect() directly with NULL bus and a dummy
address does seem to make the ethernet work.
Signed-off
Signed-off-by: Rasmus Villemoes
---
drivers/net/qe/uec.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/qe/uec.h b/drivers/net/qe/uec.h
index 7cd4b8737a..32b7d3e561 100644
--- a/drivers/net/qe/uec.h
+++ b/drivers/net/qe/uec.h
@@ -678,7 +678,7 @@ struct uec_priv
Signed-off-by: Rasmus Villemoes
---
drivers/net/qe/dm_qe_uec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qe/dm_qe_uec.c b/drivers/net/qe/dm_qe_uec.c
index 3482b3ff17..e2b8bf02f9 100644
--- a/drivers/net/qe/dm_qe_uec.c
+++ b/drivers/net/qe/dm_qe_uec.c
Hi,
I'm trying to keep our board in sync with upstream, but when trying to
port it to v2020.10-rc4, the kernel verification fails:
## Loading kernel from FIT Image at 0300 ...
Using 'conf-def.dtb' configuration
Verifying Hash Integrity ... sha1,rsa2048:dev- error!
Verification failed f
On 20/09/2020 02.49, Simon Glass wrote:
> The intention which bloblists is that each blob's data is aligned in
> memory. At present it is only the headers that are aligned.
>
> Update the code to correct this and add a little more documentation.
Hi Simon
I haven't read this patch in detail, but
On 06/10/2020 08.02, Heiko Schocher wrote:
> Hello Rasmus,
>
> Am 05.10.2020 um 15:15 schrieb Rasmus Villemoes:
>> When trying to port our mpc8309-based board to DM_ETH, on top of
>> Heiko's patches, I found that nothing in mdio-uclass.c seems to
>> support the us
On 05/10/2020 16.10, Rasmus Villemoes wrote:
> I wanted to try using tools/fit_check_sign as a quick way to bisect
> this, unfortunately the v2020.10-rc4 version (also) says that the kernel
> image is correctly signed.
>
> Does anyone have a crystal ball that says what might
unaligned accesses, add
a little helper that first memcpy's the bytes to a local fdt64_t, then
applies fdt64_to_cpu(). [The name is chosen based on the
[bl]eXX_to_cpup in linux/byteorder/generic.h].
Fixes: fdf0819afb ("rsa: fix alignment issue when getting public exponent")
Signed
On 07/10/2020 00.02, Simon Glass wrote:
> Hi Rasmus,
>
> On Tue, 6 Oct 2020 at 04:10, Rasmus Villemoes
> wrote:
>>
>> Commit fdf0819afb (rsa: fix alignment issue when getting public
>> exponent) changed the logic to avoid doing an 8-byte access to a
>>
.
No functional change.
Signed-off-by: Rasmus Villemoes
---
common/cli_hush.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index 5b1f119074..072b871f1e 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
-- arg1 arg2 arg3
and use $1... up to $9 in the definition of foo. $# is set so foo can
make decisions based on that, and ${3:-default} works as expected.
In v2, at Heinrich's suggestion, make this available as an extension
of the existing run command rather than being a separate 'call'
c
This is primarily to add a test of the new "call" command, but we
might as well add some very basic tests as well.
Signed-off-by: Rasmus Villemoes
---
configs/sandbox64_defconfig | 1 +
configs/sandbox_defconfig | 1 +
include/test/suites.h | 1 +
test/cmd/Makefile
f $1 $2; run g -- 123; do_more_f_stuff $1 $2'
run f -- arg1 arg2
Everything except
- b_addchr(dest, '?');
+ b_addchr(dest, ch);
is under CONFIG_CMD_RUN_ARGS, and when CONFIG_CMD_RUN_ARGS=n, the ch
there can only be '?'. So no functional c
able,
then doing 'env set abc xyz'.
Signed-off-by: Rasmus Villemoes
---
common/cli_hush.c | 8
1 file changed, 8 deletions(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index 5b1f119074..66995c255b 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
@@ -21
On 09/10/2020 15.08, Tom Rini wrote:
> On Wed, Oct 07, 2020 at 12:17:56AM +0200, Rasmus Villemoes wrote:
>> On 07/10/2020 00.02, Simon Glass wrote:
>>>
>>> Reviewed-by: Simon Glass
>>>
>>> Is there a way to add a test for this?
>>
>> Not
On 12/10/2020 05.34, Simon Glass wrote:
> On Wed, 7 Oct 2020 at 01:21, Rasmus Villemoes
> wrote:
>>
>> cmd/Kconfig| 10 ++
>> cmd/nvedit.c | 7 ++-
>> common/cli.c | 44 ++
On 15/10/2020 17.05, Simon Glass wrote:
> Hi Rasmus,
>
> On Mon, 12 Oct 2020 at 01:06, Rasmus Villemoes
> wrote:
>>
>> On 12/10/2020 05.34, Simon Glass wrote:
>>> On Wed, 7 Oct 2020 at 01:21, Rasmus Villemoes
>>> wrote:
>>>>
>>>>
On 03/01/2020 13.42, Stefano Babic wrote:
> Hi Rasmus,
>
> On 27/09/19 10:33, Rasmus Villemoes wrote:
>> On 12/09/2019 11.17, Rasmus Villemoes wrote:
>>> While trying to implement an mxs_set_gpmiclk() I stumbled on a few minor
>>> things.
>>>
>
On 28/12/2019 03.27, Simon Glass wrote:
> Hi Rasmus,
>
> On Sat, 14 Dec 2019 at 16:27, Rasmus Villemoes
> wrote:
>>
>> Hi
>>
>> I'm wondering how commit 60e2809a84 (dm: spi: Avoid setting the speed
>> with every transfer) works. AFAIU, the curre
On 30/12/2019 02.21, Simon Glass wrote:
> Hi Rasmus,
>
> On Wed, 11 Dec 2019 at 04:03, Rasmus Villemoes
> wrote:
>>
>> From: "Klaus H. Sorensen"
>>
>> Allow reading compressed content from fit image, even if
>> CONFIG_SPL_OS_BOOT is not set.
think there's some value in seeing that certain variables are defined
multiple times.
Signed-off-by: Rasmus Villemoes
---
scripts/get_default_envs.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/get_default_envs.sh b/scripts/get_default_envs.sh
index da86a9d69c..
r device tree used "cs-gpios"
rather than "gpios", so gpio_request_list_by_name() had returned 0.
That would have been a lot easier to figure out if the chip select
index was sanity checked, so rename max_cs to cs_count, and reject a
xfer with a too large cs index.
Signed-off-
the gazerbeam board can test that this doesn't break that
- in particular, the "only do transfers that are multiple of 8 bits"
part.
Rasmus Villemoes (4):
gazerbeam: add clocks property to SPI node
mpc8xxx_spi: put max_cs to use
mpc8xxx_spi: always use 8-bit characters, don&
Prepare for supporting setting different speeds in mpc8xxx_spi.c.
Signed-off-by: Rasmus Villemoes
---
arch/powerpc/dts/gdsys/mpc8308.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/dts/gdsys/mpc8308.dtsi
b/arch/powerpc/dts/gdsys/mpc8308.dtsi
index 23e7403d91
le it ends being
more work for the CPU, we're mostly bounded by the speed of the SPI
bus, and we avoid writing to the mode register in every loop.
Based on work by Klaus H. Sørensen.
Cc: Klaus H. Sorensen
Signed-off-by: Rasmus Villemoes
---
drivers/spi/mpc8xxx_spi.c | 80
-by: Rasmus Villemoes
---
drivers/spi/mpc8xxx_spi.c | 64 ---
1 file changed, 53 insertions(+), 11 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 8ef2451411..1bde31ad34 100644
--- a/drivers/spi/mpc8xxx_spi.c
+++ b/drivers/
venient to present it to the
spi driver that way. The alternative it to teach mpc8xxx_spi to handle
the SPISEL_BOOT signal itself (that is how it's done in the linux
kernel, see commit 69b921acae8a)
Signed-off-by: Klaus H. Sorensen
Signed-off-by: Rasmus Villemoes
---
.../gpio/fsl,mpc83xx-
output in an environment variable, not a shell variable.
Signed-off-by: Rasmus Villemoes
---
env/Kconfig | 10 ++
env/common.c| 6 --
lib/hashtable.c | 3 +++
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/env/Kconfig b/env/Kconfig
index 4661082f0e..69fd2ca
On 15/12/2019 23.29, Rasmus Villemoes wrote:
> I'm also seeing the build failure that commit
>
> 7d4776545b env: solve compilation error in SPL
>
> tried to fix, namely that the reference to env_flags_validate from
> env_htab cannot be satisfied when flags.o is not bu
On 10/01/2020 15.34, Tom Rini wrote:
> On Fri, Jan 10, 2020 at 02:28:54PM +0000, Rasmus Villemoes wrote:
>> On 15/12/2019 23.29, Rasmus Villemoes wrote:
>>> I'm also seeing the build failure that commit
>>>
>>> 7d4776545b env: solve compilation error
On 11/01/2020 23.44, Rasmus Villemoes wrote:
> On 10/01/2020 15.34, Tom Rini wrote:
>> On Fri, Jan 10, 2020 at 02:28:54PM +0000, Rasmus Villemoes wrote:
>>> On 15/12/2019 23.29, Rasmus Villemoes wrote:
>>>> I'm also seeing the build failure that commit
>>
Hi
I'm wondering a bit about the semantics of having multiple keys with the
'required = "conf"' property. Currently, the fit image (or rather the
chosen configuration) must be signed by all such keys. I assume this is
for the case where multiple parties (vendor, subvendor, customer?) all
have to s
, but since the patch is not
identical I've elided the R-b.
Rasmus Villemoes (6):
imx8: add hidden IMX8_ROMAPI Kconfig symbol
imx8: sys_proto.h: change guard logic around ROM API
imx8: add rom api wrappers
imx8: use ROM API wrappers in spl_imx_romapi.c
imx8m: soc.c: use rom_api_query_
In order not to repeat the IMX8MN || IMX8MP || IMX8ULP logic in
multiple places where we need to know if the SOC exposes the ROM API,
add a "def_bool y" Kconfig symbol.
Reviewed-by: Peng Fan
Signed-off-by: Rasmus Villemoes
---
arch/arm/mach-imx/Kconfig | 6 +-
1 file changed, 5
.
Reviewed-by: Peng Fan
Signed-off-by: Rasmus Villemoes
---
arch/arm/include/asm/mach-imx/sys_proto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h
b/arch/arm/include/asm/mach-imx/sys_proto.h
index fdbbfb169c..02816197c1 100644
e of these to reduce boilerplate.
[1] One wonders, for example, if the check is only applied to the
lower 32 bits, or if we're implicitly relying on all 64-bit pointer
values we're passing effectively have 0 in the upper 32 bits.
Reviewed-by: Peng Fan
Signed-off-by: Rasmus Villemoes
-
Signed-off-by: Rasmus Villemoes
---
arch/arm/mach-imx/imx8ulp/soc.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-imx/imx8ulp/soc.c b/arch/arm/mach-imx/imx8ulp/soc.c
index 35020c9714..c0f0df356e 100644
--- a/arch/arm/mach-imx/imx8ulp/soc.c
+++ b
Simplify the use of the ROM API by using the wrappers that take care
of saving/restoring gd and computing the xor value. This makes the
generated code smaller and the C code easier to read.
Reviewed-by: Peng Fan
Signed-off-by: Rasmus Villemoes
---
arch/arm/mach-imx/spl_imx_romapi.c | 47
Reviewed-by: Peng Fan
Signed-off-by: Rasmus Villemoes
---
arch/arm/mach-imx/imx8m/soc.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
index 59335356b5..d5eb50143c 100644
--- a/arch/arm/mach-imx/imx8m/soc.c
CONFIG_* macro
as a proxy, but it's much more readable, maintainable and robust if
one's .dts has "ifdef __U_BOOT__" rather than "ifdef __ASSEMBLY__".
Signed-off-by: Rasmus Villemoes
---
scripts/Makefile.lib | 1 +
1 file changed, 1 insertion(+)
diff --git a
On 01/07/2022 21.25, Tom Rini wrote:
> On Fri, Jul 01, 2022 at 09:27:59AM +0200, Rasmus Villemoes wrote:
>> When trying to use the exact same device tree source to build the dtbs
>> used with U-Boot and linux, one often runs into various problems. For
>> example, files unde
On 05/07/2022 11.47, Simon Glass wrote:
> Hi Tom,
>
> On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote:
>>
>> On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote:
>>> Hi,
>>>
>>> On Sun, 3 Jul 2022 at 02:25, Simon Glass wrote:
The fdt_path_offset() function is slow since it must sca
ral limit.]
Signed-off-by: Rasmus Villemoes
---
drivers/i2c/i2c-uclass.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers/i2c/i2c-uclass.c b/drivers/i2c/i2c-uclass.c
index 71bc2b5b8a..a06553324e 100644
--- a/drivers/i2c/i2c-uclass.c
++
On 10/01/2022 04.13, Simon Glass wrote:
> This behaviour is necessary with boards where the binman description
> requires processing external blobs, since these may be missing.
>
> Enable it by default, so that CI is happy. Warnings indicate that a valid
> image is not produced, as with the --allo
On 15/07/2022 14.40, ZHIZHIKIN Andrey wrote:
> Hello Gaurav,
>
> In the new v2022.07, I've stumbled upon the issue with calculating the SHA256
> of
> memory blocks with CAAM hashing. This causes the FIT image not to pass the
> hash
> validation, and also `sha256` command not operable.
>
> I'm a
assed on the 'make' line to enable this
> behavior.
Recreating the bitbake scenario that bit me with this applied correctly
failed to build. Thanks.
Tested-by: Rasmus Villemoes
On 10/10/2022 15.55, Tom Rini wrote:
> On Sun, Oct 09, 2022 at 09:12:25PM +0200, Pali Rohár wrote:
>
>> Hello! Watchdog code seems to be broken in u-boot master branch.
>> On Nokia N900 I'm getting following message in qemu:
>>
>> cyclic function rx51_watchdog took too long: 1us vs 1000us max,
On 12/10/2022 18.28, Sean Anderson wrote:
> On 10/12/22 08:59, Simon Glass wrote:
>> Hi Sean,
>>
>> On Tue, 11 Oct 2022 at 17:25, Sean Anderson
>> wrote:
>>>
>>> When reading data from a FIT image, we must verify the configuration we
>>> get it from. This is because when we have a key with require
On 13/10/2022 08.20, Gaurav Jain wrote:
> Hi Fabio
>
> Thanks for the patch information.
> @Rasmus Villemoes I hope this fixed your problem?
>
Sort of, kind of. I monkey-patched arch/arm/dts/imx8mp-u-boot.dtsi to
include that
+&sec_jr0 {
+ status = "disabled"
On 12/10/2022 21.47, Michal Suchanek wrote:
> In file included from ../tools/imagetool.h:24,
> from ../tools/default_image.c:16:
> In function ‘image_set_name’,
> inlined from ‘image_set_header’ at ../tools/default_image.c:133:2:
> ../include/image.h:786:9: warning: ‘strncpy’ s
On 12/10/2022 16.52, Tom Rini wrote:
>> Option 1 has the benefit that we don't do any of the blob handling, so
>> it just dies right away. Perhaps this is a philosophical question, but
>> it is a little subtle and I'm not actually sure people would notice
>> the difference so long as they get the
entially lifting the "ensure the payload has non-negative size"
to the first place we can check that instead of relying on that check
to happen in several places.
Rasmus Villemoes (6):
net: improve check for no IP options
net: compare received length to sizeof(ip_hdr), not sizeof(ip_ud
ure of compute_ip_checksum(), that would then
lead to accessing ~4G of address space, very likely leading to a
crash.
Signed-off-by: Rasmus Villemoes
---
net/net.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/net.c b/net/net.c
index 536731245b..86b1d90159 1006
There's no reason we should accept an IP packet with a malformed IHL
field. So ensure that it is exactly 5, not just <= 5.
Signed-off-by: Rasmus Villemoes
---
net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index 81905f6315..536731245
yte = start;
case, and thus in the memcpy happily overwrite the second H with our
chosen payload. This is probably worth fixing...
Signed-off-by: Rasmus Villemoes
---
net/net.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index 86b1d90159..340e7b8f
d, since the RHS really should be
"ntohs(ip->ip_len) - 20", i.e. the IP payload size.
Now that we've fixed things so that len == ntohs(ip->ip_len) in all
cases, change that sanity check to use len-20 as the RHS.
Signed-off-by: Rasmus Villemoes
---
net/net.c | 4 ++--
1 file change
Nothing inside this block depends on NET_TFTP_VARS to be set to parse
correctly. Switch to C if() in preparation for adding code before
this (to avoid a declaration-after-statement warning).
Signed-off-by: Rasmus Villemoes
---
net/tftp.c | 56
net_tx_packet (which only has room for 1500 bytes plus change).
Similarly, if tftpblocksize is set to something larger than what we
can actually receive (e.g. 5, with NET_MAXDEFRAG being 16384), any
tftp get just hangs because we never receive any packets.
Signed-off-by: Rasmus Villemoes
---
net
501 - 600 of 945 matches
Mail list logo
