Re: [PATCH] board: amlogic: odroid: add runtime detection of the N2/N2+/C4/HC4 variants

2021-02-04 Thread Neil Armstrong
Hi, On 04/02/2021 10:11, Marek Szyprowski wrote: > Use the ADC channel 1 to check the hardware revision of the board and > detect the N2 vs. N2+ and the C4 vs. HC4 variants. Each of them use > different dtb file, so adjust fdtfile environment variable to the > detected variant. > > The ADC min/ma

Re: [PATCH 2/3] mmc: meson_gx_mmc: use mmc_pwrseq instead of meson_mmc_pwrseq

2021-02-04 Thread Neil Armstrong
t; }, > - { } > -}; > - > -U_BOOT_DRIVER(meson_mmc_pwrseq_drv) = { > - .name = "mmc_pwrseq_emmc", > - .id = UCLASS_PWRSEQ, > - .of_match = meson_mmc_pwrseq_ids, > - .ops= &meson_mmc_pwrseq_ops, > -}; > -#endif > Acked-by: Neil Armstrong You should probably also update the amlogic defconfigs in this patchset, no ? Neil

Re: [PATCH] board: amlogic: odroid: add runtime detection of the N2/N2+/C4/HC4 variants

2021-02-10 Thread Neil Armstrong
On 04/02/2021 10:11, Marek Szyprowski wrote: > Use the ADC channel 1 to check the hardware revision of the board and > detect the N2 vs. N2+ and the C4 vs. HC4 variants. Each of them use > different dtb file, so adjust fdtfile environment variable to the > detected variant. > > The ADC min/max val

[PULL u-boot] Please pull u-boot-amlogic-20210210

2021-02-10 Thread Neil Armstrong
: odroid: add runtime detection of the N2/N2+/C4/HC4 variants Neil Armstrong (4): phy: dphy: Add configuration helpers generic-phy: add configure op phy: Add Amlogic AXG MIPI D-PHY driver phy: Add Amlogic AXG MIPI PCIe Analog PHY driver arch/arm/dts/meson-g12b-odroid-n2-u-b

[PATCH] configs: meson64: add fdtoverlay_addr_r

2021-02-10 Thread Neil Armstrong
/20210120085453.2783678-1-narmstr...@baylibre.com/ Signed-off-by: Neil Armstrong --- include/configs/meson64.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/meson64.h b/include/configs/meson64.h index 52cc01f73d..7e97f89052 100644 --- a/include/configs/meson64.h +++ b/include/configs/meson64

Re: [PATCH] board: amlogic: vim3: fix phy-names property setup

2021-07-26 Thread Neil Armstrong
", 32 - len) + 1; > + len = strlcpy(data, "usb2-phy0", 32); > + len += strlcpy(&data[len], "usb2-phy1", 32 - len); > ret = fdt_setprop(blob, node, "phy-names", data, len); > if (ret < 0) { > printf("vim3: failed to update usb phy names property > (%d)\n", ret); > Good catch, Acked-by: Neil Armstrong Neil

Re: [PATCH] dts: khadas vim series: Use devicetree for SMBIOS settings

2021-07-26 Thread Neil Armstrong
Hi, Subject should be: "[PATCH] ARM: dts: meson: Use devicetree for SMBIOS settings for Khadas VIM boards" with that: Reviewed-by: Neil Armstrong On 15/07/2021 07:00, Artem Lapkin wrote: > Khadas vim series: Use devicetree for SMBIOS settings > Add settings and enable the

Re: [PATCH] configs: khadas-vim*: Enable SMBIOS

2021-07-26 Thread Neil Armstrong
Hi, Subject should be: "[PATCH] configs: Enable SMBIOS for Khadas VIM boards" with that: Reviewed-by: Neil Armstrong On 15/07/2021 07:00, Artem Lapkin wrote: > Enable configs to support SMBIOS for all Khadas vim* boards > > Signed-off-by: Artem Lapkin > --- > conf

Re: [PATCH] net: designware: improve ethernet DMA reset

2021-07-26 Thread Neil Armstrong
Hi, On 21/07/2021 08:19, Artem Lapkin wrote: > Problem: uboot ethernet always have "DMA reset timeout" after > linux usage, detected on VIM2 VIM3 VIM3L amlogic devices, > mainline uboot and mainline linux > 5.1? . > > How-to reproduce: > > 1) Poweron device => ethernet uboot work fine. > 2) Linu

Re: [PATCH] board: amlogic: vim3: fix phy-names property setup

2021-07-27 Thread Neil Armstrong
On 13/07/2021 08:48, Artem Lapkin wrote: > phy-names was improperly implemented resulting in an inoperable USB-OTG > port. > > - phy-names = "usb2-phy0\0\0usb2-phy1\0"; > + phy-names = "usb2-phy0\0usb2-phy1"; > > Signed-off-by: Artem Lapkin > --- > board/amlogic/vim3/vim3.c | 4 ++-- > 1 file c

Re: [PATCH] meson64: add kernel compression vars

2021-07-27 Thread Neil Armstrong
On 27/05/2021 08:43, Artem Lapkin wrote: > make possible to load simple compressed linux kernel for meson64 > > Signed-off-by: Artem Lapkin > --- > include/configs/meson64.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/meson64.h b/include/configs/meson64.h > index

Re: [PATCH] ARM: dts: meson: Use devicetree for SMBIOS settings for Khadas VIM boards

2021-07-27 Thread Neil Armstrong
On 27/07/2021 03:23, Artem Lapkin wrote: > Khadas vim series: Use devicetree for SMBIOS settings > Add settings and enable the default sysinfo driver so that these can come > from the device tree. > > Reviewed-by: Neil Armstrong > Signed-off-by: Artem Lapkin > --- > ...

Re: [PATCH] configs: Enable SMBIOS for Khadas VIM boards

2021-07-27 Thread Neil Armstrong
On 27/07/2021 03:23, Artem Lapkin wrote: > Enable configs to support SMBIOS for all Khadas VIM boards > > Reviewed-by: Neil Armstrong > Signed-off-by: Artem Lapkin > --- > configs/khadas-vim2_defconfig | 2 ++ > configs/khadas-vim3_defconfig | 2 ++ > configs/kh

Re: [PATCH 1/2] phy: meson-axg-mipi: Rename "priv_auto_alloc_size" to "priv_auto"

2021-07-27 Thread Neil Armstrong
On 14/05/2021 22:54, Alper Nebi Yasak wrote: > With commit 41575d8e4c33 ("dm: treewide: Rename auto_alloc_size members > to be shorter") "priv_auto_alloc_size" was renamed to "priv_auto". Apply > the rename to these two drivers as well. > > Fixes: 4547551aa019 ("phy: Add Amlogic AXG MIPI PCIe Anal

Re: [PATCH 2/2] phy: meson-axg-mipi: Access parent ofnode through dev_ofnode()

2021-07-27 Thread Neil Armstrong
On 14/05/2021 22:54, Alper Nebi Yasak wrote: > With commit 84a42ae36683 ("dm: core: Rename device node to indicate it > is private") and commit f10643cf8a4c ("dm: core: Access device ofnode > through functions") accesses to the "node" member were replaced with > dev_ofnode(). Also apply that replac

[PULL u-boot] Please pull u-boot-amlogic-20210727

2021-07-27 Thread Neil Armstrong
Hi Tom, Here is bunch of fixes/changes for the Amlogic based VIM boards, and a build fix for the AXG MIPI DSP PHY driver. The CI job is at https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/pipelines/8444 Thanks, Neil The following changes since commit b70b9b07463db2f6937c7ea6d7fb5122feb

Re: [PATCH 1/6] configs: sei610: fix typo in header comment

2021-07-29 Thread Neil Armstrong
* > * Copyright (C) 2019 Baylibre, SAS > * Author: Jerome Brunet > Acked-by: Neil Armstrong

Re: [PATCH 2/6] configs: meson64_android: fix bad indent in EXTRA_ENV_SETTINGS

2021-07-29 Thread Neil Armstrong
\ > - "fdtfile=amlogic/" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" BOOTENV > + "fdtfile=amlogic/" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0"\ > + BOOTENV > > #include > > Acked-by: Neil Armstrong

Re: [PATCH 3/6] configs: meson64_android: use CONFIG_FASTBOOT_USB_DEV

2021-07-29 Thread Neil Armstrong
"fi;" \ > "if test \"${run_recovery}\" -eq 1; then " \ > "echo Running Recovery...;" \ > - "fastboot 0;" \ > + "fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \ > "fi\0" > > #define BOOTENV_DEV_NAME_RECOVERY(devtypeu, devtypel, instance) \ > Acked-by: Neil Armstrong

Re: [PATCH 4/6] configs: meson64_android: use boot part label instead of index

2021-07-29 Thread Neil Armstrong
dr};" \ > @@ -111,7 +114,6 @@ > #define CONFIG_EXTRA_ENV_SETTINGS \ > "partitions=" PARTS_DEFAULT "\0" \ > "mmcdev=2\0" \ > - "bootpart=1\0"\ > "logopart=2\0"\ > "gpio_recovery=88\0" \ > "check_button=gpio input ${gpio_recovery};test $? -eq 0;\0" \ > Acked-by: Neil Armstrong

Re: [PATCH 5/6] configs: meson64_android: use logo part label instead of index

2021-07-29 Thread Neil Armstrong
uot; \ > "mmcdev=2\0" \ > - "logopart=2\0"\ > "gpio_recovery=88\0" \ > "check_button=gpio input ${gpio_recovery};test $? -eq 0;\0" \ > "load_logo=" PREBOOT_LOAD_LOGO "\0" \ > Acked-by: Neil Armstrong

Re: [PATCH 6/6] configs: meson64_android: don't set console bootargs

2021-07-29 Thread Neil Armstrong
\ > - "console=/dev/ttyAML0\0" \ > - "bootargs=no_console_suspend\0" \ > "stdin=" STDIN_CFG "\0" \ > "stdout=" STDOUT_CFG "\0" \ > "stderr=" STDOUT_CFG "\0" \ > Acked-by: Neil Armstrong

Re: [PATCH 0/6] VIM3: misc cleanups to prepare android support

2021-07-29 Thread Neil Armstrong
On 29/07/2021 09:21, Mattijs Korpershoek wrote: > The Khadas VIM3 and VIM3L boards are well supported in the > Android Open Source project via the yukawa[1] platform. > > Their U-Boot version, despite being public [2] is not in mainline. > > These series a couple of cleanups to prepare to add mai

Re: [PATCH 0/5] meson64_android: use BCB for reboot reason

2021-07-30 Thread Neil Armstrong
+ > include/configs/meson64_android.h | 60 -- > 4 files changed, 42 insertions(+), 54 deletions(-) > Looks fine, but I'll move the patch 1 as last. Can you re-post ? Please add: Acked-by: Neil Armstrong to all patches if you repost. Neil

Re: [PATCH v2 0/5] meson64_android: use BCB for reboot reason

2021-07-30 Thread Neil Armstrong
On 30/07/2021 14:28, Mattijs Korpershoek wrote: > The SEI-610 and SEI-510 boards are well supported in the > Android Open Source project via the yukawa [1] platform. > > Their U-Boot version, despite being public [2] is not in mainline. > > Android has multiple OSes it can boot into: > * Main and

Re: [PATCH v6 5/5] test: add a simple test for the adc-keys button driver

2021-02-18 Thread Neil Armstrong
Hi Marek, On 11/02/2021 09:47, Marek Szyprowski wrote: > Add adc-keys device to the sandbox/test.dts and connect it to the channel > #3 of the sandbox_adc driver. The default values sampled by sandbox_adc > driver determines that button3 and button4 are released and button5 is > pressed. > > Sign

Re: [PATCH v7 0/5] VIM3: add support for checking 'Function' button state

2021-02-18 Thread Neil Armstrong
On 18/02/2021 11:33, Marek Szyprowski wrote: > Hi All, > > This patchset adds all building blocks needed for checking the 'Function' > button state in the boot script on Amlogic A311D based VIM3 board. This > button is connected to the ADC line of the SoC, so it required to enable > meson SARADC,

Re: [PATCH v7 0/5] VIM3: add support for checking 'Function' button state

2021-02-18 Thread Neil Armstrong
On 18/02/2021 11:35, Neil Armstrong wrote: > On 18/02/2021 11:33, Marek Szyprowski wrote: >> Hi All, >> >> This patchset adds all building blocks needed for checking the 'Function' >> button state in the boot script on Amlogic A311D based VIM3 board. This >

[PATCH] button: add udevice forward declaration

2021-02-18 Thread Neil Armstrong
dding struct udevice forward declaration in button.h solves the build error. Fixes: 401d1c4f5d2d ("common: Drop asm/global_data.h from common header") Suggested-by: Heinrich Schuchardt Signed-off-by: Neil Armstrong --- Hi, This is needed to fix build on vim3/vim3l aft

[PULL u-boot] Please pull u-boot-amlogic-20210222

2021-02-22 Thread Neil Armstrong
adc: meson-saradc: add support for getting reference voltage value configs: khadas-vim3(l): enable Function button support test: add a simple test for the adc-keys button driver Neil Armstrong (1): button: add udevice forward declaration arch/sandbox/dts/test.dts

Re: [PATCH] button: add udevice forward declaration

2021-02-22 Thread Neil Armstrong
On 20/02/2021 12:55, Simon Glass wrote: > On Fri, 19 Feb 2021 at 00:41, Neil Armstrong wrote: >> >> After 401d1c4f5d2d ("common: Drop asm/global_data.h from common header") >> build fails with : >> >> drivers/button/button-uclass.c:13:5: error: con

Re: [PATCH V2 4/5] ARM: mach-meson: select MMC_PWRSEQ config

2021-02-22 Thread Neil Armstrong
arch/arm/mach-meson/Kconfig > @@ -9,6 +9,7 @@ config MESON64_COMMON > select SYSCON > select REGMAP > select PWRSEQ > + select MMC_PWRSEQ > select BOARD_LATE_INIT > imply CMD_DM > > Reviewed-by: Neil Armstrong

Re: [PULL u-boot] Please pull u-boot-amlogic-20210222

2021-02-23 Thread Neil Armstrong
On 22/02/2021 21:03, Tom Rini wrote: > On Mon, Feb 22, 2021 at 03:30:36PM +0100, Neil Armstrong wrote: > >> Hi Tom, >> >> These changes adds support for reading the ADC key on the Khadas VIM3 & >> VIM3L, in the same >> time it adds plumbing for ADC keys

[PULL u-boot] Please pull u-boot-amlogic-20210223

2021-02-23 Thread Neil Armstrong
erter device based button driver adc: meson-saradc: add support for getting reference voltage value configs: khadas-vim3(l): enable Function button support test: add a simple test for the adc-keys button driver Neil Armstrong (1): button: add udevice forward declaration

Re: [PULL u-boot] Please pull u-boot-amlogic-20210223

2021-02-23 Thread Neil Armstrong
On 23/02/2021 16:04, Tom Rini wrote: > On Tue, Feb 23, 2021 at 03:58:25PM +0100, Neil Armstrong wrote: > >> Hi Tom, >> >> These changes adds support for reading the ADC key on the Khadas VIM3 & >> VIM3L, in the same >> time it adds plumbing for ADC keys a

[PATCH] button: adc: fix treshold typo

2021-02-23 Thread Neil Armstrong
Fix the treshold typo in code by threshold. Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device based button driver") Suggested-by: Tom Rini Signed-off-by: Neil Armstrong --- drivers/button/button-adc.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH] net: add MMIO Register MDIO MUX driver

2021-02-24 Thread Neil Armstrong
Add support for MMIO register MDIO muxes based on the Linux mdio-mux-mmioreg driver. Signed-off-by: Neil Armstrong --- drivers/net/Kconfig| 7 ++ drivers/net/Makefile | 1 + drivers/net/mdio_mux_mmioreg.c | 129 + 3 files changed, 137

[PATCH] net: designware: add DM_MDIO support

2021-02-24 Thread Neil Armstrong
Add support for DM_MDIO to connect to PHY and expose a MDIO device for the internal MDIO bus in order to dynamically connect to MDIO PHYs with DT with eventual MDIO muxes in between. Signed-off-by: Neil Armstrong --- drivers/net/designware.c | 93 +++- 1 file

Re: [PATCH] configs: meson64: add fdtoverlay_addr_r

2021-02-24 Thread Neil Armstrong
On 10/02/2021 15:26, Neil Armstrong wrote: > In order to support loading FTD Overlays when booting with the pxe > command (or extlinux.conf), supported with [1], add the missing > fdtoverlay_addr_r used to load the overlay before applying it to > the FDT loaded at fdt_addr_r. >

[PATCH] net: add Amlogic Meson G12A MDIO MUX driver

2021-02-24 Thread Neil Armstrong
The Amlogic G12A & compatible SoCs embeds a mux to either communicate with the external PHY or the internal 10/100 PHY. This adds support for this mux as a MDIO MUX device. Signed-off-by: Neil Armstrong --- drivers/net/Kconfig | 7 ++ drivers/net/Makefile |

[PATCH] net: designware: add Amlogic Meson8b & later glue driver

2021-02-24 Thread Neil Armstrong
905x Internal RMII 10/100 PHY) and Khadas VIM3 (A113d with external 10/100/1000 RGMII PHY) to cover the most extreme setups. Signed-off-by: Neil Armstrong --- drivers/net/Kconfig | 8 ++ drivers/net/Makefile| 1 + drivers/net/dwmac_meson8b.c | 150 +++

[RFC/RFT 0/7] arm: meson: static ethernet init cleanup

2021-02-25 Thread Neil Armstrong
com/ [3] https://patchwork.ozlabs.org/project/uboot/patch/20210224163153.2678768-1-narmstr...@baylibre.com/ [4] https://patchwork.ozlabs.org/project/uboot/patch/20210224193356.2948805-1-narmstr...@baylibre.com/ Neil Armstrong (7): configs: update Amlogic Meson GXL & GXM config for MDIO MUX confi

[RFC/RFT 1/7] configs: update Amlogic Meson GXL & GXM config for MDIO MUX

2021-02-25 Thread Neil Armstrong
Use DM_MDIO and the new MMIOREG MDIO MUX driver for GXL & GXM board. Signed-off-by: Neil Armstrong --- configs/khadas-vim2_defconfig| 3 +++ configs/khadas-vim_defconfig | 5 +++-- configs/libretech-ac_defconfig | 5 +++-- configs/libretech-cc_defconfig

[RFC/RFT 3/7] arm: meson: remove static MDIO mux handling

2021-02-25 Thread Neil Armstrong
The static MDIO mux handling in mach-meson is no more needed, delete it. Signed-off-by: Neil Armstrong --- arch/arm/mach-meson/board-g12a.c | 33 arch/arm/mach-meson/board-gx.c | 14 ++ 2 files changed, 2 insertions(+), 45 deletions(-) diff --git

[RFC/RFT 2/7] configs: update Amlogic Meson G12A, G12B & SM1 configs for MDIO MUX

2021-02-25 Thread Neil Armstrong
Use DM_MDIO and the new G12A MDIO MUX driver for G12A, G12B & SM1 boards. Signed-off-by: Neil Armstrong --- configs/beelink-gtking_defconfig| 3 +++ configs/beelink-gtkingpro_defconfig | 3 +++ configs/khadas-vim3_defconfig | 3 +++ configs/khadas-vim3l_defconfig | 3 +++ con

[RFC/RFT 6/7] arm: meson: remove static ethernet memory power domain enable

2021-02-25 Thread Neil Armstrong
The ethernet memory power domain is handled by the meson-ee-pwrc driver, delete the static code. Signed-off-by: Neil Armstrong --- arch/arm/mach-meson/board-g12a.c | 3 --- arch/arm/mach-meson/board-gx.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/arch/arm/mach-meson/board-g12a.c b

[RFC/RFT 5/7] net: designware: remove amlogic compatibles

2021-02-25 Thread Neil Armstrong
These compatibles are now handled by the dwmac_meson8b glue driver. Signed-off-by: Neil Armstrong --- drivers/net/designware.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index acf3a82828..b8ba00b7c0 100644 --- a/drivers/net

[RFC/RFT 4/7] configs: meson: use Designware glue driver for Amlogic Meson8b & later SoCs

2021-02-25 Thread Neil Armstrong
Use the proper Synopsys DWMAC Meson8b glue to handle the ethernet link type. Signed-off-by: Neil Armstrong --- configs/beelink-gtking_defconfig | 2 +- configs/beelink-gtkingpro_defconfig | 2 +- configs/khadas-vim2_defconfig| 2 +- configs/khadas-vim3_defconfig| 2

[RFC/RFT 7/7] arm: meson: remove static ethernet link setup

2021-02-25 Thread Neil Armstrong
The static ethernet link type config code is no more needed because now handled by the meson8b glue driver, delete it. Signed-off-by: Neil Armstrong --- arch/arm/include/asm/arch-meson/axg.h | 22 - arch/arm/include/asm/arch-meson/eth.h | 12 --- arch/arm/include

Re: [PATCH v2] usb: gadget: dwc2_udc_otg: Fix dwc2_gadget_start() and usb_gadget_register_driver()

2021-02-26 Thread Neil Armstrong
- if (!driver || > - (driver->speed != USB_SPEED_FULL && > - driver->speed != USB_SPEED_HIGH) || > + if (!driver || driver->speed < USB_SPEED_FULL || > !driver->bind || !driver->disconnect || !driver->setup) > return -EINVAL; > > Thx for the fix ! Tested-by: Neil Armstrong

[PATCH] nvme: add cache flush in get/set_features

2021-02-26 Thread Neil Armstrong
On Amlogic G12A platforms, the NVME probe timeouts at get/set_feature(), adding a cache flush solves the timeout. Signed-off-by: Neil Armstrong --- drivers/nvme/nvme.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index

Re: [PATCH] nvme: add cache flush in get/set_features

2021-02-26 Thread Neil Armstrong
Hi Andre, Bin, On 26/02/2021 16:22, André Przywara wrote: > On 26/02/2021 14:13, Neil Armstrong wrote: > > Hi, > [..] > > And if this seems to fix something, how? Good question... sorry for the noise my patch is totally wrong, but it fixed something somehow. But, "

Re: [RFC PATCH] nvme: Always invalidate whole cqes[] array

2021-02-26 Thread Neil Armstrong
> qid) > nvmeq->q_db = &dev->dbs[qid * 2 * dev->db_stride]; > memset((void *)nvmeq->cqes, 0, NVME_CQ_SIZE(nvmeq->q_depth)); > flush_dcache_range((ulong)nvmeq->cqes, > -(ulong)nvmeq->cqes + NVME_CQ_SIZE(nvmeq->q_depth)); > +(ulong)nvmeq->cqes + NVME_CQ_ALLOCATION); > dev->online_queues++; > } > > On Amlogic A311D, fixes timeout on nvme scan: Tested-by: Neil Armstrong

Re: [PATCH] net: designware: add Amlogic Meson8b & later glue driver

2021-03-08 Thread Neil Armstrong
On 24/02/2021 20:33, Neil Armstrong wrote: > This adds a proper glue driver for the Designware DWMAC ethernet MAC IP > found in the Amlogic Meson8, GXBB, GXL, GXM, G12A, G12B & SM1 SoCs. > > This is aimed to replace the static ethernet link setup found on the board > init code

Re: [PATCH] net: add Amlogic Meson G12A MDIO MUX driver

2021-03-08 Thread Neil Armstrong
On 25/02/2021 20:34, Ramon Fried wrote: > On Wed, Feb 24, 2021 at 6:31 PM Neil Armstrong > wrote: >> >> The Amlogic G12A & compatible SoCs embeds a mux to either communicate with >> the external PHY or the internal 10/100 PHY. >> >> This adds s

Re: [PATCH] net: designware: add DM_MDIO support

2021-03-08 Thread Neil Armstrong
On 25/02/2021 20:34, Ramon Fried wrote: > On Wed, Feb 24, 2021 at 4:02 PM Neil Armstrong > wrote: >> >> Add support for DM_MDIO to connect to PHY and expose a MDIO device for the >> internal MDIO bus in order to dynamically connect to MDIO PHYs with DT >> with

Re: [PATCH] net: add MMIO Register MDIO MUX driver

2021-03-08 Thread Neil Armstrong
On 25/02/2021 20:36, Ramon Fried wrote: > On Wed, Feb 24, 2021 at 4:02 PM Neil Armstrong > wrote: >> >> Add support for MMIO register MDIO muxes based on the Linux mdio-mux-mmioreg >> driver. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers

Re: [RFC/RFT 0/7] arm: meson: static ethernet init cleanup

2021-03-08 Thread Neil Armstrong
On 25/02/2021 09:44, Neil Armstrong wrote: > This serie finally removes the static ethernet link setup, MDIO mux & memory > power domain after introduction of : > - "net: add MMIO Register MDIO MUX driver" at [1] > - "net: designware: add DM_MDIO support" at [

Re: [PATCH] button: adc: fix treshold typo

2021-03-08 Thread Neil Armstrong
On 23/02/2021 19:18, Marek Szyprowski wrote: > On 23.02.2021 16:10, Neil Armstrong wrote: >> Fix the treshold typo in code by threshold. >> >> Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device >> based button driver") >> Sug

[PULL u-boot] Please pull u-boot-amlogic-20210308

2021-03-08 Thread Neil Armstrong
Neil Armstrong (2): button: adc: fix treshold typo configs: meson64: add fdtoverlay_addr_r drivers/button/button-adc.c | 14 +++--- include/configs/meson64.h | 1 + 2 files changed, 8 insertions(+), 7 deletions(-)

Re: [PATCH 0/2] u-boot support for ODROID-C4

2020-06-30 Thread Neil Armstrong
Hi, On 30/06/2020 13:33, Anand Moon wrote: > Hi Beniamino, > > On Wed, 6 May 2020 at 01:53, Beniamino Galvani wrote: >> >> Hi, >> >> these two patches add initial u-boot support for Hardkernel ODROID-C4. >> >> https://wiki.odroid.com/odroid-c4/odroid-c4 >> >> Beniamino Galvani (2): >> arm: dts

Re: [PATCH] board: amlogic: Add Odroid-N2 board support

2020-06-30 Thread Neil Armstrong
On 18/06/2020 16:40, Neil Armstrong wrote: > From: Pascal Vizeli > > Add a proper Odroid-N2 board support to handle the Ethernet MAC > address stored in the in-SoC eFuses. > > Signed-off-by: Pascal Vizeli > Signed-off-by: Neil Armstrong > --- > board/amlogic

Re: [PATCH 0/2] u-boot support for ODROID-C4

2020-07-02 Thread Neil Armstrong
Hi, On 30/06/2020 18:02, Anand Moon wrote: > Hi Neil, > > On Tue, 30 Jun 2020 at 18:30, Neil Armstrong wrote: >> >> Hi, >> >> On 30/06/2020 13:33, Anand Moon wrote: >>> Hi Beniamino, >>> >>> On Wed, 6 May 2020 at 01:53, Beniamino G

Re: [PATCH 0/2] u-boot support for ODROID-C4

2020-07-02 Thread Neil Armstrong
Hi, On 01/07/2020 13:31, Anand Moon wrote: > Hi Neil, > > On Wed, 1 Jul 2020 at 13:22, Neil Armstrong wrote: >> >> Hi, >> >> On 30/06/2020 18:02, Anand Moon wrote: >>> Hi Neil, >>> >>> On Tue, 30 Jun 2020 at 18:30, Neil Armstrong &

[PATCH 0/3] board: amlogic: add Odroid C4 support

2020-07-02 Thread Neil Armstrong
Linux 5.8-rc1 boards: amlogic: add Odroid C4 support Neil Armstrong (1): ARM: dts: meson-sm1-odroid-c4: add ethernet PHY reset arch/arm/dts/Makefile| 1 + arch/arm/dts/meson-g12-common.dtsi | 13 +- arch/arm/dts/meson-g12.dtsi | 32 +- arch

[PATCH 1/3] ARM: dts: sync amlogic G12A/G12B/SM1 DT from Linux 5.8-rc1

2020-07-02 Thread Neil Armstrong
From: Christian Hewitt This imports the changes and the new Odroid-C4 board from the Linux commit b3a9e3b9622a ("Linux 5.8-rc1"). Signed-off-by: Neil Armstrong --- arch/arm/dts/Makefile| 1 + arch/arm/dts/meson-g12-common.dtsi | 13 +- arch/arm/dts/meso

[PATCH 3/3] ARM: dts: meson-sm1-odroid-c4: add ethernet PHY reset

2020-07-02 Thread Neil Armstrong
The PHY needs a reset in order to be functionnal for U-Boot, add the old PHY reset bindings for dwmac until we support the new bindings in the PHY node. Signed-off-by: Neil Armstrong --- arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch

Re: [PATCH 0/2] u-boot support for ODROID-C4

2020-07-02 Thread Neil Armstrong
On 01/07/2020 16:43, Anand Moon wrote: > Hi Neil, > > On Wed, 1 Jul 2020 at 18:38, Neil Armstrong wrote: >> >> Hi, >> >> On 01/07/2020 13:31, Anand Moon wrote: >>> Hi Neil, >>> >>> On Wed, 1 Jul 2020 at 13:22, Neil Armstrong wrote: &

[PATCH 2/3] boards: amlogic: add Odroid C4 support

2020-07-02 Thread Neil Armstrong
From: Christian Hewitt Odroid C4 is an Amlogic SM1 device, the board config and board documentation are adapted from the Odroid-N2 support from the same vendor. Signed-off-by: Christian Hewitt Signed-off-by: Neil Armstrong --- arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 7 + board

Re: [PATCH 0/2] u-boot support for ODROID-C4

2020-07-02 Thread Neil Armstrong
On 01/07/2020 18:09, Anand Moon wrote: > Hi Neil, > > On Wed, 1 Jul 2020 at 20:16, Neil Armstrong wrote: >> >> On 01/07/2020 16:43, Anand Moon wrote: >>> Hi Neil, >>> >>> On Wed, 1 Jul 2020 at 18:38, Neil Armstrong wrote: >>>> >&g

Re: [PATCH v3 7/7] arm: meson: change trace level for phy errors managed by uclass

2020-07-07 Thread Neil Armstrong
r USB PHY%d for %s\n", > -i, ofnode_get_name(dwc2_node)); > + pr_debug("Can't power USB PHY%d for %s\n", > + i, ofnode_get_name(dwc2_node)); > return ret; > } > } > Acked-by: Neil Armstrong

Re: [PATCH 0/3] board: amlogic: add Odroid C4 support

2020-07-07 Thread Neil Armstrong
Le 01/07/2020 à 16:43, Neil Armstrong a écrit : > This patchset adds support for the Hardkernel Odroid-C4 board > based on an Amlogic S905X3 SoC (SM1). > > These patches were made very early from Christian Hewitt when the device > was unveiled by Hardkernel, and superseed th

[PULL u-boot] Please pull u-boot-amlogic-20200708

2020-07-08 Thread Neil Armstrong
Christian Hewitt (2): ARM: dts: sync amlogic G12A/G12B/SM1 DT from Linux 5.8-rc1 boards: amlogic: add Odroid C4 support Neil Armstrong (1): ARM: dts: meson-sm1-odroid-c4: add ethernet PHY reset Pascal Vizeli (1): board: amlogic: Add Odroid-N2 board support arch/arm

Re: [PATCH v4 1/2] arm: move CONFIG_PREBOOT="usb start" to KConfig

2020-07-20 Thread Neil Armstrong
> index 50138aa3ac..6b2c949823 100644 > --- a/configs/libretech-s912-pc_defconfig > +++ b/configs/libretech-s912-pc_defconfig > @@ -13,7 +13,6 @@ CONFIG_IDENT_STRING=" libretech-s912-pc" > CONFIG_DEBUG_UART=y > CONFIG_OF_BOARD_SETUP=y > CONFIG_USE_PREBOOT=y > -CONFIG_PREBOOT="usb start" > CONFIG_MISC_INIT_R=y > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_CMD_BDI is not set For Amlogic libretech amlogic boards. Reviewed-by: Neil Armstrong Neil

Re: [PATCHv6 1/5] mmc: meson-gx: Fix clk phase tuning for MMC

2020-02-13 Thread Neil Armstrong
On 13/02/2020 12:58, Anand Moon wrote: > hi Niel / Jerome, > > Thanks for your review comments and debug output > Sorry for late reply. > > On Mon, 10 Feb 2020 at 14:33, Neil Armstrong wrote: >> >> On 09/02/2020 18:22, Anand Moon wrote: >>> Hi Neil,

Re: [RFC 2/2] Revert "dm: core: device: switch off power domain after device removal"

2020-02-13 Thread Neil Armstrong
Hi, On 03/02/2020 14:59, Oliver Graute wrote: > The conga-imx8 board isn't booting without this revert. Can someone tell me > what I need to Do so that this revert is not necessary? > > This reverts commit 52edfed65de967a86983a55c51ba0727090efc43. > --- > drivers/core/device-remove.c | 5 - >

Re: [PATCH 1/1] clk: meson-g12a: missing break

2020-02-17 Thread Neil Armstrong
On 15/02/2020 21:10, Heinrich Schuchardt wrote: > Add missing break for CLKID_PCIE_PLL in switch statement. > > Reported by CppCheck. > > Cc: Neil Armstrong > Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support") > Signed-off-by: Heinrich Schuchardt >

Re: [RFC 2/2] Revert "dm: core: device: switch off power domain after device removal"

2020-02-17 Thread Neil Armstrong
On 14/02/2020 05:20, Lokesh Vutla wrote: > > > On 13/02/20 10:42 PM, Neil Armstrong wrote: >> Hi, >> >> On 03/02/2020 14:59, Oliver Graute wrote: >>> The conga-imx8 board isn't booting without this revert. Can someone tell me >>> what I need to

[PATCH] Revert "dm: core: device: switch off power domain after device removal"

2020-02-17 Thread Neil Armstrong
meantime revert this commit until a proper solution is found. This reverts commit 52edfed65de967a86983a55c51ba0727090efc43. Signed-off-by: Neil Armstrong --- Hi Simon, Tom, This revert is the simplest fix to make the boards boot again on v2020.04, the goal is to make this behavior happen again

Re: [PATCH] power-domain: fix hang in endless loop on i.MX8

2020-02-17 Thread Neil Armstrong
Hi, On 17/02/2020 10:07, Oliver Graute wrote: > On 15/02/20, Anatolij Gustschin wrote: >> Currently when booting the kernel on i.MX8 U-Boot hangs in an >> endless loop when switching off dma, connectivity or lsio power >> domains during device removal. It hapens first when removing >> gpio0 (gpio@

Re: [PATCH] Revert "dm: core: device: switch off power domain after device removal"

2020-02-17 Thread Neil Armstrong
Hi Anatolij, On 17/02/2020 12:53, Anatolij Gustschin wrote: > On Mon, 17 Feb 2020 10:10:36 +0100 > Neil Armstrong narmstr...@baylibre.com wrote: > >> This commit breaks Linux boot on Amlogic libretech-cc, libretech-ac, sei510, >> sei610 board by automatically disabling t

Re: [PATCH 1/2] dm: core: Add a flag for power domain control on device removal

2020-02-17 Thread Neil Armstrong
booting OS. > + */ > +#define DM_FLAG_REMOVE_WITH_PD_ON(1 << 13) > + > /* > * One or multiple of these flags are passed to device_remove() so that > * a selective device removal as specified by the remove-stage and the > Acked-by: Neil Armstrong and Tested-by: Guillaume La Roque Thanks, Neil

Re: [PATCH 2/2] video: meson: keep power domain up after booting

2020-02-17 Thread Neil Armstrong
u.c > @@ -210,5 +210,5 @@ U_BOOT_DRIVER(meson_vpu) = { > .probe = meson_vpu_probe, > .bind = meson_vpu_bind, > .priv_auto_alloc_size = sizeof(struct meson_vpu_priv), > - .flags = DM_FLAG_PRE_RELOC, > + .flags = DM_FLAG_PRE_RELOC | DM_FLAG_REMOVE_WITH_PD_ON

Re: [PATCH 09/10] usb: Use ofnode as usb_get_dr_mode() parameter

2020-02-18 Thread Neil Armstrong
-393,7 +393,7 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) > } > #endif > > - priv->otg_mode = usb_get_dr_mode(dev_of_offset(dev)); > + priv->otg_mode = usb_get_dr_mode(dev->node); > > ret = dwc3_meson_g12a_usb_init(priv); > if (ret) For drivers/usb/dwc3/dwc3-meson-g12a.c: Acked-by: Neil Armstrong

Re: [PATCH 1/1] drivers/rng: add Amlogic hardware RNG driver

2020-02-26 Thread Neil Armstrong
eturn err; > + > + return 0; > +} > + > +static const struct dm_rng_ops meson_rng_ops = { > + .read = meson_rng_read, > +}; > + > +static const struct udevice_id meson_rng_match[] = { > + { > + .compatible = "amlogic,meson-rng", >

Re: [PATCH] Revert "dm: core: device: switch off power domain after device removal"

2020-03-02 Thread Neil Armstrong
Hi Analolij, On 17/02/2020 12:53, Anatolij Gustschin wrote: > On Mon, 17 Feb 2020 10:10:36 +0100 > Neil Armstrong narmstr...@baylibre.com wrote: > >> This commit breaks Linux boot on Amlogic libretech-cc, libretech-ac, sei510, >> sei610 board by automatically disabling t

Re: [PATCH v2 1/6] dt-bindings: leds: import common led bindings from linux v5.5

2020-03-02 Thread Neil Armstrong
On 27/02/2020 12:27, Jerome Brunet wrote: > Import the common leds bindings definition from linux > d5226fa6dbae ("Linux 5.5") > > Reviewed-by: Neil Armstrong > Signed-off-by: Jerome Brunet > --- > include/dt-bindings/leds/common.h | 75 ++

Re: [PATCH v2 6/6] arm64: dts: meson: add libretech-pc support

2020-03-02 Thread Neil Armstrong
e > --- /dev/null > +++ b/arch/arm/dts/meson-gxl-s905d-libretech-pc-u-boot.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2019 BayLibre, SAS. > + * Author: Neil Armstrong > + */ > + > +#include "meson-gx-u-boot

Re: [PATCH v2 4/6] arm64: dts: meson: sync dt and bindings from v5.6-rc2

2020-03-02 Thread Neil Armstrong
> - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > #ifndef _DT_BINDINGS_AMLOGIC_MESON_GXBB_RESET_H > #define _DT_BINDINGS_AMLOGIC_MESON_GXBB_RESET_H > Acked-by: Neil Armstrong

Re: [PATCH v2 5/6] arm64: dts: meson: import libretech-pc from linux v5.6-rc2

2020-03-02 Thread Neil Armstrong
00..100a1cfeea15 > --- /dev/null > +++ b/arch/arm/dts/meson-gxl-s905d-libretech-pc.dts > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019 BayLibre SAS. All rights reserved. > + * Author: Jerome Brunet > + */ > + > +/dts-v1/; > + > +#include "meson-gxl-s905d.dtsi" > +#include "meson-gx-libretech-pc.dtsi" > + > +/ { > + compatible = "libretech,aml-s905d-pc", "amlogic,s905d", > + "amlogic,meson-gxl"; > + model = "Libre Computer AML-S905D-PC"; > +}; > diff --git a/arch/arm/dts/meson-gxl-s905d.dtsi > b/arch/arm/dts/meson-gxl-s905d.dtsi > new file mode 100644 > index ..43321919547a > --- /dev/null > +++ b/arch/arm/dts/meson-gxl-s905d.dtsi > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2016 Endless Computers, Inc. > + * Author: Carlo Caione > + */ > + > +#include "meson-gxl.dtsi" > +#include "meson-gxl-mali.dtsi" > + > +/ { > + compatible = "amlogic,s905d", "amlogic,meson-gxl"; > +}; > diff --git a/arch/arm/dts/meson-gxm-s912-libretech-pc.dts > b/arch/arm/dts/meson-gxm-s912-libretech-pc.dts > new file mode 100644 > index ..444c249863cb > --- /dev/null > +++ b/arch/arm/dts/meson-gxm-s912-libretech-pc.dts > @@ -0,0 +1,62 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019 BayLibre SAS. All rights reserved. > + * Author: Jerome Brunet > + */ > + > +/dts-v1/; > + > +#include "meson-gxm.dtsi" > +#include "meson-gx-libretech-pc.dtsi" > + > +/ { > + compatible = "libretech,aml-s912-pc", "amlogic,s912", > + "amlogic,meson-gxm"; > + model = "Libre Computer AML-S912-PC"; > + > + typec2_vbus: regulator-typec2_vbus { > + compatible = "regulator-fixed"; > + regulator-name = "TYPEC2_VBUS"; > + regulator-min-microvolt = <500>; > + regulator-max-microvolt = <500>; > + vin-supply = <&vcc5v>; > + > + gpio = <&gpio GPIODV_1 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > +}; > + > +&pinctrl_periphs { > + /* > + * Make sure the irq pin of the TYPE C controller is not driven > + * by the SoC. > + */ > + fusb302_irq_pins: fusb302_irq { > + mux { > + groups = "GPIODV_0"; > + function = "gpio_periphs"; > + bias-pull-up; > + output-disable; > + }; > + }; > +}; > + > +&i2c_C { > + fusb302@22 { > + compatible = "fcs,fusb302"; > + reg = <0x22>; > + > + pinctrl-0 = <&fusb302_irq_pins>; > + pinctrl-names = "default"; > + interrupt-parent = <&gpio_intc>; > + interrupts = <59 IRQ_TYPE_LEVEL_LOW>; > + > + vbus-supply = <&typec2_vbus>; > + > + status = "okay"; > + }; > +}; > + > +&usb2_phy2 { > + phy-supply = <&typec2_vbus>; > +}; > Acked-by: Neil Armstrong

Re: [PATCH v2 0/6] arm64: meson: add libretech-pc support

2020-03-02 Thread Neil Armstrong
On 27/02/2020 12:27, Jerome Brunet wrote: > Add libretech PC platform support. This platform comes in 2 variants, > one with the s905d and the other s912. > > While working on these boards, I've found a problem related the mmc > clock. In some cases, the ROM code will leave the mmc clocks in such

Re: [PATCH v2 2/6] mmc: meson-gx: enable input clocks

2020-03-02 Thread Neil Armstrong
ot work with. > > Enable the input clocks provided to the mmc controller. While the > u-boot mmc controller driver is not doing fancy settings like the Linux, > it at least needs to make these clocks are running. > > Reviewed-by: Neil Armstrong > Signed-off-by: Jerome Brunet &g

Re: [PATCH v2 4/6] arm64: dts: meson: sync dt and bindings from v5.6-rc2

2020-03-02 Thread Neil Armstrong
On 02/03/2020 10:33, Neil Armstrong wrote: > On 27/02/2020 12:27, Jerome Brunet wrote: >> Sync the device tree and dt-bindings from Linux v5.6-rc2 >> 11a48a5a18c6 ("Linux 5.6-rc2") >> >> The only exception to this is the mmc pinctrl pin bias of gxl SoC family.

Re: [PATCH v2 6/6] arm64: dts: meson: add libretech-pc support

2020-03-02 Thread Neil Armstrong
On 02/03/2020 10:34, Neil Armstrong wrote: > On 27/02/2020 12:27, Jerome Brunet wrote: >> Add support for the Amlogic based libretech-pc platform. >> This platform comes with 2 variant, based on the s905d or s912 SoC. >> >> Signed-off-by: Jerome Brunet >&

Re: [PATCH v2 6/6] arm64: dts: meson: add libretech-pc support

2020-03-02 Thread Neil Armstrong
Hi, On 02/03/2020 10:57, Jerome Brunet wrote: > > On Mon 02 Mar 2020 at 10:52, Neil Armstrong wrote: > >> On 02/03/2020 10:34, Neil Armstrong wrote: >>> On 27/02/2020 12:27, Jerome Brunet wrote: >> >> The defconfig fails with : >> scripts/kconfig

[PATCH] ARM: dts: add missing meson-gxl-s805x-libretech-ac-u-boot.dtsi file

2020-04-15 Thread Neil Armstrong
The libretech-ac u-boot.dtsi file is missing to enabled DT nodes changes to enable Video output on U-Boot. Fixes: 671b1db8f8 ("arm64: dts: meson-gx: vpu should be probed before relocation") Reported-by: Jerome Brunet Signed-off-by: Neil Armstrong --- arch/arm/dts/meson-gxl-s805x-li

Re: [PATCH 1/1] configs: correct SMBIOS information for ODROID-C2

2020-04-15 Thread Neil Armstrong
E_MUX=y > @@ -41,3 +42,4 @@ CONFIG_DEBUG_UART_ANNOUNCE=y > CONFIG_DEBUG_UART_SKIP_INIT=y > CONFIG_MESON_SERIAL=y > CONFIG_OF_LIBFDT_OVERLAY=y > +CONFIG_SMBIOS_MANUFACTURER="Hardkernel Co., Ltd." > -- > 2.25.1 > Acked-by: Neil Armstrong Applied to u-boot-amlogic

Re: [PATCH] arm: meson: imply DM_RNG

2020-04-15 Thread Neil Armstrong
On 05/04/2020 12:20, Heinrich Schuchardt wrote: > All ARCH_MESON boards have a hardware random number generator. So we should > enable building the RNG driver. > > Signed-off-by: Heinrich Schuchardt > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/Kconf

Re: [PATCH 01/10] generic-phy: add generic_phy_get_by_node()

2020-04-15 Thread Neil Armstrong
Tom, Marek, On 30/03/2020 11:27, Neil Armstrong wrote: > Add generic_phy_get_by_node() to get a PHY phandle from a node instead > of a udevice. > > Signed-off-by: Neil Armstrong > --- > drivers/phy/phy-uclass.c | 17 - > include/

Re: [PATCH] ARM: dts: add missing meson-gxl-s805x-libretech-ac-u-boot.dtsi file

2020-04-16 Thread Neil Armstrong
On 15/04/2020 17:58, Neil Armstrong wrote: > The libretech-ac u-boot.dtsi file is missing to enabled DT nodes changes > to enable Video output on U-Boot. > > Fixes: 671b1db8f8 ("arm64: dts: meson-gx: vpu should be probed before > relocation") > Reported-by: Jerome B

<    1   2   3   4   5   6   7   8   9   10   >