Re: [PATCH] include/fastboot.h: add missing types.h include

2024-07-05 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On ven., juin 21, 2024 at 03:51, Caleb Connolly wrote: > Fixes a compile error when building with only the TCP fastboot implementation. > > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > include/fastboot.h |

Re: [PATCH] include/fastboot.h: add missing types.h include

2024-07-09 Thread Mattijs Korpershoek
Hi, On Fri, 21 Jun 2024 03:51:02 +0200, Caleb Connolly wrote: > Fixes a compile error when building with only the TCP fastboot implementation. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu) [1/1] include/fastboot.h: add missing types.h include h

Re: [PATCH] eth: asix88179: reset during probe

2024-07-09 Thread Mattijs Korpershoek
ller during probe so we always start with it in a > known state, and don't have wait for the first asix_wait_link() to > time out. > > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > I see this behaviour consistently across three Qualc

Re: [PATCH v2 1/3] phy: Extend generic_setup_phy() with PHY mode and submode

2024-07-09 Thread Mattijs Korpershoek
phy_set_mode() call returns 0 and does not error out, so this > should not break any existing systems. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Caleb Connolly > Cc: Fabio Estevam > Cc: Fabrice Gasnier > Cc: Jonas Karlman >

Re: [PATCH v2 2/3] phy: rcar: Split init and set_mode operations

2024-07-09 Thread Mattijs Korpershoek
gt; Since the OTG mode may enable IRQ generation in the PHY, disable > that IRQ generation in the exit callback again. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Caleb Connolly > Cc: Fabio Estevam > Cc: Fabrice Gasnier > Cc: Jonas Karlman

Re: [PATCH v2 3/3] phy: test: Implement sandbox PHY .set_mode and DM test

2024-07-09 Thread Mattijs Korpershoek
dm phy_setup' > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Caleb Connolly > Cc: Fabio Estevam > Cc: Fabrice Gasnier > Cc: Jonas Karlman > Cc: Mathieu Othacehe > Cc: Mattijs Korpershoek > Cc: Neil Armstrong > Cc: Nishanth

Re: [PATCH] eth: asix88179: reset during probe

2024-07-09 Thread Mattijs Korpershoek
Hi Marek, On mar., juil. 09, 2024 at 13:13, Marek Vasut wrote: > On 7/9/24 10:39 AM, Mattijs Korpershoek wrote: >> Hi Caleb, > > Hi, > >> Thank you for the patch. >> >> On mar., juin 18, 2024 at 16:57, Caleb Connolly >> wrote: >> >>>

[PATCH v3 0/5] bootstd: Add Android support

2024-07-10 Thread Mattijs Korpershoek
nfigs/meson64_android.h [5] https://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/ [6] https://software-dl.ti.com/processor-sdk-android/esd/AM62X/09_02_00/docs/android/Overview.html Signed-off-by: Mattijs Korpershoek --- Changes in v3: - Fixed CI issues (Tom): * Generate bootv4.im

[PATCH v3 1/5] boot: android: Provide vendor_bootimg_addr in boot_get_fdt()

2024-07-10 Thread Mattijs Korpershoek
don't have CMD_ABOOTIMG, add a weak implementation to avoid linking errors. Reviewed-by: Simon Glass Reviewed-by: Julien Masson Reviewed-by: Igor Opaniuk Reviewed-by: Guillaume La Roque Tested-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- boot/image-android.

[PATCH v3 2/5] bootstd: Add bootflow_iter_check_mmc() helper

2024-07-10 Thread Mattijs Korpershoek
Some bootflows might be able to only boot from MMC devices. Add a helper function these bootflows can use. Reviewed-by: Igor Opaniuk Reviewed-by: Julien Masson Reviewed-by: Guillaume La Roque Tested-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- boot/bootflow.c| 12

[PATCH v3 3/5] android: boot: Add set_abootimg_addr() and set_avendor_bootimg_addr()

2024-07-10 Thread Mattijs Korpershoek
useful for implementing an Android bootmethod. Reviewed-by: Igor Opaniuk Reviewed-by: Julien Masson Reviewed-by: Simon Glass Reviewed-by: Guillaume La Roque Tested-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- cmd/abootimg.c | 10 ++ include/image.h | 14 +

[PATCH v3 5/5] bootstd: Add test for bootmeth_android

2024-07-10 Thread Mattijs Korpershoek
BOOTMETH_ANDROID as a dependency on sandbox so that we can test this with: $ ./test/py/test.py --bd sandbox --build -k test_ut # build the mmc7.img $ ./test/py/test.py --bd sandbox --build -k bootflow_android Signed-off-by: Mattijs Korpershoek --- arch/sandbox/dts/test.dts | 8 + configs

[PATCH v3 4/5] bootstd: Add a bootmeth for Android

2024-07-10 Thread Mattijs Korpershoek
://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/ Reviewed-by: Simon Glass Reviewed-by: Julien Masson Tested-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 7 + boot/Kconfig| 17 ++ boot/Makefile | 2 + boot

[GIT PULL] Please pull u-boot-dfu-20240711

2024-07-11 Thread Mattijs Korpershoek
Hi Tom, Please find some new developments for master: Usb gadget: - A welcome cleanup: epautoconf workaround is dropped to use .match_ep() instead - Introduce handle_interrupts() op for USB_GADGET_GENERIC, which allows a per-driver interrupt handling Fastboot: - Fix mssing include when build

Re: [PATCH 01/13] MAINTAINERS: Rename BOOTDEVICE

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On lun., juil. 15, 2024 at 11:13, Simon Glass wrote: > Rename this to BOOTSTD which is the normal name for the feature. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > MAINTAINERS | 2 +- > 1 file chang

Re: [PATCH 02/13] doc: Move bootstd into its own directory

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On lun., juil. 15, 2024 at 11:13, Simon Glass wrote: > Before adding more files, move the bootstd docs into a new directory, > with an index. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- &

Re: [PATCH 03/13] doc: Add a description for bootmeth_extlinux

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On lun., juil. 15, 2024 at 11:13, Simon Glass wrote: > Add documentation for the extlinux bootmeth. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek Minor nitpicks below, feel free to ignore or apply. > --- > > d

Re: [PATCH 04/13] doc: Add a description for bootmeth_pxe

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On lun., juil. 15, 2024 at 11:13, Simon Glass wrote: > Add documentation for the pxe bootmeth. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek Nitpick: now that pxelinux.rst exist, can we link to this file in extlinux.rst ? >

Re: [PATCH 05/13] doc: Add a description for bootmeth_qfw

2024-07-16 Thread Mattijs Korpershoek
gt; +When invoked on a bootdev for UCLASS_QFW, this bootmeth reads the kernel > +provided by the QEMU `-kernel` argument, the iniital ramdisk and provided by iniital -> initial ramdisk and provided by -> ramdisk provided by With that fixed: Reviewed-by: Mattijs Korpershoek > +`-init

Re: [PATCH 06/13] doc: Add a description for bootmeth_cros

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On lun., juil. 15, 2024 at 11:13, Simon Glass wrote: > Add documentation for the cros bootmeth. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > doc/develop/bootstd/cros.rst | 33 +

Re: [PATCH 07/13] doc: Add a description for bootmeth_sandbox

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On lun., juil. 15, 2024 at 11:13, Simon Glass wrote: > Add documentation for the sandbox bootmeth. > > Fix up the compatible string to drop the 'extlinux' part, which is not > relevant to this bootmeth. > > Signed-off-by: Simon

Re: [PATCH v2 01/14] MAINTAINERS: Rename BOOTDEVICE

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Rename this to BOOTSTD which is the normal name for the feature. > > Signed-off-by: Simon Glass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek > --- > >

Re: [PATCH v2 02/14] doc: Move bootstd into its own directory

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Before adding more files, move the bootstd docs into a new directory, > with an index. > > Signed-off-by: Simon Glass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek

Re: [PATCH v2 03/14] doc: Mention automatic binding of bootmeths

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Add a note about how bootmeth drivers are instantiated. > > Signed-off-by: Simon Glass > Suggested-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > > Changes in

Re: [PATCH v2 04/14] doc: Add a description for bootmeth_extlinux

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Add documentation for the extlinux bootmeth. > > Signed-off-by: Simon Glass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek Minor nitpicks below, feel free to ign

Re: [PATCH v2 05/14] doc: Add a description for bootmeth_pxe

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Add documentation for the pxe bootmeth. > > Signed-off-by: Simon Glass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek Nitpick: now that pxelinux.rst exist, can we link to

Re: [PATCH v2 06/14] doc: Add a description for bootmeth_qfw

2024-07-16 Thread Mattijs Korpershoek
or UCLASS_QFW, this bootmeth reads the kernel > +provided by the QEMU `-kernel` argument, the initial ramdisk and provided by There is a "and" which should be removed here: ramdisk and provided by -> ramdisk provided by With that fixed: Reviewed-by: Mattijs Korpershoek > +`

Re: [PATCH v2 07/14] doc: Add a description for bootmeth_cros

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Add documentation for the cros bootmeth. > > Signed-off-by: Simon Glass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - Adj

Re: [PATCH v2 08/14] doc: Add a description for bootmeth_sandbox

2024-07-16 Thread Mattijs Korpershoek
lass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - Adjustments from Heinrich's comments > > boot/bootmeth_sandbox.c | 2 +- > doc/develop/bootstd/index.rst| 1 + > doc/develop/bootstd/

Re: [PATCH v2 09/14] bootstd: Tidy up comments on the boothmeth drivers

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Fix a typo in the comment and add one to the EFI driver too. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > Reviewed-by: Quentin Schulz Reviewed-by: Matt

Re: [PATCH v2 10/14] bootstd: Correct handling of script from network

2024-07-16 Thread Mattijs Korpershoek
k devices. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > boot/bootmeth_script.c | 51 +- > 1 file changed, 31 insertions(+), 20 deletions(-) > > diff --git a/boot/bootmeth_sc

Re: [PATCH v2 11/14] doc: Add a description for bootmeth_script

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Add documentation for the script bootmeth. > > Signed-off-by: Simon Glass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - Adj

Re: [PATCH v2 12/14] doc: Add a link to VBE from the bootstd docs

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Link to this page to make it easier to find the VBE docs. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > Reviewed-by: Quentin Schulz Reviewed-by: Matt

Re: [PATCH v2 13/14] boot: Correct indentation in efi bootmeth

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > Fix a minor indentation / whitespace problem in a comment. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > Reviewed-by: Quentin Schulz Reviewed-by: Matt

Re: [PATCH v2 14/14] doc: Describe the bootstd settings

2024-07-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mar., juil. 16, 2024 at 08:04, Simon Glass wrote: > The bootstd node provides some configuration properties. Add these to > the documentation. > > Signed-off-by: Simon Glass > Reviewed-by: Quentin Schulz Reviewed-by: Mattijs Korpershoek

Re: [PATCH] cmd: move CMD_DHCP6 options beneath CMD_DHCP6

2024-07-17 Thread Mattijs Korpershoek
Hi Heinrich, Thank you for the patch. On mer., juil. 17, 2024 at 16:54, Heinrich Schuchardt wrote: > All Kconfig options that depend on CONFIG_CMD_DHCP6 should immediately > follow it. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- >

Re: [PATCH v2 01/21] sandbox: Use const in os_jump_to_file()

2024-07-18 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On sam., juil. 13, 2024 at 08:00, Simon Glass wrote: > The argument array is not changed by the callee, so mark it const. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > a

Re: [PATCH v2 02/21] sandbox: Fix a comment in os_find_u_boot()

2024-07-18 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On sam., juil. 13, 2024 at 08:00, Simon Glass wrote: > Fix a missing dot in a comment, since '..' is confusing. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > arch

[PATCH] env: mmc: Fix env loading with CONFIG_SYS_MMC_ENV_PART

2024-07-19 Thread Mattijs Korpershoek
env default -a -f => saveenv # 3. Read back mmc0boot1 and confirm the env is present => mmc read ${loadaddr} 0 400 => md ${loadaddr} 4 8200: 13e0632e 72646461 7469665f 3978303d .c..addr_fit=0x9 Fixes: 5b4acb0ff79d ("env: mmc: Apply GPT only on eMMC user HW partition&q

Re: [PATCH] usb: gadget: usbhs: Add Renesas USBHS device driver

2024-07-23 Thread Mattijs Korpershoek
es have a few checkpatch warnings in it, those > also partly come from Linux. > --- > Cc: Jonas Karlman > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Miquel Raynal > Cc: Simon Glass > Cc: Tom Rini > Cc: Vitaliy Vasylskyy I've reviewed this by

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Mattijs Korpershoek
Hi Tom, Thank you for the report. On mar., juil. 23, 2024 at 08:18, Tom Rini wrote: > Here's the latest report. > > -- Forwarded message - > From: > Date: Mon, Jul 22, 2024, 8:07 PM > Subject: New Defects reported by Coverity Scan for Das U-Boot > To: > > > Hi, > > Please find

[PATCH] cmd: bcb: Fix segfault on invalid block device

2024-07-24 Thread Mattijs Korpershoek
n (being a global static initialized) can be used safely. This issue has been reported by coverity [1] [1] https://lore.kernel.org/all/20240723141844.GF989285@bill-the-cat/ Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") Signed-off-by: Mattijs Korpers

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Mattijs Korpershoek
On mer., juil. 24, 2024 at 11:21, Mattijs Korpershoek wrote: > Hi Tom, > > Thank you for the report. > > On mar., juil. 23, 2024 at 08:18, Tom Rini wrote: > >> Here's the latest report. >> >> -- Forwarded message - >> From: >

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Mattijs Korpershoek
Hi Heinrich, On mer., juil. 24, 2024 at 11:45, Heinrich Schuchardt wrote: > On 24.07.24 11:21, Mattijs Korpershoek wrote: >> Hi Tom, >> >> Thank you for the report. >> >> On mar., juil. 23, 2024 at 08:18, Tom Rini wrote: >> >>> Here's th

Re: [PATCH v3 1/7] usb: gadget: atmel: Sort includes

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Sort includes in alphabetical order. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atmel_usba_udc.c | 6 +++--- > 1 file changed, 3 insertio

Re: [PATCH v3 2/7] usb: gadget: atmel: Replace printf() and pr_err() by log_err()

2024-07-24 Thread Mattijs Korpershoek
udc->driver = NULL; > } > > @@ -1231,7 +1231,7 @@ int usb_gadget_unregister_driver(struct > usb_gadget_driver *driver) > struct usba_udc *udc = &controller; > > if (!driver || !driver->unbind || !driver->disconnect) { > - pr_e

Re: [PATCH v3 3/7] usb: gadget: atmel: Fix typo in usb_gadget_register_driver()

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Replace "paramter" by "parameter". > > Signed-off-by: Zixun LI Same remark on checkpatch warning: WARNING: From:/Signed-off-by: email address mismatch: 'From: Zixun LI ' != 'Signed-off-by: Zixun LI ' >

Re: [PATCH v3 4/7] usb: gadget: atmel: Move usba_udc_pdata() with other static functions

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > To make all static functions in the top, no functional change. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atmel_

Re: [PATCH v3 5/7] usb: gadget: atmel: Rename atmel_usba_start()/_stop() to usba_udc_enable()/_disable()

2024-07-24 Thread Mattijs Korpershoek
functions. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atmel_usba_udc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/atmel_usba_udc.c > b/drivers/usb/gadget/atmel_usba_udc

Re: [PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Add controller attach/detach support by using > usb_gadget_ops.pullup() method. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atm

Re: [PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-24 Thread Mattijs Korpershoek
On mar., juil. 23, 2024 at 15:36, Marek Vasut wrote: > On 7/23/24 3:18 PM, Zixun LI wrote: >> Add controller attach/detach support by using >> usb_gadget_ops.pullup() method. > > It is called 'function' in C, not 'method'. I think 'method' is C++ or > maybe Java ? Agreed, 'function' is more app

Re: [PATCH v3 7/7] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch and doing this very welcome DM_USB_GADGET addition :) On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Add driver model support by using the uclass UCLASS_USB_GADGET_GENERIC. > > Disable local usb_gadget_register_driver()/usb_gadget_unregister_driver() > imp

[PATCH] doc: Add a description for bootmeth_android

2024-07-24 Thread Mattijs Korpershoek
Add initial documentation for the Android bootmeth. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + doc/develop/bootstd/android.rst | 39 +++ doc/develop/bootstd/index.rst| 1 + doc/develop/bootstd/overview.rst | 2 +- 4

Re: [PATCH v2 0/5] bootstd: Add Android support

2024-07-24 Thread Mattijs Korpershoek
On mar., juin 18, 2024 at 21:03, Simon Glass wrote: > Hi Mattijs, > > On Mon, 17 Jun 2024 at 09:15, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On lun., juin 17, 2024 at 07:53, Simon Glass wrote: >> >> > Hi Mattijs, >> > >&g

Re: [PATCH 1/3] usb: dwc3: allocate setup_buf with dma_alloc_coherent()

2024-07-24 Thread Mattijs Korpershoek
: dummy req used while handling STD USB requests > * @ep0_bounce_addr: dma address of ep0_bounce > + * @setup_buf_addr: dma address if setup_buf if -> of Both remarks being minor, please add: Reviewed-by: Mattijs Korpershoek > * @scratch_addr: dma address of scratchbuf >

Re: [PATCH 2/3] usb: dwc3: fix dcache flush range calculation

2024-07-24 Thread Mattijs Korpershoek
ration failures Qualcomm platforms. > > Take in account the alignment and size of the buffer and also > flush the previous and last cacheline. > > Signed-off-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/dwc3/io.h | 5 - > 1 file changed, 4 insert

Re: [PATCH 3/3] usb: dwc3: invalidate dcache on buffer used in interrupt handling

2024-07-24 Thread Mattijs Korpershoek
is read at 0s and leads to fatal crash fixed by [1]. > > [1] > https://lore.kernel.org/all/20240528-topic-sm8x50-dwc3-gadget-crash-fix-v1-1-58434ab4b...@linaro.org/ > > Signed-off-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/dwc3/ep0.c| 2 ++ &

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-25 Thread Mattijs Korpershoek
On mer., juil. 24, 2024 at 16:40, Tom Rini wrote: [...] >> > >> >Ok, so does that mean that you agree that this code is safe and we don't >> >need any further action to fix it? >> >> No fix needed. >> >> Tom just needs to nark it in Coverity as "intended". > > Thanks. I'll copy/paste the expla

Re: [PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support

2024-07-26 Thread Mattijs Korpershoek
ernel.org/en/latest/index.html) can collect the tags: $ b4 shazam -s -l --check 20240725153204.358925-1-ad...@hifiphile.com [...] ✓ [PATCH v4 1/7] usb: gadget: atmel: Sort includes + Reviewed-by: Marek Vasut (✓ DKIM/denx.de) + Reviewed-by: Mattijs Korpershoek (✓ DKIM/baylibre-com.20230601.ga

Re: [PATCH v1 1/4] cmd: ab_select: fix indentation problems for --no-dec parameter

2024-07-30 Thread Mattijs Korpershoek
Hi Dmitry, Thank you for the patch. On jeu., juil. 25, 2024 at 22:47, Dmitry Rokosov wrote: > Command ab_select has wrong help description from indentation > perspective. > > Signed-off-by: Dmitry Rokosov Reviewed-by: Mattijs Korpershoek > --- > cmd/ab_select.c | 4 ++--

Re: [PATCH v1 2/4] cmd: ab: introduce 'ab_dump' command to print BCB block content

2024-07-30 Thread Mattijs Korpershoek
Hi Dmitry, Thank you for the patch. Hi Simon, On dim., juil. 28, 2024 at 13:36, Simon Glass wrote: > Hi Dmitry, > > On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov > wrote: >> >> It's really helpful to have the ability to dump BCB block for debugging >> A/B logic on the board supported this part

Re: [PATCH v1 3/4] test/py: introduce test for ab_dump command

2024-07-30 Thread Mattijs Korpershoek
-- >> > test/py/tests/test_android/test_ab.py | 23 +++ >> > 1 file changed, 23 insertions(+) >> >> This looks good but please use lower-case hex. > > Thank you for the quick review! > > I will change it to lower-case hex in the next version. With Simon's suggestion addressed: Reviewed-by: Mattijs Korpershoek > > -- > Thank you, > Dmitry

Re: [PATCH v1 4/4] common: android_ab: fix slot suffix for abc block

2024-07-30 Thread Mattijs Korpershoek
ange on which this is based in the commit message? https://android-review.googlesource.com/c/platform/external/u-boot/+/1446439 With that added: Reviewed-by: Mattijs Korpershoek > --- > boot/android_ab.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > di

Re: [PATCH v2] boot: android: fix booting without a ramdisk

2024-07-30 Thread Mattijs Korpershoek
can get rid of the "*rd_data = *rd_len = 0;" in the error > path, too. > > With this, I'm able to boot a linux kernel using fastboot again: > > fastboot --base 0x4100 --header-version 2 --dtb /path/to/dtb \ > --cmdline "root=/dev/mmcblk0p1 rootwa

Re: [PATCH v4 7/7] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-30 Thread Mattijs Korpershoek
isable legacy usba_udc_probe() to avoid conflict with DM when it's > enabled. > > Compared to Linux driver only supported devices' DT bindings are included > (sorted as Linux driver) > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/

Re: [PATCH] usb: bootm: Drop old USB-device-removal code

2024-07-30 Thread Mattijs Korpershoek
. > > Drop the call to this old function. > > Leave the netconsole call there, since this needs conversion to > driver model. > > Signed-off-by: Simon Glass > Suggested-by: Shantur Rathore Reviewed-by: Mattijs Korpershoek > --- > The original patch wa

Re: [PATCH v6 4/6] common: console: record console from the beginning

2024-01-02 Thread Mattijs Korpershoek
able console record on console_record_init >> > and not only on console_record_reset_enable. This fixes >> > missing start of U-Boot log for fastboot oem console >> > command. >> > >> > Signed-off-by: Ion Agorria >> > Signed-off-by: Svyatoslav R

Re: [PATCH v1 10/12] fastboot: check device type for SPI NAND too

2024-01-02 Thread Mattijs Korpershoek
Hi Alexey, Thank you for the patch. On Thu, Dec 28, 2023 at 18:39, Alexey Romanov wrote: > SPI NAND devices also supports 'fastboot erase / flash' commands. > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/fb_nand.c |

Re: [PATCH v1 11/12] fastboot: enable FASTBOOT_FLASH option for SPI NAND devices

2024-01-02 Thread Mattijs Korpershoek
Hi Alexey, Thank you for the patch. On Thu, Dec 28, 2023 at 18:39, Alexey Romanov wrote: > From now we can use FASTBOOT_FLASH_NAND option for SPI NAND. > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/Kconfig | 4 ++-- >

Re: [PATCH v1 12/12] fastboot: fb_nand: add missing newlines in pr_err() macro

2024-01-02 Thread Mattijs Korpershoek
Hi Alexey, Thank you for the patch. On Thu, Dec 28, 2023 at 18:39, Alexey Romanov wrote: > pr_err() doesn't add an newline symbol when printing. > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/fb_nand.c | 10 +-

[PATCH] doc: dfu: fix a handful of typos

2024-01-03 Thread Mattijs Korpershoek
Reword some sentences, add missing periods and fix various typos in the dfu documentation. This was originally contributed on [1] [1] https://github.com/Maalobs/u-boot/commit/9a21ed8ba722d904b68945f40ca6697b4b1cc4d4 Signed-off-by: Mattijs Korpershoek --- The author wished to remain anonymous

Re: [PATCH v6 4/6] common: console: record console from the beginning

2024-01-03 Thread Mattijs Korpershoek
Hi Simon, On Tue, Jan 02, 2024 at 07:06, Simon Glass wrote: > Hi Mattijs, > > On Tue, Jan 2, 2024 at 2:52 AM Mattijs Korpershoek > wrote: >> >> Hi Simon, Svyatoslav, >> >> On Thu, Dec 28, 2023 at 21:52, Svyatoslav Ryhel wrote: >> >>

Re: [PATCH v6 0/6] Implement fastboot multiresponce

2024-01-04 Thread Mattijs Korpershoek
Hello Svyatoslav, On jeu., déc. 28, 2023 at 20:01, Svyatoslav Ryhel wrote: > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the required data is obtained. This behavior > can be adjus

Re: [PATCH v6 4/6] common: console: record console from the beginning

2024-01-04 Thread Mattijs Korpershoek
Hi Simon, On mer., janv. 03, 2024 at 18:38, Simon Glass wrote: > Hi Mattijs, > > On Wed, Jan 3, 2024 at 5:41 AM Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On Tue, Jan 02, 2024 at 07:06, Simon Glass wrote: >> >> > Hi Mattijs, >>

Re: [PATCH v6 0/6] Implement fastboot multiresponce

2024-01-09 Thread Mattijs Korpershoek
e_record_reset_enable(). That makes sense. Thank you for looking into this. I see that Svyatoslav included your suggestion in https://patchwork.ozlabs.org/project/uboot/patch/20240105072212.6615-8-clamo...@gmail.com/ I will review it there. > > Regards, > Ion > > El jue, 4 ene 2024 a

Re: [PATCH v7 7/7] test: hush: dollar: fix bagous behavior

2024-01-09 Thread Mattijs Korpershoek
gt; ut_assert_skipline(); > ut_assert_console_end(); > > Same thing should be done with the if block mentioned above that calls > console_record_reset_enable(). > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel I confirm this fixes the problem re

Re: [PATCH 1/2] include: env: ti: ti_common: Fix a missing semicolon

2024-01-09 Thread Mattijs Korpershoek
2b0f2f83b ("include: env: ti: ti_common: Run > main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry Reviewed-by: Mattijs Korpershoek > --- > include/env/ti/ti_common.env | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > &

Re: [PATCH 2/2] include: env: ti: add default for do_main_cpsw0_qsgmii_phyinit

2024-01-09 Thread Mattijs Korpershoek
> boot >## Error: "main_cpsw0_qsgmii_phyinit" not defined >[...] > > Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run > main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry Reviewed-by: Mattijs Korpershoek > --- > include

Re: [PATCH v7 7/7] test: hush: dollar: fix bagous behavior

2024-01-09 Thread Mattijs Korpershoek
Hi Svyatoslav, On mar., janv. 09, 2024 at 15:57, Svyatoslav wrote: > 9 січня 2024 р. 15:54:32 GMT+02:00, Mattijs Korpershoek > написав(-ла): >>Hi Svyatoslav, >> >>Thank you for the patch. >> >>On ven., janv. 05, 2024 at 09:22, Svyatoslav Ryhel wrote: &

Re: [PATCH] doc: fix three-dash references in reStructuredText

2024-01-09 Thread Mattijs Korpershoek
ent > its conversion; that is, enclose it in a pair of double backquotes (`). > > Signed-off-by: Grzegorz Szymaszek Reviewed-by: Mattijs Korpershoek > --- > doc/develop/sending_patches.rst | 4 ++-- > tools/patman/patman.rst | 2 +- > 2 files changed, 3 insertions(+

Re: [PATCH v7 0/7] Implement fastboot multiresponce

2024-01-09 Thread Mattijs Korpershoek
Hi, On Fri, 05 Jan 2024 09:22:05 +0200, Svyatoslav Ryhel wrote: > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the required data is obtained. This behavior > can be adjusted using mul

Re: [PATCH v1] fastboot: introduce 'oem board' subcommand

2024-01-11 Thread Mattijs Korpershoek
Hi Alexey, Sean, On mer., janv. 10, 2024 at 08:03, Alexey Romanov wrote: > Hi, > > On Tue, Jan 09, 2024 at 10:45:46AM -0500, Sean Anderson wrote: >> On 1/9/24 05:27, Alexey Romanov wrote: >> > Hello Sean! >> > >> > Thanks for you reply. >> > >> > On Thu, Dec 28, 2023 at 11:45:04AM -0500, Sean

[GIT PULL] Please pull u-boot-dfu-20240111

2024-01-11 Thread Mattijs Korpershoek
Hi Tom, Here are some developments for master including: - Implement fastboot multi-response. This allows multi-line response and most importantly, finally adds support for fastboot getvar all command. - New 'fastboot oem console' command. Useful for debugging to send data the u-boot shell v

[PATCH 0/2] MAINTAINERS: add Mattijs for Android AB / AVB

2024-01-12 Thread Mattijs Korpershoek
daily job is still doing android work. Add myself as maintainer for Android AB and for Android AVB. Note: the patches are split because I discussed taking over AB privately with Sam, but I did not discuss taking over AVB. Signed-off-by: Mattijs Korpershoek --- Mattijs Korpershoek (2): M

[PATCH 1/2] MAINTAINERS: add Mattijs for Android AB

2024-01-12 Thread Mattijs Korpershoek
or Android AB. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4fec063a242f..3c73d8c35c4a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -59,6 +59,7 @@ F:lib/acpi/ ANDROID AB M: Igor Opaniuk +M:

[PATCH 2/2] MAINTAINERS: add Mattijs for Android AVB

2024-01-12 Thread Mattijs Korpershoek
tainer for Android AVB. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3c73d8c35c4a..4978470c1664 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -70,6 +70,7 @@ F:test/py/tests/test_android/test_ab.py ANDR

Re: [PATCH v2] android_ab: don't ignore ab_control_store return code

2024-01-12 Thread Mattijs Korpershoek
ass the error code to the caller. >> >> Signed-off-by: Alexey Romanov >> Reviewed-by: Mattijs Korpershoek >> --- >> boot/android_ab.c | 16 ++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/boot/andro

Re: [PATCH v4 7/7] doc: board: Add document for DFU boot on am62x SoCs

2024-01-12 Thread Mattijs Korpershoek
Hi Sjoerd, Nishanth, On Fri, Jan 12, 2024 at 13:58, Sjoerd Simons wrote: > On Fri, 2024-01-12 at 06:36 -0600, Nishanth Menon wrote: >> On 09:52-20240112, Sjoerd Simons wrote: >> > >> > +DFU based boot >> > +-- >> > + >> > +To boot the board over DFU, ensure there is no SD card ins

Re: [PATCH 0/2] MAINTAINERS: add Mattijs for Android AB / AVB

2024-01-16 Thread Mattijs Korpershoek
Hi Tom, all, On ven., janv. 12, 2024 at 08:50, Tom Rini wrote: > On Fri, Jan 12, 2024 at 09:40:43AM +0100, Mattijs Korpershoek wrote: > >> Igor has not been active for quite some time on lore: >> https://lore.kernel.org/all/?q=igor.opan...@gmail.com >> >> It seems

Re: [PATCH 0/2] MAINTAINERS: add Mattijs for Android AB / AVB

2024-01-16 Thread Mattijs Korpershoek
Hi, On Fri, 12 Jan 2024 09:40:43 +0100, Mattijs Korpershoek wrote: > Igor has not been active for quite some time on lore: > https://lore.kernel.org/all/?q=igor.opan...@gmail.com > > It seems that Android AB and AVB could use some help maintaining. > > I'm interested in h

Re: [PATCH v4 0/7] Add DFU and usb boot for TI am62x SK and beagleplay

2024-01-16 Thread Mattijs Korpershoek
l@280 Out: serial@280 Err: serial@280 Net: No ethernet found. Press SPACE to abort autoboot in 2 seconds I've also tested (from the DFU'd U-Boot) that I could scan for usb keys: => usb start [..] 1 USB Device(s) found So for the series: Tested-by: Mattijs Korpershoe

Re: [PATCH v4 1/7] usb: dwc3: Add dwc3 glue driver for am62

2024-01-16 Thread Mattijs Korpershoek
lk"); > + if (IS_ERR(syscon)) { > + dev_err(dev, "unable to get ti,syscon-phy-pll-refclk regmap\n"); > + return; > + } > + > + ret = ofnode_parse_phandle_with_args(dev_ofnode(dev), > "ti,syscon-phy-pll-refclk", NULL, 1, &

Re: [PATCH v4 2/7] usb: dwc3: Switch to device mode on gadget start

2024-01-16 Thread Mattijs Korpershoek
t on gadget start switch to _DEVICE > mode globally and go back to _OTG on stop again. > > For this the dwc3_set_mode is renamed to dwc3_core_set_mode to avoid a > conflict with the same function exposed by xhci-dwc3 > > Signed-off-by: Sjoerd Simons Reviewed-by: Mattijs Korpers

Re: [PATCH v4 2/7] usb: dwc3: Switch to device mode on gadget start

2024-01-16 Thread Mattijs Korpershoek
Hi Sjoerd, Caleb On ven., janv. 12, 2024 at 12:55, Caleb Connolly wrote: > Hi Sjoerd, > > On 12/01/2024 08:52, Sjoerd Simons wrote: >> When dr_mode is "otg" the dwc3 is initially configured in _OTG mode; >> However in this mode the gadget functionality doesn't work without >> further configurat

Re: [PATCH v4 3/7] board: ti: am62x: am62x: include env for DFU

2024-01-16 Thread Mattijs Korpershoek
Hi Sjoerd, Thank you for the patch. On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote: > Include standard TI K3 dfu environment > > Signed-off-by: Sjoerd Simons Reviewed-by: Mattijs Korpershoek > > --- > > (no changes since v3) > > Changes in v3: > - Add d

Re: [PATCH v4 7/7] doc: board: Add document for DFU boot on am62x SoCs

2024-01-16 Thread Mattijs Korpershoek
> +uploaded one by one with a tool like dfu-util. > + > +.. am62x_evm_rst_include_start_dfu_boot > + > +The initial ROM will have a DFU alt named `bootloader` for the initial R5 spl > +upload. The next stages as exposed by u-boot have target alts matching the > name s/u-boo

Re: [PATCH v4 4/7] arm: dts: k3-am625-sk: Enable usb port in u-boot

2024-01-16 Thread Mattijs Korpershoek
Hi Sjoerd Thank you for the patch. On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote: > Enable usb0 in all boot phases for use with DFU > > Signed-off-by: Sjoerd Simons > > --- > > Changes in v4: > - Don't force usb0 into peripheral mode I know that dr_mode = "peripheral" has been removed

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-02-01 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On mer., janv. 31, 2024 at 14:57, Caleb Connolly wrote: > The Qualcomm specific dwc3 wrapper isn't hugely complicated, implemented > the missing initialisation for host and gadget mode. > > Signed-off-by: Caleb Connolly > --- > drivers/usb/dwc3/dwc3-generic

Re: [PATCH] usb: gadget: f_mass_storage: Stop ums on START-STOP UNIT SCSI command

2023-11-07 Thread Mattijs Korpershoek
the media > and enter low power state. > > This effectively adds support for exitting the 'ums' command from > host using 'eject /dev/sdN' that is on par with 'dfu-util -e' . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek

RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-07 Thread Mattijs Korpershoek
Hi Jaehoon, On ven., nov. 03, 2023 at 14:49, "Jaehoon Chung" wrote: > Hi, > >> -Original Message- >> From: U-Boot On Behalf Of Jaehoon Chung >> Sent: Friday, November 3, 2023 10:07 AM >> To: 'Mattijs Korpershoek' >> Cc: lu...@d

<    1   2   3   4   5   6   7   8   9   10   >