Re: EFI breaks USB dual port detection - our observations

2023-07-18 Thread Heinrich Schuchardt
On 7/19/23 02:55, Da Xue wrote: On Tue, Jul 18, 2023 at 3:13 PM Heinrich Schuchardt mailto:xypron.g...@gmx.de>> wrote: Am 18. Juli 2023 20:37:04 MESZ schrieb Suniel Mahesh mailto:su...@amarulasolutions.com>>: >Hi, > >I am testing the USB infrast

[PATCH 1/1] efi_loader: support all uclasses in device path

2023-07-18 Thread Heinrich Schuchardt
device. Add support for generating device path nodes for all uclasses. Reported-by: Suniel Mahesh Signed-off-by: Heinrich Schuchardt --- include/efi_api.h| 7 lib/efi_loader/efi_device_path.c | 56 ++-- 2 files changed, 32 insertions(+), 31 deletions

Re: [PATCH 1/1] efi_loader: support all uclasses in device path

2023-07-19 Thread Heinrich Schuchardt
On 19.07.23 07:00, AKASHI Takahiro wrote: On Wed, Jul 19, 2023 at 06:43:08AM +0200, Heinrich Schuchardt wrote: On devices with multiple USB mass storage devices errors like Path /../USB(0x0,0x0)/USB(0x1,0x0)/Ctrl(0x0) already installed. are seen. This is due to creating non-unique

Re: [BUG] efi_loader: incorrect creation of device paths

2023-07-19 Thread Heinrich Schuchardt
On 03.12.21 17:32, Heinrich Schuchardt wrote: On 11/25/21 06:44, AKASHI Takahiro wrote: Heinrich, On Wed, Nov 24, 2021 at 12:10:32PM +0900, AKASHI Takahiro wrote: On Sat, Nov 20, 2021 at 01:54:30PM +0100, Heinrich Schuchardt wrote: Hello Takahiro, in a prior mail we have discussed the

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread Heinrich Schuchardt
On 19.07.23 15:04, Simon Glass wrote: Hi, On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro wrote: Hi Simon, On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote: Hi AKASHI, On Tue, 18 Jul 2023 at 18:22, AKASHI Takahiro wrote: An EFI application may create an EFI block device (EFI_BL

Re: [PATCH v2 2/6] ramdisk: add ramdisk uclass and driver

2023-07-19 Thread Heinrich Schuchardt
On 14.07.23 07:44, Masahisa Kojima wrote: This introcudes the ramdisk uclass and driver. Signed-off-by: Masahisa Kojima --- Newly introcuded in v2 disk/part.c | 3 + drivers/block/Kconfig| 7 +- drivers/block/Makefile | 2 + drivers/block/b

[PATCH v2 0/2] efi_loader: support all uclasses in device path

2023-07-19 Thread Heinrich Schuchardt
device. Add support for generating device path nodes for all uclasses. v2: Add a prerequisite patch for BLKMAP, HOST, VIRTIO block devices Heinrich Schuchardt (2): efi_loader: fix dp_fill() for BLKMAP, HOST, VIRTIO efi_loader: support all uclasses in device path include/efi_api.h

[PATCH v2 1/2] efi_loader: fix dp_fill() for BLKMAP, HOST, VIRTIO

2023-07-19 Thread Heinrich Schuchardt
ot;efi_loader: device path for virtio block devices") Fixes: 272ec6b45304 ("efi_loader: device_path: support blkmap devices") Signed-off-by: Heinrich Schuchardt --- v2: new patch --- lib/efi_loader/efi_device_path.c | 12 +++- 1 file changed, 3 insertions(+)

[PATCH v2 2/2] efi_loader: support all uclasses in device path

2023-07-19 Thread Heinrich Schuchardt
device. Add support for generating device path nodes for all uclasses. Reported-by: Suniel Mahesh Signed-off-by: Heinrich Schuchardt --- v2: no change --- include/efi_api.h| 7 lib/efi_loader/efi_device_path.c | 56 ++-- 2 files changed, 32

Pull request efi-2023-10-rc1-2

2023-07-20 Thread Heinrich Schuchardt
block devices * use InstallMultipleProtocolInterfaces() in TCG protocol implementation to increase UEFI compliance ---- Heinrich Schuchardt (4): efi_loader: simplify efi_uninstall_protocol() test: avoid function name 'set

Re: data abort when run 'dhcp'

2023-07-20 Thread Heinrich Schuchardt
l tftp pass... If anyone has more details to >share, or perhaps a subsequent thread giving more details, I would >really like to see this fixed upstream, I suppose I am not the only one >:-) > >Thanks, >Miquèl Can this problem be reproduced on QEMU? Best regards Heinrich >

[PATCH 1/1] doc: update coc/sphinx/requirements.txt

2023-07-20 Thread Heinrich Schuchardt
Update the following requirements to their latest version: * Pygments - syntax highlighting * pytz - world timezone definitions * certifi - Mozilla's CA bundle Signed-off-by: Heinrich Schuchardt --- doc/sphinx/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 dele

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Heinrich Schuchardt
07:49, AKASHI Takahiro wrote: Hi, On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: On 7/18/23 17:41, Heinrich Schuchardt wrote: On 13.07.23 16:35, Michal Simek wrote: Empty capsule are also allowed to be process. Without it updated images can't change their Image Acceptance

[PATCH 1/1] efi_loader: device paths for special block devices

2023-07-20 Thread Heinrich Schuchardt
path nodes. The current implementation fails to create unique device paths for block devices based on other uclasses like UCLASS_PVBLOCK. Let's use a VenHw() node with the U-Boot GUID with a length dividable by four and encoding blkdesc->uclass_id as well as blkdesc->devnum. Signed-off-b

[PATCH 1/1] efi_loader: simplify dp_fill()

2023-07-20 Thread Heinrich Schuchardt
Move the recursive dp_fill(dev->parent) call to a single location. Determine uclass_id only once. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path.c | 45 +--- 1 file changed, 18 insertions(+), 27 deletions(-) diff --git a/lib/efi_loa

[PATCH 1/1] spl: blk: use CONFIG_SPL_FS_LOAD_PAYLOAD_NAME

2023-07-21 Thread Heinrich Schuchardt
binary to integrate into u-boot-with-spl.bin. See commit 7550dbe38b3f ("spl: Add option SPL_PAYLOAD"). Change spl_blk_load_image() to use CONFIG_SPL_FS_LOAD_PAYLOAD_NAME. Fixes: 8ce6a2e17577 ("spl: blk: Support loading images from fs") Signed-off-by: Heinrich Schuchardt --- com

[PATCH 1/1] riscv: define a cache line size for QEMU

2023-07-21 Thread Heinrich Schuchardt
The USB 3.0 driver xhci-mem.c requires CONFIG_SYS_CACHELINE_SIZE to be set. Define the cache line size for QEMU on RISC-V to be 64 bytes. Signed-off-by: Heinrich Schuchardt --- arch/Kconfig | 1 + arch/riscv/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/riscv/Kconfig

[PATCH 1/1] spl: boot always fail on CONFIG_SHOW_ERRORS=y

2023-07-21 Thread Heinrich Schuchardt
Commit 7d84fbb57312 ("spl: Provide more information on boot failure") left debug code to let boot_from_devices() always fail if CONFIG_SHOW_ERRORS=y. Remove the debug code. Fixes: 7d84fbb57312 ("spl: Provide more information on boot failure") Signed-off-by: Heinrich Schucha

[PATCH 1/1] part: check CONFIG_IS_ENABLED(ENV_SUPPORT)

2023-07-21 Thread Heinrich Schuchardt
In SPL environment variables may not be enabled. Suggested-by: Tom Rini Signed-off-by: Heinrich Schuchardt --- disk/part.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/disk/part.c b/disk/part.c index 3a9315c0ab..6a30335a48 100644 --- a/disk/part.c +++ b/disk

[PATCH v2 1/1] riscv: define a cache line size for the generic CPU

2023-07-21 Thread Heinrich Schuchardt
The USB 3.0 driver xhci-mem.c requires CONFIG_SYS_CACHELINE_SIZE to be set. Define the cache line size for QEMU on RISC-V to be 64 bytes. Signed-off-by: Heinrich Schuchardt --- v2: Select SYS_CACHE_SHIFT_6 for GENERIC_RISCV and not for TARGET_QEMU_VIRT (as suggested by Bin

[PATCH 1/1] spl: blk: partition numbers are hexadecimal

2023-07-22 Thread Heinrich Schuchardt
find partition nvme 0:15 Like the command line interface fs_det_blk_dev() expects that the device number and the partition number are hexadecimal. Fixes: 8ce6a2e17577 ("spl: blk: Support loading images from fs") Signed-off-by: Heinrich Schuchardt --- common/spl/spl_blk_fs.c | 2 +- 1

[PATCH 1/1] riscv: qemu: provide more SPL boot methods

2023-07-22 Thread Heinrich Schuchardt
QEMU can supply block devices or semihosting to U-Boot SPL. Allow booting from these. Signed-off-by: Heinrich Schuchardt --- board/emulation/qemu-riscv/qemu-riscv.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/board/emulation/qemu-riscv/qemu-riscv.c b

[PATCH 1/1] spl: spl_legacy: simplify spl_parse_legacy_validate

2023-07-22 Thread Heinrich Schuchardt
The check for an overlap of the loaded image and SPL is overly complicated. Fixes: 77aed22b48ab ("spl: spl_legacy: Add extra address checks") Signed-off-by: Heinrich Schuchardt --- common/spl/spl_legacy.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/

[PATCH 1/1] spl: add FIT support to semihosting boot method

2023-07-22 Thread Heinrich Schuchardt
Allow loading a FIT image via semihosting in SPL. Signed-off-by: Heinrich Schuchardt --- common/spl/spl_semihosting.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/common/spl/spl_semihosting.c b/common/spl/spl_semihosting.c index 5b5e842a11..f7dd289286

Re: [PATCH 1/1] spl: spl_legacy: simplify spl_parse_legacy_validate

2023-07-22 Thread Heinrich Schuchardt
On 7/22/23 21:09, Marek Vasut wrote: On 7/22/23 20:46, Heinrich Schuchardt wrote: The check for an overlap of the loaded image and SPL is overly complicated. Fixes: 77aed22b48ab ("spl: spl_legacy: Add extra address checks") Signed-off-by: Heinrich Schuchardt ---   common/spl/sp

[PATCH 1/1] spl: initialize PCI before booting from SATA

2023-07-22 Thread Heinrich Schuchardt
Many SATA controllers are PCI bus devices. Before calling scsi_scan() we must bind the PCI devices. Signed-off-by: Heinrich Schuchardt --- common/spl/spl_sata.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/spl/spl_sata.c b/common/spl/spl_sata.c index 32746ce9f3..060da49006

Re: [PATCH 1/1] riscv: qemu: provide more SPL boot methods

2023-07-22 Thread Heinrich Schuchardt
On 7/22/23 16:22, Bin Meng wrote: Hi Heinrich, On Sat, Jul 22, 2023 at 7:10 PM Heinrich Schuchardt wrote: QEMU can supply block devices or semihosting to U-Boot SPL. Allow booting from these. Signed-off-by: Heinrich Schuchardt --- board/emulation/qemu-riscv/qemu-riscv.c | 17

Re: [PATCH 18/18] riscv: qemu: Enable usb keyboard as an input device

2023-07-22 Thread Heinrich Schuchardt
Am 23. Juli 2023 06:40:41 MESZ schrieb Bin Meng : >This brings PCI xHCI support to QEMU RISC-V and uses a usb keyboard >as one of the input devices. > >Signed-off-by: Bin Meng > >--- > > board/emulation/qemu-riscv/Kconfig | 5 + > board/emulation/qemu-riscv/qemu-riscv.c | 5 + > doc/

Re: [PATCH 14/18] console: Print out complete stdio device list

2023-07-22 Thread Heinrich Schuchardt
On 7/23/23 06:40, Bin Meng wrote: At present if both CONSOLE_MUX and SYS_CONSOLE_IS_IN_ENV are on, during boot, the printed out stdio devices are incomplete, e.g.: with "stdout=serial,vidconsole", only "vidconsole" is printed. For such case, we can print out the stdio device name from the enviro

Re: [PATCH 13/18] console: Refactor stdio_print_current_devices() a little bit

2023-07-22 Thread Heinrich Schuchardt
On 7/23/23 06:40, Bin Meng wrote: In preparation to future changes, refactor this routine a little bit. Signed-off-by: Bin Meng --- common/console.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/common/console.c b/common/console.c index

Re: [PATCH 11/18] console: kconfig: Drop the redundant VIDEO dependency

2023-07-22 Thread Heinrich Schuchardt
On 7/23/23 06:40, Bin Meng wrote: The VIDEO dependency is described twice in CONSOLE_MUX. Signed-off-by: Bin Meng Reviewed-by: Heinrich Schuchardt --- common/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/Kconfig b/common/Kconfig index 973482f075

Re: [PATCH 18/18] riscv: qemu: Enable usb keyboard as an input device

2023-07-23 Thread Heinrich Schuchardt
Am 23. Juli 2023 10:38:00 MESZ schrieb Mark Kettenis : >> From: Bin Meng >> Date: Sun, 23 Jul 2023 12:40:41 +0800 >> >> This brings PCI xHCI support to QEMU RISC-V and uses a usb keyboard >> as one of the input devices. >> >> Signed-off-by: Bin Meng >> >> --- >> >> board/emulation/qemu-ri

Re: [PATCH 14/18] console: Print out complete stdio device list

2023-07-23 Thread Heinrich Schuchardt
Am 23. Juli 2023 14:04:39 MESZ schrieb Bin Meng : >Hi Heinrich, > >On Sun, Jul 23, 2023 at 2:38 PM Heinrich Schuchardt wrote: >> >> On 7/23/23 06:40, Bin Meng wrote: >> > At present if both CONSOLE_MUX and SYS_CONSOLE_IS_IN_ENV are on, >> > during

[PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI

2023-07-24 Thread Heinrich Schuchardt
CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense. Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency. Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL") Signed-off-by: Heinrich Schuchardt --- common/spl/Kconfig | 12 drivers/pci/Kc

[PATCH 1/1] spl: initialize PCI before booting from USB

2023-07-24 Thread Heinrich Schuchardt
Many USB controllers are PCI bus devices. Before calling spl_usb_load() we must bind the PCI devices. Signed-off-by: Heinrich Schuchardt --- common/spl/spl_usb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/spl/spl_usb.c b/common/spl/spl_usb.c index 479e2dc182..57275d6000

Re: [PATCH 1/1] spl: initialize PCI before booting from SATA

2023-07-24 Thread Heinrich Schuchardt
On 7/24/23 00:58, Simon Glass wrote: Hi Heinrich, On Sat, 22 Jul 2023 at 15:56, Heinrich Schuchardt wrote: Many SATA controllers are PCI bus devices. Before calling scsi_scan() we must bind the PCI devices. Signed-off-by: Heinrich Schuchardt --- common/spl/spl_sata.c | 2 ++ 1 file

[PATCH 1/1] doc: fix typo device_compat/.h

2023-07-24 Thread Heinrich Schuchardt
%s/device_compat\/.h/device_compat.h/ Signed-off-by: Heinrich Schuchardt --- doc/develop/codingstyle.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/codingstyle.rst b/doc/develop/codingstyle.rst index 3d05a6b988..b25bfbd271 100644 --- a/doc/develop

[PATCH 1/1] doc: describe QEMU emulation of block devices

2023-07-24 Thread Heinrich Schuchardt
* Add a new page about the emulation of block devices * Add semihosting to the emulation index page * Set toc maxdepth to 1 to improve readability Signed-off-by: Heinrich Schuchardt --- doc/board/emulation/blkdev.rst | 38 ++ doc/board/emulation/index.rst | 4

[PATCH 1/1] spl: initialize PCI before booting from MMC

2023-07-24 Thread Heinrich Schuchardt
Some MMC controllers are PCI bus devices. Before calling spl_mmc_load() we must bind the PCI devices. Don't write any warning if pci_init() fails as other MMC controllers don't need it. Signed-off-by: Heinrich Schuchardt --- common/spl/spl_mmc.c | 4 1 file changed, 4 insertion

[PATCH v2 1/1] spl: initialize PCI before booting from MMC

2023-07-24 Thread Heinrich Schuchardt
Some MMC controllers are PCI bus devices. Before calling spl_mmc_load() we must bind the PCI devices. Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese --- v2: Remove empty line at start of code block. Add empty line before return. --- common/spl/spl_mmc.c | 4

Re: [PATCH 1/1] spl: add FIT support to semihosting boot method

2023-07-24 Thread Heinrich Schuchardt
On 24.07.23 17:53, Sean Anderson wrote: On 7/22/23 15:27, Heinrich Schuchardt wrote: Allow loading a FIT image via semihosting in SPL. I had previously attempted this in [1], which is a more general approach. I put together a v4 earlier this year but I got sidetracked before I sent it out

Re: [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI

2023-07-24 Thread Heinrich Schuchardt
On 24.07.23 17:14, Tom Rini wrote: On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote: CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense. Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency. Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable fo

Re: [PATCH v2 1/1] spl: initialize PCI before booting from MMC

2023-07-24 Thread Heinrich Schuchardt
On 24.07.23 17:12, Tom Rini wrote: On Mon, Jul 24, 2023 at 12:33:08PM +0200, Heinrich Schuchardt wrote: Some MMC controllers are PCI bus devices. Before calling spl_mmc_load() we must bind the PCI devices. Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese --- v2: Remove

Re: [PATCH 18/18] riscv: qemu: Enable usb keyboard as an input device

2023-07-24 Thread Heinrich Schuchardt
On 23.07.23 12:11, Mark Kettenis wrote: Date: Sun, 23 Jul 2023 11:30:31 +0200 From: Heinrich Schuchardt Am 23. Juli 2023 10:38:00 MESZ schrieb Mark Kettenis : From: Bin Meng Date: Sun, 23 Jul 2023 12:40:41 +0800 This brings PCI xHCI support to QEMU RISC-V and uses a usb keyboard as one of

[PATCH v2 1/1] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI

2023-07-24 Thread Heinrich Schuchardt
CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense. Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL") Signed-off-by: Heinrich Schuchardt --- v2: Keep CONFIG_SPL_PCI_PNP in drivers/pci/Kconfig Add ' in SPL' to label --- drivers/pci/Kconfig | 3 ++

[PATCH v2 1/1] spl: initialize PCI before booting

2023-07-24 Thread Heinrich Schuchardt
MMC, SATA, and USB may be using PCI based controllers. Initialize the PCI sub-system before trying to boot. Remove the initialization for NVMe that is now redundant. Signed-off-by: Heinrich Schuchardt --- v2: Centralize the PCI initialization --- common/spl/spl.c | 7

[PATCH 1/1] acpi: Add missing RISC-V acpi_table header

2023-07-24 Thread Heinrich Schuchardt
The pci_mmc.c driver can generate ACPI info and therefore includes asm/acpi_table.h. This file does not exist for the RISC-V architecture and thus code compilation fails when using this driver on RISC-V Create an empty include file. Signed-off-by: Heinrich Schuchardt --- arch/riscv/include/asm

[PATCH v2 1/1] spl: spl_legacy: clean up spl_parse_legacy_validate

2023-07-25 Thread Heinrich Schuchardt
ks") Signed-off-by: Heinrich Schuchardt --- v2: consider wrap around fix TPL prefix @Marek: You suggested to carve out a function for memory region overlaps. A function call for two comparisons would increase code size. Introducing LMB for SPL would run into code size limit

Re: [PATCH 1/1] acpi: Add missing RISC-V acpi_table header

2023-07-25 Thread Heinrich Schuchardt
On 7/25/23 04:26, Bin Meng wrote: +Simon, On Tue, Jul 25, 2023 at 9:30 AM Heinrich Schuchardt wrote: The pci_mmc.c driver can generate ACPI info and therefore includes asm/acpi_table.h. This file does not exist for the RISC-V architecture and thus code compilation fails when using this

[PATCH 1/1] riscv: sifive: initialize PCI on Unmatched

2023-07-25 Thread Heinrich Schuchardt
The Unmatched board is typically booted from NVMe which requires PCI. When dropping to a console PCI is not initialized yet. 'pci enum' has to be called. Change the configuration to call pci_init() in board_init_r(). Signed-off-by: Heinrich Schuchardt --- configs/sifive_unmatched

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-25 Thread Heinrich Schuchardt
On 25.07.23 16:51, Simon Glass wrote: On Mon, 24 Jul 2023 at 14:19, Heinrich Schuchardt wrote: MMC, SATA, and USB may be using PCI based controllers. Initialize the PCI sub-system before trying to boot. Remove the initialization for NVMe that is now redundant. Signed-off-by: Heinrich

Re: [PATCH v5 08/12] doc: Add documentation to highlight capsule generation related updates

2023-07-25 Thread Heinrich Schuchardt
On 25.07.23 10:57, Sughosh Ganu wrote: The UEFI capsule can now be generate by specifying the capsule parameters through a config file. Additionally, the capsules can be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu

Re: [PATCH] efi_loader: use well-known guid for auto-created boot option

2023-10-11 Thread Heinrich Schuchardt
Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt --- include/efi_loader.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index c4207edc91..106006127b 100644 --- a/include/efi_loader.h +++ b/include/efi_loa

Re: [PATCH 12/26] fs: Compile in sandbox filesystem in SPL if it is enabled

2023-10-11 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: fs.c thinks that the sandbox filesystem is available if SANDBOX is enabled, but it is not in SPL. Compile it in SPL to avoid linker errors. Signed-off-by: Sean Anderson --- fs/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/Makefile b/

Re: [PATCH 13/26] net: Fix compiling SPL when fastboot is enabled

2023-10-11 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: When fastboot is enabled in U-Boot proper and SPL_NET is enabled, we will try to (unsuccessfully) reference it in SPL. Fix these linker errors by conditioning on SPL_UDP/TCP_FUNCTION_FASTBOOT. Signed-off-by: Sean Anderson --- net/Makefile | 4 ++-- ne

Re: [PATCH 14/26] net: bootp: Move port numbers to header

2023-10-11 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: These defines are useful when testing bootp. Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- net/bootp.c | 3 --- net/bootp.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bootp.c b/net/bootp.c

Re: [PATCH 15/26] net: bootp: Fall back to BOOTP from DHCP when unit testing

2023-10-12 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: If we sent a DHCP packet and get a BOOTP response from the server, we shouldn't try to send a DHCPREQUEST packet, since it won't be DHCPACKed. Transition straight to BIND. This is only enabled for UNIT_TEST to avoid bloat, since I suspect the number of BOOT

Re: [PATCH 16/26] spl: Don't cache devices when UNIT_TEST is enabled

2023-10-12 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: Several SPL functions try to avoid performing initialization twice by caching devices. This is fine for regular boot, but does not work with UNIT_TEST, since all devices are torn down after each test. Disable caching so we don't use stale devices. Signed-o

Re: [PATCH 05/26] arm: imx: Add newlines after error messages

2023-10-12 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: These error messages are missing newlines. Add them. Fixes: 6e81ca220e0 ("imx: parse-container: Use malloc for container processing") Signed-off-by: Sean Anderson --- arch/arm/mach-imx/parse-container.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

Re: [PATCH 07/26] arm: imx: Check header before calling spl_load_imx_container

2023-10-12 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: Make sure we have an IMX header before calling spl_load_imx_container, since if we don't it will fail with -ENOENT. This allows us to fall back to legacy/raw images if they are also enabled. Looking at CONFIG_AHAB_BOOT (related to secure boot) we must be

Re: [PATCH 1/1] i2c: designware_i2c: adjust timing calculation

2023-10-13 Thread Heinrich Schuchardt
On 10/13/23 06:37, Heiko Schocher wrote: Hello Heinrich, On 11.10.23 06:48, Heinrich Schuchardt wrote: In SPL probing of the designware_i2c device on the StarFive VisionFive 2 board fails with dw_i2c: mode 0, ic_clk 100, speed 10, period 10 rise 1 fall 1 tlow 5 thigh 4 spk 0

[PATCH v2] i2c: designware_i2c: adjust timing calculation

2023-10-13 Thread Heinrich Schuchardt
ation") Signed-off-by: Heinrich Schuchardt --- v2: use the same timing offset at Linux provide a descriptive comment for the constant --- drivers/i2c/designware_i2c.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/designware_i2c.c

Pull request efi-2024-01-rc1

2023-10-13 Thread Heinrich Schuchardt
itBlt test ---- Heinrich Schuchardt (1): efi_selftest: BitBlt test Masahisa Kojima (1): efi_loader: use well-known guid for auto-created boot option Paul Barker (1): doc: Migrate Renesas board docs to rst Simon Glass (1): doc: Add a short intro video T

Re: [PATCH v2 12/29] fs: Disable sandbox filesystem in SPL

2023-10-15 Thread Heinrich Schuchardt
Am 14. Oktober 2023 22:47:48 MESZ schrieb Sean Anderson : >Don't bother compiling the sandbox filesystem in SPL for now, as it is not >needed. > >Signed-off-by: Sean Anderson >--- > >Changes in v2: >- Disable sandbox filesystem in SPL instead of compiling it in > > fs/fs.c | 2 +- > 1 file chang

Re: [PATCH v2 16/29] net: bootp: Move port numbers to header

2023-10-15 Thread Heinrich Schuchardt
Am 14. Oktober 2023 22:47:52 MESZ schrieb Sean Anderson : >These defines are useful when testing bootp. > >Signed-off-by: Sean Anderson >Reviewed-by: Simon Glass >Reviewed-by: Heinrich Schuchardt >--- > >(no changes since v1) > > net/bootp.c | 3 --- > net/boo

Re: [PATCH v2 17/29] net: bootp: Fall back to BOOTP from DHCP when unit testing

2023-10-15 Thread Heinrich Schuchardt
Am 14. Oktober 2023 22:47:53 MESZ schrieb Sean Anderson : >If we sent a DHCP packet and get a BOOTP response from the server, we >shouldn't try to send a DHCPREQUEST packet, since it won't be DHCPACKed. >Transition straight to BIND. This is only enabled for UNIT_TEST to avoid >bloat, since I sus

Re: [PATCH v7 4/9] efi_loader: create default file boot option

2023-10-16 Thread Heinrich Schuchardt
Am 16. Oktober 2023 08:45:21 MESZ schrieb Masahisa Kojima : >Current efibootmgr automatically creates the >boot options of all disks and partitions installing >EFI_SIMPLE_FILE_SYSTEM_PROTOCOL. >Some of the automatically created boot options are >useless if the disk and partition does not have >

Re: [PATCH v7 4/9] efi_loader: create default file boot option

2023-10-16 Thread Heinrich Schuchardt
On 16.10.23 14:31, Ilias Apalodimas wrote: Hi Heinrich, On Mon, 16 Oct 2023 at 10:06, Heinrich Schuchardt wrote: Am 16. Oktober 2023 08:45:21 MESZ schrieb Masahisa Kojima : Current efibootmgr automatically creates the boot options of all disks and partitions installing

Re: [PATCH v7 4/9] efi_loader: create default file boot option

2023-10-16 Thread Heinrich Schuchardt
On 16.10.23 15:00, Masahisa Kojima wrote: On Mon, 16 Oct 2023 at 21:46, Heinrich Schuchardt wrote: On 16.10.23 14:31, Ilias Apalodimas wrote: Hi Heinrich, On Mon, 16 Oct 2023 at 10:06, Heinrich Schuchardt wrote: Am 16. Oktober 2023 08:45:21 MESZ schrieb Masahisa Kojima : Current

Re: [PATCH v5 1/6] sysinfo: Add IDs for board id and revision

2023-10-16 Thread Heinrich Schuchardt
On 10/2/23 17:20, Detlev Casanova wrote: These IDs will be used by the sysinfo command. The new IDs are: * SYSINFO_ID_BOARD_ID: The board ID as an integer * SYSINFO_ID_BOARD_REV_MAJOR: The board major revision as int * SYSINFO_ID_BOARD_REV_MINOR: The board minor revision as int Integers w

Re: [PATCH v5 4/6] sysinfo: Add documentation

2023-10-16 Thread Heinrich Schuchardt
On 10/2/23 17:20, Detlev Casanova wrote: Add documentation for the sysinfo command with examples. Reviewed-by: Marek Vasut Signed-off-by: Detlev Casanova --- doc/usage/cmd/sysinfo.rst | 56 +++ Thank you for providing a man-page. Unfortunately this does

Re: [PATCH 9/9] cmd: test_enter_suspend: Add test_enter_suspend command

2023-10-16 Thread Heinrich Schuchardt
On 10/16/23 16:11, Thomas Richard wrote: From: Gregory CLEMENT Add test_enter_suspend command using PSCI. This command is only to test suspend sequence from U-Boot. The resume will not work. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Richard --- cmd/Kconfig | 7 +++

[PATCH 1/1] config: qemu: relax print and console buffer size

2023-10-16 Thread Heinrich Schuchardt
s from the defconfig files and go with the generic defaults. Fixes: d0ee7f295d74 ("Convert CONFIG_SYS_PBSIZE to Kconfig") Fixes: d31466b382dd ("Convert CONFIG_SYS_CBSIZE to Kconfig") Signed-off-by: Heinrich Schuchardt --- configs/qemu-ppce500_defconfig | 1 - configs/qe

[PATCH 1/1] efi_loader: expose the device-tree file name

2023-10-17 Thread Heinrich Schuchardt
approach currently requires to know the device-tree name before first boot which makes it unusable for generic images. Expose the device-tree file name as EFI variable FdtFile. This will allow bootloaders to load a kernel specific device-tree. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader

Re: [PATCH 1/1] efi_loader: expose the device-tree file name

2023-10-17 Thread Heinrich Schuchardt
On 17.10.23 11:14, Ilias Apalodimas wrote: Hi Heinrich, On Tue, 17 Oct 2023 at 11:55, Heinrich Schuchardt <mailto:heinrich.schucha...@canonical.com>> wrote: Forward and backward compatibility of Linux kernel device-trees is sometimes missing. One solution approach is to load

Re: [PATCH 1/1] efi_loader: expose the device-tree file name

2023-10-17 Thread Heinrich Schuchardt
On 17.10.23 11:49, Ilias Apalodimas wrote: On Tue, 17 Oct 2023 at 12:23, Heinrich Schuchardt <mailto:heinrich.schucha...@canonical.com>> wrote: On 17.10.23 11:14, Ilias Apalodimas wrote: > Hi Heinrich, > > On Tue, 17 Oct 2023 at 11:55, H

[PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-17 Thread Heinrich Schuchardt
or if the environment variable fdtfile is not defined. Signed-off-by: Heinrich Schuchardt --- v2: Use a unique GUID to enable future U-Boot independent standardization. Do not try to add the variable on ACPI based systems. --- include/efi_loader.h | 5 + lib

[PATCH] efi_loader: fix efi_bootmgr_enumerate_boot_option

2023-10-17 Thread Heinrich Schuchardt
-drive if=none,file=disk.img,format=raw,id=USB1 \ -device usb-storage,drive=USB1,removable=on Fixes: c416f1c0bcab ("bootmenu: add removable media entries") Fixes: 339b527bd450 ("Move bootorder and bootoption apis to lib") Signed-off-by: Heinrich Schuchardt --- lib/efi_loade

Re: [PATCH v7 4/9] efi_loader: create default file boot option

2023-10-17 Thread Heinrich Schuchardt
On 17.10.23 07:32, Masahisa Kojima wrote: Hi Heinrich, On Mon, 16 Oct 2023 at 23:52, Heinrich Schuchardt wrote: On 16.10.23 15:00, Masahisa Kojima wrote: On Mon, 16 Oct 2023 at 21:46, Heinrich Schuchardt wrote: On 16.10.23 14:31, Ilias Apalodimas wrote: Hi Heinrich, On Mon, 16 Oct 2023

Re: [PATCH 1/1] efi_loader: expose the device-tree file name

2023-10-17 Thread Heinrich Schuchardt
On 17.10.23 17:17, Mark Kettenis wrote: From: Heinrich Schuchardt Date: Tue, 17 Oct 2023 10:55:07 +0200 Forward and backward compatibility of Linux kernel device-trees is sometimes missing. One solution approach is to load a kernel specific device-tree. This can either be done via a U-Boot

Re: [PATCH v7 5/9] efi_loader: support boot from URI device path

2023-10-17 Thread Heinrich Schuchardt
On 16.10.23 08:45, Masahisa Kojima wrote: This supports to boot from the URI device path. When user selects the URI device path, bootmgr downloads the file using wget into the address specified by loadaddr env variable. If the file is .iso or .img file, mount the image with blkmap then try to boo

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-18 Thread Heinrich Schuchardt
On 10/18/23 05:33, Simon Glass wrote: Hi Heinrich, On Tue, 17 Oct 2023 at 07:50, Heinrich Schuchardt wrote: Forward and backward compatibility of Linux kernel device-trees is sometimes missing. One solution approach is to load a kernel specific device-tree. This can either be done via a U

Re: [PATCH v7 4/9] efi_loader: create default file boot option

2023-10-18 Thread Heinrich Schuchardt
, Heinrich Schuchardt wrote: On 16.10.23 15:00, Masahisa Kojima wrote: On Mon, 16 Oct 2023 at 21:46, Heinrich Schuchardt wrote: On 16.10.23 14:31, Ilias Apalodimas wrote: Hi Heinrich, On Mon, 16 Oct 2023 at 10:06, Heinrich Schuchardt wrote: Am 16. Oktober 2023 08:45:21 MESZ schrieb Masahisa

Re: [PATCH v7 6/9] efi_loader: add CDROM short-form device path

2023-10-18 Thread Heinrich Schuchardt
On 10/16/23 08:45, Masahisa Kojima wrote: UEFI specification does not mandate to support the short-form of the CDROM media device path. Fedora installation ISO image is identified as CDROM media device path, supporting short-form CDROM media device path is required to automatically add the boot o

Re: [PATCH] sphinx: Bump urllib3 version

2023-10-18 Thread Heinrich Schuchardt
On 10/18/23 14:33, Tom Rini wrote: While unlikely to be a direct issue for us, urllib3 before 2.0.7 is vulnerable to CVE-2023-45803, so bump our version up. Reported-by: GitHub dependabot Signed-off-by: Tom Rini Reviewed-by: Heinrich Schuchardt --- Cc: Heinrich Schuchardt --- doc

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-18 Thread Heinrich Schuchardt
On 10/17/23 16:09, Tom Rini wrote: On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: Since efi_device_path.c calls eth_get_dev() and assumes that Ethernet is available, add it as an explicit dependency. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new

Re: [PATCH v3 04/32] cmd: Add a few more dependencies on CMDLINE

2023-10-18 Thread Heinrich Schuchardt
On 10/17/23 00:27, Simon Glass wrote: Add this to some more commands to avoid build errors with sandbox. Note that this is a temporary solution to expose more problems. A later patch puts these behind an 'if CMDLINE' Signed-off-by: Simon Glass --- Changes in v3: - Add an explation as to why t

Re: [PATCH v3 06/32] sifive: Drop an unnecessary #ifdef

2023-10-18 Thread Heinrich Schuchardt
On 10/17/23 00:27, Simon Glass wrote: This code is normally compiled for sifive, but sandbox can also compile it. We should not use UNIT_TEST as a synonym for SANDBOX, since it is possible to disable UNIT_TEST for sandbox. Drop the condition since it isn't needed. This is not what the patch do

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-19 Thread Heinrich Schuchardt
On 19.10.23 17:00, Tom Rini wrote: From: Simon Glass The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the same code is built. Signed-off-by: Simon Glass Suggested-by: AKASHI Takahiro --- Cc: Heinrich

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-19 Thread Heinrich Schuchardt
On 19.10.23 17:19, Tom Rini wrote: On Thu, Oct 19, 2023 at 05:16:28PM +0200, Heinrich Schuchardt wrote: On 19.10.23 17:00, Tom Rini wrote: From: Simon Glass The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-19 Thread Heinrich Schuchardt
On 19.10.23 15:55, Simon Glass wrote: Hi Heinrich, On Wed, 18 Oct 2023 at 02:15, Heinrich Schuchardt wrote: On 10/18/23 05:33, Simon Glass wrote: Hi Heinrich, On Tue, 17 Oct 2023 at 07:50, Heinrich Schuchardt wrote: Forward and backward compatibility of Linux kernel device-trees is

Re: [PATCH v13 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-10-19 Thread Heinrich Schuchardt
ed-by: Heinrich Schuchardt --- lib/efi_loader/efi_tcg2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index 7ada536568..dae1b166c8 100644 --- a/lib/efi_loader/efi_tcg2.c +++ b/lib/efi_loader/efi_tcg2.c @@ -949,16 +9

Re: [PATCH v13 6/8] doc: Add measured boot documentation

2023-10-19 Thread Heinrich Schuchardt
On 10/19/23 18:21, Eddie James wrote: Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v12: - Add a bit of detail about OS usage and what pieces are measured doc/usage/index.rst | 1 + doc/usage/meas

Falcon mode on RISC-V

2023-10-19 Thread Heinrich Schuchardt
Hello Randolph, I just saw your patches merged to enable Falcon mode on RISC-V using CONFIG_SPL_LOAD_FIT_OPENSBI_OS_BOOT. I did not see any documentation update. Should information about your development be added to doc/develop/falcon.rst? Would you be willing to provide a patch? Best regards

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-20 Thread Heinrich Schuchardt
On 20.10.23 15:21, Simon Glass wrote: +Doug Anderson Hi Heinrich, On Thu, 19 Oct 2023 at 09:09, Heinrich Schuchardt wrote: On 19.10.23 15:55, Simon Glass wrote: Hi Heinrich, On Wed, 18 Oct 2023 at 02:15, Heinrich Schuchardt wrote: On 10/18/23 05:33, Simon Glass wrote: Hi Heinrich, On

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-21 Thread Heinrich Schuchardt
On 10/21/23 17:42, Simon Glass wrote: Hi Tom, On Fri, 20 Oct 2023 at 09:24, Tom Rini wrote: On Fri, Oct 20, 2023 at 05:40:03PM +0200, Heinrich Schuchardt wrote: On 20.10.23 15:21, Simon Glass wrote: +Doug Anderson Hi Heinrich, On Thu, 19 Oct 2023 at 09:09, Heinrich Schuchardt wrote

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-21 Thread Heinrich Schuchardt
On 10/21/23 20:26, Tom Rini wrote: On Sat, Oct 21, 2023 at 08:43:08AM -0700, Simon Glass wrote: Hi, On Thu, 19 Oct 2023 at 17:30, AKASHI Takahiro wrote: On Thu, Oct 19, 2023 at 08:01:11AM -0600, Simon Glass wrote: Hi Heinrich, On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt wrote: On

[PATCH 1/1] efi_loader: fix efi_dp_from_eth

2023-10-21 Thread Heinrich Schuchardt
figuration check. As the function is exported __maybe_unused can be removed. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c index

[PATCH 1/1] sandbox: eliminate unused functions from binaries

2023-10-21 Thread Heinrich Schuchardt
The sandbox should closely mimic other architectures. Place each function or data in a separate section and let the linker eliminate unused ones. This will reduce the binary size. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/config.mk | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH v3 1/1] efi_loader: expose the device-tree file name

2023-10-22 Thread Heinrich Schuchardt
or if the environment variable fdtfile is not defined. Signed-off-by: Heinrich Schuchardt --- v3: Add documentation v2: Use a unique GUID to enable future U-Boot independent standardization. Do not try to add the variable on ACPI based systems. --- doc/develop/uefi

<    1   2   3   4   5   6   7   8   9   10   >