On 24.07.23 17:14, Tom Rini wrote:
On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote:
CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense.
Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency.
Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL")
Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
---
common/spl/Kconfig | 12 ++++++++++++
drivers/pci/Kconfig | 11 -----------
2 files changed, 12 insertions(+), 11 deletions(-)
Lets not move this out of drivers/pci/Kconfig, just add the dependency.
Hello Tom,
when you configure boot methods you will enable SPL_PCI and with the
patch SPL_PCI_PNP will pop up beneath. If you leave SPL_PCI_PNP in the
old place, you will have a hard time figuring out why yout PCI is not
working.
Why would you prefer to keep SPL_PCI_PNP outside of the SPL menu?
Best regards
Heinrich
