Re: [U-Boot] [PATCH] spl: fix debug print in spl_common_init()

> On 13 Aug 2018, at 11:24, Simon Goldschmidt > wrote: > > spl_common_init() debug-prints "spl_early_init()\n" but it is > called both from spl_early_init() and spl_init(). > > Fix this by moving the debug() statement to the calling functions > which now print their name. > > Signed-off-by: S

Re: [U-Boot] [PATCH] kconfig: fix typo 'parition'

> On 13 Aug 2018, at 11:34, Simon Goldschmidt > wrote: > > %s/parition/partition Make this a whole sentence to make it easier to read. > > Signed-off-by: Simon Goldschmidt Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.d

Re: [U-Boot] [PATCH 3/3] bootcount: add DM-based backing store for bootcount

Lukasz, > On 14 Aug 2018, at 13:10, Lukasz Majewski wrote: > > Hi Philipp, > >> The original bootcount methods do not provide an interface to DM and >> rely on a static configuration for I2C devices (e.g. bus, chip-addr, >> etc. are configured through defines statically). On a modern system >>

Re: [U-Boot] [PATCH 1/3] rtc: rv3029: add to Kconfig

> On 14 Aug 2018, at 18:46, Heinrich Schuchardt wrote: > > On 08/14/2018 11:51 AM, Philipp Tomsich wrote: >> The MicroCrystal RV3029 driver didn't have a Kconfig entry and was not used >> anywhere. Add it to Kconfig to make it selectable. >> >> Signed-off-by: Philipp Tomsich >> Tested-by: Klau

Re: [U-Boot] [PATCH v2] kconfig: fix typo 'parition'

> On 16 Aug 2018, at 09:44, Simon Goldschmidt > wrote: > > Replaced misspelled words "parition"/"paritioning" (missing 't') in two > Kconfig files by correct words "partition"/"partitioning" > > Signed-off-by: Simon Goldschmidt Reviewed-by: Philipp Tomsich _

Re: [U-Boot] [PATCH 3/3] bootcount: add DM-based backing store for bootcount

Simon, > On 17 Aug 2018, at 14:49, Simon Glass wrote: > > Hi Philipp, > > On 14 August 2018 at 05:39, Dr. Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Lukasz, >> >>> On 14 Aug 2018, at 13:10, Lukasz Majewski wr

Re: [U-Boot] [PATCH 3/3] bootcount: add DM-based backing store for bootcount

Simon, > On 23 Aug 2018, at 12:45, Simon Glass wrote: > > Hi Philipp, > > On 17 August 2018 at 06:56, Dr. Philipp Tomsich > wrote: >> Simon, >> >> On 17 Aug 2018, at 14:49, Simon Glass wrote: >> >> Hi Philipp, >> >> On 14 August

Re: [U-Boot] [PATCH 11/25] clk: Allow clock defaults to be set also during re-reloc state

+Kever > On 24 Aug 2018, at 16:12, Tom Rini wrote: > > On Tue, Aug 21, 2018 at 08:01:49PM +0530, Lokesh Vutla wrote: > >> From: Andreas Dannenberg >> >> The earlier commit f4fcba5c5ba ("clk: implement clk_set_defaults()") >> which introduced the functionality for setting clock defaults such a

Re: [U-Boot] [PATCH 11/25] clk: Allow clock defaults to be set also during re-reloc state

> On 24 Aug 2018, at 17:54, Andreas Dannenberg wrote: > > Philipp, > > On Fri, Aug 24, 2018 at 04:42:15PM +0200, Dr. Philipp Tomsich wrote: >> +Kever >> >>> On 24 Aug 2018, at 16:12, Tom Rini wrote: >>> >>> On Tue, Aug 21, 2018 a

Re: [U-Boot] [PATCH] rockchip: dts: fix unnecessary '-cells' warning

> On 28 Aug 2018, at 11:57, Kever Yang wrote: > > Fix warning below: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" > property > > Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists

Re: [U-Boot] [U-Boot, 01/10] rockchip: enable DEBUG_UART_BOARD_INIT by default

Kever, Could you rebase this series to u-boot-rockchip/next and resubmit? I’d like to avoid any issues from manually fixing up git-am issues (as I happened to introduce on last set of UART changes). Thanks, Philipp. > On 29 Aug 2018, at 20:33, Philipp Tomsich > wrote: > >> All Rockchip SoCs

Re: [U-Boot] [PATCH] rockchip: add TPL_TINY_FRAMEWORK support

> On 28 Aug 2018, at 11:23, Kever Yang wrote: > > Rockchip BootRom support load firmware from storage media twice, > one for ddr sdram init code into sram and another time to load > firmware into DDR. For ddr sdram init code(which is TPL in U-Boot > project), it's OK to re-use the stack and vect

Re: [U-Boot] [U-Boot, 1/8] rockchip: add STIMER_BASE for Rockchip SoCs

Kever, [Sorry for the delay, I am switching laptops and this got stuck in my Drafts folder on the old machine — which I noticed only today] > On 3 Sep 2018, at 05:21, Kever Yang wrote: > > Hi Philipp, > > > On 08/30/2018 05:11 PM, Philipp Tomsich wrote: >> >> >> On Wed, 18 Apr 2018, Kever

Re: [U-Boot] [PATCH] cmd: part: use MAX_SEARCH_PARTITIONS for part search

> On 7 Sep 2018, at 11:37, Kever Yang wrote: > > Use Macro instead of hard code. Nitpick: mentioning where the macro is defined (and if it was recently introduced, what commit this references) would be helpful in a cursory review. I just ran a 'git grep’ instead ;-) > Signed-off-by: Kever Ya

Re: [U-Boot] [PATCH] rtc: Add read8 and write8 support to isl1208 driver

> On 31 May 2018, at 20:14, Trent Piepho wrote: > > This can be used for device register access from board code. > > This allows access to capabilities in the RTC chip not abstracted in > U-Boot's RTC class. E.g., device NVRAM or a tamper detection circuit. > > Cc: Klaus Goger > Cc: Philipp

Re: [U-Boot] Exception Level switching seems broken on RK3399

Vincente, > On 1 Jun 2018, at 00:28, Vicente Bergas wrote: > > On Thu, May 24, 2018 at 7:05 PM, Dr. Philipp Tomsich > wrote: >> Vincente, >> >> On 24 May 2018, at 18:48, Vicente Bergas wrote: >> >> Hello Philipp, >> your answer is much appreci

Re: [U-Boot] [PATCH 1/1] rockchip: evb-rk3399: correct README for board bring up

> On 3 Jun 2018, at 16:50, Heinrich Schuchardt wrote: > > %s/rkflashtool/rkdeveloptool/ > > We are using rkdeveloptool not rkflashtool. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Philipp Tomsich Acked-by: Philipp Tomsich ___ U-Boot mail

Re: [U-Boot] [PATCH 1/1] rockchip: rk3399: spl: add missing \n to output

> On 3 Jun 2018, at 21:10, Heinrich Schuchardt wrote: > > Without the patch SPL (in case of an error) creates an output like: > > U-Boot SPL board initMissing DTB > > The patch adds the missing line feed. So now we get: > > U-Boot SPL board init > Missing DTB > > Signed-off

Re: [U-Boot] [PATCH RESEND 1/2] rockchip: make_fit_atf: use elf entry point

Mian, Did you change anything or is this just a resend with the same content? I didn’t have a chance to review this yet, so wanted to make sure I work off the latest version... Thanks, Philipp. > On 8 Jun 2018, at 10:47, Mian Yousaf Kaukab wrote: > > make_fit_atf.py uses physical address of fi

Re: [U-Boot] [PATCH v2 3/3] rockchip: veyron: Set vcc33_sd regulator value

> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > From: Carlo Caione > > On the veyron board the vcc33_sd regulator is used as vmmc-supply for > the SD card. This regulator is powered in the MMC core during power on > but its value is never actually set. > > In the veyron platform the reset

Re: [U-Boot] [PATCH v2 1/3] rk3288: veyron: Init boot-on regulators

> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > From: Carlo Caione > > Use regulators_enable_boot_on() to init all the regulators with > regulator-boot-on property. > > Signed-off-by: Carlo Caione > Reviewed-by: Simon Glass Reviewed-by: Philipp Tomsich Acked-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 2/3] rk3288: Disable JTAG function from sdmmc0 IO

> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > From: Carlo Caione > > The GRF_SOC_CON0.grf_force_jtag bit is automatically set at boot and it > is preventing the SDMMC to work correctly. Disable the JTAG function on > the assumption that a working SD has higher priority over JTAG. > > Si

Re: [U-Boot] [PATCH v2 2/3] rk3288: Disable JTAG function from sdmmc0 IO

On 11 Jun 2018, at 19:08, Carlo Caione wrote: > > On Mon, 2018-06-11 at 10:41 +0200, Dr. Philipp Tomsich wrote: >>> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > /cut >>> +#define GRF_SOC_CON0 0xff770244 >>> #define GRF_SOC_CON2 0xff77024c >> &

Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann wrote: >> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >> to enable the RX delay. >> The MASK was used in a wrong

Re: [U-Boot] [PATCH 0/4] rockchip: Reduce prerequisites from the host

Vicente, > On 18 Jun 2018, at 22:07, Vicente Bergas wrote: > > On Wed, 13 Jun 2018 11:51:13 +0800, kever.yang at rock-chips.com wrote: >> (snip) >> I just not understand why remove the dependency on python is so important, >> there already many modules depend on python. > > On Wed, 13 Jun 2018

Re: [U-Boot] [PATCH v2 1/6] dm: SMEM (Shared memory) uclass

> On 22 Jun 2018, at 04:11, Ramon Fried wrote: > > This is a uclass for Shared memory manager drivers. > > A Shared Memory Manager driver implements an interface for allocating > and accessing items in the memory area shared among all of the > processors. > > Signed-off-by: Ramon Fried Revie

Re: [U-Boot] [PATCH 2/2] arm: timer: sunxi: add Allwinner timer erratum workaround

> On 27 Jun 2018, at 02:42, Andre Przywara wrote: > > The Allwinner A64 SoCs suffers from an arch timer implementation erratum, > where sometimes the lower 11 bits of the counter value erroneously > become all 0's or all 1's [1]. This leads to sudden jumps, both forwards and > backwards, with th

Re: [U-Boot] build fail due to dependence error

Kever, is the link for ‘asm’ set up correctly? Thanks, Philipp. > On 28 Jun 2018, at 10:38, Kever Yang wrote: > > Hi Simon, > > Do you have any idea about this error? > > CC lib/asm-offsets.s > CC arch/arm/lib/asm-offsets.s > fixdep: error opening config file: arch/arm/in

Re: [U-Boot] build fail due to dependence error

Glass wrote: >> Hi, >> >> On 28 June 2018 at 01:41, Dr. Philipp Tomsich >> wrote: >>> Kever, >>> >>> is the link for ‘asm’ set up correctly? >>> >>> Thanks, >>> Philipp. >>> >>> On 28 Jun 2018, at 10

Re: [U-Boot] build fail due to dependence error

9 GMT+09:00 Simon Glass : >>> +Masahiro who might know >>> >>> On 2 July 2018 at 01:23, Dr. Philipp Tomsich >>> wrote: >>>> Kever, >>>> >>>> Could you check the build artifacts in Jenkins to see whether after >>>> the ‘m

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 10 Jul 2018, at 16:41, Simon Glass wrote: > > Hi, > > On 8 May 2018 at 04:21, Dr. Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Marty, >> >>> On 8 May 2018, at 02:52, Marty E. Plummer wrote: >>>

Re: [U-Boot] [PATCH 1/1] rockchip: rk3399: spl: add missing \n to output

at 19:28, Dr. Philipp Tomsich > wrote: >> >>> On 3 Jun 2018, at 21:10, Heinrich Schuchardt wrote: >>> >>> Without the patch SPL (in case of an error) creates an output like: >>> >>> U-Boot SPL board initMissing DTB >>> >&g

Re: [U-Boot] [PATCH v3 4/4] rk3288: Convert register defines to const uintptr_t

> On 9 Jul 2018, at 05:05, Simon Glass wrote: > > On 11 June 2018 at 13:00, Carlo Caione wrote: >> From: Carlo Caione >> >> No functional change but at least we can now guarantee type safety. >> >> Signed-off-by: Carlo Caione >> --- >> arch/arm/mach-rockchip/rk3288-board.c | 5 ++--- >> 1 fi

Re: [U-Boot] [PATCH 2/3] rockchip: add support for veyron-speedy (ASUS Chromebook C201)

> On 7 May 2018, at 02:20, Marty E. Plummer wrote: > > On Mon, May 07, 2018 at 12:12:54AM +0200, klaus.go...@theobroma-systems.com > wrote: >> >>> On 06.05.2018, at 16:25, Marty E. Plummer wrote: >>> >>> This adds support for the ASUS C201, a RK3288

Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

Joe, > On 14 Jun 2018, at 20:26, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich > wrote: >> >>> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: >>> >>> On Thu, Jun 14, 2018 at 4:48 AM, Jan

Re: [U-Boot] [PATCH] sysreset: Add support for gpio-restart

> On 13 Jul 2018, at 11:15, Michal Simek wrote: > > The Linux kernel has binding for gpio-restart node. > This patch is adding basic support without supporting any optional > properties. Nice. This may also give us an opportunity to streamline some of the reset logic (and the FDT-interface to t

[U-Boot] CONFIG_SPL_TINY_MEMSET for configs/smartweb_defconfig?

Heiko, I have a SPL change assigned in my queue that breaks the smartweb config due to increasing SPL by a few bytes of extra code. I’d like to enable CONFIG_SPL_TINY_MEMSET in configs/smartweb_defconfig to fix this. If this is ok with you, I’ll submit a patch against the defconfing and then

Re: [U-Boot] [PATCH v2 01/11] arch: arm: mach-rockchip: rk3288: Enable regulators in board_init

Janine, > On 18 Jul 2018, at 10:46, Janine Hagemann wrote: > > At start-up, the regulators have to be enabled. Let's use > regulators_enable_boot_on() to enable the regulators needed > for boot. > > Signed-off-by: Wadim Egorov > Signed-off-by: Janine Hagemann An equivalent change from Carlo

Re: [U-Boot] [U-Boot, 3/3] rockchip: rk3399: Add more instructions to the README

Thanks for the clarification, I’ll take this as-is. > On 20 Jul 2018, at 19:09, Ezequiel Garcia wrote: > > On Fri, 2018-07-20 at 18:28 +0200, Philipp Tomsich wrote: >> >> On Mon, 16 Jul 2018, Ezequiel Garcia wrote: >> >>> This commit adds a content section and also instructions >>> on how to c

Re: [U-Boot] [U-Boot, 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

> On 20 Jul 2018, at 19:14, Ezequiel Garcia wrote: > > On Fri, 2018-07-20 at 18:26 +0200, Philipp Tomsich wrote: >> >> On Mon, 16 Jul 2018, Ezequiel Garcia wrote: >> >>> From: Randy Li >>> >>> Those pins would be used by many boards. >> >> The Rockchip pinctrl driver in U-Boot does not (yet

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, The first batch of changes for u-boot-rockchip/master in this iteration is ready for you to pull. The associated Travis report (prior to the rebase) is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406299101 Thanks, Philipp. The following changes since commit 0dd1fc09bb

Re: [U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

Ezequiel, This series breaks the build (see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695). Did you test with Travis prior to submitting? When you revise, I’d also prefer a ‘rockchip:’ and a ‘board:’ tag over the ARM tag … Thanks, Philipp. > On 20 Jul 2018, at 19:30, Philip

Re: [U-Boot] [PATCH 2/3] rockchip: add support for veyron-speedy (ASUS Chromebook C201)

> On 24 Jul 2018, at 07:12, Marty E. Plummer wrote: > > On Fri, Jul 13, 2018 at 12:31:49PM +0200, Dr. Philipp Tomsich wrote: >> >>> On 7 May 2018, at 02:20, Marty E. Plummer wrote: >>> >>> On Mon, May 07, 2018 at 12:12:54AM +0200, klaus.go...@t

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Marty, > On 6 Jul 2018, at 05:11, Marty E. Plummer wrote: > > On Sat, May 19, 2018 at 02:08:53PM +0200, Dr. Philipp Tomsich wrote: >> Marty, >> >>> On 19 May 2018, at 12:40, Marty E. Plummer wrote: >>> >>> So explain to me what you'd lik

Re: [U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

Ezequiel, > On 25 Jul 2018, at 22:31, Ezequiel Garcia wrote: > > On Sat, 2018-07-21 at 16:23 +0200, Dr. Philipp Tomsich wrote: >> Ezequiel, >> >> This series breaks the build (see >> https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695). >

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 26 Jul 2018, at 22:05, Carlo Caione wrote: > > On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >> The calculation in `rockchip_sdram_size` would overflow for 4GB on >> 32bit systems (i.e. when PHYS_64BIT is not defined). >> >> This makes the internal variables and the signature p

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 26 Jul 2018, at 22:05, Carlo Caione wrote: > > On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >> The calculation in `rockchip_sdram_size` would overflow for 4GB on >> 32bit systems (i.e. when PHYS_64BIT is not defined). >> >> This makes the internal variables and the signature p

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 26 Jul 2018, at 22:05, Carlo Caione wrote: > > On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >> The calculation in `rockchip_sdram_size` would overflow for 4GB on >> 32bit systems (i.e. when PHYS_64BIT is not defined). >> >> This makes the internal variables and the signature p

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 27 Jul 2018, at 09:50, Carlo Caione wrote: > > On Fri, 2018-07-27 at 00:54 +0200, Dr. Philipp Tomsich wrote: >>> On 26 Jul 2018, at 22:05, Carlo Caione wrote: >>> >>> On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >>>> The cal

Re: [U-Boot] [PATCH] board_f: drop 'dead code' in ram_top computation

> On 27 Jul 2018, at 11:16, Philipp Tomsich > wrote: > > gd->ram_top is assigned to twice on consecutive lines and the compiler > won't be able to tell that the first assignment is dead (including its > r-value) due to the r-value containing a (side-effect free) function > call. > > This drops

Re: [U-Boot] [PATCH 1/9] dm: allow 4GB of DRAM on 32bit systems

> On 2 Aug 2018, at 22:36, Simon Glass wrote: > > On 26 July 2018 at 07:59, Philipp Tomsich > > wrote: >> Even on 32bit systems a full 4GB of DRAM may be installed and reported >> by the DRAM controller. Whether these 4GB are larger available >> de

Re: [U-Boot] [PATCH v2 2/6] dm: core: Allow multiple drivers to bind for a single node

Hi Simon, > On 03 Mar 2017, at 05:52, Simon Glass wrote: > > Hi Philipp, > > On 22 February 2017 at 13:47, Philipp Tomsich > > wrote: >> Currently, driver binding stops once it encounters the first >> compatible driver that doesn't refuse to bind.

Re: [U-Boot] [PATCH v3 0/9] sunxi: DM-based CLK, RESET and PINCTRL

Andre, > On 06 Mar 2017, at 03:08, André Przywara wrote: > > On 01/03/17 21:19, Philipp Tomsich wrote: >> Hi everyone, >> >> here's the the new version of CLK, RESET and PINCTRL drivers to >> configure sunxi from the device-tree. This adds support for the >> upstream CCU node (for reset and pi

Re: [U-Boot] [PATCH 00/17] SPL: extend FIT loading support

Reviewed-by: Philipp Tomsich > On 01 Mar 2017, at 03:25, Andre Przywara wrote: > > This is an updated and slightly extended version of the SPL FIT loading > series I posted as an RFC some weeks ago. > I tried to fix all bugs that have been pointed out by the diligent > reviewers, also added pat

Re: [U-Boot] [PATCH 5/8] sunxi: Add selective DRAM type and timing

> On 15 Mar 2017, at 01:42, André Przywara wrote: > > On 11/03/17 16:19, Icenowy Zheng wrote: >> DRAM chip varies, and one code cannot satisfy all DRAMs. >> >> Add options to select a timing set. >> >> Currently only DDR3-1333 (the original set) is added into it. > > Yes, separating the timin

Re: [U-Boot] [PATCH 6/6] dts: rk3399-puma: add gmac for the RK3399-Q7

Simon, > On 26 Mar 2017, at 05:48, Simon Glass wrote: > > Hi Philipp, > > On 24 March 2017 at 12:24, Philipp Tomsich > wrote: >> This change enables the Gigabit Ethernet support on the RK3399-Q7. >> >> X-AffectedPlatforms: RK3399-Q7 >> Signed-off-by: Philipp Tomsich >> --- >> >> arch/arm/dt

Re: [U-Boot] [PATCH v2 1/2] rockchip: rk3399: spl: add UART0 support for SPL

Simon, you’ll need CONFIG_DEBUG_UART_BOARD_INIT=y as include/debug_uart.h checks this macro and either defines this function inline (with an empty body) or allows the function definition. Seems like everyone just adds this to their defconfig (as did we), but I am open towards an automat

Re: [U-Boot] [PATCH v2] rockchip: mmc: rk3399: work around DMA issue in SPL

Kever, we didn’t have time to track this down yet, so we’ve put this work-around in place to be reverted once we isolate this issue. The problem goes away once ATF is running in EL3 and U-Boot executes in its normal privilege level… so our guess is that it’s either an issue with running in EL3 or

Re: [U-Boot] [PATCH v2] rockchip: mmc: rk3399: work around DMA issue in SPL

initialisation for some of the security registers into arch/arm/mach-rockchip/rk3399-board-spl.c … Regards, Philipp. > On 29 Mar 2017, at 09:51, Dr. Philipp Tomsich > wrote: > > Kever, > > we didn’t have time to track this down yet, so we’ve put this work-around > in place to be rev

Re: [U-Boot] [PATCH v3 05/19] SPL: FIT: allow loading multiple images

> On 03 Apr 2017, at 12:05, Andre Przywara wrote: > > On 03/04/17 10:40, Lukasz Majewski wrote: >> Hi Andre , >> >>> So far we were not using the FIT image format to its full potential: >>> The SPL FIT loader was just loading the first image from the /images >>> node plus one of the listed DTBs

Re: [U-Boot] [PATCH] usb: dwc3: gadget: make cache-maintenance on event buffers more robust

> On 04 Apr 2017, at 18:15, Marek Vasut wrote: > > On 04/03/2017 07:49 PM, Philipp Tomsich wrote: >> Merely using dma_alloc_coherent does not ensure that there is no stale >> data left in the caches for the allocated DMA buffer (i.e. that the >> affected cacheline may still be dirty). >> >> The

Re: [U-Boot] [PATCH] usb: dwc3: gadget: make cache-maintenance on event buffers more robust

> On 04 Apr 2017, at 21:01, Marek Vasut wrote: > >> Good point on the “long”, especially as I just copied this from other >> occurrences and it’s consistently wrong throughout DWC3 in U-Boot: > > Hrm, I thought the driver was ported over from Linux, so is this broken > in Linux too ? Apparent

Re: [U-Boot] [PATCH] usb: dwc3: gadget: make cache-maintenance on event buffers more robust

> On 04 Apr 2017, at 22:09, Marek Vasut wrote: > >> The DWC3 flush expands to a clean+invalidate. It is not wrong, as long as >> it is used as in my patch: >> a. before the first time data is expected to be written by the peripheral >> (i.e. >> before the peripheral is started)—to ensure that t

Re: [U-Boot] [PATCH] usb: dwc3: gadget: make cache-maintenance on event buffers more robust

Felipe, > On 05 Apr 2017, at 10:18, Felipe Balbi wrote: > >>> Good point on the “long”, especially as I just copied this from other >>> occurences and it’s consistently wrong throughout DWC3 in U-Boot: >> >> Hrm, I thought the driver was ported over from Linux, so is this broken >> in Linux to

Re: [U-Boot] [PATCH] usb: dwc3: gadget: make cache-maintenance on event buffers more robust

> On 05 Apr 2017, at 12:25, Marek Vasut wrote: > > On 04/04/2017 10:26 PM, Dr. Philipp Tomsich wrote: >> >>> On 04 Apr 2017, at 22:09, Marek Vasut wrote: >>> >>>> The DWC3 flush expands to a clean+invalidate. It is not wrong, as long as >&

Re: [U-Boot] [PATCH v2 14/18] sunxi: Pine64: defconfig: enable SPL FIT support

> On 29/03/17 07:57, Maxime Ripard wrote: >> On Tue, Mar 28, 2017 at 01:45:22AM +0100, Andre Przywara wrote: >>> The Pine64 (and all other 64-bit Allwinner boards) need to load an >>> ARM Trusted Firmware image beside the actual U-Boot proper. >>> This can now be easily achieved by using the just e

Re: [U-Boot] [PATCH v1 1/2] sunxi (sun50i): support i2c on A64 (pin-config, clocking)

> On 18 Feb 2017, at 02:15, André Przywara wrote: > >> diff --git a/board/sunxi/board.c b/board/sunxi/board.c >> index bba9b7c..a47b113 100644 >> --- a/board/sunxi/board.c >> +++ b/board/sunxi/board.c >> @@ -485,90 +485,108 @@ int board_mmc_init(bd_t *bis) >> void i2c_init_board(void) >> { >> #i

Re: [U-Boot] [PATCH v1] env_mmc: configure environment offsets via device tree

Igor, > On 19 Feb 2017, at 12:52, Igor Grinberg wrote: > > On 02/17/17 19:28, Philipp Tomsich wrote: >> This introduces the ability to override the environment offets from the >> device tree by setting the following nodes in '/config': >> 'u-boot,mmc-env-offset' - overrides CONFIG_ENV_OFFSE

Re: [U-Boot] [PATCH v1] sunxi: improve throughput in the sunxi_mmc driver

> On 20 Feb 2017, at 07:16, Chen-Yu Tsai wrote: > > On Mon, Feb 20, 2017 at 6:08 AM, Jaehoon Chung > wrote: >> Hi, >> >> On 02/18/2017 02:22 AM, Philipp Tomsich wrote: >>> Throughput tests have shown the sunxi_mmc driver to take over 10s to >>> read 10MB from a f

Re: [U-Boot] [PATCH v1] env_mmc: configure environment offsets via device tree

> On 20 Feb 2017, at 08:22, Igor Grinberg wrote: > >>> That sounds too odd... >>> DT's purpose is to describe the h/w... and that does not look so... >>> We also, have a dt file name in the environment, so this creates will create >>> a chicken and an egg problem… >> >> I don’t really follow… a

Re: [U-Boot] [PATCH v1 1/2] sunxi (sun50i): support i2c on A64 (pin-config, clocking)

> On 20 Feb 2017, at 11:18, Andre Przywara wrote: > >> Our board’s early-stage normally shouldn't need to do anything on this I2C >> bus, but customer boards may come up with a use for it (image this going >> towards battery/power managing circuitry on a baseboard). > > In this case we should d

Re: [U-Boot] [PATCH v1 02/11] sunxi: add pinctrl (UCLASS_PINCTRL) support for sunxi and tie back into GPIO

Chen, > On 21 Feb 2017, at 04:48, Chen-Yu Tsai wrote: > > On Sat, Feb 18, 2017 at 1:52 AM, Philipp Tomsich > > wrote: >> This change adds a full device-model pinctrl driver for sunxi (tested with >> sun50iw1p1) based on the support available in Linu

Re: [U-Boot] [PATCH v1 0/2] disk: efi: allow gap before partition entries

Maxime, > On 21 Feb 2017, at 18:45, Maxime Ripard > wrote: > > Hi Philipp, > > On Fri, Feb 17, 2017 at 06:31:29PM +0100, Philipp Tomsich wrote: >> Motivated by the the SPL layout for SD/MMC devices on Allwinner SoCs >> (the SPL code needs to reside an 8K offset into the device), we add >> supp

Re: [U-Boot] [PATCH v1] sunxi: improve throughput in the sunxi_mmc driver

> On 21 Feb 2017, at 19:00, Maxime Ripard > wrote: > > On Fri, Feb 17, 2017 at 06:22:45PM +0100, Philipp Tomsich wrote: >> Throughput tests have shown the sunxi_mmc driver to take over 10s to >> read 10MB from a fast eMMC device due to excessive delays in polling >> loops. >> >> This commit re

Re: [U-Boot] [PATCH v1] sun8i_emac: configure PHY reset GPIO via DM

> On 21 Feb 2017, at 18:57, Maxime Ripard > wrote: > > On Fri, Feb 17, 2017 at 06:42:42PM +0100, Philipp Tomsich wrote: >> This ports the support for configuring a GPIO for resetting the >> Ethernet PHY (incl. such details as the reset polarity and >> pulse-length) from the Designware driver. >

Re: [U-Boot] [PATCH v1 0/2] disk: efi: allow gap before partition entries

> On 21 Feb 2017, at 18:45, Maxime Ripard > wrote: > > However, I'm a bit skeptical on the /config node. First, this node > doesn't exist at all, and needs to be documented and acked by the DT > maintainers. And why would one need to change that per device? What’s the consensus on this: remove

Re: [U-Boot] [PATCH v1] sunxi: improve throughput in the sunxi_mmc driver

> On 21 Feb 2017, at 19:11, Dr. Philipp Tomsich > wrote: > > We’ve never seen performance problems on Linux and benchmarked at > up to ~50MByte/s on the A31-uQ7. I dug into our disti training slides from early 2015—looks like the throughput number (sustained) for the eMMC was

Re: [U-Boot] [PATCH v1 2/2] sun8i: enable support for the Micrel KSZ9031 with SUN8I_EMAC

Maxime, > On 21 Feb 2017, at 20:56, Maxime Ripard > wrote: > > On Fri, Feb 17, 2017 at 06:47:55PM +0100, Philipp Tomsich wrote: >> #ifdef CONFIG_SUN8I_EMAC >> #define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY >> */ >> +#define CONFIG_PHY_MICREL >> +#define CONFIG_PHY

Re: [U-Boot] [PATCH v1 1/2] sun8i: define CONFIG_PHY_GIGE for EMAC

On 21 Feb 2017, at 20:55, Maxime Ripard wrote: > > On Fri, Feb 17, 2017 at 06:47:54PM +0100, Philipp Tomsich wrote: >> +#ifdef CONFIG_SUN8I_EMAC >> +#define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY >> */ >> +#endif > > It would make more sense to move that option to

Re: [U-Boot] [PATCH v1 02/11] sunxi: add pinctrl (UCLASS_PINCTRL) support for sunxi and tie back into GPIO

ChenYu, > On 22 Feb 2017, at 07:07, Chen-Yu Tsai wrote: > >> (b) binding the existing gpio driver to the same node (but as the driverdata >> needs to be matched as well, we’d need to select this based on the >> compatible string and have a tighter coupling between the drivers than >> strictly ne

Re: [U-Boot] [PATCH v1 0/2] disk: efi: allow gap before partition entries

> On 22 Feb 2017, at 07:11, Rask Ingemann Lambertsen wrote: > > On Fri, Feb 17, 2017 at 06:31:29PM +0100, Philipp Tomsich wrote: >> Motivated by the the SPL layout for SD/MMC devices on Allwinner SoCs >> (the SPL code needs to reside an 8K offset into the device), we add >> support for leaving a

Re: [U-Boot] [PATCH v1 2/2] sun8i: enable support for the Micrel KSZ9031 with SUN8I_EMAC

Maxime, > On 21 Feb 2017, at 21:35, Dr. Philipp Tomsich > wrote: > > Maxime, > >> On 21 Feb 2017, at 20:56, Maxime Ripard >> wrote: >> >> On Fri, Feb 17, 2017 at 06:47:55PM +0100, Philipp Tomsich wrote: >>> #ifdef CONFIG_SUN8I_EMAC >>

Re: [U-Boot] [PATCH v1 1/2] sun8i: define CONFIG_PHY_GIGE for EMAC

> On 22 Feb 2017, at 18:18, Maxime Ripard > wrote: > > On Tue, Feb 21, 2017 at 09:37:14PM +0100, Dr. Philipp Tomsich wrote: >> On 21 Feb 2017, at 20:55, Maxime Ripard >> wrote: >>> >>> On Fri, Feb 17, 2017 at 06:47:54PM +0100, Philipp Tom

Re: [U-Boot] [PATCH v1] sunxi: improve throughput in the sunxi_mmc driver

> On 22 Feb 2017, at 18:22, Maxime Ripard > wrote: > > On Tue, Feb 21, 2017 at 07:34:40PM +0100, Dr. Philipp Tomsich wrote: >> >>> On 21 Feb 2017, at 19:11, Dr. Philipp Tomsich >>> wrote: >>> >>> We’ve never seen performance problems o

Re: [U-Boot] [PATCH v1 2/2] sun8i: enable support for the Micrel KSZ9031 with SUN8I_EMAC

Maxime, > On 22 Feb 2017, at 20:00, Maxime Ripard > wrote: > > On Wed, Feb 22, 2017 at 03:45:41PM +0100, Dr. Philipp Tomsich wrote: >> Maxime, >> >>> On 21 Feb 2017, at 21:35, Dr. Philipp Tomsich >>> wrote: >>> >>> Maxime, &g

Re: [U-Boot] [PATCH v2 6/6] sun50i: dts: update DTS to avoid warnings

> On 23 Feb 2017, at 00:20, Maxime Ripard > wrote: > > On Wed, Feb 22, 2017 at 09:47:32PM +0100, Philipp Tomsich wrote: >> +<<< HEAD >> allwinner,drive = ; >> allwinner,pull = ; >> +=== >> +drive-stren

Re: [U-Boot] [PATCH v3] armv8: spl: Call spl_relocate_stack_gd for ARMv8

Simon, > On 23 Feb 2017, at 03:23, Simon Glass wrote: > > On 22 February 2017 at 11:01, Philipp Tomsich > > wrote: >> As part of the startup process for boards using the SPL, we need to >> call spl_relocate_stack_gd. This is needed to set up malloc

Re: [U-Boot] [PATCH v1] spi: sunxi_spi: Add DM SPI driver for A31/A80/A64

Jagan, > On 25 Feb 2017, at 09:43, Jagan Teki wrote: > >> +/* The SPI flash opcode for a FAST READ DUAL OUTPUT operation. */ >> +#define CMD_READ_DUAL_OUTPUT_FAST 0x3b > > Flash(slave) specific opcodes shouldn't use it on spi driver, try to > implement the spi in generic way instead of making t

Re: [U-Boot] [PATCH v8 4/8] rockchip: configs: rk3328: enable dwc2 driver and config fastboot

> On 28 Jun 2017, at 13:22, Meng Dongyang wrote: > > Config dwc2 driver support host and gadget function. Add support > of fastboot function. > > Signed-off-by: Meng Dongyang > Acked-by: Philipp Tomsich Reviewed-by: Philipp Tomsich I’ll migrate the remaining uses of CONFIG_USB_DWC2, when I

Re: [U-Boot] [PATCH 0/5] fix the boot issue of Rockchip RK3036

> Hi Philipp: >> >> >> On 2017年06月30日 16:14, Dr. Philipp Tomsich wrote: >>> Andy, >>> >>>> On 30 Jun 2017, at 09:47, Andy Yan wrote: >>>> >>>> >>>> As Kever mentioned in [0], the RK3036 based boards could't >&g

Re: [U-Boot] [PATCH 1/2] armv8: apply -mgeneral-regs-only

Tom, Please note that some GCC versions had a code-generation bug when -mgeneral-regs-only was used (we hit this for a customer in a vendor GCC we maintain): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64304 Until everyone upgrades to a recently recent GCC (or until UBoot enforces this n

Re: [U-Boot] [PATCH 1/2] armv8: apply -mgeneral-regs-only

> On 05 Jul 2017, at 03:23, Peng Fan wrote: > > > >> -Original Message- >> From: Tom Rini [mailto:tr...@konsulko.com] >> Sent: Wednesday, July 05, 2017 3:38 AM >> To: Dr. Philipp Tomsich >> Cc: Peng Fan ; u-boot@lists.denx.de >>

Re: [U-Boot] [PATCH 1/2] armv8: apply -mgeneral-regs-only

> On 05 Jul 2017, at 10:59, Peng Fan wrote: > >> I just tested the “armv8-a+nosimd” specification on (configured as aarch64-*- >> linux-gnueabi) 4.9.1, 4.9.3, 5.4.0, 6.3.0 and (configured as aarch64-*-elf) >> 6.3.0 >> and 7.1.0… …unfortunately this was all that I could find installed on our >>

Re: [U-Boot] [PATCH] net: gmac_rockchip: Add support for pinctrl

> On 10 Jul 2017, at 08:43, Romain Perier wrote: > > Le 07/07/2017 à 05:58, Simon Glass a écrit : >> +Philipp >> >> Hi Romain, >> >> On 3 July 2017 at 01:13, Romain Perier wrote: >>> Currently, selecting state simple is done by the device driver model, >>> prior probing the driver. The proble

Re: [U-Boot] [PATCH] net: gmac_rockchip: Add support for pinctrl

> On 07 Jul 2017, at 05:58, Simon Glass wrote: > > +Philipp > > Hi Romain, > > On 3 July 2017 at 01:13, Romain Perier wrote: >> Currently, selecting state simple is done by the device driver model, >> prior probing the driver. The problem is that it's done and called on >> the pinctrl node wi

Re: [U-Boot] Data Abort with gcc 7.1

Maxime, > On 11 Jul 2017, at 18:59, Tom Rini wrote: > > On Tue, Jul 11, 2017 at 06:54:55PM +0200, Maxime Ripard wrote: >> Hi, >> >> I recently got a gcc 7.1 based toolchain, and it seems like it >> generates unaligned code, specifically in the net_set_ip_header >> function in my case. >> >> Wh

[U-Boot] Pull request: u-boot-rockchip/master

Tom, With the new merge window open, I’d like to sync some of changes accumulated for Rockchip. Please pull into u-boot/master. Thanks! Thanks, Phil. The following changes since commit d85ca029f257b53a96da6c2fb421e78a003a9943: Prepare v2017.07 (2017-07-10 13:07:38 -0400) are available in th

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

> On 12 Jul 2017, at 16:34, Maxime Ripard > wrote: > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating > unaligned accesses (obviously) will only do so on packed structures. > > It seems like gcc 7.1 is a bit stricter than previous gcc versions on this, > and using it

Re: [U-Boot] Data Abort with gcc 7.1

> On 12 Jul 2017, at 16:34, Tom Rini wrote: > > On Wed, Jul 12, 2017 at 04:20:52PM +0200, Maxime Ripard wrote: >> On Tue, Jul 11, 2017 at 07:59:21PM +0200, Dr. Philipp Tomsich wrote: >>> Maxime, >>> >>>> On 11 Jul 2017, at 18:59, Tom Rini wrote:

Re: [U-Boot] Data Abort with gcc 7.1

Tom & Maxime, > On 12 Jul 2017, at 16:34, Tom Rini wrote: > > On Wed, Jul 12, 2017 at 04:20:52PM +0200, Maxime Ripard wrote: >> On Tue, Jul 11, 2017 at 07:59:21PM +0200, Dr. Philipp Tomsich wrote: >>> Maxime, >>> >>>> On 11 Jul 2017, at 18:59,

  1   2   3   4   5   6   >