Maxime, > On 21 Feb 2017, at 21:35, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > Maxime, > >> On 21 Feb 2017, at 20:56, Maxime Ripard <maxime.rip...@free-electrons.com> >> wrote: >> >> On Fri, Feb 17, 2017 at 06:47:55PM +0100, Philipp Tomsich wrote: >>> #ifdef CONFIG_SUN8I_EMAC >>> #define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY >>> */ >>> +#define CONFIG_PHY_MICREL >>> +#define CONFIG_PHY_MICREL_KSZ9031 /* used on A64-uQ7 */ >>> #endif >> >> Same thing here, and that way you could enable it only on the board >> defconfig.
I’d really like to keep this for all SUN8I_EMAC configurations, as we need the PHY support to initialise the pad timing parameters from the DTS. If these are not initialised, then RGMII (i.e. Gigabit) will not work. As we are moving towards a ‘universal’ U-Boot binary for sun50i and try to put all board specific info into the DTS, I’d like to keep this in sunxi-common.h to ensure that nobody rebuild without it and then has issues on our boards. Regards, Philipp. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot