[PATCH] usb: kbd: Add probe quirk for some generic USB mini keyboard

2024-06-07 Thread Dang Huynh
213" It's not known if those generic USB mini keyboard has the same VID/PID. Signed-off-by: Dang Huynh --- common/usb_kbd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/usb_kbd.c b/common/usb_kbd.c index 820f591fc5..d6451ba7c2 100644 --- a/common/usb_kbd.c +++ b/commo

Re: [PATCH 05/10] video: rockchip: Add VOP2 support

2025-01-19 Thread Dang Huynh
Hi Andy, On Sunday, January 19, 2025 9:10:10 AM UTC Andy Yan wrote: > Hi Danq, > > Do you have tests with this u-boot video enabled then boot a linux kernel > also with drm display enabled? > Yes, I booted Linux with U-Boot VOP2 and Linux VOP2 enabled without any problem. > Because the u-boot v

Re: [PATCH 10/10] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-01-19 Thread Dang Huynh
Hi Jonas, On Sunday, January 19, 2025 2:08:37 PM UTC Jonas Karlman wrote: > Hi Dang, > > On 2025-01-16 10:15, Dang Huynh wrote: > > +CONFIG_CLK_CCF=y > > +CONFIG_CLK_COMPOSITE_CCF=y > > Is CCF and COMPOSITE_CCF needed? Yes, it's required to turn on and set

[PATCH 01/10] video: rockchip: dw-mipi-dsi: Depend on CONFIG_VIDEO_BRIDGE

2025-01-16 Thread Dang Huynh
The driver is in video bridge class, so we must depend on it or the driver will fail to init. Signed-off-by: Dang Huynh --- drivers/video/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/Kconfig b/drivers/video/rockchip/Kconfig index

[PATCH 00/10] Rockchip VOP2 support

2025-01-16 Thread Dang Huynh
This series adds VOP2 support to U-Boot and enable it for PineTab2. HDMI should work flawlessly but there's still some timings issue with DW MIPI DSI, perhaps that's something to look into later. Signed-off-by: Dang Huynh --- Dang Huynh (8): video: rockchip: dw-mipi-dsi:

[PATCH 05/10] video: rockchip: Add VOP2 support

2025-01-16 Thread Dang Huynh
VOP2 (Video Output Processor v2) is a display controller on Rockchip SoCs. It can be found on RK3566/8 and RK3588. This commit currently only supports RK3566/8. Signed-off-by: Dang Huynh --- arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 249 + drivers/video/rockchip/Makefile

[PATCH 03/10] video: rockchip: dw_mipi_dsi: Proceed when external PHY is not defined

2025-01-16 Thread Dang Huynh
From: Ondrej Jirman In this case the DM returns ENOENT, not ENODATA. Signed-off-by: Ondrej Jirman Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/dw_mipi_dsi_rockchip.c b

[PATCH 04/10] video: Add BOE TH101MB31IG002-28A MIPI-DSI panel

2025-01-16 Thread Dang Huynh
BOE TH101MB31IG002-28A is a MIPI-DSI panel used in the Pine64 PineTab2. Signed-off-by: Dang Huynh --- drivers/video/Kconfig | 10 ++ drivers/video/Makefile | 1 + drivers/video/boe-th101mb31ig002-28a.c | 231 + 3 files changed

[PATCH 09/10] video: rockchip: Add HDMI support for RK3568

2025-01-16 Thread Dang Huynh
HDMI on RK3568 is mostly simplified, all this does is enabling DDC for display timings and HPD. Signed-off-by: Dang Huynh --- drivers/video/rockchip/Makefile | 1 + drivers/video/rockchip/rk3568_hdmi.c | 63 2 files changed, 64 insertions(+) diff

[PATCH 07/10] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper

2025-01-16 Thread Dang Huynh
We need to prerelocate VOP2 memory so the driver can work. This will only support U-Boot proper. Signed-off-by: Dang Huynh --- arch/arm/dts/rk356x-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi index

[PATCH 10/10] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-01-16 Thread Dang Huynh
Now that we have VOP2 support, let's enable it and support the built in USB keyboard. Signed-off-by: Dang Huynh --- configs/pinetab2-rk3566_defconfig | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configs/pinetab2-rk3566_defconfig b/configs/pinetab2-rk3566_defconfig

[PATCH 02/10] video: rockchip: dw_mipi_dsi: Improve pixel clock calculations

2025-01-16 Thread Dang Huynh
From: Ondrej Jirman Calculate burst mode overhead in one place for both internal and external PHY use case and exit if out of range, instead of ignoring the wrong value. Signed-off-by: Ondrej Jirman Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 24

[PATCH 06/10] video: rockchip: vop2: Add video bridge support

2025-01-16 Thread Dang Huynh
Add support for the MIPI DSI bridge driver that we have. Signed-off-by: Dang Huynh --- drivers/video/rockchip/rk_vop2.c | 89 ++-- 1 file changed, 67 insertions(+), 22 deletions(-) diff --git a/drivers/video/rockchip/rk_vop2.c b/drivers/video/rockchip

[PATCH 08/10] configs: quartz64: Enable vidconsole

2025-01-16 Thread Dang Huynh
Now that we have VOP2 support, we should enable vidconsole. Signed-off-by: Dang Huynh --- include/configs/quartz64_rk3566.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/configs/quartz64_rk3566.h b/include/configs/quartz64_rk3566.h index

Re: [PATCH v2 00/11] Rockchip VOP2 support

2025-04-05 Thread Dang Huynh
Hi Maciej, On Monday, March 24, 2025 3:46:12 PM UTC Maciej Pijanowski wrote: > Hello, > > First of all, thanks for your work on this Rockchip upstream code. We have > tested your patches on RK3566 board (Radxa CM3 IO) and HDMI output in > U-Boot works great. We didn't have success with MIPI yet s

Re: [PATCH v3 08/12] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper

2025-04-15 Thread Dang Huynh
On Sun, Apr 13, 2025 at 04:33:25PM +0200, Jonas Karlman wrote: > Hi, > > On 2025-04-12 16:27, Dang Huynh wrote: > > We need to prerelocate VOP2 memory so the driver can work. This > > will only support U-Boot proper. > > > > Signed-off-by: Dang Huynh > > -

Re: [PATCH v3 11/12] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-04-15 Thread Dang Huynh
On Sun, Apr 13, 2025 at 05:26:03PM +0200, Jonas Karlman wrote: > Hi, > > On 2025-04-12 16:27, Dang Huynh wrote: > > Now that we have VOP2 support, let's enable it and support the > > built in USB keyboard. > > > > Signed-off-by: Dang Huynh > > ---

Re: [PATCH v3 11/12] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-04-18 Thread Dang Huynh
Hi Jonas, On Tue, Apr 15, 2025 at 05:52:55PM +0200, Jonas Karlman wrote: > On 2025-04-15 15:29, Dang Huynh wrote: > > On Sun, Apr 13, 2025 at 05:26:03PM +0200, Jonas Karlman wrote: > >> Hi, > >> > >> On 2025-04-12 16:27, Dang Huynh wrote: > >>> No

[PATCH v4 08/12] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper

2025-05-05 Thread Dang Huynh
We need to prerelocate VOP2 memory so the driver can work. This will only support U-Boot proper. Signed-off-by: Dang Huynh --- arch/arm/dts/rk356x-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi index

[PATCH v4 00/12] Rockchip VOP2 support

2025-05-05 Thread Dang Huynh
Tested-by: Piotr Zalewski Signed-off-by: Dang Huynh --- Changes in v4: - Remove unnecessary clk_enable() as VOP clocks are enabled by TF-A - Adjust I2C clock configuration to match 24 MHz clock - Reorganize VOP node order - Link to v3: https://lore.kernel.org/r/20250412-vop2-pt2-v3-0-7c796db33...@

[PATCH v4 03/12] video: rockchip: dw_mipi_dsi: Proceed when external PHY is not defined

2025-05-05 Thread Dang Huynh
From: Ondrej Jirman In this case the DM returns ENOENT, not ENODATA. Signed-off-by: Ondrej Jirman Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v4 02/12] video: rockchip: dw_mipi_dsi: Improve pixel clock calculations

2025-05-05 Thread Dang Huynh
From: Ondrej Jirman Calculate burst mode overhead in one place for both internal and external PHY use case and exit if out of range, instead of ignoring the wrong value. Signed-off-by: Ondrej Jirman Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 24

[PATCH v4 01/12] video: rockchip: dw-mipi-dsi: Depend on CONFIG_VIDEO_BRIDGE

2025-05-05 Thread Dang Huynh
The driver is in video bridge class, so we must depend on it or the driver will fail to init. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/Kconfig b/drivers

[PATCH v4 06/12] video: rockchip: Add VOP2 support

2025-05-05 Thread Dang Huynh
VOP2 (Video Output Processor v2) is a display controller on Rockchip SoCs. It can be found on RK3566/8 and RK3588. This commit currently only supports RK3566/8. Signed-off-by: Dang Huynh --- arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 280 + drivers/video/rockchip/Makefile

[PATCH v4 07/12] video: rockchip: vop2: Add video bridge support

2025-05-05 Thread Dang Huynh
Add support for video bridge to VOP2 so we can use the MIPI DSI bridge driver that we have. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/rk_vop2.c | 81 +--- 1 file changed, 59 insertions(+), 22 deletions(-) diff --git

[PATCH v4 05/12] video: Add BOE TH101MB31IG002-28A MIPI-DSI panel

2025-05-05 Thread Dang Huynh
BOE TH101MB31IG002-28A is a MIPI-DSI panel used in the Pine64 PineTab2. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/Kconfig | 10 ++ drivers/video/Makefile | 1 + drivers/video/boe-th101mb31ig002-28a.c | 236

[PATCH v4 04/12] video: rockchip: dw-mipi-dsi: Add get_display_timing support

2025-05-05 Thread Dang Huynh
This allows video drivers to obtain display timings from the video bridge. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/video/rockchip

[PATCH v4 09/12] configs: quartz64: Enable vidconsole

2025-05-05 Thread Dang Huynh
Now that we have VOP2 support, we should enable vidconsole. Signed-off-by: Dang Huynh --- include/configs/quartz64_rk3566.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/configs/quartz64_rk3566.h b/include/configs/quartz64_rk3566.h index

[PATCH v4 10/12] video: rockchip: Add HDMI support for RK3568

2025-05-05 Thread Dang Huynh
HDMI on RK3568 is mostly simplified, all this does is enabling DDC for display timings and HPD. Signed-off-by: Dang Huynh --- drivers/video/rockchip/Makefile | 1 + drivers/video/rockchip/rk3568_hdmi.c | 71 2 files changed, 72 insertions(+) diff

[PATCH v4 11/12] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-05-05 Thread Dang Huynh
Now that we have VOP2 support, let's enable it and support the built in USB keyboard. Signed-off-by: Dang Huynh --- configs/pinetab2-rk3566_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configs/pinetab2-rk3566_defconfig b/configs/pinetab2-rk3566_defconfig

[PATCH v4 12/12] clk: rockchip: rk3568: Use assigned VPLL clock when possible

2025-05-05 Thread Dang Huynh
This matches how VPLL is configured under Linux and avoid weird behaviors when VPLL is reconfigured under Linux. Signed-off-by: Dang Huynh --- drivers/clk/rockchip/clk_rk3568.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk_rk3568.c b/drivers

[PATCH v3 06/12] video: rockchip: Add VOP2 support

2025-04-12 Thread Dang Huynh
VOP2 (Video Output Processor v2) is a display controller on Rockchip SoCs. It can be found on RK3566/8 and RK3588. This commit currently only supports RK3566/8. Signed-off-by: Dang Huynh --- arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 280 + drivers/video/rockchip/Makefile

[PATCH v3 09/12] configs: quartz64: Enable vidconsole

2025-04-12 Thread Dang Huynh
Now that we have VOP2 support, we should enable vidconsole. Signed-off-by: Dang Huynh --- include/configs/quartz64_rk3566.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/configs/quartz64_rk3566.h b/include/configs/quartz64_rk3566.h index

[PATCH v3 04/12] video: rockchip: dw-mipi-dsi: Add get_display_timing support

2025-04-12 Thread Dang Huynh
This allows video drivers to obtain display timings from the video bridge. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/video/rockchip

[PATCH v3 07/12] video: rockchip: vop2: Add video bridge support

2025-04-12 Thread Dang Huynh
Add support for video bridge to VOP2 so we can use the MIPI DSI bridge driver that we have. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/rk_vop2.c | 81 +--- 1 file changed, 59 insertions(+), 22 deletions(-) diff --git

[PATCH v3 10/12] video: rockchip: Add HDMI support for RK3568

2025-04-12 Thread Dang Huynh
HDMI on RK3568 is mostly simplified, all this does is enabling DDC for display timings and HPD. Signed-off-by: Dang Huynh --- drivers/video/rockchip/Makefile | 1 + drivers/video/rockchip/rk3568_hdmi.c | 71 2 files changed, 72 insertions(+) diff

[PATCH v3 11/12] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-04-12 Thread Dang Huynh
Now that we have VOP2 support, let's enable it and support the built in USB keyboard. Signed-off-by: Dang Huynh --- configs/pinetab2-rk3566_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configs/pinetab2-rk3566_defconfig b/configs/pinetab2-rk3566_defconfig

[PATCH v3 12/12] clk: rockchip: rk3568: Use assigned VPLL clock when possible

2025-04-12 Thread Dang Huynh
This matches how VPLL is configured under Linux and avoid weird behaviors when VPLL is reconfigured under Linux. Signed-off-by: Dang Huynh --- drivers/clk/rockchip/clk_rk3568.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk_rk3568.c b/drivers

[PATCH v3 05/12] video: Add BOE TH101MB31IG002-28A MIPI-DSI panel

2025-04-12 Thread Dang Huynh
BOE TH101MB31IG002-28A is a MIPI-DSI panel used in the Pine64 PineTab2. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/Kconfig | 10 ++ drivers/video/Makefile | 1 + drivers/video/boe-th101mb31ig002-28a.c | 236

[PATCH v3 03/12] video: rockchip: dw_mipi_dsi: Proceed when external PHY is not defined

2025-04-12 Thread Dang Huynh
From: Ondrej Jirman In this case the DM returns ENOENT, not ENODATA. Signed-off-by: Ondrej Jirman Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v3 01/12] video: rockchip: dw-mipi-dsi: Depend on CONFIG_VIDEO_BRIDGE

2025-04-12 Thread Dang Huynh
The driver is in video bridge class, so we must depend on it or the driver will fail to init. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/Kconfig b/drivers

[PATCH v3 00/12] Rockchip VOP2 support

2025-04-12 Thread Dang Huynh
aster. [1]: https://lore.kernel.org/u-boot/20250220170629.228485-1-clamo...@gmail.com Tested-by: Piotr Zalewski Signed-off-by: Dang Huynh --- Changes in v3: - Renaming prefix from "rkvop" to "rkvop2" and similar - Win planes are platform-configurable - Link to v2: https://l

[PATCH v3 02/12] video: rockchip: dw_mipi_dsi: Improve pixel clock calculations

2025-04-12 Thread Dang Huynh
From: Ondrej Jirman Calculate burst mode overhead in one place for both internal and external PHY use case and exit if out of range, instead of ignoring the wrong value. Signed-off-by: Ondrej Jirman Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 24

[PATCH v3 08/12] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper

2025-04-12 Thread Dang Huynh
We need to prerelocate VOP2 memory so the driver can work. This will only support U-Boot proper. Signed-off-by: Dang Huynh --- arch/arm/dts/rk356x-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi index

Re: [PATCH] clk: Fix clk_set_parent() regression

2025-04-19 Thread Dang Huynh
Hi Jonas, Tested on PineTab 2 (RK3566) and this got rid of "Cannot enable parent" errors. Tested-by: Dang Huynh On Sat, Apr 19, 2025 at 09:07:16AM +, Jonas Karlman wrote: > The commit ac30d90f3367 ("clk: Ensure the parent clocks are enabled > while reparenting"

Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-03-01 Thread Dang Huynh
Hi Chaoyi Chen, On Thursday, February 27, 2025 6:29:13 AM UTC Chaoyi Chen wrote: > > Could you use a naming prefix like "rkvop2" to explicitly indicate the > use of vop2, thereby distinguishing it from rk_vop.c? > Yes. This will be in v3. > > + struct rk3568_vop_esmart *esmart = priv->regs +

Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-03-03 Thread Dang Huynh
Hi Chaoyi Chen, On Monday, March 3, 2025 9:48:14 AM UTC Chaoyi Chen wrote: > Hi Dang, > > On 2025/3/2 12:09, Dang Huynh wrote: > >>> + struct rk3568_vop_esmart *esmart = priv->regs + > > > > VOP2_ESMART_OFFSET(0); > > > >> You are ass

[PATCH v2 09/11] configs: quartz64: Enable vidconsole

2025-02-23 Thread Dang Huynh
Now that we have VOP2 support, we should enable vidconsole. Signed-off-by: Dang Huynh --- include/configs/quartz64_rk3566.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/configs/quartz64_rk3566.h b/include/configs/quartz64_rk3566.h index

[PATCH v2 10/11] video: rockchip: Add HDMI support for RK3568

2025-02-23 Thread Dang Huynh
HDMI on RK3568 is mostly simplified, all this does is enabling DDC for display timings and HPD. Signed-off-by: Dang Huynh --- drivers/video/rockchip/Makefile | 1 + drivers/video/rockchip/rk3568_hdmi.c | 71 2 files changed, 72 insertions(+) diff

Re: [PATCH v2 1/3] video: bridge-uclass: add get_display_timing ops

2025-02-23 Thread Dang Huynh
Works with Rockchip DW MIPI DSI bridge (drivers/video/rockchip/ dw_mipi_dsi_rockchip.c) after I add ops to the driver. Tested-by: Dang Huynh (PineTab 2) On Thursday, February 20, 2025 5:06:27 PM UTC Svyatoslav Ryhel wrote: > Add get_display_timing ops for internal bridges linked to >

[PATCH v2 00/11] Rockchip VOP2 support

2025-02-23 Thread Dang Huynh
he patches can be merged. [1]: https://lore.kernel.org/u-boot/20250220170629.228485-1-clamo...@gmail.com Signed-off-by: Dang Huynh --- Changes in v2: - Get display timings from video bridge (requires [1]) - Disable esmart and post before booting to OS - Enable avdd-0v9 and avdd-1v8 when probing HD

[PATCH v2 01/11] video: rockchip: dw-mipi-dsi: Depend on CONFIG_VIDEO_BRIDGE

2025-02-23 Thread Dang Huynh
The driver is in video bridge class, so we must depend on it or the driver will fail to init. Signed-off-by: Dang Huynh --- drivers/video/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/Kconfig b/drivers/video/rockchip/Kconfig index

[PATCH v2 06/11] video: rockchip: Add VOP2 support

2025-02-23 Thread Dang Huynh
VOP2 (Video Output Processor v2) is a display controller on Rockchip SoCs. It can be found on RK3566/8 and RK3588. This commit currently only supports RK3566/8. Signed-off-by: Dang Huynh --- arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 249 + drivers/video/rockchip/Makefile

[PATCH v2 05/11] video: Add BOE TH101MB31IG002-28A MIPI-DSI panel

2025-02-23 Thread Dang Huynh
BOE TH101MB31IG002-28A is a MIPI-DSI panel used in the Pine64 PineTab2. Signed-off-by: Dang Huynh --- drivers/video/Kconfig | 10 ++ drivers/video/Makefile | 1 + drivers/video/boe-th101mb31ig002-28a.c | 236 + 3 files changed

[PATCH v2 02/11] video: rockchip: dw_mipi_dsi: Improve pixel clock calculations

2025-02-23 Thread Dang Huynh
From: Ondrej Jirman Calculate burst mode overhead in one place for both internal and external PHY use case and exit if out of range, instead of ignoring the wrong value. Signed-off-by: Ondrej Jirman Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 24

[PATCH v2 07/11] video: rockchip: vop2: Add video bridge support

2025-02-23 Thread Dang Huynh
Add support for video bridge to VOP2 so we can use the MIPI DSI bridge driver that we have. Signed-off-by: Dang Huynh --- drivers/video/rockchip/rk_vop2.c | 81 +--- 1 file changed, 59 insertions(+), 22 deletions(-) diff --git a/drivers/video/rockchip

[PATCH v2 03/11] video: rockchip: dw_mipi_dsi: Proceed when external PHY is not defined

2025-02-23 Thread Dang Huynh
From: Ondrej Jirman In this case the DM returns ENOENT, not ENODATA. Signed-off-by: Ondrej Jirman Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/dw_mipi_dsi_rockchip.c b

[PATCH v2 04/11] video: rockchip: dw-mipi-dsi: Add get_display_timing support

2025-02-23 Thread Dang Huynh
This allows video drivers to obtain display timings from the video bridge. Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/video/rockchip/dw_mipi_dsi_rockchip.c b

[PATCH v2 11/11] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-02-23 Thread Dang Huynh
Now that we have VOP2 support, let's enable it and support the built in USB keyboard. Signed-off-by: Dang Huynh --- configs/pinetab2-rk3566_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configs/pinetab2-rk3566_defconfig b/configs/pinetab2-rk3566_defconfig

[PATCH v2 08/11] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper

2025-02-23 Thread Dang Huynh
We need to prerelocate VOP2 memory so the driver can work. This will only support U-Boot proper. Signed-off-by: Dang Huynh --- arch/arm/dts/rk356x-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi index

[PATCH v5 00/12] Rockchip VOP2 support

2025-06-06 Thread Dang Huynh
Tested-by: Piotr Zalewski Signed-off-by: Dang Huynh --- Changes in v5: - Add check for invalid win_id value - Link to v4: https://lore.kernel.org/r/20250505-vop2-pt2-v4-0-3b7c3ab1a...@riseup.net Changes in v4: - Remove unnecessary clk_enable() as VOP clocks are enabled by TF-A - Adjust

[PATCH v5 01/12] video: rockchip: dw-mipi-dsi: Depend on CONFIG_VIDEO_BRIDGE

2025-06-06 Thread Dang Huynh
The driver is in video bridge class, so we must depend on it or the driver will fail to init. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/Kconfig b/drivers

[PATCH v5 02/12] video: rockchip: dw_mipi_dsi: Improve pixel clock calculations

2025-06-06 Thread Dang Huynh
From: Ondrej Jirman Calculate burst mode overhead in one place for both internal and external PHY use case and exit if out of range, instead of ignoring the wrong value. Signed-off-by: Ondrej Jirman Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 24

[PATCH v5 03/12] video: rockchip: dw_mipi_dsi: Proceed when external PHY is not defined

2025-06-06 Thread Dang Huynh
From: Ondrej Jirman In this case the DM returns ENOENT, not ENODATA. Signed-off-by: Ondrej Jirman Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v5 04/12] video: rockchip: dw-mipi-dsi: Add get_display_timing support

2025-06-06 Thread Dang Huynh
This allows video drivers to obtain display timings from the video bridge. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/video/rockchip

[PATCH v5 05/12] video: Add BOE TH101MB31IG002-28A MIPI-DSI panel

2025-06-06 Thread Dang Huynh
BOE TH101MB31IG002-28A is a MIPI-DSI panel used in the Pine64 PineTab2. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/Kconfig | 10 ++ drivers/video/Makefile | 1 + drivers/video/boe-th101mb31ig002-28a.c | 236

[PATCH v5 06/12] video: rockchip: Add VOP2 support

2025-06-06 Thread Dang Huynh
VOP2 (Video Output Processor v2) is a display controller on Rockchip SoCs. It can be found on RK3566/8 and RK3588. This commit currently only supports RK3566/8. Signed-off-by: Dang Huynh --- arch/arm/include/asm/arch-rockchip/vop_rk3568.h | 280 + drivers/video/rockchip/Makefile

[PATCH v5 07/12] video: rockchip: vop2: Add video bridge support

2025-06-06 Thread Dang Huynh
Add support for video bridge to VOP2 so we can use the MIPI DSI bridge driver that we have. Reviewed-by: Svyatoslav Ryhel Signed-off-by: Dang Huynh --- drivers/video/rockchip/rk_vop2.c | 81 +--- 1 file changed, 59 insertions(+), 22 deletions(-) diff --git

[PATCH v5 08/12] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper

2025-06-06 Thread Dang Huynh
We need to prerelocate VOP2 memory so the driver can work. This will only support U-Boot proper. Signed-off-by: Dang Huynh --- arch/arm/dts/rk356x-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi index

[PATCH v5 09/12] configs: quartz64: Enable vidconsole

2025-06-06 Thread Dang Huynh
Now that we have VOP2 support, we should enable vidconsole. Signed-off-by: Dang Huynh --- include/configs/quartz64_rk3566.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/configs/quartz64_rk3566.h b/include/configs/quartz64_rk3566.h index

[PATCH v5 10/12] video: rockchip: Add HDMI support for RK3568

2025-06-06 Thread Dang Huynh
HDMI on RK3568 is mostly simplified, all this does is enabling DDC for display timings and HPD. Signed-off-by: Dang Huynh --- drivers/video/rockchip/Makefile | 1 + drivers/video/rockchip/rk3568_hdmi.c | 71 2 files changed, 72 insertions(+) diff

[PATCH v5 11/12] configs: pinetab2-rk3566: Enable video and USB keyboard

2025-06-06 Thread Dang Huynh
Now that we have VOP2 support, let's enable it and support the built in USB keyboard. Signed-off-by: Dang Huynh --- configs/pinetab2-rk3566_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configs/pinetab2-rk3566_defconfig b/configs/pinetab2-rk3566_defconfig

[PATCH v5 12/12] clk: rockchip: rk3568: Use assigned VPLL clock when possible

2025-06-06 Thread Dang Huynh
This matches how VPLL is configured under Linux and avoid weird behaviors when VPLL is reconfigured under Linux. Signed-off-by: Dang Huynh --- drivers/clk/rockchip/clk_rk3568.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk_rk3568.c b/drivers