Hi Chaoyi Chen, On Thursday, February 27, 2025 6:29:13 AM UTC Chaoyi Chen wrote: > > Could you use a naming prefix like "rkvop2" to explicitly indicate the > use of vop2, thereby distinguishing it from rk_vop.c? > Yes. This will be in v3.
> > + struct rk3568_vop_esmart *esmart = priv->regs + VOP2_ESMART_OFFSET(0); > > You are assuming that the RK356X is always used ESMART0, which generally > works. But considering > that there are multiple Video Ports and different Video Ports may have > different primary win, > selecting the appropriate win can simplifies the processing for U-Boot > to Kernel transitions in the future. > > It's a good idea to implement the win selection as a configurable > parameter, or we can consider the > default win used for different Video Ports. ESMART0 is configured to the desired video port on U-Boot. VOP2 should be reconfigured by Linux.
