[PATCH] arm: mach-k3: introduce generic board detction kconfig option

2023-03-03 Thread Christian Gmeiner
For non TI boards it is not possible to enable the do_board_detect() call as TI_I2C_BOARD_DETECT is defined in board/ti/common/Kconfig. I want to use do_board_detect() to dectect boards and properties based on some SPI communication with a FPGA. Signed-off-by: Christian Gmeiner --- arch/arm

[PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-03-03 Thread Christian Gmeiner
The call to DEFINE_ALIGN_BUFFER for the rx_desc array conained an icnonsistency as 16 receive descriptors were allocated when the remaining code would only use 8 of them. Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c | 6 +++--- drivers/net/e1000.h | 2 ++ 2 files changed, 5

[PATCH 2/4] net: e1000: move all rx data structures to hw instance

2023-03-03 Thread Christian Gmeiner
Preparation for per driver instance allocated data structures. Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c | 26 +++--- drivers/net/e1000.h | 5 + 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c

[PATCH 3/4] net: e1000: dynamically allocate rx data buffers per instance

2023-03-03 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c index 08c84ce3d1..ea9ca76917 100644 --- a/drivers/net/e1000.c +++ b/drivers/net/e1000.c @@ -54,14

[PATCH 4/4] net: e1000: make use of multiple rx packets

2023-03-03 Thread Christian Gmeiner
When facing a very busy network, the single rx packet buffer was oftentimes overwritten before a desired response packet (e.g. a Ping reply) could have been processed. This change improves resistance to this by utilising multiple buffers. Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c

[PATCH v2 0/4] NFSv1 support

2023-03-10 Thread Christian Gmeiner
This patch series adds support for NFSv1 and is more or less a rebased version of an older series. During V1 there was a discussion if it really makes sense to bring more features into the network stack of U-Boot as it is just a bootloader. As TCP support landed I thought I might give this patch s

[PATCH v2 1/4] nfs: convert supported_nfs_versions bitfield to an enum

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL Prep. work to support nfs v1. Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 93 +++ 1 file changed, 52 insertions(+), 41 deletions(-) diff --git a/net/nfs.c b/net/nfs.c index c6a124885e..d1858faaa9 100644 --- a/net/n

[PATCH v2 3/4] nfs: handle rpc errors for mount calls

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/nfs.c b/net/nfs.c index a2749bae82..21cae52f35 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -524,6 +524,7 @@ static int rpc_lookup_reply(int pr

[PATCH v2 2/4] nfs: factor out generic reply error handling

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 94 ++- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/net/nfs.c b/net/nfs.c index d1858faaa9..a2749bae82 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -443,6

[PATCH v2 4/4] net: add NFSv1 support

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL NFSv1 support added by Christian Gmeiner, Thomas Rienoessl, September 27, 2018. As of now, NFSv3 is the default choice. if the server does not support NFSv3, we fall back to versions 2 or 1. Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 42

Re: [PATCH v2 0/4] NFSv1 support

2023-03-17 Thread Christian Gmeiner
ded I thought I might > give this patch series another try. > gentle ping -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-03-17 Thread Christian Gmeiner
> > The call to DEFINE_ALIGN_BUFFER for the rx_desc array > conained an icnonsistency as 16 receive descriptors > were allocated when the remaining code would only use > 8 of them. > > Signed-off-by: Christian Gmeiner gentle ping -- greets -- Christian Gmeiner, M

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2023-03-21 Thread Christian Gmeiner
> > > - return; > > > + return 0; > > > > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; ++i) { > > > if (bd->bi_dram[i].size) { > > > @@ -1068,7 +1070,7 @@ static void decode_regions(struct pci_controller > > > *hose, ofnode parent_

Re: [PATCH 07/13] pci: coreboot: Don't read regions when booting

2023-03-22 Thread Christian Gmeiner
nges. > > > > Signed-off-by: Simon Glass > > --- > > > > drivers/pci/pci-uclass.c | 4 > > 1 file changed, 4 insertions(+) > > > Tested-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2023-03-22 Thread Christian Gmeiner
Hi > > Hi, > > On Tue, Mar 21, 2023 at 08:57:18AM +0100, Christian Gmeiner wrote: > > Am So., 4. Dez. 2022 um 22:22 Uhr schrieb Pierre-Clément Tosi > > : > > > > > > Hi, > > > > > > On Fri, Dec 02, 2022 at 08:38:37PM +0100, s...@g

[PATCH] led: Do not overwrite label

2023-10-23 Thread Christian Gmeiner
are not available. Fixes: 83c63f0d11 ("led: Move OF "label" property parsing to core") Signed-off-by: Christian Gmeiner --- drivers/led/led-uclass.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/led/led-uclass.c b/drivers/led/led-uclas

Re: [PATCH 2/6] led-uclass: honour ->label field populated by driver's own .bind

2023-10-23 Thread Christian Gmeiner
be one sysfs entry, but with > attributes exposing the multicolor functionality. I must admit I don't > know the status of that work, when something reaches v31, > http://archive.lwn.net:8080/linux-kernel/20200722071055.GA8984@amd/t/ , > it's hard to know if it ever lands, or if pieces of it has landed.] > > Rasmus > I have an almost similar patch sent out today as I have not seen yours before. The end results is the same as mine https://patchwork.ozlabs.org/project/uboot/patch/20231023082117.39290-1-christian.gmei...@gmail.com/ Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-03-23 Thread Christian Gmeiner
> > > > > The call to DEFINE_ALIGN_BUFFER for the rx_desc array > > conained an icnonsistency as 16 receive descriptors > > were allocated when the remaining code would only use > > 8 of them. > > > > Signed-off-by: Christian Gmeiner > > gentle

Re: [PATCH v2 08/16] pci: coreboot: Don't read regions when booting

2023-03-24 Thread Christian Gmeiner
> Signed-off-by: Simon Glass > Reviewed-by: Bin Meng Tested-by: Christian Gmeiner This fixes a regression that got introduced with f2ebaaa9f3 ("pci: Handle failed calloc in decode_regions()") For more details see: https://lore.kernel.org/all/202205191648

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
is just a bootloader. As TCP support landed I thought I might > > give this patch series another try. > > > > gentle ping Adding some more people to CC - maybe this helps. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
se but we want to upstream most of our downstream patches. Btw. if this patch series will not land does this mean NFSv2 will die too soon? -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
Hi Peter, Am Fr., 24. März 2023 um 11:10 Uhr schrieb Peter Robinson : > > On Fri, Mar 24, 2023 at 9:35 AM Christian Gmeiner > wrote: > > > > Hi Peter, > > > > > > > > > > This patch series adds support for NFSv1 and is more &

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
Hi Peter > > > > Hi Peter, > > > > Am Fr., 24. März 2023 um 11:10 Uhr schrieb Peter Robinson > > : > > > > > > On Fri, Mar 24, 2023 at 9:35 AM Christian Gmeiner > > > wrote: > > > > > > > > Hi Peter, >

[PATCH] arm: mach-k3: am642: move do_dt_magic() after sysfw loading

2023-03-28 Thread Christian Gmeiner
Makes it possible to use e.g mcu_spi0 for custom board detection. Signed-off-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-k3/am642_init.c b/arch/arm/mach-k3/am642_init.c index 96f292ea75..2478ac162b

Re: [PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-02 Thread Christian Gmeiner
is function, which might not be the right guard ifdef > should a board use a different method for board detection. > > Signed-off-by: Andrew Davis This change is conflicting with what is u-boot/next: https://source.denx.de/u-boot/u-boot/-/commit/e44657ed744d1b4e216d8dda5d528ff0d0a623

Re: [PATCH 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-02 Thread Christian Gmeiner
uses these SoCs. > > We use ft_system_setup() here instead of ft_board_setup() since it is no > longer board level. Enable OF_SYSTEM_SETUP in the configurations that use > this to keep functionality the same. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner &

Re: [PATCH v3 08/16] pci: coreboot: Don't read regions when booting

2023-04-02 Thread Christian Gmeiner
Signed-off-by: Simon Glass > Reviewed-by: Bin Meng Tested-by: Christian Gmeiner This fixes a regression that got introduced with f2ebaaa9f3 ("pci: Handle failed calloc in decode_regions()") For more details see: https://lore.kernel.org/all/202205191

Re: [PATCH 2/4] net: e1000: move all rx data structures to hw instance

2023-04-05 Thread Christian Gmeiner
Hi all > > Preparation for per driver instance allocated data structures. > > Signed-off-by: Christian Gmeiner gentle ping - what can I do better to get some feedback, RBs, etc faster? This experience is quite frustrating and it happens for me from time to time for U-Boot patches :(

Re: [PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Christian Gmeiner
--git a/board/ti/common/Kconfig b/board/ti/common/Kconfig > index f03357cc751..49edd98014a 100644 > --- a/board/ti/common/Kconfig > +++ b/board/ti/common/Kconfig > @@ -1,6 +1,5 @@ > config TI_I2C_BOARD_DETECT > bool "Support for Board detection for TI platforms" > - select K3_BOARD_DETECT if ARCH_K3 > help >Support for detection board information on Texas Instrument's >Evaluation Boards which have I2C based EEPROM detection > -- > 2.39.2 > -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Christian Gmeiner
u32 soc; > + > + soc = (readl(CTRLMMR_WKUP_JTAG_ID) & > + JTAG_ID_PARTNO_MASK) >> JTAG_ID_PARTNO_SHIFT; > + > + return soc == JTAG_ID_PARTNO_J721E; > +} > + > +bool soc_is_j7200(void) static bool soc_is_j7200(void) > +{ > + u32 soc; > +

Re: [PATCH v2 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-06 Thread Christian Gmeiner
> > The K3 JTAG and SoC ID information is already stored in the K3 arch > hardware file, include that and use its definitions here. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > drivers/soc/Kconfig | 2 +- > driv

Re: [PATCH v2 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-06 Thread Christian Gmeiner
> > The J7200 EVM will not include this file, this J7200 checks look > to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > include/configs/j721s2_evm.h | 2 +- > 1 file ch

Re: [PATCH v2 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-06 Thread Christian Gmeiner
> > This function is not used currently; remove it. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/common.c | 19 --- > arch/arm/mach-k3/include/mach/sys_proto.h | 1 - > 2 files changed, 20 del

Re: [PATCH v2 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Christian Gmeiner
-ddrss.c > +++ b/drivers/ram/k3-am654-ddrss.c > @@ -18,6 +18,10 @@ > #include > #include "k3-am654-ddrss.h" > > +void sdelay(unsigned long loops); > +u32 wait_on_value(u32 read_bit_mask, u32 match_value, void *read_addr, > + u32 bound); > + >

Re: [PATCH v2 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-06 Thread Christian Gmeiner
> > This matches AM64 and J721e and removes the need to forward > declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() > in sys_proto.h. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/include/mach/sys_proto.h |

Re: [PATCH v2 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-06 Thread Christian Gmeiner
> > This function is the same for each device when it needs to shutdown > the R5 core. Move this to the common section and move the remaining > device specific ID list to the device hardware include. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --

Re: [PATCH v2 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-06 Thread Christian Gmeiner
> > This header is only used locally by K3 init files, no need to have it > up with the global mach includes. Move into local includes. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/am625_init.c | 2 +

Re: [PATCH v2 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-06 Thread Christian Gmeiner
> > The TARGET_x_R5_EVM check is already enough to limit these defines to > only the correct builds. Remove the extra outer check. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > board/ti/j721e/j721e.env | 2 -- > board/ti/j721s2/j721s2.env |

Re: [PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Christian Gmeiner
Am Mi., 5. Apr. 2023 um 22:29 Uhr schrieb Andrew Davis : > > On 4/5/23 3:09 PM, Christian Gmeiner wrote: > > Hi > > > >> > >> This matches how it was done for pre-K3 TI platforms and it allows > >> us to move the forward declaration out of sys_pr

Re: [PATCH 2/4] net: e1000: move all rx data structures to hw instance

2023-04-06 Thread Christian Gmeiner
> > On Wed, Apr 05, 2023 at 09:50:08AM +0200, Christian Gmeiner wrote: > > Hi all > > > > > > > > Preparation for per driver instance allocated data structures. > > > > > > Signed-off-by: Christian Gmeiner > > > > gentle ping - wh

Re: [PATCH] arm: mach-k3: am642: move do_dt_magic() after sysfw loading

2023-04-06 Thread Christian Gmeiner
> > Makes it possible to use e.g mcu_spi0 for custom board detection. > gentle ping > Signed-off-by: Christian Gmeiner > --- > arch/arm/mach-k3/am642_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-k3/am64

Re: [PATCH v3 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Christian Gmeiner
TYPE_SHIFT 0 > #define SYS_STATUS_DEV_TYPE_MASK (0xf) > diff --git a/arch/arm/mach-k3/include/mach/sys_proto.h > b/arch/arm/mach-k3/include/mach/sys_proto.h > index 0b5d606eaa2..d5d4b787b7d 100644 > --- a/arch/arm/mach-k3/include/mach/sys_proto.h > +++ b/arch/arm/mach-k3/inc

Re: [PATCH v3 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Christian Gmeiner
ned-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/Kconfig | 5 - > arch/arm/mach-k3/am642_init.c | 4 ++-- > arch/arm/mach-k3/am654_init.c | 4 ++-- > arch/arm/mach-k3/common.c | 10

Re: [PATCH v3 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-06 Thread Christian Gmeiner
> > This header file is now empty, remove it. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/am642_init.c | 2 -- > arch/arm/mach-k3/am654_init.c | 1 - > arch/arm/mach-k3/common.c |

Re: [PATCH v4 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-09 Thread Christian Gmeiner
st of the SoC IDs for completeness and later use. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/common.c | 20 -- > arch/arm/mach-k3/common.h | 3 --- > arch/ar

[PATCH] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
The non DM code path already would enable pci bus mastering. Do the same for the DM code path. Fixes AHCI problems I am seeing on an Intel Apollolake device. Signed-off-by: Christian Gmeiner --- drivers/ata/ahci.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a

[PATCH v2] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
The non DM code path already would enable pci bus mastering. Do the same for the DM code path. Fixes AHCI problems I am seeing on an Intel Apollolake device. v2: Add Bin's R-b and remove the ending '.' from comment. Signed-off-by: Christian Gmeiner Reviewed-by: Bin Meng -

Re: [PATCH v2] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
Am Di., 11. Apr. 2023 um 16:29 Uhr schrieb Bin Meng : > > On Tue, Apr 11, 2023 at 10:25 PM Christian Gmeiner > wrote: > > > > The non DM code path already would enable pci bus mastering. Do the > > same for the DM code path. > > > > Fixes AHCI problems I

[PATCH v3] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
The non DM code path already would enable pci bus mastering. Do the same for the DM code path. Fixes AHCI problems I am seeing on an Intel Apollolake device. Signed-off-by: Christian Gmeiner Reviewed-by: Bin Meng --- v2: Add Bin's R-b and remove the ending '.' from comment. v3

Re: [PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-05-02 Thread Christian Gmeiner
Am Sa., 1. Apr. 2023 um 21:01 Uhr schrieb Ramon Fried : > > On Fri, Mar 3, 2023 at 10:49 PM Christian Gmeiner > wrote: > > > > The call to DEFINE_ALIGN_BUFFER for the rx_desc array > > conained an icnonsistency as 16 receive descriptors > > were allocated when

Re: [PATCH v3 00/19] Migration to using binman for bootloader

2023-05-04 Thread Christian Gmeiner
lding U-Boot with sysfw alot - thanks for your work! I have tested this series on an am642 based design. One thing is missing for my HSM use case. I want to build an unsigned Image and need to sign it with binman in the context of the HSM. Therefore we need repacking support. Are you workin

Re: [PATCH v3 00/19] Migration to using binman for bootloader

2023-05-05 Thread Christian Gmeiner
Hi > > On 04/05/23 14:08, Christian Gmeiner wrote: > > Hi > > > >> > >> This series aims to eliminate the use of additional custom repositories > >> such as k3-image-gen (K3 Image Generation) repo and core-secdev-k3 (K3 > >> Security Developm

Re: [RFC PATCH 3/3] net: phy: dp83869: Port the kernel driver

2021-04-27 Thread Christian Gmeiner
gt; +/* CFG3 bits */ > >>>> +#define DP83869_CFG3_PORT_MIRROR_EN BIT(0) > >>>> + > >>>> +/* CFG4 bits */ > >>>> +#define DP83869_INT_OEBIT(7) > >>>> + > >>>> +/* OP MODE */ > >>>> +#define DP83869_OP_MODE_MIIBIT(5) > >>>> +#define DP83869_SGMII_RGMII_BRIDGEBIT(6) > >>>> + > >>>> +enum { > >>>> +DP83869_PORT_MIRRORING_KEEP, > >>>> +DP83869_PORT_MIRRORING_EN, > >>>> +DP83869_PORT_MIRRORING_DIS, > >>>> +}; > >>> We have met with this in the kernel. Greg was asking us to write exact > >>> value to all enum entries. > >>> > >> Hmm. Can you give me a reference? I am not doubting you but I would > >> like to read that guidance. > >> > >> That reference will help with an debate I am having in the kernel. > > Take a look at this thread. > > https://lore.kernel.org/linux-arm-kernel/20200318125003.ga2727...@kroah.com/ > Thank you > > > > > >>>> + > >>>> +#ifdef CONFIG_OF_MDIO > >>> Isn't there a way to remove these? > >>> > >>> if (IS_ENABLED(CONFIG_OF_MDIO)) > >>> ... > >> I looked at the 83867 it uses #if defined(CONFIG_DM_ETH) so I can change > >> this > > There are a lot of places which should be update/done better. > Are you inferring that this is not correct either? > > > > > >>>> +static int dp83869_of_init(struct phy_device *phydev) > >>>> +{ > >>>> +struct dp83869_private *dp83869 = phydev->priv; > >>>> +struct device *dev = &phydev->mdio.dev; > >>>> +struct device_node *of_node = dev->of_node; > >>>> +int ret; > >>>> + > >>>> +if (!of_node) > >>>> +return -ENODEV; > >>> didn't go deep to this but can this happen? > >> Does every device in the uBoot tree use the DT or do some still use > >> board files? > > IIRC ethernet phys are not based on driver model that's why devices are > > not created for it and I am not quite sure if platdata are supported. > > > > I think question is what way you use. If you use just OF_MDIO/DM_ETH > > then Kconfig should have dependencies. And if someone else want to run > > it without it (which is IMHO unlikely) then they can update the driver self. > > Well technically some phys like this one may not need DT at all if > strapped in hardware. > > > >>>> + > >>>> +dp83869->io_impedance = -EINVAL; > >>> I would prefer to group it together. It means move this before dt > >>> reading. > >>> > > No reaction on this line that's why just commenting it that you spot it. > > I had to look at it in detail. Not sure why this was set there. This > should be removed > > Dan > > > > Thanks, > > Michal > > > > > > -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] led: Do not overwrite label

2023-11-14 Thread Christian Gmeiner
ping Am Mo., 23. Okt. 2023 um 10:26 Uhr schrieb Marek Vasut : > > On 10/23/23 10:21, Christian Gmeiner wrote: > > label might have been set by a non device-tree based U-Boot driver already. > > > > In my concrete case there is a PCI driver that uses device_bind_driver(..)

Re: [PATCH 2/6] led-uclass: honour ->label field populated by driver's own .bind

2023-11-14 Thread Christian Gmeiner
work that has been ongoing for many many years (I think there was an > > LWN article at some point), where this could be exposed as a single > > multi-color LED, as opposed to the "traditional" three/four individual > > LEDs. In the former case, there would only be one sysfs entry, but with > > attributes exposing the multicolor functionality. I must admit I don't > > know the status of that work, when something reaches v31, > > http://archive.lwn.net:8080/linux-kernel/20200722071055.GA8984@amd/t/ , > > it's hard to know if it ever lands, or if pieces of it has landed.] > > +CC Pavel -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 4/6] led: led_gpio: use led_bind_generic() helper

2023-11-27 Thread Christian Gmeiner
> > Use the helper led_bind_generic() to reduce code duplication. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Christian Gmeiner > --- > drivers/led/led_gpio.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/drivers/l

Re: [PATCH v2 5/6] led: led_pwm: use led_bind_generic() helper

2023-11-27 Thread Christian Gmeiner
> > Use the helper led_bind_generic() to reduce code duplication. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Christian Gmeiner > --- > drivers/led/led_pwm.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/

Re: [PATCH] mx6cuboxi: Do not print devicetree model

2024-03-28 Thread Christian Gmeiner
Hi Fabio > The mx6cuboxi_defconfig target supports several board > variants. All of these variants use the hummingboard devicetree in U-Boot. > > Currently, the devicetree model as well as the board variant name > are shown: > > U-Boot 2024.04-rc5-3-g774ec4fda8 (Mar 27 2024 - 16:48:35 +0100)

Re: [PATCH v2] mx6cuboxi: Do not print devicetree model

2024-04-01 Thread Christian Gmeiner
fit WDT: Started watchdog@20bc000 with servicing every 1000ms (128s timeout) MMC: FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... *** Warning - bad CRC, using default environment In:serial Out: serial Err: serial Board: MX6 Cubox-i Net: eth0: ethernet@2188000 Tested-by: Christian Gmeiner Thanks & Regards, Christian

Re: [PATCH v2] mx6cuboxi: Fix Ethernet after DT sync with Linux

2024-04-01 Thread Christian Gmeiner
x6qdl-sr-som-u-boot.dtsi.] > Signed-off-by: Fabio Estevam > Tested-by: Christian Gmeiner > --- > Changes since v1: > - Disable ethernet-phy at addresses 0, 1 and 4. > - Remove the fixup of the fake 0xff address before booting Linux. > > Josua and Christian, >

Re: [PATCH 03/10] smbios: Move smbios_write_type to the C file

2021-01-08 Thread Christian Gmeiner
Am Do., 7. Jan. 2021 um 05:22 Uhr schrieb Simon Glass : > > This type is not used outside the smbios.c file so there is no need for it > to be in the header file. Move it. > > Signed-off-by: Simon Glass Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc ht

Re: [PATCH 04/10] smbios: Use char consistently for the eos member

2021-01-08 Thread Christian Gmeiner
Am Do., 7. Jan. 2021 um 05:22 Uhr schrieb Simon Glass : > > At present a few of the structs use u8 instead of char. This is a string, > so char is better. Update them. > > Signed-off-by: Simon Glass Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc ht

[PATCH] x86: coreboot: add SMBIOS cbmem entry parsing

2020-05-14 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- arch/x86/cpu/coreboot/tables.c | 14 ++ arch/x86/include/asm/arch-coreboot/sysinfo.h | 2 ++ arch/x86/include/asm/coreboot_tables.h | 11 +++ 3 files changed, 27 insertions(+) diff --git a/arch/x86/cpu/coreboot

Re: [PATCH 1/1] fs: fat: remove superfluous assignments

2021-01-25 Thread Christian Gmeiner
n = itr->dent->nameext.name[0] & ~LAST_LONG_ENTRY_MASK; > > while (seqn--) { > + struct dir_entry *dent; > int ret; > > ret = delete_single_dentry(itr); > -- > 2.29.2 > -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH 07/16] arm: Remove ot1200 board

2021-02-17 Thread Christian Gmeiner
e > required. > I will drive tomorrow to the office to get my hands on the device again. On Monday I will ack this patch or will post some patches to keep the board. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH 07/16] arm: Remove ot1200 board

2021-03-01 Thread Christian Gmeiner
Am Mi., 17. Feb. 2021 um 10:58 Uhr schrieb Christian Gmeiner : > > Hi Tom > > Am Mi., 10. Feb. 2021 um 03:43 Uhr schrieb Tom Rini : > > > > This board relies on using CONFIG_LIBATA but does not enable CONFIG_AHCI. > > The > > deadline for this conversion wa

[U-Boot] [PATCH] usb: increase USB control timeout value

2019-11-21 Thread Christian Gmeiner
Increase USB control timeout value to 5000 milliseconds, matching the value used in Linux kernel. This improves communication stability with some USB devices. In the concrete case a Apacer AP8GAH322B gets not deteced in a silent console configuration. Signed-off-by: Christian Gmeiner

[PATCH] fs: fat: fix fat iteration

2020-06-09 Thread Christian Gmeiner
Windows. Fixes: 39606d462c ("fs: fat: handle deleted directory entries correctly") Signed-off-by: Christian Gmeiner --- fs/fat/fat.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 7fd29470c1..9578b74bae 100644 --- a/fs/fat/fat.c ++

Re: [PATCH] fs: fat: fix fat iteration

2020-06-09 Thread Christian Gmeiner
Hi Am Di., 9. Juni 2020 um 09:19 Uhr schrieb Heinrich Schuchardt : > > On 09.06.20 09:09, Christian Gmeiner wrote: > > According to the FAT specification it is valid to have files with an > > attribute value of 0x0. This fixes a regression where different U-Boot > > versio

[PATCH] net: e1000: add defaults for i210 TX/RX PBSIZE

2020-09-23 Thread Christian Gmeiner
ister from its default value, the e1000 driver doesn't function correctly. It detects a hang of the transmitter and continuously resets the adapter. Here we set this value to its default when resetting the i210 to resolve this issue. Signed-off-by: Christian Gmeiner --- drivers/net/e

Re: [PATCH] net: e1000: add defaults for i210 TX/RX PBSIZE

2020-10-06 Thread Christian Gmeiner
Hi Tom Am Mi., 30. Sept. 2020 um 22:54 Uhr schrieb Tom Rini : > > On Wed, Sep 23, 2020 at 05:05:44PM +0200, Christian Gmeiner wrote: > > > Set the defaults on probe for the packet buffer size registers > > for the i210. > > > > The TXPBSIZE register of the i210

[PATCH v2] net: e1000: add defaults for i210 TX/RX PBSIZE

2020-10-06 Thread Christian Gmeiner
her driver, another OS, etc.) modifies this register from its default value, the e1000 driver doesn't function correctly. It detects a hang of the transmitter and continuously resets the adapter. Here we set this value to its default when resetting the i210 to resolve this issue. Signed-of

[PATCH v2 1/2] smbios: add parsing API

2020-10-07 Thread Christian Gmeiner
Add an very simple API to be able to access SMBIOS strings like vendor, model and bios version. Signed-off-by: Christian Gmeiner --- include/smbios.h| 27 + lib/Kconfig | 6 +++ lib/Makefile| 1 + lib/smbios-parser.c | 96

[PATCH v2 2/2] coreboot: make use of smbios parser

2020-10-07 Thread Christian Gmeiner
any key to stop autoboot: 0 Signed-off-by: Christian Gmeiner --- board/coreboot/coreboot/coreboot.c | 45 ++ configs/coreboot_defconfig | 1 + 2 files changed, 46 insertions(+) diff --git a/board/coreboot/coreboot/coreboot.c b/board/coreboot/coreboot

[PATCH] arm: dts: ti: k3-am64-main: Add RTI watchdog nodes

2022-10-26 Thread Christian Gmeiner
Add the needed bus mappings for the two main RTI memory ranges and the required device tree nodes in the main domain. Same as kernel commit 6dd8457dc20693e2ba9054c171499b22664fd4e7 --- arch/arm/dts/k3-am64-main.dtsi | 18 ++ arch/arm/dts/k3-am64.dtsi | 2 ++ 2 files changed,

[PATCH v2] arm: dts: ti: k3-am64-main: Add RTI watchdog nodes

2022-10-26 Thread Christian Gmeiner
Add the needed bus mappings for the two main RTI memory ranges and the required device tree nodes in the main domain. Same as kernel commit 6dd8457dc20693e2ba9054c171499b22664fd4e7 Signed-off-by: Christian Gmeiner --- arch/arm/dts/k3-am64-main.dtsi | 18 ++ arch/arm/dts/k3-am64

Re: [PATCH v2] arm: dts: ti: k3-am64-main: Add RTI watchdog nodes

2022-11-04 Thread Christian Gmeiner
Am Do., 3. Nov. 2022 um 18:24 Uhr schrieb Tom Rini : > > On Thu, Nov 03, 2022 at 12:27:39AM -0500, Nishanth Menon wrote: > > On 13:15-20221026, Christian Gmeiner wrote: > > > Add the needed bus mappings for the two main RTI memory ranges and > > > the required device

Re: [PATCH 1/3] arm: dts: k3-am62x: sync dt with linux kernel

2022-11-04 Thread Christian Gmeiner
s files? > > I would also like to see a sync of all k3 dts files! Can you come up with such a patch the next days as it a duplicate of my patch here: https://patchwork.ozlabs.org/project/uboot/patch/20221026111556.1427201-1-christian.gmei...@gmail.com/ greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

[PATCH] arm: dts: ti: k3-am64-mcu: Add pinctrl

2022-12-05 Thread Christian Gmeiner
Add the definition of the pinctrl for the MCU domain. Same as kernel commit 500e6dfbb465531150ac6e2ff0856dd357ddc8a4 Signed-off-by: Christian Gmeiner --- arch/arm/dts/k3-am64-mcu.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/k3-am64-mcu.dtsi b/arch/arm/dts/k3

[PATCH] arch: arm: mach-k3: am642_init: bring back MCU_PADCFG_MMR1 unlock

2022-05-11 Thread Christian Gmeiner
Without this register unlock it is not possible to configure the pinmux used for mcu spi0. Fixes: 92e46092f2 ("arch: arm: mach-k3: am642_init: Probe ESM nodes") Signed-off-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [ANN] U-Boot v2022.07-rc4 released

2022-06-07 Thread Christian Gmeiner
re are any bug > fixes people are aware of that have not yet been applied, please let me > know. Can we land https://patchwork.ozlabs.org/project/uboot/patch/20220512062101.1786376-1-christian.gmei...@gmail.com/ ? -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] fs: fat: directory entries starting with 0x05

2020-11-22 Thread Christian Gmeiner
es: 39606d462c97 ("fs: fat: handle deleted directory entries correctly") > Signed-off-by: Heinrich Schuchardt Reviewed-by: Christian Gmeiner

[U-Boot] [PATCH] edid: add function to convert edid to fb_videomode

2014-01-04 Thread Christian Gmeiner
There may be some custom boards in the field which have an seperate eeprom chip to store edid informations in it. To make use of those edid information in the board code this patch add a function to convert edid to fb_videomode. Signed-off-by: Christian Gmeiner --- common/edid.c | 29

Re: [U-Boot] [PATCH] edid: add function to convert edid to fb_videomode

2014-01-04 Thread Christian Gmeiner
2014/1/4 Wolfgang Denk : > Dear Christian Gmeiner, > > In message <39679-8461-1-git-send-email-christian.gmei...@gmail.com> you > wrote: >> There may be some custom boards in the field which have >> an seperate eeprom chip to store edid informations in it. >

[U-Boot] [PATCH 2/5] imx: mx6q_4x_mt41j128.cfg: enable ecspi3 clocks

2014-01-07 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg b/board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg index bb6c60b..b9e107a 100644 --- a/board

[U-Boot] [PATCH 3/5] fdt: add fdt_add_display_timings(..)

2014-01-07 Thread Christian Gmeiner
; hfront-porch = <16>; vback-porch = <31>; vfront-porch = <12>; hsync-len = <96>; vsync-len = <2>; }; }; Signed-off-by: Christian Gmeiner --- common/fdt_support.c | 23

[U-Boot] [PATCH 4/5] imx6: add ot1200 mr board

2014-01-07 Thread Christian Gmeiner
connected via ldb (init and usage in linux only) + emmc Signed-off-by: Christian Gmeiner --- board/bachmann/ot1200/Makefile |9 ++ board/bachmann/ot1200/ot1200.c | 246 boards.cfg |1 + include/configs/ot1200.h | 241

[U-Boot] [PATCH 5/5] imx6: make use of lldiv(..)

2014-01-07 Thread Christian Gmeiner
Commit 762a88ccf8540948fbf8c31b40a29d1e0684a25b introduces a 64-bit division without using the lldiv() function, which pulls in previously unused libgcc stuff. Signed-off-by: Måns Rullgård Signed-off-by: Christian Gmeiner --- arch/arm/cpu/armv7/mx6/clock.c |3 ++- 1 file changed, 2

[U-Boot] [PATCH 1/5] edid: add function to convert edid to fb_videomode

2014-01-07 Thread Christian Gmeiner
There may be some custom boards in the field which have an seperate eeprom chip to store edid informations in it. To make use of those edid information in the board code this patch add a function to convert edid to fb_videomode. Signed-off-by: Christian Gmeiner --- common/edid.c | 29

Re: [U-Boot] [PATCH 2/5] imx: mx6q_4x_mt41j128.cfg: enable ecspi3 clocks

2014-01-08 Thread Christian Gmeiner
Hi Stefano, > > On 08/01/2014 08:24, Christian Gmeiner wrote: >> Signed-off-by: Christian Gmeiner >> --- >> board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/board/freescal

Re: [U-Boot] [PATCH 5/5] imx6: make use of lldiv(..)

2014-01-08 Thread Christian Gmeiner
Hi Stefano, 2014/1/8 Stefano Babic : > Hi Christian, > > On 08/01/2014 08:24, Christian Gmeiner wrote: >> Commit 762a88ccf8540948fbf8c31b40a29d1e0684a25b introduces >> a 64-bit division without using the lldiv() function, >> which pulls in previously unused libgcc stuff

Re: [U-Boot] [PATCH 4/5] imx6: add ot1200 mr board

2014-01-08 Thread Christian Gmeiner
HI Stefano, 2014/1/8 Stefano Babic : > Hi Christian, > > On 08/01/2014 08:24, Christian Gmeiner wrote: >> This patch add support for one device of the Bachmann OT1200 >> series - the mr variant. > > Nobody knows (at least, me !) what mr variant means. > its just a

Re: [U-Boot] [PATCH 2/5] imx: mx6q_4x_mt41j128.cfg: enable ecspi3 clocks

2014-01-08 Thread Christian Gmeiner
Hi Stefano, > >> >> On 08/01/2014 08:24, Christian Gmeiner wrote: >>> Signed-off-by: Christian Gmeiner >>> --- >>> board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg |2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>

Re: [U-Boot] [PATCH 3/5] fdt: add fdt_add_display_timings(..)

2014-01-08 Thread Christian Gmeiner
Hi Stefano, 2014/1/8 Stefano Babic : > Hi Christian, > > On 08/01/2014 08:24, Christian Gmeiner wrote: >> This new function is used to set all display-timings >> properties based on fb_videomode. >> >> display-timings { >> timing0 { >&

Re: [U-Boot] [PATCH 3/5] fdt: add fdt_add_display_timings(..)

2014-01-09 Thread Christian Gmeiner
HI Stephen. 2014/1/9 Stephen Warren : > On 01/09/2014 07:52 AM, Eric Nelson wrote: >> Hi Stefano, >> >> On 01/09/2014 03:44 AM, Stefano Babic wrote: >>> Hi Christian, >>> >>> On 09/01/2014 08:12, Christian Gmeiner wrote: >>> >>>

Re: [U-Boot] [PATCH 1/5] edid: add function to convert edid to fb_videomode

2014-01-13 Thread Christian Gmeiner
2014/1/12 Anatolij Gustschin : > On Wed, 8 Jan 2014 08:24:21 +0100 > Christian Gmeiner wrote: > >> There may be some custom boards in the field which have >> an seperate eeprom chip to store edid informations in it. >> To make use of those edid information in the boa

Re: [U-Boot] [PATCH 3/5] fdt: add fdt_add_display_timings(..)

2014-01-13 Thread Christian Gmeiner
t. Or update the existing node with new info. > Thanks for your comments... will come up with something in the next version of the patch series. thanks -- Christian Gmeiner, MSc ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] net/bootp: add CONFIG_BOOTP_BOOTFILE

2014-01-14 Thread Christian Gmeiner
In some cases the TFTP server provides a bootfile name, which does not expects our requirements. Make it possible to not store the TFTP provided bootfile in the environment. Signed-off-by: Christian Gmeiner --- README |4 net/bootp.c |2 ++ 2 files changed, 6 insertions

Re: [U-Boot] [PATCH 3/5] fdt: add fdt_add_display_timings(..)

2014-01-16 Thread Christian Gmeiner
Hi all 2014/1/14 Christian Gmeiner : > 2014/1/12 Anatolij Gustschin : >> Hi Stefano, >> >> On Wed, 08 Jan 2014 11:53:39 +0100 >> Stefano Babic wrote: >> ... >>> Agree that we have to sync u-boot and kernel, and this can be a way in >>> the sho

Re: [U-Boot] [PATCH] net/bootp: add CONFIG_BOOTP_BOOTFILE

2014-01-29 Thread Christian Gmeiner
2014-01-15 Wolfgang Denk : > Dear Christian Gmeiner, > > In message <1389688171-31688-1-git-send-email-christian.gmei...@gmail.com> > you wrote: >> In some cases the TFTP server provides a bootfile name, which >> does not expects our requirements. Make it pos

  1   2   3   4   >