Re: [U-Boot] [PATCH 2/6] efi_loader: Fix memory map size check to avoid out-of-bounds access

2016-09-30 Thread Brüns , Stefan
On Freitag, 30. September 2016 14:25:40 CEST Alexander Graf wrote: > On 30.09.16 02:03, Stefan Brüns wrote: > > memory_map_size as IN parameter specifies the size of the provided buffer. > > If the buffer is to small, memory_map_size is updated to indicate the > > required size, and an error code i

Re: [U-Boot] git send-email and patch headers/subject line

2016-10-04 Thread Brüns , Stefan
On Montag, 3. Oktober 2016 17:02:37 CEST Stephen Arnold wrote: > Howdy: > > I could swear this worked the last time I sent patches to the OE list > (at least it didn't need the gmail insecure app workaround so I guess > it was a while ago). > > Anyway, the real commit msg starts with ARM, I git f

Re: [U-Boot] [PATCH] test/py: Fix exception, do not parametrize with empty set

2016-10-17 Thread Brüns , Stefan
On Montag, 17. Oktober 2016 12:11:26 CEST Stephen Warren wrote: > On 10/16/2016 12:17 PM, Stefan Brüns wrote: > > If the parameter set is empty, the pytest setup fails: > > --- > > > > call: > ['env__dfu_config'], function test_dfu at [...]test_dfu.py:107> > > > > --- > > > > This abort

Re: [U-Boot] [RFC PATCH 3/4] ext4: fix endianess problems in ext4 write support

2016-08-16 Thread Brüns , Stefan
On Dienstag, 16. August 2016 13:41:21 CEST you wrote: > Hi Stefan, > > Am 2016-08-14 03:50, schrieb Stefan Bruens: > > On Freitag, 12. August 2016 15:16:20 CEST Michael Walle wrote: > >> All fields were accessed directly instead of using the proper byte > >> swap > >> functions. Thus, ext4 write s

Re: [U-Boot] ext4 delete file fails when ext4 extents enabled in filesystem

2016-09-02 Thread Brüns , Stefan
On Donnerstag, 1. September 2016 19:25:30 CEST you wrote: > On Donnerstag, 1. September 2016 16:08:51 CEST you wrote: > > Hi Stefan, > > > > applying patch [U-Boot,v4,06/13]ext4 and Michael Walles patch > > [U-Boot,v4,3/4]ext4, I'm now able to write into directories on ext4 fs > > from > > u-boot.

Re: [U-Boot] ext4 delete file fails when ext4 extents enabled in filesystem

2016-09-05 Thread Brüns , Stefan
On Freitag, 2. September 2016 14:51:59 CEST Thomas Schaefer wrote: > > -Ursprüngliche Nachricht- > > Von: Brüns, Stefan [mailto:stefan.bru...@rwth-aachen.de] > > Gesendet: Freitag, 2. September 2016 13:43 > > An: Thomas Schaefer > > Cc: u-boot@lists.denx.de;

Re: [U-Boot] [PATCH 2/2] fs/fat: Optimizes memory size with single global variable instead of 3

2016-09-09 Thread Brüns , Stefan
On Sonntag, 14. August 2016 00:57:38 CEST Benoît Thébaudeau wrote: > Hi, > > On Tue, Aug 2, 2016 at 9:35 PM, Benoît Thébaudeau > > wrote: > > On Tue, Aug 2, 2016 at 8:53 PM, Stephen Warren wrote: > >> On 07/28/2016 12:11 AM, Tien Fong Chee wrote: > >>> Single 64KB get_contents_vfatname_block g

Re: [U-Boot] [PATCH] ext4: fix possible crash on directory traversal, ignore deleted entries

2016-09-09 Thread Brüns , Stefan
On Freitag, 2. September 2016 10:53:08 CEST you wrote: > > > > Adding this to the current test script is somewhat problematic. The test > > runs all tests for fat and ext4, so each testcase should be file system > > agnostic. Unfortunately fat and ext4 (at least as implemented in U-Boot) > > have

Re: [U-Boot] [PATCH 3/3] test/fs: Check writes using "." (same dir) relative path

2016-09-13 Thread Brüns , Stefan
On Dienstag, 13. September 2016 12:36:26 CEST you wrote: > On 09/12/2016 04:04 PM, Stefan Bruens wrote: > > On Montag, 12. September 2016 12:44:08 CEST you wrote: > >> On 09/11/2016 02:46 PM, Stefan Brüns wrote: > >>> / and /./ should reference the same file. > >>> > >>> diff --git a/test/fs/fs-te

Re: [U-Boot] [PATCH 2/3] test/fs: Check ext4 behaviour if dirent is first entry in directory block

2016-09-13 Thread Brüns , Stefan
On Dienstag, 13. September 2016 12:33:15 CEST Stephen Warren wrote: > On 09/12/2016 03:48 PM, Stefan Bruens wrote: > > On Montag, 12. September 2016 12:39:35 CEST you wrote: > >> On 09/11/2016 02:46 PM, Stefan Brüns wrote: > >>> This is a regression test for a crash happening if the first dirent >

Re: [U-Boot] [PATCH v5 02/19] usb: dwc2: Use separate input and output buffers

2017-04-03 Thread Brüns , Stefan
On Montag, 3. April 2017 01:23:17 CEST you wrote: > Hi Stefan, > > On 2 April 2017 at 15:34, Stefan Bruens wrote: > > On Sonntag, 2. April 2017 17:43:38 CEST Simon Glass wrote: > >> Hi Stefan, > >> > >> On 2 April 2017 at 07:10, Stefan Bruens > > > > wrote: > >> > On Sonntag, 2. April 2017 05

Re: [U-Boot] usb: dwc2: invalidate the dcache before starting the DMA

2017-04-03 Thread Brüns , Stefan
On Samstag, 1. April 2017 08:51:39 CEST Eddie Cai wrote: > We should invalidate the dcache before starting the DMA. In case there are > any dirty lines from the DMA buffer in the cache, subsequent cache-line > replacements may corrupt the buffer in memory while the DMA is still going > on. Cache-li

Re: [U-Boot] [PATCH v5 02/19] usb: dwc2: Use separate input and output buffers

2017-04-03 Thread Brüns , Stefan
On Montag, 3. April 2017 17:38:40 CEST you wrote: > Hi Stefan, > > On 3 April 2017 at 08:26, Brüns, Stefan wrote: > > On Montag, 3. April 2017 01:23:17 CEST you wrote: > >> Hi Stefan, > >> > >> On 2 April 2017 at 15:34, Stefan Bruens > > >

Re: [U-Boot] [PATCH v5 02/19] usb: dwc2: Use separate input and output buffers

2017-04-03 Thread Brüns , Stefan
On Montag, 3. April 2017 20:18:42 CEST Brüns, Stefan wrote: > On Montag, 3. April 2017 17:38:40 CEST you wrote: > > > > What am I missing? > > The following is a gross oversimplification, but might explain it: > > 1. Assume all of the 64kB of the aligned_buffe

Re: [U-Boot] [PATCH] efi_loader: fix bug in efi_get_memory_map

2017-07-27 Thread Brüns , Stefan
On Mittwoch, 26. Juli 2017 22:25:29 CEST Rob Clark wrote: > On Wed, Jul 26, 2017 at 4:10 PM, Alexander Graf wrote: > > On 26.07.17 20:34, Rob Clark wrote: > >> When booting shim -> fallback -> shim -> grub -> linux the memory map is > >> a bit larger than the size linux passes in on the first call

Re: [U-Boot] TPM2.0 support in u-boot

2017-06-01 Thread Brüns , Stefan
On Montag, 29. Mai 2017 10:28:38 CEST peter.hu...@infineon.com wrote: > Hi, > > I was wondering if anyone is currently working on u-boot support for TPM2.0 > chips, especially the "native" spi versions. (i.e. direct access to the tpm > via spi, not via something like the pch) Having support for TP

Re: [U-Boot] [PATCH v3] drivers: usb: fsl-dt-fixup: Fix the dt for multiple USB nodes in single traversal of device tree

2016-10-28 Thread Brüns , Stefan
On Freitag, 28. Oktober 2016 01:52:26 CEST Marek Vasut wrote: [...] > > + > > +enum fdt_fsl_usb_erratum { > > + A006261, > > + A007075, > > + A007792, > > + A005697, > > + A008751, > > + FSL_USB_ERRATUM_END > > The compiler can assign completely arbitrary numbers to the enum > elements

Re: [U-Boot] [PATCH v3 2/3] spl: dfu: move DFU Kconfig to SPL Kconfig

2016-11-15 Thread Brüns , Stefan
On Dienstag, 15. November 2016 13:02:45 CET Stefan Agner wrote: > From: Stefan Agner > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index bb99f1f..54bcba3 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -497,6 +497,32 @@ config SPL_USB_SUPPORT > config option

Re: [U-Boot] ext4: crash when writing a file

2016-11-29 Thread Brüns , Stefan
On Dienstag, 29. November 2016 10:50:45 CET you wrote: > Hello, > > I am working on a i.MX6UL based board with a 4GB eMMC partitioned as > following: > > Device Boot Start End Sectors Size Id Type > /dev/sdb1 2048 264191 262144 128M 83 Linux > /dev/sdb2264192 445849

Re: [U-Boot] ext4: crash when writing a file

2016-11-29 Thread Brüns , Stefan
On Dienstag, 29. November 2016 14:10:54 CET Sébastien Szymanski wrote: > > > Btw, which u-boot version are you using? > > I first noticed the issue on U-Boot 2016.05 so I rebase on master from > http://git.denx.de/u-boot.git > > Regards, That still doesn't make clear on which version you see th

Re: [U-Boot] [PATCH] efi_loader: make pool allocations cacheline aligned

2017-08-02 Thread Brüns , Stefan
On Mittwoch, 2. August 2017 11:28:37 CEST Rob Clark wrote: > On Tue, Aug 1, 2017 at 9:10 PM, Heinrich Schuchardt [...] > >> > >> @@ -356,7 +356,8 @@ efi_status_t efi_allocate_pool(int pool_type, > >> unsigned long size,>> > >> { > >> > >> efi_status_t r; > >> efi_physical_addr_t t;

Re: [U-Boot] [PATCH] fs: add fs_readdir()

2017-08-03 Thread Brüns , Stefan
On Donnerstag, 3. August 2017 18:54:30 CEST Rob Clark wrote: > Needed to support efi file protocol. The fallback.efi loader wants > to be able to read the contents of the /EFI directory to find an OS > to boot. > > Currently only implemented for FAT, but that is all that UEFI is > required to sup

Re: [U-Boot] [PATCH v0 01/20] fs: add fs_readdir()

2017-08-07 Thread Brüns , Stefan
On Freitag, 4. August 2017 21:31:43 CEST Rob Clark wrote: > Needed to support efi file protocol. The fallback.efi loader wants > to be able to read the contents of the /EFI directory to find an OS > to boot. > > For reference, the expected EFI semantics are described in (v2.7 of UEFI > spec) in s

Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-08-14 Thread Brüns , Stefan
On Montag, 14. August 2017 15:16:15 CEST Rob Clark wrote: > And drop a whole lot of ugly code! > > Signed-off-by: Rob Clark > --- > fs/fat/fat.c | 723 > ++ include/fat.h | > 6 - > 2 files changed, 75 insertions(+), 654 deletions(-) Nic

Re: [U-Boot] [PATCH] fs: ext4: Fix journal overrun issue reported by Coverity

2017-08-22 Thread Brüns , Stefan
On Montag, 21. August 2017 04:30:15 CEST Tom Rini wrote: > While &p_jdb[fs->blksz] is a valid expression (it points *one* char > sized element past the end of the array, e.g. &p_jdb[fs->blksz + 1] is > invalid (according to the C standard (C99/C11)). > > Changing this to tag = (struct ext3_journal

Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden target $(obj)/helloworld.so:

2017-09-07 Thread Brüns , Stefan
On Sonntag, 3. September 2017 17:26:43 CEST Heinrich Schuchardt wrote: > On 09/03/2017 02:19 PM, Alexander Graf wrote: > > On 03.09.17 08:17, Heinrich Schuchardt wrote: > >> The target > >> $(obj)/helloworld.so: > >> exists twice in Makefile.lib. > >> > >> If you add an echo command to each of the

Re: [U-Boot] ext4: crash when writing a file

2017-01-23 Thread Brüns , Stefan
On Freitag, 20. Januar 2017 18:32:49 CET Sébastien Szymanski wrote: [...] > Then under the sandbox I do the following: > > U-Boot 2017.01-2-g558e41e-dirty (Jan 20 2017 - 16:19:47 +0100) > > DRAM: 256 MiB > MMC: > Using default environment > > In:serial > Out: serial > Err: serial >

[U-Boot] [PATCH] fs/fat: Fix unaligned __u16 reads for FAT12 access

2017-01-26 Thread Brüns , Stefan
Doing unaligned reads is not supported on all architectures, use byte sized reads of the little endian buffer. Rename off16 to off8, as it reflects the buffer offset in byte granularity (offset is in entry, i.e. 12 bit, granularity). Fix a regression introduced in 8d48c92b45aea91e2a2be90f2ed93677e8

[U-Boot] [PATCH v2] fs/fat: Fix unaligned __u16 reads for FAT12 access

2017-01-26 Thread Brüns , Stefan
Doing unaligned reads is not supported on all architectures, use byte sized reads of the little endian buffer. Rename off16 to off8, as it reflects the buffer offset in byte granularity (offset is in entry, i.e. 12 bit, granularity). Fix a regression introduced in 8d48c92b45aea91e2a2be90f2ed93677e8

Re: [U-Boot] [PATCH] bcm2835_wdt: support for the BCM2835/2836 watchdog

2017-01-27 Thread Brüns , Stefan
On Freitag, 27. Januar 2017 10:59:05 CET Paolo Pisati wrote: > Signed-off-by: Paolo Pisati > --- > arch/arm/mach-bcm283x/reset.c | 21 ++--- > board/raspberrypi/rpi/rpi.c| 4 > drivers/watchdog/Makefile | 1 + > drivers/watchdog/bcm2835_wdt.c | 34