d_tags: True
dry_run: True
and they start taking effect only after this patch.
Reviewed-by: Alper Nebi Yasak
Tested-by: Alper Nebi Yasak
>
> diff --git a/tools/patman/settings.py b/tools/patman/settings.py
> index 7c2b5c196c..658fe12be5 100644
> --- a/tools/patman/settings.py
&
On 25/04/2022 20:06, Angus Ainslie wrote:
> Initial commit of Librem5 u-boot and SPL
>
> Signed-off-by: Angus Ainslie
> Co-developed-by: Sebastian Krzyszkowiak
> Signed-off-by: Sebastian Krzyszkowiak
> ---
>
> All of the pre-requisite patches for this board are now upstream or in review.
>
>
entry/node for the input file. I've got this working as a proof
of concept, but I need to experiment more to see what works best.
Alper Nebi Yasak (7):
binman: Fix unique names having '/.' for images read from files
binman: Collect bintools for images when replacing entries
b
pping at the '/' node like how it
stops at the binman node. As the unique names are used as filenames, add
tests that check if they're safe to use as filenames.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/entry.py| 2 +-
tools/binman/ftest.py
when replacing entries to fix
Pack() errors. Add a way to mock bintool usage in the testing entry type
and tests that check bintools are being resolved for such an entry.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/control.py | 1 +
tools/binman/etype/_testi
s
constrained to its existing offset/size.
Add tests that replace an entry with smaller or equal-sized data, in an
image that doesn't allow repacking. Attempting to do so with bigger-size
data is already an error that is already being tested.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/
rrect data for a FIT
entry and its subentries.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/etype/fit.py | 2 +-
tools/binman/ftest.py | 35 +
tools/binman/test/233_fit_extract_replace.dts | 74 +++
3 files changed
oo' forms to the subentry node names. Extend the simple
FIT tests to check for this.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/etype/fit.py | 13 -
tools/binman/ftest.py | 7 +++
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/tools/binman/etype
sizes. Replacing the subsections or the whole FIT section does
not work yet due to the section contents being re-built from unreplaced
subentries' data.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/ftest.py | 38 ++
1 file changed, 38 insertions(+)
ently pretending it was
replaced.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/etype/section.py | 3 +++
tools/binman/ftest.py | 9
.../test/234_replace_section_simple.dts | 23 +++
3 files changed, 35 insertions(+)
create
--
> Ran 48 tests in 4.469s
>
> FAILED (failures=1, errors=1, skipped=1)
There are some weird parts in this as well, like the stdout/stderr being
quoted with braces and test descriptions being the same as test names,
but they're quirks of the libraries used for concurr
When printing a python tool's test results, the entire list of failed
tests and their tracebacks are reprinted for every failed test. This
makes the test output quite unreadable. Fix the loop to print failures
and tracebacks one at a time.
Signed-off-by: Alper Nebi Yasak
---
tools/p
tests from multiple places one by one and the test we want only
exists in one.
The test_util helpers currently remove these fake tests when printing
test results, but that's more of a workaround than a proper solution.
Instead, don't even try to load the missing tests.
Signed-off-
By default, unittest test summaries only print extended info about tests
that failed or couldn't run due to an error. Use a custom text result
class to print info about more cases: skipped tests, expected failures
and unexpected successes.
Signed-off-by: Alper Nebi Yasak
---
This cou
hable in
the CI output.
Signed-off-by: Alper Nebi Yasak
---
tools/binman/main.py | 8 ++
tools/buildman/main.py| 8 ++
tools/dtoc/main.py| 9 +++---
tools/dtoc/test_fdt.py| 8 +++---
tools/patman/main.py | 8 ++
tools/patman/te
erged into their test's
error traceback message, which is later rebuilt into an exception and
passed to our unittest report class.
Signed-off-by: Alper Nebi Yasak
---
The way I had to do this for concurrencytest feels hacky, so I am
ambivalent towards this patch. I'm actually fine with
e changed, 10 insertions(+), 17 deletions(-)
Reviewed-by: Alper Nebi Yasak
> diff --git a/tools/dtoc/test_fdt.py b/tools/dtoc/test_fdt.py
> index 914ed6aed59..3859af8d032 100755
> --- a/tools/dtoc/test_fdt.py
> +++ b/tools/dtoc/test_fdt.py
> @@ -780,25 +780,17 @@ def RunTests(args)
On 22/03/2022 00:43, Ivan Mikhaylov wrote:
> Introduce proof of concept for binman's new option which provides sign
> and replace sections in binary images.
>
> Usage as example:
>
> from:
> mkimage -G privateky -r -o sha256,rsa4096 -F fit
> binman replace -i flash.bin -f fit.fit fit
>
> to:
> b
On 06/04/2022 23:28, Ivan Mikhaylov wrote:
> On Tue, 2022-04-05 at 21:54 +0300, Alper Nebi Yasak wrote:
>> On 22/03/2022 00:43, Ivan Mikhaylov wrote:
>>> Introduce proof of concept for binman's new option which provides
>>> sign
>>> and replace sections i
we don't use Ubuntu 16.04 for our CI anymore drop the import.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> tools/binman/main.py | 7 ---
> 1 file changed, 7 deletions(-)
I see the same warnings (and error) on Debian unstable as it started
using Python 3.10 by default. This fixes them for me as well.
Reviewed-by: Alper Nebi Yasak
I initially ignored this test because I didn't like the implementation
anyway, but I disagree with some of Sean's comments here so I wanted to
add on what I think.
On 08/04/2022 22:26, Ivan Mikhaylov wrote:
> On Fri, 2022-04-08 at 11:39 -0400, Sean Anderson wrote:
>> On 3/21/22 5:43 PM, Ivan Mikha
On 10/05/2022 23:05, Tom Rini wrote:
> Adding the other binman maintainer..
Thanks. I haven't been able to focus on anything for a while. I'll try
to review the few series that have accumulated, maybe can manage this
week or so if things go well. Just wanted to send an update.
On 27/04/2022 12:22, Johan Jonker wrote:
> [...]
>
> There's a trend to solve everything in python.
> Don't have knowledge about python, but there's a 3rd image format for
> NAND [1]. Could someone advise how to fit the extra XXX padding option
> in the mkimage.py file? (Simon ?)
Binman's mkimage
On 16/05/2022 14:07, Andrew Abbott wrote:
> My original goal was to produce SPI images for Rockchip platforms
> (specifically
> for me, ROCKPro64, and in the future ROCK64). Looking into it, it seemed nicer
> to just switch the SD/MMC image generation over to binman as well in the
> process.
>
>
On 16/05/2022 14:07, Andrew Abbott wrote:
> mkimage supports combining multiple input binaries separating them
> with colons (':'). This is used at least for Rockchip platforms to
> encode payload offsets and sizes in the image header. It is required for
> Rockchip SPI boot since for the rkspi form
On 16/05/2022 14:07, Andrew Abbott wrote:
> Currently, building for Rockchip targets produces:
>
> - idbloader.img
> - rksd-formatted TPL with SPL appended; or
> - rksd-formatted SPL
> - u-boot.itb
> - U-Boot Proper FIT image
> - u-boot-rockchip.bin
> - idbloader.img + u-boot.itb,
On 16/05/2022 14:07, Andrew Abbott wrote:
> This pulls in binman definitions so images can be built for all
> Rockchip platforms.
>
> Signed-off-by: Andrew Abbott
> ---
See Simon's patch [1] for this, which contains these changes and is more
complete. I think the 'imply BINMAN's there achieve th
On 16/05/2022 14:07, Andrew Abbott wrote:
> This needs to be accessible to binman (via CONFIG_ preprocessor macros)
> so it can build SPI images using the correct offset.
>
> The documentation at 'doc/device-tree-bindings/config.txt' says that
> the 'u-boot,spl-payload-offset' device tree option s
On 16/05/2022 14:07, Andrew Abbott wrote:
> Binman is now being used to build the final flashable images for
> Rockchip devices, thus enabling it for all Rockchip targets here. But
> it is not yet being used to generate the FIT image (u-boot.itb),
> thus we need to force it to be built.
>
> Signed
On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> set the symbol as weak not work if LTO is enabled. Since u_boot_any is
> only used on X86 for now, so guard it with X86, otherwise build break
> if we use BINMAN_SYMBOLS on i.MX.
>
> Tested-by: Tim Harvey #imx8m[m,n,p]-venice
> Sig
On 21/05/2022 15:05, Tom Rini wrote:
> On Sat, May 21, 2022 at 08:33:56AM +, Peng Fan wrote:
>>> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86
>>>
>>> On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote:
>>>
From: Peng Fan
set the symbol as weak not work
On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> We are migrating to use BINMAN SYMBOLS, the current name is not
> a valid binman type, so update to use blob-ext@[1,2,3,4].
>
> Tested-by: Tim Harvey #imx8m[m,n,p]-venice
> Signed-off-by: Peng Fan
> ---
> arch/arm/dts/imx8mm-u-bo
On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> Use BINMAN instead of imx specific packing method.
>
> Signed-off-by: Peng Fan
> ---
> arch/arm/mach-imx/imx8m/Kconfig | 1 +
> arch/arm/mach-imx/imx8m/imximage-8mm-lpddr4.cfg | 10 +-
Maybe this could be
On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> In arch/arm/dts/imx8mp-u-boot.dtsi, there are blob-ext@1, blob-ext@2 and
> etc which is for packing ddr phy firmware. However we could not declare
> symbol name such as 'binman_sym_declare(ulong, blob_ext@1, image_pos)',
> because '@
On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> By reading binman symbols, we no need hard coded IMEM_LEN/DMEM_LEN after
> we update the binman dtsi to drop 0x8000/0x4000 length for the firmware.
>
> And that could save binary size for many KBs.
>
> Tested-by: Tim Harvey #imx8m
On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> There is case that CONFIG_BINMAN is defined, but
> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and
> define CONFIG_SPL_BINMAN_SYMBOLS in
On 22/05/2022 17:50, Tom Rini wrote:
> On Sun, May 22, 2022 at 04:56:08PM +0300, Alper Nebi Yasak wrote:
>> It looks like we should be able to change things in common/spl/spl.c to:
>>
>> #if CONFIG_IS_ENABLED(BINMAN_SYMBOLS)
>> /* See spl.h
On 23/05/2022 17:10, Tom Rini wrote:
> On Mon, May 23, 2022 at 06:28:44AM +, Peng Fan (OSS) wrote:
>>> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86
>>>
>>> Why are you mentioning LTO in the commit message? When I read the
>>> commit message it sounds like you're saying the proble
On 23/05/2022 10:01, Peng Fan (OSS) wrote:
>> Subject: Re: [PATCH V4 2/8] arm: dts: imx8m: update binman ddr firmware
>> node name
>>
>> On 20/05/2022 17:10, Peng Fan (OSS) wrote:
>>> From: Peng Fan
>>>
>>> We are migrating to use BINMAN SYMBOLS, the current name is not a
>>> valid binman type, so
On 20/05/2022 17:10, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> After we switch to use BINMAN_SYMBOLS, there is no need to pad
> the file size to 0x8000 and 0x4000. After we use BINMAN_SYMBOLS,
> the u-boot-spl-ddr.bin shrink about 36KB with i.MX8MP-EVK.
>
> Tested-by: Tim Harvey #imx8m[m,n,p]-
On 24/05/2022 11:00, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> We are migrating to use BINMAN SYMBOLS, the current name is not
> a valid binman type, so update to unify them.
'not a valid binman type, so' here is misleading. Names do not need to
be binman types if you have the 'type' property.
On 24/05/2022 11:00, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> In arch/arm/dts/imx8mp-u-boot.dtsi, there are blob-ext@1, blob-ext@2 and
> etc which is for packing ddr phy firmware. However we could not declare
> symbol name such as 'binman_sym_declare(ulong, blob_ext@1, image_pos)',
> because '@
On 24/05/2022 11:00, Peng Fan (OSS) wrote:
> By default when BINMAN_SYMBOLS is enabled, common/spl/spl.c has a code
> piece `binman_sym_declare(ulong, u_boot_any, image_pos);` which requires
> u-boot* node in device tree binman node section. But some
> platforms(i.MX8M) not need it. To avoid build
On 24/05/2022 11:00, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> There is case that CONFIG_BINMAN is defined, but
> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and
> define CONFIG_SPL_BINMAN_SYMBOLS in
On 26/05/2022 17:15, Tom Rini wrote:
> On Thu, May 26, 2022 at 10:28:45AM +0300, Roger Quadros wrote:
>> Any thoughts on how to get the new ti-secure etype work with atf-bl31 and
>> tee-os etypes so that it can take the data output of those entries and create
>> a signed binary with filenames from
x the boot on the imx8mn evk LPDDR4 variant.
>
> Signed-off-by: Fabio Estevam
> ---
> arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Alper Nebi Yasak
> diff --git a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> b/arc
e to binman, since
it's not as good at deconstructing things. I can't say I understand
OP-TEE OS or its files/formats, so:
Acked-by: Alper Nebi Yasak
> diff --git a/arch/arm/mach-rockchip/make_fit_atf.py
> b/arch/arm/mach-rockchip/make_fit_atf.py
> index f3224d2555..fcea6523
On 28/05/2022 01:08, Jerome Forissier wrote:
> On 5/27/22 21:24, Alper Nebi Yasak wrote:
>> On 11/05/2022 18:35, Jerome Forissier wrote:
>>> +if paged_sz != 0:
>>> +raise ValueError("OP-TEE paged mode not supported")
>>
>>
On 22/05/2022 03:55, Andrew Abbott wrote:
> On Thu May 19, 2022 at 9:36 PM AEST, Alper Nebi Yasak wrote:
>> Do we need the 'idbloader.img' as a build output, assuming we have a
>> working 'u-boot-rockchip.bin'? I'm asking because Simon was trying to
>&
On 02/06/2022 13:43, Jens Wiklander wrote:
> On Thu, Jun 2, 2022 at 9:50 AM Jerome Forissier
> wrote:
>> On 5/29/22 18:08, Alper Nebi Yasak wrote:
>>> Why I am asking these is that I'm hypothesizing we can put the
>>> unmodified 'tee.bin' (including he
On 31/05/2022 17:15, Andrew Davis wrote:
> On 5/31/22 12:06 AM, Roger Quadros wrote:
>> On 27/05/2022 20:50, Alper Nebi Yasak wrote:
>>> This would definitely work, see etype/mkimage.py for example. I'd prefer
>>> to know the file-format details (and maybe repl
On 01/06/2022 11:29, Stefan Herbrechtsmeier wrote:
> Hi Simon,
>
> I want to compress a FPGA Image on the fly via binman but this doesn't
> work. I have add a bintool implementation for gzip, add gzip support to
> comp_util.py and set `compress` and `compression` property in the binman
> node o
; Signed-off-by: Peng Fan
> ---
> common/spl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Alper Nebi Yasak
gned-off-by: Peng Fan
> ---
> configs/imx8mm_data_modul_edm_sbc_defconfig | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Alper Nebi Yasak
8mq-cm-u-boot.dtsi| 12
> arch/arm/dts/imx8mq-u-boot.dtsi | 8 ----
> 10 files changed, 58 insertions(+), 38 deletions(-)
Reviewed-by: Alper Nebi Yasak
age_copy_start' for binman update image-pos/size.
>
> So update link file
>
> Reviewed-by: Tom Rini
> Tested-by: Tim Harvey #imx8m[m,n,p]-venice
> Signed-off-by: Peng Fan
> ---
> arch/arm/cpu/armv8/u-boot-spl.lds | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Alper Nebi Yasak
t; Tested-by: Tim Harvey #imx8m[m,n,p]-venice
> Signed-off-by: Peng Fan
> ---
> drivers/ddr/imx/imx8m/helper.c | 51 --
> 1 file changed, 43 insertions(+), 8 deletions(-)
Reviewed-by: Alper Nebi Yasak
| 8
> arch/arm/dts/imx8mq-cm-u-boot.dtsi| 8
> arch/arm/dts/imx8mq-u-boot.dtsi | 8
> 10 files changed, 38 insertions(+), 38 deletions(-)
Reviewed-by: Alper Nebi Yasak
onf.h | 3 +++
> tools/binman/test/u_boot_binman_syms.c | 2 +-
> tools/binman/test/u_boot_binman_syms_size.c | 2 +-
> 5 files changed, 7 insertions(+), 4 deletions(-)
> create mode 100644 tools/binman/test/generated/autoconf.h
Reviewed-by: Alper Nebi Yasak
--
> configs/imx8mm-icore-mx8mm-ctouch2_defconfig| 2 +-
> configs/imx8mm-icore-mx8mm-edimm2.2_defconfig | 2 +-
> 4 files changed, 4 insertions(+), 11 deletions(-)
Reviewed-by: Alper Nebi Yasak
On 06/06/2022 17:07, Marek Vasut wrote:
> On 6/3/22 09:17, Peng Fan (OSS) wrote:
>> From: Peng Fan
>>
>> i.MX8M use FIT image, not RAW image. And to support binman symbols,
>> u_boot_any could be optimized if RAW image is not selected, otherwise
>> there will be build failure. So not select SPL_RA
On 03/06/2022 18:07, Stefan Herbrechtsmeier wrote:
> Am 02.06.2022 um 20:10 schrieb Alper Nebi Yasak:
>> On 01/06/2022 11:29, Stefan Herbrechtsmeier wrote:
>>> Hi Simon,
>>>
>>> I want to compress a FPGA Image on the fly via binman but this doesn't
>>
On 07/06/2022 21:11, Marek Vasut wrote:
> On 6/7/22 19:26, Alper Nebi Yasak wrote:
>> On 06/06/2022 17:07, Marek Vasut wrote:
>>> On 6/3/22 09:17, Peng Fan (OSS) wrote:
>>>> From: Peng Fan
>>>>
>>>> i.MX8M use FIT image, not RAW image. A
#20220610.3 spl: binman: Fixes for BINMAN_SYMBOLS
https://dev.azure.com/u-boot/u-boot/_build/results?buildId=4431&view=results
Alper Nebi Yasak (5):
spl: binman: Fix use of undeclared u_boot_any symbols
spl: binman: Make TPL_BINMAN_SYMBOLS depend on TPL_FRAMEWORK
spl: binman: Declare extern
returning early
in those cases.
Signed-off-by: Alper Nebi Yasak
---
common/spl/spl.c | 10 +++---
common/spl/spl_ram.c | 2 +-
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c
index 2a69a7c9324d..5630dcdb5c1e 100644
--- a/common/spl/spl.c
++
igned-off-by: Alper Nebi Yasak
---
common/spl/Kconfig.tpl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl
index 9a0e719cf949..834cb6b6dd82 100644
--- a/common/spl/Kconfig.tpl
+++ b/common/spl/Kconfig.tpl
@@ -10,7 +10,7 @@ c
The binman extern symbol declarations in spl.h are missing the VPL
symbols recently added to spl.c, add them like the others.
Signed-off-by: Alper Nebi Yasak
---
include/spl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/spl.h b/include/spl.h
index 83ac583e0b49..1778e0f53686
The SPL/TPL_BINMAN_SYMBOLS config only disables the u_boot_any symbol.
Extend its #if directive to cover declarations for all phases. Update
the Kconfig prompt and help message to make it clearer about this.
Signed-off-by: Alper Nebi Yasak
---
common/spl/Kconfig | 12 ++--
common
The SPL code declares binman symbols for U-Boot phases depending on
CONFIG_IS_ENABLED(BINMAN_SYMBOLS). This config exists for SPL and TPL,
also add a version for VPL.
Signed-off-by: Alper Nebi Yasak
---
common/spl/Kconfig.vpl | 12
1 file changed, 12 insertions(+)
diff --git a
On 08/06/2022 01:54, Marek Vasut wrote:
> I still don't see why we should randomly damage board configs to work
> around what looks like a bug in binman -- are we now implementing
> workarounds instead of trying to fully understand issues and implement
> proper fixes for those ?
>
> Why can't w
On 04/06/2022 14:50, Alper Nebi Yasak wrote:
> On 03/06/2022 10:17, Peng Fan (OSS) wrote:
>> From: Peng Fan
>>
>> There is case that CONFIG_BINMAN is defined, but
>> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
>> build failure. So use C
On 11/06/2022 13:32, Peng Fan (OSS) wrote:
> 在 2022/6/11 0:47, Alper Nebi Yasak 写道:
>> I have sent a patch [1] that fixes the build error mentioned here, which
>> should be used instead of this patch. Please:
>>
>> - Rebase on top of that series [1]
>> - Maybe d
On 09/10/2021 18:24, Kever Yang wrote:
> On 2021/10/9 上午1:33, Philipp Tomsich wrote:
>> Could you point me to a public version of the TRM (and
>> ideally also of the datasheet), so I can review this series?
>
> I believe there is no public TRM or datasheet for rk3568 is available
> for now.
I se
~51.5 MiB/s
256MiB Load Speed | ~177.8 MiB/s | ~114.5 MiB/s
Listing partitions, listing files, reading files and the loaded bytes
all look fine to me, but I'm not sure I haven't missed anything.
Alper Nebi Yasak (3):
mmc: sdhci: Add HS400 Enhanced Strobe support
r
Delegate setting the Enhanced Strobe configuration to individual drivers
if they set a function for it. Return -ENOTSUPP if they do not, like
what the MMC uclass does.
Signed-off-by: Alper Nebi Yasak
---
drivers/mmc/sdhci.c | 18 ++
include/sdhci.h | 1 +
2 files changed
tree).
Signed-off-by: Alper Nebi Yasak
---
drivers/mmc/rockchip_sdhci.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
index 278473899c7c..7457255fa080 100644
--- a/drivers/mmc/rockchip_sdhci.c
+++ b/dr
configuration is requested.
This is mostly ported from Linux' Synopsys DWC MSHC driver which happens
to be the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in Linux
tree).
Signed-off-by: Alper Nebi Yasak
---
Merely build-tested as I don't have a RK3568 board.
drivers/mmc/rockchip_sd
On 01/11/2021 12:07, Alper Nebi Yasak wrote:
> I'm trying this with "load mmc 0:1 0xd000 /bigfile $size" and getting
> the following speeds; and with "mmc info" the following differences:
>
> gru-kevin mmc0 | w/o t
On 01/11/2021 12:19, Jaehoon Chung wrote:
> On 11/1/21 6:07 PM, Alper Nebi Yasak wrote:
>> I'm trying this with "load mmc 0:1 0xd000 /bigfile $size" and getting
>> the following speeds; and with "mmc info" the following differences:
>>
>>
On 01/11/2021 14:18, Jack Mitchell wrote:
> On 01/11/2021 09:07, Alper Nebi Yasak wrote:
>> I'm trying to make my gru-kevin's eMMC work properly (it times out while
>> tuning for HS400 and stops working when reinitialized via "mmc dev 0").
>
> I'm al
Hi,
I've had some recent success with my gru-kevin and wanted to update you
on this. Long story short, I can boot from SPI flash and have the
display, keyboard, eMMC, microSD card, USB disks all work (however with
some hacks); but can't boot into Linux. Things seem to hang shortly
after "Starting
On 02/11/2021 11:09, Peter Robinson wrote:
> On Mon, Nov 1, 2021 at 11:25 PM Alper Nebi Yasak
> wrote:
>> some hacks); but can't boot into Linux. Things seem to hang shortly
>> after "Starting kernel..." but I don't know if something fails in U-Boot
>>
On 06/11/2021 06:16, Simon Glass wrote:
> On Tue, 2 Nov 2021 at 17:05, Simon Glass wrote:
>> On Mon, 1 Nov 2021 at 17:25, Alper Nebi Yasak
>> wrote:
>>> Most of the patches are small config and dts changes that I've grouped
>>> by whatever effect they have
On 12/11/2021 19:39, Tom Rini wrote:
> On Fri, Nov 12, 2021 at 11:35:15AM +0300, Aleksei wrote:
>
>> Hi U-boot developers,
>> I'm booting RockPro64 by writing compiled u-boot-rockchip.bin to SD card
>> offset
>> 64 as described in doc/board/rockchip/rockchip.rst. There is a USB flash
>> drive
>>
On 28/12/2021 11:34, Simon Glass wrote:
> Should add comments for the struct
I can do that and send as a v3.
> Also I wonder if a simple fixed-length array might be possible instead
> of the linked list?
I think it's possible, my first prototype was something like:
#define MAX_PHYS 16
stru
On 28/12/2021 16:08, Simon Glass wrote:
> On Tue, 28 Dec 2021 at 05:55, Tom Rini wrote:
>> Thanks for the review Simon. Since I think this should unblock some
>> common hardware, does everyone think this should be safe enough to pull
>> in now, or no, I shouldn't bend the rules, and take this for
nges those would
require, this patch solves things by dynamically allocating a list of
structs (one per instance) in the provider's uclass-private area.
Signed-off-by: Alper Nebi Yasak
Reviewed-by: Simon Glass
---
Changes in v3:
- Add tag: "Reviewed-by: Simon Glass "
-
3399_set_enhanced_strobe -> rk3399_sdhci_set_enhanced_strobe
- Rename rk3568_set_enhanced_strobe -> rk3568_sdhci_set_enhanced_strobe
- Let set_enhanced_strobe() unset the ES bit if mode is not HS400_ES
- Rewrote cover letter
v1: https://patchwork.ozlabs.org/project/uboot/list/?series=269768
Alper Nebi Y
Delegate setting the Enhanced Strobe configuration to individual drivers
if they set a function for it. Return -ENOTSUPP if they do not, like
what the MMC uclass does.
Signed-off-by: Alper Nebi Yasak
Reviewed-by: Jaehoon Chung
---
Changes in v2:
- Add tag: "Reviewed-by: Jaehoon
least on a chromebook_kevin.
Signed-off-by: Alper Nebi Yasak
---
RK3568 parts only build-tested as I don't have a RK3568 board.
Changes in v2:
- Add this patch
drivers/mmc/rockchip_sdhci.c | 53 +---
1 file changed, 43 insertions(+), 10 deletions(-)
diff --gi
().
This is mostly ported from Linux's Arasan SDHCI driver which happens
to be the underlying IP. (drivers/mmc/host/sdhci-of-arasan.c in Linux
tree).
Signed-off-by: Alper Nebi Yasak
---
Didn't add Reviewed-by tag due to changes.
Changes in v2:
- Unset ES bit in rk3399 set_control_reg(
configuration is requested.
This is mostly ported from Linux's Synopsys DWC MSHC driver which
happens to be the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in
Linux tree).
Signed-off-by: Alper Nebi Yasak
---
Didn't add Reviewed-by tag due to changes. Only build-tested as I don'
On 12/01/2022 05:03, 赵仪峰 wrote:
> The Synopsys DWC MSHC for RK3568 and RK3588 need config
> DWCMSHC_EMMC_CONTROL.bit0 = 1 （CARD_IS_EMMC）
> to enable Data Strobe pin for HS400 and HS400ES.
>
> reference code:
> #define DWCMSHC_EMMC_CONTROL 0x52c
> #define DWCMSHC_CARD_IS_EMMC BIT(0)
>
> /* set CAR
unset the ES bit if mode is not HS400_ES
- Rewrote cover letter
v1: https://patchwork.ozlabs.org/project/uboot/list/?series=269768
Alper Nebi Yasak (4):
mmc: sdhci: Add HS400 Enhanced Strobe support
rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
rockchip: sdhci: Add HS400 Enhanced Strobe
Delegate setting the Enhanced Strobe configuration to individual drivers
if they set a function for it. Return -ENOTSUPP if they do not, like
what the MMC uclass does.
Signed-off-by: Alper Nebi Yasak
Reviewed-by: Jaehoon Chung
---
(no changes since v2)
Changes in v2:
- Add tag: "Review
least on a chromebook_kevin.
Signed-off-by: Alper Nebi Yasak
---
RK3568 parts only build-tested as I don't have a RK3568 board.
(no changes since v2)
Changes in v2:
- Add this patch
drivers/mmc/rockchip_sdhci.c | 53 +---
1 file changed, 43 insertions(+
().
This is mostly ported from Linux's Arasan SDHCI driver which happens
to be the underlying IP. (drivers/mmc/host/sdhci-of-arasan.c in Linux
tree).
Signed-off-by: Alper Nebi Yasak
---
(no changes since v2)
Changes in v2:
- Unset ES bit in rk3399 set_control_reg() to fix a reinit issue
-
e the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in
Linux tree).
Signed-off-by: Alper Nebi Yasak
---
Only build-tested as I don't have a RK3568 board.
Changes in v3:
- Set DWCMSHC_CARD_IS_EMMC bit in rk3568_emmc_phy_init()
Changes in v2:
- Rename rk3568_set_enhan
On 21/01/2022 06:25, Simon Glass wrote:
> On Sun, 16 Jan 2022 at 13:18, Alper Nebi Yasak
> wrote:
>> mmc: sdhci: Add HS400 Enhanced Strobe support
>> rockchip: sdhci: Fix RK3399 eMMC PHY power cycling
>> rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3
On 19/10/2020 05:41, Simon Glass wrote:
> Create a new _BuildSectionData() to hold the code that is now in
> GetData(), so that it is clearly separated from entry.GetData() base
> function.
>
> Separate out the 'pad-before' processing to make this easier to
> understand.
>
> Unfortunately this br
201 - 300 of 466 matches
Mail list logo
