Re: [PATCH 23/40] lmb: add a flags parameter to the API's

2024-08-09 Thread Sughosh Ganu
On Thu, 8 Aug 2024 at 19:58, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 7 Aug 2024 at 00:32, Sughosh Ganu wrote: > > > > On Wed, 7 Aug 2024 at 03:21, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > On Mon, 5 Aug 2024 at 05:55, Sughosh Ganu wrote: > > > > > > > > On Mon, 29 Jul 2024 a

Re: [PATCH] rockchip: configs: puma-rk3399: disable VIDEO support that breaks Linux

2024-08-09 Thread Kever Yang
On 2024/7/29 19:04, Quentin Schulz wrote: From: Quentin Schulz RK3399 Puma has support for driving multiple displays at the same time, the most notable scenario being HDMI+DSI since there exists a devkit with both DSI display and HDMI output. While HDMI seems to work fine in U-Boot, as the U

Re: [PATCH v2 1/2] rockchip: rk3308: Remove OTP device node from soc u-boot dtsi

2024-08-09 Thread Kever Yang
On 2024/7/30 22:27, Jonas Karlman wrote: The merged upstream DT node for OTP differs in nodename and will cause following build errors once rk3308.dtsi in dts/upstream is updated: ERROR (duplicate_label): /nvmem@ff21: Duplicate label 'otp' on /nvmem@ff21 and /efuse@ff21 ERRO

Re: [PATCH v2 2/2] arm64: dts: rockchip: Add OTP device node for RK3308

2024-08-09 Thread Kever Yang
On 2024/7/30 22:27, Jonas Karlman wrote: The RK3308 SoC contains a controller for one-time-programmable memory, add a device node for it. Signed-off-by: Jonas Karlman Link: https://lore.kernel.org/r/20240521211029.1236094-9-jo...@kwiboo.se Signed-off-by: Heiko Stuebner [ upstream commit: 36

Re: [PATCH 1/2] arm64: dts: rockchip: Add Radxa ROCK 3B

2024-08-09 Thread Kever Yang
On 2024/7/31 15:28, Jonas Karlman wrote: The Radxa ROCK 3B is a single-board computer based on the Pico-ITX form factor (100mm x 75mm). Two versions of the ROCK 3B exists, a community version based on the RK3568 SoC and an industrial version based on the RK3568J SoC. Add initial support for eM

Re: [PATCH 2/2] board: rockchip: Add Radxa ROCK 3B

2024-08-09 Thread Kever Yang
On 2024/7/31 15:28, Jonas Karlman wrote: The Radxa ROCK 3B is a single-board computer based on the Pico-ITX form factor (100mm x 75mm). Two versions of the ROCK 3B exists, a community version based on the RK3568 SoC and an industrial version based on the RK3568J SoC. Features tested on ROCK 3B

Re: [PATCH 2/2] board: rockchip: Add Xunlong Orange Pi 3B

2024-08-09 Thread Kever Yang
On 2024/7/31 17:03, Jonas Karlman wrote: From: Ricardo Pardini The Xunlong Orange Pi 3B is a single-board computer based on the Rockchip RK3566 SoC. The two hw revisions use different io-voltage for Ethernet PHY and can be identified using GPIO4_C4: - v1.1.1: x (internal pull-down) - v2.1:

Re: [PATCH 1/2] arm64: dts: rockchip: Add Xunlong Orange Pi 3B

2024-08-09 Thread Kever Yang
On 2024/7/31 17:03, Jonas Karlman wrote: The Xunlong Orange Pi 3B is a single-board computer based on the Rockchip RK3566 SoC. Add initial support for eMMC, SD-card, Ethernet, HDMI, PCIe and USB. Signed-off-by: Jonas Karlman Link: https://lore.kernel.org/r/20240626230319.1425316-3-jo...@kwib

[PATCH 3/8] net: dc2114x: set the card number to start at zero

2024-08-09 Thread Hanyuan Zhao
Otherwise the number might get kind of weird. Signed-off-by: Hanyuan Zhao --- drivers/net/dc2114x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dc2114x.c b/drivers/net/dc2114x.c index 7f0715429f..cf9f78163a 100644 --- a/drivers/net/dc2114x.c +++ b/drivers/net/

[PATCH 2/8] net: dc2114x: get mac address from environment

2024-08-09 Thread Hanyuan Zhao
Let this old driver work like the other newer network card drivers, loading the MAC address from environment, which could be more flexible to set. Signed-off-by: Hanyuan Zhao --- drivers/net/dc2114x.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/n

[PATCH 4/8] net: dc2114x: add support for CPUs that have cache between the memory and the card

2024-08-09 Thread Hanyuan Zhao
This commit adds support for the MIPS and LoongArch CPUs, which would use cache after they jump into U-Boot. This commit requests the CPU to return the addresses in uncached windows and flushes the cache in need, to make sure the memory between the CPU and the network card is in consistency. Signe

[PATCH 5/8] net: dc2114x: remove unused lines and change the var and print types

2024-08-09 Thread Hanyuan Zhao
This commit fixes a problem that even though the network card does not report any issues in transmitting a setup frame, the driver prints the error status every time. Let's set it for debug use. Signed-off-by: Hanyuan Zhao --- drivers/net/dc2114x.c | 13 ++--- 1 file changed, 6 insertion

[PATCH 7/8] net: dc2114x: allow users to decide how to tx packets according to IP core

2024-08-09 Thread Hanyuan Zhao
Some IP cores of dc2114x or its variants do not comply so well with the behaviors described by the official document. Originally this driver uses only one tx descriptor and organizes it as a ring buffer, which would lead to a problem that one packet would be sent twice. This commit adds support to

[PATCH 6/8] net: dc2114x: allow users to decide whether to detect the tx No Carrier errors

2024-08-09 Thread Hanyuan Zhao
Some IP cores of dc2114x or its variants do not comply so well with the behaviors described by the official document. A packet could be sent successfully but reported with No Carrier error. Latest drivers of this IP core have not detect this error anymore. Signed-off-by: Hanyuan Zhao --- drivers

[PATCH 8/8] net: dc2114x: remove the pass all multicast flag in operation mode settings

2024-08-09 Thread Hanyuan Zhao
Remove the OMR_PM flag and choose 16 perfect filtering mode since in modern networks there're plenty of multicasts and set ORM_PM flag will increase the dc2114x's workload and ask the U-Boot to handle packets not related to itself. And most of the time, U-Boot does not need this feature. Signed-of

[PATCH 1/8] net: dc2114x: add support for platforms that don't have pci controllers

2024-08-09 Thread Hanyuan Zhao
There're a few ethernet IP cores which have the same functions with dc2114x, and can be connected to CPU by AXI or other buses. This commit adds support for the platforms that do not have PCI controllers, using MMIO to communicate with the dc2114x IP core. Signed-off-by: Hanyuan Zhao --- drivers

Re: [PATCH] arm: dts: rockchip: disable "usb_host0_ohci" to make boot faster for Radxa ROCK 3A

2024-08-09 Thread Kever Yang
Hi Naoki, On 2024/8/2 10:49, FUKAUMI Naoki wrote: on-board USB 2.0 hub, FE1.1s, has Transaction Translator which can handle USB 1.x devices via "usb_host0_ehci". so we can omit "usb_host0_ohci" and make boot faster (a little). The OHCI is in use when the direct connect device is USB1.1; and if

Re: [PATCH] arm: dts: rockchip: fix dts for Radxa ROCK 4C+

2024-08-09 Thread Kever Yang
On 2024/8/9 06:19, FUKAUMI Naoki wrote: Radxa ROCK Pi 4 series and Radxa ROCK 4C+ are not compatible. A little bit more detail about why not compatible? The eMMC is different? Thanks, - Kever add rk3399-rock-pi-4-u-boot.dtsi contents and remove dependency of it. no functional change is

Re: [PATCH] arm: dts: rockchip: remove upstreamed props for Radxa ROCK 3A

2024-08-09 Thread Kever Yang
On 2024/8/6 09:18, FUKAUMI Naoki wrote: "sfc" node was already upstreamed. remove unnecessary properties from u-boot.dtsi. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 9 - 1 file changed, 9 deletions(-) dif

Re: [PATCH] arm: dts: rockchip: remove upstreamed props for Radxa ROCK 5B

2024-08-09 Thread Kever Yang
On 2024/8/6 11:37, FUKAUMI Naoki wrote: "usb_host1_xhci" and related node were already upstreamed. remove unnecessary properties from u-boot.dtsi. Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 17 - 1

Re: [PATCH v3 3/7] board: rock5b-rk3588: add USB-C controller support

2024-08-09 Thread Kever Yang
On 2024/8/3 01:59, Sebastian Reichel wrote: Enable support for the fusb302 USB Type-C controller. This will do early USB PD (power deliver) negotiation, which must happen within 5 seconds after the USB-C connector has plugged in according to the specification. It takes almost 5 seconds to go t

Re: [PATCH v3 5/7] rockchip: rk3588-rock-5b: Add USB-C controller to u-boot.dtsi

2024-08-09 Thread Kever Yang
On 2024/8/3 01:59, Sebastian Reichel wrote: Add USB-C controller (fusb302), which will be used by U-Boot to initialize USB-PD. This is needed, because USB-PD communication must happen within 5 seconds after the USB-C connector got plugged. On my Rock 5B it often takes 5 seconds to jump to the L

Re: [PATCH v3 6/7] rockchip: rock5b-rk3588: Enable USB-C PD support

2024-08-09 Thread Kever Yang
On 2024/8/3 01:59, Sebastian Reichel wrote: Now that all code has been prepared update the default configuration to make use of it. Signed-off-by: Sebastian Reichel Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 5 + 1 file changed, 5 insertions(+) d

Re: [PATCH v3 4/7] board: rock5b-rk3588: enable USB-C in operating system

2024-08-09 Thread Kever Yang
On 2024/8/3 01:59, Sebastian Reichel wrote: Since older U-Boot releases do not negotiate USB PD, the kernel DT may not enable the USB-C controller by default to avoid a regression. The plan is to upstream it with 'status = "fail";' instead. U-Boot should then mark it as 'status = "okay";' if it

Re: [PATCH v2 4/4] board: rockchip: Add Radxa ROCK 5 ITX

2024-08-09 Thread Kever Yang
On 2024/8/3 05:00, Heiko Stuebner wrote: The Rock 5 ITX is board in ITX form factor using the RK358 SoC It can be powered either by 12V, ATX power-supply or PoE. Notable peripherals are the 4 SATA ports, M.2 M-Key slot, M.2 E-key slot, 2*2.5Gb PCIe-connected Ethernet NICs. Display options ar

Re: [PATCH v3 3/7] board: rock5b-rk3588: add USB-C controller support

2024-08-09 Thread Jonas Karlman
Hi Sebastian, On 2024-08-03 18:17, Sebastian Reichel wrote: > Hi Jonas, > > On Fri, Aug 02, 2024 at 10:42:56PM GMT, Jonas Karlman wrote: >> On 2024-08-02 19:59, Sebastian Reichel wrote: >>> Enable support for the fusb302 USB Type-C controller. >>> >>> This will do early USB PD (power deliver) neg

Re: [PATCH v2 1/5] arm64: dts: rockchip: Add Radxa ZERO 3W/3E

2024-08-09 Thread Kever Yang
On 2024/8/3 06:12, Jonas Karlman wrote: The Radxa ZERO 3W/3E is an ultra-small, high-performance single board computer based on the Rockchip RK3566, with a compact form factor and rich interfaces. The ZERO 3W and ZERO 3E are basically the same size and model, but differ only in storage and net

Re: [PATCH v2 2/5] arm64: dts: rockchip: fix mmc aliases for Radxa ZERO 3E/3W

2024-08-09 Thread Kever Yang
On 2024/8/3 06:12, Jonas Karlman wrote: From: FUKAUMI Naoki align with other Radxa products. - mmc0 is eMMC - mmc1 is microSD for ZERO 3E, there is no eMMC, but aliases should start at 0, so mmc0 is microSD as exception. Fixes: 1a5c8d307c83 ("arm64: dts: rockchip: Add Radxa ZERO 3W/3E") Si

Re: [PATCH v2 3/5] arm64: dts: rockchip: add gpio-line-names to radxa-zero-3

2024-08-09 Thread Kever Yang
On 2024/8/3 06:12, Jonas Karlman wrote: From: Trevor Woerner Add names to the pins of the general-purpose expansion header as given in the Radxa documentation[1] following the conventions in the kernel[2] to make it easier for users to correlate pins with functions when using utilities such a

Re: [PATCH v2 4/5] dm: adc: Add SPL_ADC Kconfig symbol for use of ADC in SPL

2024-08-09 Thread Kever Yang
On 2024/8/3 06:12, Jonas Karlman wrote: What model of Radxa ZERO 3W/3E board can be identified using ADC at runtime, add a Kconfig symbol to allow use of ADC in SPL. This will be used to identify board model in SPL to allow loading correct FIT configuration and FDT for U-Boot proper at SPL pha

Re: [PATCH v2 5/5] board: rockchip: Add Radxa ZERO 3W/3E

2024-08-09 Thread Kever Yang
On 2024/8/3 06:12, Jonas Karlman wrote: The Radxa ZERO 3W/3E is an ultra-small, high-performance single board computer based on the Rockchip RK3566, with a compact form factor and rich interfaces. Implement rk_board_late_init() to set correct fdtfile env var and board_fit_config_name_match() t

Re: [PATCH v2 02/10] pinctrl: rockchip: Add a pin_to_bank() helper

2024-08-09 Thread Kever Yang
On 2024/8/3 06:56, Jonas Karlman wrote: Add a pin_to_bank() helper that can locate a pin bank based on the pin offset, to be used in get_gpio_mux() and gpio_request_enable() ops. Reset ctrl->nr_pins to 0 so that pin_to_bank() can locate a bank after the second probe in U-Boot proper. Signed-o

Re: [PATCH v3 4/7] board: rock5b-rk3588: enable USB-C in operating system

2024-08-09 Thread Jonas Karlman
Hi Sebastian, On 2024-08-03 18:09, Sebastian Reichel wrote: > Hi Jonas, > > On Fri, Aug 02, 2024 at 11:04:05PM GMT, Jonas Karlman wrote: >> Hi Sebastian, >> >> On 2024-08-02 19:59, Sebastian Reichel wrote: >>> Since older U-Boot releases do not negotiate USB PD, the kernel >>> DT may not enable t

Re: [PATCH v2 05/10] pinctrl: rockchip: Add gpio_request_enable() ops

2024-08-09 Thread Kever Yang
On 2024/8/3 06:56, Jonas Karlman wrote: Implement gpio_request_enable() ops so that the gpio request() ops can be implemented and a gpio requested pin automatically is pinmuxed for gpio use, similar to Linux kernel. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH v2 08/10] gpio: rockchip: Add request() ops

2024-08-09 Thread Kever Yang
On 2024/8/3 06:56, Jonas Karlman wrote: Add a request() ops that call pinctrl_gpio_request() when the required gpio-ranges prop has been defined to signal pinctrl driver to use gpio pinmux. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: New patch from "rockch

Re: [PATCH v2 09/10] rockchip: gpio: Add gpio-ranges props

2024-08-09 Thread Kever Yang
On 2024/8/3 06:56, Jonas Karlman wrote: Add gpio-ranges props to supported SoCs based on the following Linux patches: ARM: dts: rockchip: add gpio-ranges property to gpio nodes https://lore.kernel.org/all/26007385-81dc-9961-05d5-8b9a0969d...@gmail.com/ arm64: dts: rockchip: add gpio-ranges pr

[PATCH] sf: Add lock info option to sf command list

2024-08-09 Thread Venkatesh Yadav Abbarapu
Many SPI flashes have status/OTP bit for TOP or BOTTOM selection in the status register that can protect selected regions of the SPI NOR. Take this bit into consideration while locking the region. The command "sf lockinfo" shows whether the flash is TOP or BOTTOM protected, based on this info the

Re: [PATCH v2 10/10] rockchip: gpio: Add missing gpio aliases

2024-08-09 Thread Kever Yang
On 2024/8/3 06:56, Jonas Karlman wrote: Add aliases for gpio controllers to soc u-boot dtsi files that are missing aliases in soc dtsi files to ensure dev_seq() return the expected number when a gpio controller is included in SPL. Also drop the aliases from rk3288-u-boot.dtsi, they are already

Re: [PATCH] rockchip: rk3568-nanopi-r5: Disable SPL_DM_WARN Kconfig option

2024-08-09 Thread Kever Yang
On 2024/8/3 07:48, Jonas Karlman wrote: With the commit 6afdb1585112 ("dm: core: migrate debug() messages to use dm_warn") use of DM_WARN/SPL_DM_WARN print a lot of debug messages. Disable the SPL_DM_WARN Kconfig option to remove verbose logging and restore normal serial console output during

Re: [PATCH v6] board: rockchip: add Radxa ROCK 3 Model C

2024-08-09 Thread Kever Yang
On 2024/8/9 03:37, Maxim Moskalets wrote: From: Maxim Moskalets Based on rock-3a-rk3568_defconfig. Tested on v1.31 revision. Board Specifications: - Rockchip RK3566 - 1/2/4GB LPDDR4 2112MT/s - eMMC socket - uSD card slot - M.2 2230 Connector - GbE LAN with POE - 3.5mm jack with mic - HDMI 2.

Re: [PATCH] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C

2024-08-09 Thread Kever Yang
On 2024/8/5 10:26, FUKAUMI Naoki wrote: SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency. Signed-off-by: FUKAUMI Naoki Link: https://lore.kernel.org/r/20240623023329.1044-3-na...@radxa.com Signed-off-by: Heiko Stuebner [ upstream commit: 06f6dd4d607766a527e37529f2f3f90dd14

Re: [Binman] Question regarding SPL symbol offsets generation

2024-08-09 Thread Lukasz Majewski
Hi Simon, > Hi Lukasz, > > On Thu, 8 Aug 2024 at 03:06, Lukasz Majewski wrote: > > > > Dear Community > > > > I'd like to ask about one issue with generation of symbol offsets in > > binman [1]. > > > > In my case the CONFIG_FSPI_CONF_HEADER is defined. > > > > Problem is with generated symbols

[PATCH v2 2/3] compiler: Ensure __builtin_*_overflow() support

2024-08-09 Thread Richard Weinberger
Both gcc and clang support this for a long time. Make sure the feature is present. Signed-off-by: Richard Weinberger --- include/linux/compiler_types.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index 1a3060117f..8b6

[PATCH v2 1/3] ext4: Fix integer overflow in ext4fs_read_symlink()

2024-08-09 Thread Richard Weinberger
While zalloc() takes a size_t type, adding 1 to the le32 variable will overflow. A carefully crafted ext4 filesystem can exhibit an inode size of 0x and as consequence zalloc() will do a zero allocation. Later in the function the inode size is again used for copying data. So an attacker ca

[PATCH v2 3/3] ext4: Fix zalloc()

2024-08-09 Thread Richard Weinberger
Currently, zalloc() calls uncondtionally memset(), if the allocation failes, memset() will write to a null pointer. Fix by using kzalloc(). Signed-off-by: Richard Weinberger --- fs/ext4/ext4_common.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ext4/ext4_common.h

Re: [PATCH] configs: rockchip: enable "ums" command for Radxa ROCK 5B

2024-08-09 Thread Kever Yang
On 2024/8/6 11:47, FUKAUMI Naoki wrote: USB Type-C port is configured as "peripheral" port. so enable "ums" command to use as USB Mass Storage device. ("rockusb" command is already enabled and working) Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock

Re: [PATCH v2 3/3] ext4: Fix zalloc()

2024-08-09 Thread Heinrich Schuchardt
On 8/9/24 11:54, Richard Weinberger wrote: Currently, zalloc() calls uncondtionally memset(), if the allocation failes, memset() will write to a null pointer. Fix by using kzalloc(). Signed-off-by: Richard Weinberger Reviewed-by: Heinrich Schuchardt --- fs/ext4/ext4_common.h | 5 ++---

Re: [PATCH v8 02/23] net: wget: removed unused function wget_success()

2024-08-09 Thread Ilias Apalodimas
On Wed, 7 Aug 2024 at 20:12, Jerome Forissier wrote: > > wget_success() is used nowhere so remove it. > > Signed-off-by: Jerome Forissier > --- > net/wget.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/net/wget.c b/net/wget.c > index f1dd7abeff6..0e4dc5159d0 100644 > --- a/net/

Re: [PATCH] arm: dts: rockchip: fix dts for Radxa ROCK 4C+

2024-08-09 Thread FUKAUMI Naoki
Hi, On 8/9/24 18:16, Kever Yang wrote: On 2024/8/9 06:19, FUKAUMI Naoki wrote: Radxa ROCK Pi 4 series and Radxa ROCK 4C+ are not compatible. A little bit more detail about why not compatible? The eMMC is different? I should say "ROCK Pi 4 series and ROCK 4C+ cannot share dts file." $ gre

Re: [PATCH v8 03/23] net: wget: allow EFI boot

2024-08-09 Thread Ilias Apalodimas
On Wed, 7 Aug 2024 at 20:12, Jerome Forissier wrote: > > wget followed by bootefi currently fails as follows: > > U-Boot> wget 20 192.168.0.30:helloworld.efi > Waiting for Ethernet connection... done. > HTTP/1.0 200 OK > Packets received 13, Transfer Successful > Bytes transferred = 12720

[PATCH 1/1] tools: fix signature of toc0_verify_cert_item()

2024-08-09 Thread Heinrich Schuchardt
Avoid a build warning with GCC 14.2 tools/sunxi_toc0.c: In function ‘toc0_verify_cert_item’: tools/sunxi_toc0.c:447:12: warning: ‘nonnull’ argument ‘digest’ compared to NULL [-Wnonnull-compare] 447 | if (digest && memcmp(&extension->digest, digest, SHA256_DIGEST_LENGTH)) {

Re: [PATCH v2 4/4] board: rockchip: Add Radxa ROCK 5 ITX

2024-08-09 Thread Philipp Tomsich
On Fri, 2 Aug 2024 at 23:00, Heiko Stuebner wrote: > > The Rock 5 ITX is board in ITX form factor using the RK358 SoC type "is a board" typo: "RK3588" > It can be powered either by 12V, ATX power-supply or PoE. > > Notable peripherals are the 4 SATA ports, M.2 M-Key slot, M.2 E-key slot, > 2*2.5

Re: [PATCH] mtd: nand: raw: atmel: remove unnecessary return value

2024-08-09 Thread Alexander Dahl
Hello Marcus, Am Fri, Aug 09, 2024 at 02:15:43PM +0200 schrieb Marcus Folkesson: > The condition 'ret' is always true as it is never set to other than > -EIO. Technically, you're right. I quickly compared with the same driver in Linux. That has some additional lines for DMA transfers which prob

Re: [PATCH 1/1] tools: fix signature of toc0_verify_cert_item()

2024-08-09 Thread Andre Przywara
On Fri, 9 Aug 2024 13:22:16 +0200 Heinrich Schuchardt wrote: Hi Heinrich, > Avoid a build warning with GCC 14.2 > > tools/sunxi_toc0.c: In function ‘toc0_verify_cert_item’: > tools/sunxi_toc0.c:447:12: warning: ‘nonnull’ argument ‘digest’ > compared to NULL [-Wnonnull-compare] >

Re: [PATCH] mtd: nand: raw: atmel: remove unnecessary return value

2024-08-09 Thread Michael Nazzareno Trimarchi
Hi all On Fri, Aug 9, 2024 at 2:25 PM Alexander Dahl wrote: > > Hello Marcus, > > Am Fri, Aug 09, 2024 at 02:15:43PM +0200 schrieb Marcus Folkesson: > > The condition 'ret' is always true as it is never set to other than > > -EIO. > > Technically, you're right. > > I quickly compared with the sam

Re: [PATCH v8 03/23] net: wget: allow EFI boot

2024-08-09 Thread Jerome Forissier
On 8/9/24 12:53, Ilias Apalodimas wrote: > On Wed, 7 Aug 2024 at 20:12, Jerome Forissier > wrote: >> >> wget followed by bootefi currently fails as follows: >> >> U-Boot> wget 20 192.168.0.30:helloworld.efi >> Waiting for Ethernet connection... done. >> HTTP/1.0 200 OK >> Packets receiv

Re: [PATCH v2] remoteproc: uclass: Modify uc_pdata->name to use combination of device name and device's parent name

2024-08-09 Thread Roger Quadros
On 07/08/2024 12:08, MD Danish Anwar wrote: > uc_pdata->name is populated from device tree property "remoteproc-name". > For those devcices that don't set "remoteproc-name", uc_pdata->name > falls back to dev->name. > > If two devices have same name, this will result into uc_pdata->name not > b

[PATCH] mtd: nand: raw: atmel: remove unnecessary return value

2024-08-09 Thread Marcus Folkesson
The condition 'ret' is always true as it is never set to other than -EIO. Remove 'ret' and the condition for copy. Signed-off-by: Marcus Folkesson --- drivers/mtd/nand/raw/atmel/nand-controller.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/ra

Re: [PATCH v2] remoteproc: uclass: Modify uc_pdata->name to use combination of device name and device's parent name

2024-08-09 Thread Andrew Davis
On 8/7/24 4:08 AM, MD Danish Anwar wrote: uc_pdata->name is populated from device tree property "remoteproc-name". For those devcices that don't set "remoteproc-name", uc_pdata->name falls back to dev->name. If two devices have same name, this will result into uc_pdata->name not being unique and

Re: [PATCH v8 00/23] Introduce the lwIP network stack

2024-08-09 Thread Jerome Forissier
On 8/8/24 19:24, Tom Rini wrote: > On Thu, Aug 08, 2024 at 06:41:02PM +0200, Jerome Forissier wrote: >> >> >> On 8/7/24 22:44, Tom Rini wrote: >>> On Wed, Aug 07, 2024 at 07:11:44PM +0200, Jerome Forissier wrote: >>> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >>

Re: pinctrl warning on sandbox

2024-08-09 Thread Sean Anderson
Hi Simon, On 8/7/24 19:17, Simon Glass wrote: Hi Sean, I was looking at [1] and bisected the message to this commit: 7f0f1806e3a (refs/bisect/bad) test: pinmux: Add test for pin muxing I'm not quite sure what is going on, but could you please take a look? Regards, Simon [1] https://source.d

Please pull v2 u-boot-i2c

2024-08-09 Thread Heiko Schocher
Hello Tom, please pull from u-boot-i2c master, sorted out the DM_I2C patches from Anatolij, to seperate pull request for next. The following changes since commit eb8e25c000d185ece0136b13cca73084eb980253: Merge tag 'u-boot-nand-20240808' of https://source.denx.de/u-boot/custodians/u-boot-nand-

Please pull u-boot-i2c next

2024-08-09 Thread Heiko Schocher
Hello Tom, please pull from u-boot-i2c next The following changes since commit 2078abaf00b63fc4f70f8a599b61a476e22352f3: Merge patch series "alist: Implement a pointer list / array of structs" (2024-08-07 08:51:25 -0600) are available in the Git repository at: https://source.denx.de/u-bo

Re: pinctrl warning on sandbox

2024-08-09 Thread Simon Glass
Hi Sean, On Fri, 9 Aug 2024 at 07:31, Sean Anderson wrote: > > Hi Simon, > > On 8/7/24 19:17, Simon Glass wrote: > > Hi Sean, > > > > I was looking at [1] and bisected the message to this commit: > > > > 7f0f1806e3a (refs/bisect/bad) test: pinmux: Add test for pin muxing > > > > I'm not quite sur

Re: [PATCH] cmd: sf: prevent overwriting the reserved memory

2024-08-09 Thread Simon Glass
Hi Michal, On Thu, 8 Aug 2024 at 23:39, Michal Simek wrote: > > Hi Simon, > > On 8/8/24 16:28, Simon Glass wrote: > > Hi Michal, > > > > On Wed, 7 Aug 2024 at 23:31, Michal Simek wrote: > >> > >> > >> > >> On 8/7/24 16:36, Simon Glass wrote: > >>> Hi Prasad, > >>> > >>> On Tue, 6 Aug 2024 at 23:

Re: [PATCH] cmd: sf: prevent overwriting the reserved memory

2024-08-09 Thread Michal Simek
On 8/9/24 16:44, Simon Glass wrote: Hi Michal, On Thu, 8 Aug 2024 at 23:39, Michal Simek wrote: Hi Simon, On 8/8/24 16:28, Simon Glass wrote: Hi Michal, On Wed, 7 Aug 2024 at 23:31, Michal Simek wrote: On 8/7/24 16:36, Simon Glass wrote: Hi Prasad, On Tue, 6 Aug 2024 at 23:05, Ku

[PATCH] tqma6q_mba6: Convert to watchdog driver model

2024-08-09 Thread Fabio Estevam
From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset. Signed-off-by

Re: [PATCH] usb: dwc3-generic: fix CONFIG_DM_REGULATOR-off case

2024-08-09 Thread Caleb Connolly
On 09/08/2024 07:19, Jan Kiszka wrote: On 08.08.24 16:27, Caleb Connolly wrote: Hi Jan, On 08/08/2024 10:51, Jan Kiszka wrote: From: Jan Kiszka When DM_REGULATOR is disabled, all calls will return -ENOSYS. Account for that so that targets like the IOT2050 will work again. Fixes: de451d5d

[PATCH] imx6-tqma6: Convert to OF_UPSTREAM

2024-08-09 Thread Fabio Estevam
From: Fabio Estevam Instead of using the local imx6-tqma6 devicetree copies from U-Boot, convert the imx6-tqma6 target to OF_UPSTREAM so that the upstream kernel devicetrees can be used instead. Signed-off-by: Fabio Estevam --- arch/arm/dts/Makefile | 4 - arch/arm/dts/imx6dl-mb

[PATCH] env: remove vars that are not in default env

2024-08-09 Thread Ravi Minnikanti
current env_set_default_vars() doesn't delete var that are not in the imported env. hashtable removes vars that are not in the imported env but present in the current env only if H_NOCLEAR flag is not set. This change is to avoid passing H_NOCLEAR flag if specific vars are passed to env_set_defa

Re: [PATCH] sf: Add lock info option to sf command list

2024-08-09 Thread Simon Glass
Hi Venkatesh, On Fri, 9 Aug 2024 at 03:39, Venkatesh Yadav Abbarapu wrote: > > Many SPI flashes have status/OTP bit for TOP or BOTTOM selection > in the status register that can protect selected regions of > the SPI NOR. > > Take this bit into consideration while locking the region. > The command

Re: [PATCH] cmd: sf: prevent overwriting the reserved memory

2024-08-09 Thread Simon Glass
Hi Michal, On Fri, 9 Aug 2024 at 08:47, Michal Simek wrote: > > > > On 8/9/24 16:44, Simon Glass wrote: > > Hi Michal, > > > > On Thu, 8 Aug 2024 at 23:39, Michal Simek wrote: > >> > >> Hi Simon, > >> > >> On 8/8/24 16:28, Simon Glass wrote: > >>> Hi Michal, > >>> > >>> On Wed, 7 Aug 2024 at 23:

Re: [PATCH 23/40] lmb: add a flags parameter to the API's

2024-08-09 Thread Simon Glass
Hi Sughosh, On Fri, 9 Aug 2024 at 02:25, Sughosh Ganu wrote: > > On Thu, 8 Aug 2024 at 19:58, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 7 Aug 2024 at 00:32, Sughosh Ganu wrote: > > > > > > On Wed, 7 Aug 2024 at 03:21, Simon Glass wrote: > > > > > > > > Hi Sughosh, > > > > > > > >

Re: [PATCH] env: remove vars that are not in default env

2024-08-09 Thread Simon Glass
Hi Ravi, On Fri, 9 Aug 2024 at 09:38, Ravi Minnikanti wrote: > > > current env_set_default_vars() doesn't delete > var that are not in the imported env. hashtable > removes vars that are not in the imported > env but present in the current env only if H_NOCLEAR > flag is not set. > > This change

Re: [PATCH v3 19/19] CI: Allow running tests on sjg lab

2024-08-09 Thread Simon Glass
Hi Tom, On Tue, 25 Jun 2024 at 06:30, Simon Glass wrote: > > Hi, > > On Mon, 24 Jun 2024 at 19:01, Tom Rini wrote: > > > > On Mon, Jun 24, 2024 at 04:56:02PM +0200, Michael Nazzareno Trimarchi wrote: > > > Hi Simon > > > > > > On Mon, Jun 24, 2024 at 2:52 PM Andrejs Cainikovs > > > wrote: > > >

Re: [PATCH v2 0/3] efi: Start tidying up memory management

2024-08-09 Thread Simon Glass
Hi, On Thu, 1 Aug 2024 at 11:36, Simon Glass wrote: > > We have been discussing the state of EFI memory management for some > years so I thought it might be best to send a short series showing some > of the issues we have talked about. > > This one just deals with memory allocation. It updates EF

Re: [PATCH v2 1/3] ext4: Fix integer overflow in ext4fs_read_symlink()

2024-08-09 Thread Heinrich Schuchardt
On 09.08.24 11:54, Richard Weinberger wrote: While zalloc() takes a size_t type, adding 1 to the le32 variable will overflow. A carefully crafted ext4 filesystem can exhibit an inode size of 0x and as consequence zalloc() will do a zero allocation. Later in the function the inode size is

Re: [PATCH v2 1/3] ext4: Fix integer overflow in ext4fs_read_symlink()

2024-08-09 Thread Richard Weinberger
Heinrich, Am Freitag, 9. August 2024, 18:13:27 CEST schrieb 'Heinrich Schuchardt' via upstream: > Thank you for pointing at the problematic code. > > You are calling __builtin_add_overflow(int, int, size_t *). > > __builtin_add_overflow() is not defined in the C-standard. > > Is there any well

Re: [PATCH v2 1/3] efi: Allow use of malloc() for the EFI pool

2024-08-09 Thread Heinrich Schuchardt
On 01.08.24 19:36, Simon Glass wrote: This API call is intended for allocating small amounts of memory, similar to malloc(). The current implementation rounds up to whole pages which can waste large amounts of memory. It also implements its own malloc()-style header on each block. For certain al

[PATCH v4] config: Add 'update_bootimg' command to update flash.bin on Phytec's imx8mm

2024-08-09 Thread Lukasz Majewski
This command allows easy update on SD card or eMMC of the flash.bin generated (with binman) during u-boot build. Signed-off-by: Lukasz Majewski --- Changes for v2: - Remove 'update_mmc_part' variable - Change path for hostname - Use full version of dhcp command (${loadaddr} added) Changes for v3

Re: [PATCH] cmd: add a fetch utility

2024-08-09 Thread Caleb Connolly
Hi Simon, On 09/08/2024 03:55, Simon Glass wrote: Hi Caleb, On Thu, 8 Aug 2024 at 10:32, Caleb Connolly > wrote: > > While U-Boot does a pretty good job at printing information at startup > about what hardware it's running on, it can be hard to take pretty

Re: [PATCH] cmd: add a fetch utility

2024-08-09 Thread Caleb Connolly
On 09/08/2024 08:18, Heinrich Schuchardt wrote: Am 8. August 2024 18:24:24 MESZ schrieb Caleb Connolly : While U-Boot does a pretty good job at printing information at startup about what hardware it's running on, it can be hard to take pretty pictures of this to show off on the internet (b

Re: [PATCH v2 3/3] efi: Show the location of the bounce buffer

2024-08-09 Thread Heinrich Schuchardt
On 01.08.24 19:36, Simon Glass wrote: The EFI_LOADER_BOUNCE_BUFFER feature was added many years ago. It is not clear whether it is still needed, but 24 boards (lx2160ardb_tfa_stmm, lx2162aqds_tfa_SECURE_BOOT and the like) use it. This feature uses EFI page allocation to create a 64MB buffer 'in

Re: [PATCH] MAINTAINERS: Update path for U-Boot environment variables YAML

2024-08-09 Thread Srinivas Kandagatla
On Thu, 08 Aug 2024 07:57:10 +0200, Rafał Miłecki wrote: > This file was moved to the layouts/ subdirectory. > > Applied, thanks! [1/1] MAINTAINERS: Update path for U-Boot environment variables YAML commit: f6d1cddd76b2da190462d84546e5202d3b2aa92b Best regards, -- Srinivas Kandagatla

[PATCH 1/2] tqma6: Convert to PMIC and I2C driver model

2024-08-09 Thread Fabio Estevam
From: Fabio Estevam Currently, the power_init_board() function is not executed because CONFIG_POWER_LEGACY is not selected. Convert to PMIC driver model, which allows removing board I2C code in favor of the I2C driver model. Signed-off-by: Fabio Estevam --- board/tq/tqma6/tqma6.c | 61 ++

[PATCH 2/2] tqma6: Do not print the board name twice

2024-08-09 Thread Fabio Estevam
From: Fabio Estevam Currently, the devicetree model as well as the board variant name are shown: ... Model: TQ TQMa6S/DL on MBa6x Board: TQMa6DL on a MBa6x ... Unselect the CONFIG_DISPLAY_BOARDINFO option so that the board name is printed only once in board_late_init() instead. Signed-o

[PATCH 1/1] scripts/decodecode: update from Linux v6.10

2024-08-09 Thread Heinrich Schuchardt
For decoding RISC-V dumps we need to update the script. Signed-off-by: Heinrich Schuchardt --- scripts/decodecode | 169 +++-- 1 file changed, 148 insertions(+), 21 deletions(-) diff --git a/scripts/decodecode b/scripts/decodecode index 9cef558528..636421

Re: [PATCH] cmd: add a fetch utility

2024-08-09 Thread Simon Glass
Hi Caleb, On Fri, 9 Aug 2024 at 11:00, Caleb Connolly wrote: > > Hi Simon, > > On 09/08/2024 03:55, Simon Glass wrote: > > Hi Caleb, > > > > On Thu, 8 Aug 2024 at 10:32, Caleb Connolly > > wrote: > > > > > > While U-Boot does a pretty good job at printing info

Re: [PATCH v2 1/3] efi: Allow use of malloc() for the EFI pool

2024-08-09 Thread Simon Glass
Hi Heinrich, On Fri, 9 Aug 2024 at 10:38, Heinrich Schuchardt wrote: > > On 01.08.24 19:36, Simon Glass wrote: > > This API call is intended for allocating small amounts of memory, > > similar to malloc(). The current implementation rounds up to whole pages > > which can waste large amounts of me

Re: [PATCH v2 3/3] efi: Show the location of the bounce buffer

2024-08-09 Thread Simon Glass
Hi Heinrich, On Fri, 9 Aug 2024 at 11:32, Heinrich Schuchardt wrote: > > On 01.08.24 19:36, Simon Glass wrote: > > The EFI_LOADER_BOUNCE_BUFFER feature was added many years ago. It is not > > clear whether it is still needed, but 24 boards (lx2160ardb_tfa_stmm, > > lx2162aqds_tfa_SECURE_BOOT and

Re: [PATCH 00/20] i2c: Chip away at some old code

2024-08-09 Thread Simon Glass
-cc most Hi, On Thu, 18 Jul 2024 at 11:36, Simon Glass wrote: > > This series aims to remove some of the older contents of i2c.h so that > we can move towards having just the dm API. > > It removes four boards which are getting in the way. > > > Simon Glass (20): > arm: Remove pg_wcom boards >

Pull request for tpm-master-09082024

2024-08-09 Thread Ilias Apalodimas
Hi Tom, The following changes since commit 6f4c31c2b658358628b5b0fa801f55c7477c7585: Prepare v2024.10-rc2 (2024-08-05 18:13:42 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-09082024 for you to fetch changes up to c686b38

Re: [PATCH 00/20] i2c: Chip away at some old code

2024-08-09 Thread Tom Rini
On Fri, Aug 09, 2024 at 12:37:52PM -0600, Simon Glass wrote: > -cc most > > Hi, > > On Thu, 18 Jul 2024 at 11:36, Simon Glass wrote: > > > > This series aims to remove some of the older contents of i2c.h so that > > we can move towards having just the dm API. > > > > It removes four boards which

Re: [PATCH v2 3/3] efi: Show the location of the bounce buffer

2024-08-09 Thread Heinrich Schuchardt
Am 9. August 2024 20:36:35 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Fri, 9 Aug 2024 at 11:32, Heinrich Schuchardt wrote: >> >> On 01.08.24 19:36, Simon Glass wrote: >> > The EFI_LOADER_BOUNCE_BUFFER feature was added many years ago. It is not >> > clear whether it is still needed, but 24

Re: [PATCH v2 9/9] doc: introduce led.rst documentation

2024-08-09 Thread Christian Marangi
On Thu, Aug 08, 2024 at 08:34:32AM +0200, Alexander Dahl wrote: > Hello Christian, > > Am Wed, Aug 07, 2024 at 09:54:12PM +0200 schrieb Christian Marangi: > > Introduce simple led.rst documentation to document all the additional > > Kconfig and the current limitation of LED_BLINK and GPIO software

[PATCH v2] env: remove vars that are not in default env

2024-08-09 Thread Ravi Minnikanti
current env_set_default_vars() doesn't delete var that are not in the imported env. hashtable removes vars that are not in the imported env but present in the current env only if H_NOCLEAR flag is not set. This change is to avoid passing H_NOCLEAR flag if specific vars are passed to env_set_defa

Re: Please pull v2 u-boot-i2c

2024-08-09 Thread Tom Rini
On Fri, Aug 09, 2024 at 04:09:09PM +0200, Heiko Schocher wrote: > Hello Tom, > > please pull from u-boot-i2c master, sorted out the DM_I2C patches from > Anatolij, > to seperate pull request for next. > > The following changes since commit eb8e25c000d185ece0136b13cca73084eb980253: > > Merge

Re: Please pull u-boot-i2c next

2024-08-09 Thread Tom Rini
On Fri, Aug 09, 2024 at 04:09:19PM +0200, Heiko Schocher wrote: > Hello Tom, > > please pull from u-boot-i2c next > > The following changes since commit 2078abaf00b63fc4f70f8a599b61a476e22352f3: > > Merge patch series "alist: Implement a pointer list / array of structs" > (2024-08-07 08:51:2

Re: [PATCH v8 00/23] Introduce the lwIP network stack

2024-08-09 Thread Tom Rini
On Fri, Aug 09, 2024 at 03:19:02PM +0200, Jerome Forissier wrote: > > > On 8/8/24 19:24, Tom Rini wrote: > > On Thu, Aug 08, 2024 at 06:41:02PM +0200, Jerome Forissier wrote: > >> > >> > >> On 8/7/24 22:44, Tom Rini wrote: > >>> On Wed, Aug 07, 2024 at 07:11:44PM +0200, Jerome Forissier wrote: >

Re: [PATCH v2 2/2] i2c: samsung: Support platforms other than EXYNOS4 and EXYNOS5

2024-08-09 Thread Henrik Grimler
Hi David, Thinking about this a bit more... On Fri, Aug 02, 2024 at 09:19:16PM +0200, David Virag wrote: > Newer Samsung SoCs (including newer Exynos, ExynosAuto, Google Tensor) > still use these IPs, or slightly newer versions of it. > > Make these drivers available on these platforms by guardi

  1   2   >