[U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

2012-05-11 Thread Alexander Holler
This is used for compatibility with text files which are using CRLF instead of LF as the end of a line. Signed-off-by: Alexander Holler --- lib/hashtable.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/lib/hashtable.c b/lib/hashtable.c index abd61c8..

Re: [U-Boot] [PATCH 1/3] mx53: Change IPU_CTRL_BASE_ADDR definition

2012-05-11 Thread Stefano Babic
On 11/05/2012 03:07, Fabio Estevam wrote: > From: Fabio Estevam > > The original definition of IPU_CTRL_BASE_ADDR does match the value stated > in the MX53 Reference Manual. > > However, if using such value the IPU driver hangs when trying to access the > IPU registers. > > Looking for this de

Re: [U-Boot] Unable to use USB Keyboard on u-boot

2012-05-11 Thread Marek Vasut
Dear Atul Kumar, > Dear Marek, > > I am tring to bring up USB Keyboard on u-boot with "Beagle_board > xM ver B".. found number of post,but the stack is already updated one.. > I am able to find the info of the connected device but some how keyboard > does not works.. can you suggest/gu

Re: [U-Boot] Unable to use USB Keyboard on u-boot

2012-05-11 Thread Marek Vasut
Dear Atul Kumar, Please CC the mailing list, always. > Dear Marek, > > Thanks for your attention.. After doing "coninfo", i get below > msg.. > > OMAP3 beagleboard.org # > > coninfo > > List of available devices: > > serial 8003 SIO stdin stdout stderr > > usbtty 0 > > 003

Re: [U-Boot] [PATCH 1/2] mx28evk: extend default environment

2012-05-11 Thread Otavio Salvador
On Thu, May 10, 2012 at 2:23 PM, Marek Vasut wrote: > Dear Fabio Estevam, > >> From: Otavio Salvador >> >> The environment has been based on mx53loco but keeping the possibility >> to easy change the default console device as Freescale and mainline >> kernels differ on the device name. >> >> Sign

Re: [U-Boot] [PATCH 1/2] mx28evk: extend default environment

2012-05-11 Thread Otavio Salvador
On Fri, May 11, 2012 at 10:54 AM, Otavio Salvador wrote: >> Can we possibly unify it with what's already in m28evk? Also, it'd be cool >> if we >> had some default -- very generic -- env. Can we go in that direction? > > I have prepared a set of commits in this direction. Please take a look at: >

Re: [U-Boot] [PATCH 1/2] mx28evk: extend default environment

2012-05-11 Thread Marek Vasut
Dear Otavio Salvador, > On Fri, May 11, 2012 at 10:54 AM, Otavio Salvador > > wrote: > >> Can we possibly unify it with what's already in m28evk? Also, it'd be > >> cool if we had some default -- very generic -- env. Can we go in that > >> direction? > > > > I have prepared a set of commits in

Re: [U-Boot] [PATCH 1/2] mx28evk: extend default environment

2012-05-11 Thread Stefano Babic
On 11/05/2012 16:10, Otavio Salvador wrote: > On Fri, May 11, 2012 at 10:54 AM, Otavio Salvador > wrote: >>> Can we possibly unify it with what's already in m28evk? Also, it'd be cool >>> if we >>> had some default -- very generic -- env. Can we go in that direction? >> >> I have prepared a set o

Re: [U-Boot] [PATCH 1/2] mx28evk: extend default environment

2012-05-11 Thread Otavio Salvador
On Fri, May 11, 2012 at 11:25 AM, Stefano Babic wrote: > Another example is amcc-common.h  for PowerPC 4xx. Up now we have not a > real "common" environment, that spreads among boards. Each board defines > its own set - it is not bad to define some common scripts, that a board > maintainer can use

Re: [U-Boot] [PATCH] kirkwood: add support for D-Link DNS-320

2012-05-11 Thread Jamie Lentin
On Wed, 02 May 2012 19:45:15 +0100, Luka Perkov wrote: Hi Jamie, I know that you have sent newer version of this patch but here is easier for me to comment... I have also put maintainer of NAS325 board in CC. On Thu, Apr 26, 2012 at 11:23:58AM +0100, Jamie Lentin wrote: This patch adds su

[U-Boot] [PATCH 2/8] m28evk: use same notation to alloc the 128kB stack

2012-05-11 Thread Otavio Salvador
Signed-off-by: Otavio Salvador --- include/configs/m28evk.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index c62f4d0..7472ddc 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -88,7 +88,7 @@ #de

[U-Boot] [PATCH 1/8] MX28: Fix a typo in mx28_reg_8 macro

2012-05-11 Thread Otavio Salvador
The macro mistakenly referred to 32bit struct instead of 8bit one. Signed-off-by: Otavio Salvador Cc: Fabio Estevam Cc: Marek Vasut --- arch/arm/include/asm/arch-mx28/regs-common.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/arch-mx28/regs-common

[U-Boot] [PATCH 3/8] m28evk: use "M28EVK U-Boot =>" as prompt

2012-05-11 Thread Otavio Salvador
Signed-off-by: Otavio Salvador --- include/configs/m28evk.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index 7472ddc..ebf7e39 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -114,7 +114,7 @@

[U-Boot] [PATCH 4/8] mx28evk: ensure command definition is in alphabetic order

2012-05-11 Thread Otavio Salvador
Signed-off-by: Otavio Salvador --- include/configs/mx28evk.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 0c18e50..5ccfe70 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -54,11 +54,11

[U-Boot] [PATCH 5/8] mxsboot: stop referring to i.MX28 as this ought to work for all i.MXS SoCs

2012-05-11 Thread Otavio Salvador
Signed-off-by: Otavio Salvador --- tools/mxsboot.c | 110 +++ 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/tools/mxsboot.c b/tools/mxsboot.c index 6c05aa4..9661a48 100644 --- a/tools/mxsboot.c +++ b/tools/mxsboot.c @@ -1,5 +1

[U-Boot] [PATCH 8/8] MX28: rename regs-clkctrl.h to regs-clkctrl-mx28.h

2012-05-11 Thread Otavio Salvador
The CLKCTRL registers are SoC specific so we ought to have it clear on filename. Signed-off-by: Otavio Salvador --- arch/arm/include/asm/arch-mxs/imx-regs.h |2 +- arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h | 294 + arch/arm/include/asm/arch-mxs/regs-clkc

[U-Boot] [PATCH 7/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-11 Thread Otavio Salvador
As the register accessing mode is the same for all i.MXS SoCs we ought to use 'mxs' prefix intead of 'mx28'. Signed-off-by: Otavio Salvador --- arch/arm/cpu/arm926ejs/mxs/clock.c |4 +- arch/arm/cpu/arm926ejs/mxs/iomux.c |6 +- arch/arm/cpu/arm926ejs/mxs/mx28.c

Re: [U-Boot] [PATCH 6/8] mxs: reorganize source directory for easy sharing of code among i.MXS SoCs

2012-05-11 Thread Otavio Salvador
On Fri, May 11, 2012 at 12:38 PM, Otavio Salvador wrote: > Most code can be shared amount i.MX23 and i.MX28 as both are from > i.MXS family; this source directory structure makes easy to share code > among them. > > Signed-off-by: Otavio Salvador This and next patches are not yet ready for mergi

Re: [U-Boot] [PATCH v7 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Tom Warren
Graeme, > -Original Message- > From: Graeme Russ [mailto:graeme.r...@gmail.com] > Sent: Thursday, May 10, 2012 4:46 PM > To: Tom Warren > Cc: Simon Glass; U-Boot Mailing List; Stephen Warren; Tom Rini; Albert > ARIBAUD > Subject: Re: [PATCH v7 03/23] Add abs() macro to return absolute valu

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Donnerstag 10 Mai 2012, 19:32:11 schrieb Michael Walle: > This patchset is a split-off from my patch series "Kirkwood: add lschlv2 > and lsxhl board support". Hi Joe, will you ack/nak these patch series and in case of an ack, Prafulla will fetch these into his tree? Or how is it supposed to w

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Joe Hershberger
Hi Michael, On Fri, May 11, 2012 at 11:32 AM, Michael Walle wrote: > Am Donnerstag 10 Mai 2012, 19:32:11 schrieb Michael Walle: >> This patchset is a split-off from my patch series "Kirkwood: add lschlv2 >> and lsxhl board support". > > Hi Joe, > > will you ack/nak these patch series and in case

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Prafulla Wadaskar
> -Original Message- > From: Joe Hershberger [mailto:joe.hershber...@gmail.com] > Sent: 11 May 2012 09:47 > To: Michael Walle > Cc: u-boot@lists.denx.de; Prafulla Wadaskar > Subject: Re: [PATCH v4 0/3] net: helper functions > > Hi Michael, > > On Fri, May 11, 2012 at 11:32 AM, Michael W

Re: [U-Boot] [PATCH 1/3] mx53: Change IPU_CTRL_BASE_ADDR definition

2012-05-11 Thread Fabio Estevam
Hi Stefano, On Fri, May 11, 2012 at 7:46 AM, Stefano Babic wrote: > Apart of the fact that it works, this chane appears really strange to > me. Maybe now it is not writing anymore in ipu, and the default values > are ok for mx53. It seems more a MX53 related issu in IPU3 driver, and > this chang

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

2012-05-11 Thread Wolfgang Denk
Dear Alexander Holler, In message <1336720486-7424-1-git-send-email-hol...@ahsoftware.de> you wrote: > This is used for compatibility with text files which are > using CRLF instead of LF as the end of a line. I don't think we should do this. If you have text files with CR-LF line endings, then p

Re: [U-Boot] [PATCH v7 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Wolfgang Denk
Dear Simon Glass, In message <1336685875-13177-4-git-send-email-...@chromium.org> you wrote: > This macro is generally useful to make it available in common. I agree with the idea of the patch, but I object against the current implementation. > +/* Return the absolute value of a number */ > +#de

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <1336671134-16342-1-git-send-email-mich...@walle.cc> you wrote: > This patchset is a split-off from my patch series "Kirkwood: add lschlv2 > and lsxhl board support". > > Changes: > v4: > - typo fixes (thanks Mike) > - seed all 46bits of the generated ethernet add

Re: [U-Boot] [PATCH v4 1/3] lib: add rand() function

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <1336671134-16342-2-git-send-email-mich...@walle.cc> you wrote: > It's a PRNG using the simple and fast xorshift method. ... > +static unsigned int y = 2463534242U; Hm... can we introduce at least a little entropy somewhere? Best regards, Wolfgang Denk -- DENX

Re: [U-Boot] [PATCH v4 2/3] net: add helper to generate random mac address

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <1336671134-16342-3-git-send-email-mich...@walle.cc> you wrote: > Add new function eth_random_enetaddr() to generate a locally administered > ethernet address. > > Signed-off-by: Michael Walle > --- > include/net.h | 15 +++ > net/eth.c | 20 ++

Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <1336671134-16342-4-git-send-email-mich...@walle.cc> you wrote: > Signed-off-by: Michael Walle How many boards will be using this code? Eventually this should be made configurable? > + sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index); This

Re: [U-Boot] [PATCH v7 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Simon Glass
Hi, On Fri, May 11, 2012 at 12:16 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1336685875-13177-4-git-send-email-...@chromium.org> you wrote: > > This macro is generally useful to make it available in common. > > I agree with the idea of the patch, but I object against the > curr

Re: [U-Boot] [PATCH] kirkwood: add support for D-Link DNS-320

2012-05-11 Thread Luka Perkov
On Fri, May 11, 2012 at 03:09:25PM +0100, Jamie Lentin wrote: > >Are you sure you need this CONFIG_RESET_PHY_R at all? I mean I have the > >same SoC and I do not need this at all. I think this part is left over > >from other boards that we do not need anymore. It makes sense to remove > >this if yo

Re: [U-Boot] [PATCH] spi: Tegra2: Seaboard: fix UART corruption during SPI transactions

2012-05-11 Thread jimmzhang
On Wed, 2012-05-09 at 10:34 -0700, Tom Warren wrote: > Simon Glass's proposal to fix this on Seaboard was NAK'd, so I > removed his NS16550 references and added a small delay before > SPI/UART muxing. Tested on my Seaboard with large SPI reads/writes > and saw no corruption (crc's matched) and no s

Re: [U-Boot] [PATCH v7 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > So I will go back to the more complicated way, and this time just copy what > the kernel does. The difference is that it doesn't use typeof(). I have to admit that I tend to prefer the typeof() version, and I wonder why the kernel doesn;t use that. I

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 21:18:50 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <1336671134-16342-1-git-send-email-mich...@walle.cc> you wrote: > > This patchset is a split-off from my patch series "Kirkwood: add lschlv2 > > and lsxhl board support". > > > > Changes: > > > > v4: > >

Re: [U-Boot] [PATCH v4 1/3] lib: add rand() function

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 21:20:02 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <1336671134-16342-2-git-send-email-mich...@walle.cc> you wrote: > > It's a PRNG using the simple and fast xorshift method. > > ... > > > +static unsigned int y = 2463534242U; > > Hm... can we introduce

[U-Boot] [PATCH v2] mx28evk, m28evk: sync extra environment content

2012-05-11 Thread Otavio Salvador
The environment has been based on mx53loco but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name and inclusing m28evk update commands. Signed-off-by: Otavio Salvador Cc: Fabio Estevam Cc: Stefano Babic --- include/conf

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112229.44084.mich...@walle.cc> you wrote: > > > Please submit with the patches that actually use this code. > > Please have a look at > "[PATCH v4] Kirkwood: add lschlv2 and lsxhl board support" > > All introduced functions are used by this bsp. The origin

Re: [U-Boot] [PATCH v4 1/3] lib: add rand() function

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112232.20664.mich...@walle.cc> you wrote: > > > > +static unsigned int y = 2463534242U; > > > > Hm... can we introduce at least a little entropy somewhere? > Mh? A user is supposed to seed via srand(). Then why initialize y at all? Best regards, Wolfgang D

Re: [U-Boot] [PATCH v2] mx28evk, m28evk: sync extra environment content

2012-05-11 Thread Wolfgang Denk
Dear Otavio Salvador, In message <1336768754-18896-1-git-send-email-ota...@ossystems.com.br> you wrote: > The environment has been based on mx53loco but keeping the possibility > to easy change the default console device as Freescale and mainline > kernels differ on the device name and inclusing

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 22:43:16 schrieb Wolfgang Denk: > Keep these patches together, please. The responsible custodians can > still ACK individual patches of the series. > > The fact that only a single board ever needed these functions makes me > wonder if these are really of any general use.

Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 21:25:27 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <1336671134-16342-4-git-send-email-mich...@walle.cc> you wrote: > > Signed-off-by: Michael Walle > > How many boards will be using this code? Hopefully more boars will use this function in the future, in

Re: [U-Boot] [PATCH 1/8] MX28: Fix a typo in mx28_reg_8 macro

2012-05-11 Thread Marek Vasut
Dear Otavio Salvador, > The macro mistakenly referred to 32bit struct instead of 8bit one. > > Signed-off-by: Otavio Salvador > Cc: Fabio Estevam > Cc: Marek Vasut > --- > arch/arm/include/asm/arch-mx28/regs-common.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [U-Boot] [PATCH v7 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Simon Glass
Hi Wolfgang, On Fri, May 11, 2012 at 1:13 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message gnwty47akew...@mail.gmail.com> you wrote: > > > > So I will go back to the more complicated way, and this time just copy > what > > the kernel does. The difference is that it doesn't use typeof

Re: [U-Boot] [PATCH v2] mx28evk, m28evk: sync extra environment content

2012-05-11 Thread Wolfgang Denk
Dear Otavio Salvador, please keep the ML on Cc: - thanks. In message you wrote: > > > I have to admit that I have other ideas what the environment on the > > M28 boards should look like.  I don't want to see this style enforced > > (or even encouraged) for this board. > > Can you explain what d

Re: [U-Boot] [PATCH v4 1/3] lib: add rand() function

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, please keep the ML on Cc: - thanks. In message <201205112249.27871.mich...@walle.cc> you wrote: > > > > > > +static unsigned int y = 2463534242U; > > > > > > > > Hm... can we introduce at least a little entropy somewhere? > > > > > > Mh? A user is supposed to seed via srand(

Re: [U-Boot] [PATCH 1/8] MX28: Fix a typo in mx28_reg_8 macro

2012-05-11 Thread Otavio Salvador
On Fri, May 11, 2012 at 6:03 PM, Marek Vasut wrote: >> The macro mistakenly referred to 32bit struct instead of 8bit one. > Didn't Fabio sent in something similar already? Either way Yes; I asked him to send my patch while I was in a client with a very restricted firewall. Thanks by acking it.

Re: [U-Boot] [PATCH v2] mx28evk, m28evk: sync extra environment content

2012-05-11 Thread Otavio Salvador
On Fri, May 11, 2012 at 6:08 PM, Wolfgang Denk wrote: >> Can you explain what do you have in mind? > > Over the years we have developed our own style for the default > environment of DENX maintained boards, and I want to keep this > consistently used, especially for our own products.  The (Frescal

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112254.13896.mich...@walle.cc> you wrote: > > What about the rand function? I guess that should be two > compile time options > > - CONFIG_RAND > - CONFIG_RANDOM_HWADDR > > Any better names? Please make this a single option, CONFIG_RANDOM_MACADDR. It appe

Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112301.50311.mich...@walle.cc> you wrote: > > > Eventually this should be made configurable? > Given the above, i would keep it non-configurable if youre fine with that. Only if the code size for the existing boards that don't need this does not grow. Best

Re: [U-Boot] [PATCH v4 1/3] lib: add rand() function

2012-05-11 Thread Michael Walle
> please keep the ML on Cc: - thanks. sorry wrong key > In message <201205112249.27871.mich...@walle.cc> you wrote: > > > > > > +static unsigned int y = 2463534242U; > > > > > > > > > > Hm... can we introduce at least a little entropy somewhere? > > > > > > > > Mh? A user is supposed to seed vi

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 23:14:25 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <201205112254.13896.mich...@walle.cc> you wrote: > > What about the rand function? I guess that should be two > > compile time options > > > > - CONFIG_RAND > > - CONFIG_RANDOM_HWADDR > > > > Any better

Re: [U-Boot] [PATCH v7 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > > I have to admit that I tend to prefer the typeof() version, and I > > wonder why the kernel doesn;t use that. I guess there are reasons for > > that. Does anybody know what these might be? > > > > Not me, but: Thanks. So there is indeed a proble

Re: [U-Boot] [PATCH v4 1/3] lib: add rand() function

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112320.15462.mich...@walle.cc> you wrote: > > > This is inconsequent. Either we assume that the user will seed > > srand(), then y should not be initialized at all, so it goes to the > > BSS segment and does not waste space in the binary image. Or we want >

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112322.23891.mich...@walle.cc> you wrote: > > > > - CONFIG_RAND > > > - CONFIG_RANDOM_HWADDR > > > > > > Any better names? > > > > Please make this a single option, CONFIG_RANDOM_MACADDR. It appears > > nobody else ever needed a random number before, and we

Re: [U-Boot] [PATCH v4 1/3] lib: add rand() function

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 23:29:47 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <201205112320.15462.mich...@walle.cc> you wrote: > > > This is inconsequent. Either we assume that the user will seed > > > srand(), then y should not be initialized at all, so it goes to the > > > BSS se

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 23:30:59 schrieb Wolfgang Denk: > Well, you patch did not change this code. > > And I have to admit that I doubt the increased code size would be > worth such a change, at this place. Ok, can we agree on keeping the rand function in lib/ but using just one macro CONFIG_RAN

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112342.43133.mich...@walle.cc> you wrote: > Am Freitag 11 Mai 2012, 23:30:59 schrieb Wolfgang Denk: > > Well, you patch did not change this code. > > > > And I have to admit that I doubt the increased code size would be > > worth such a change, at this place.

Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 23:16:02 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <201205112301.50311.mich...@walle.cc> you wrote: > > > Eventually this should be made configurable? > > > > Given the above, i would keep it non-configurable if youre fine with > > that. > > Only if the

Re: [U-Boot] [PATCH v7 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Simon Glass
Hi, On Fri, May 11, 2012 at 2:24 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message d6pj6bxib7oe...@mail.gmail.com> you wrote: > > > > > I have to admit that I tend to prefer the typeof() version, and I > > > wonder why the kernel doesn;t use that. I guess there are reasons for > > >

[U-Boot] [PATCH v5 0/5] Kirkwood: add lschlv2 and lsxhl board support

2012-05-11 Thread Michael Walle
Changes: v5: - combine patchset again. the "net: *" patches should be individually acked by net custodian - make features configurable at compile time (CONFIG_RANDOM_MACADDR and CONFIG_SETENV_ENETADDR_BY_INDEX) - remove unused variable in boards/buffalo/lsxl.c - fix potential compiler war

[U-Boot] [PATCH v5 1/5] lib: add rand() function

2012-05-11 Thread Michael Walle
It's a PRNG using the simple and fast xorshift method. Signed-off-by: Michael Walle Cc: Wolfgang Denk --- include/common.h |6 ++ lib/Makefile |1 + lib/rand.c | 43 +++ 3 files changed, 50 insertions(+), 0 deletions(-) create mod

[U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Michael Walle
Signed-off-by: Michael Walle Cc: Joe Hershberger --- include/net.h | 16 net/eth.c | 15 +++ 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/include/net.h b/include/net.h index f6aeba2..bdc3da6 100644 --- a/include/net.h +++ b/include/net.h @@

[U-Boot] [PATCH v5 3/5] net: fix potential compiler warning

2012-05-11 Thread Michael Walle
Future compiler versions may generate a "too many arguments for functions" warning. Signed-off-by: Michael Walle Cc: Joe Hershberger --- net/eth.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/net/eth.c b/net/eth.c index c9f05d8..afce863 100644 --- a/net

[U-Boot] [PATCH v5 2/5] net: add helper to generate random mac address

2012-05-11 Thread Michael Walle
Add new function eth_random_enetaddr() to generate a locally administered ethernet address. Signed-off-by: Michael Walle Cc: Joe Hershberger --- include/net.h | 17 + net/eth.c | 22 ++ 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/i

[U-Boot] [PATCH v5 5/5] Kirkwood: add lschlv2 and lsxhl board support

2012-05-11 Thread Michael Walle
This patch adds support for both the Linkstation Live (LS-CHLv2) and Linkstation Pro (LS-XHL) by Buffalo. Signed-off-by: Michael Walle Cc: Prafulla Wadaskar --- MAINTAINERS |5 + board/buffalo/lsxl/Makefile | 50 ++ board/buffalo/lsxl/kwbimage-lschl

Re: [U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Michael Walle
Am Samstag 12 Mai 2012, 00:50:48 schrieb Michael Walle: > Signed-off-by: Michael Walle > Cc: Joe Hershberger > --- > include/net.h | 16 > net/eth.c | 15 +++ > 2 files changed, 31 insertions(+), 0 deletions(-) > > diff --git a/include/net.h b/include/net.h

[U-Boot] [PATCH v8 03/23] Add abs() macro to return absolute value

2012-05-11 Thread Simon Glass
This macro is generally useful to make it available in common. This version is taken directly from the Linux kernel include/linux/kernel.h Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to put abs() in common.h Changes in v6: - Update x86emu and omap4 to use the abs() macro Chan

Re: [U-Boot] [PATCH] spi: Tegra2: Seaboard: fix UART corruption during SPI transactions

2012-05-11 Thread Simon Glass
Hi Tom, On Fri, May 11, 2012 at 1:14 PM, jimmzhang wrote: > On Wed, 2012-05-09 at 10:34 -0700, Tom Warren wrote: > > Simon Glass's proposal to fix this on Seaboard was NAK'd, so I > > removed his NS16550 references and added a small delay before > > SPI/UART muxing. Tested on my Seaboard with la

[U-Boot] [PATCH] mx53: Fix mask for SATA reference clock

2012-05-11 Thread Fabio Estevam
From: Fabio Estevam SATA_ALT_REF_CLK field corresponds to bits 1 and 2 of offset 0x180c. Fix the mask for these bits. Signed-off-by: Fabio Estevam --- Stefano, I don't have a SATA disk handy to try this. arch/arm/cpu/armv7/mx5/clock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

2012-05-11 Thread Marek Vasut
Dear Alexander Holler, > This is used for compatibility with text files which are > using CRLF instead of LF as the end of a line. > > Signed-off-by: Alexander Holler Why don't you run the file trough dos2unix or tr -d '\r' ? > --- > lib/hashtable.c | 18 +++--- > 1 files change

Re: [U-Boot] [PATCH 1/2] MSM7x27a:Add support for interrupt

2012-05-11 Thread Marek Vasut
Dear Srikanth Reddy Vintha, > * support for msm7x27a interrupt > > Signed-off-by: Srikanth Reddy Vintha > --- > arch/arm/cpu/armv7/msm7x27a/Makefile|1 + > arch/arm/cpu/armv7/msm7x27a/interrupts.c| 136 > +++ arch/arm/include/asm/arch-msm7x27a/e

Re: [U-Boot] [PATCH 1/3] MSM7630 Interrupt support

2012-05-11 Thread Marek Vasut
Dear Mohamed Haneef, > * Support for msm7630 interrupts > > Signed-off-by: Mohamed Haneef > --- > arch/arm/cpu/armv7/msm7630/Makefile|1 + > arch/arm/cpu/armv7/msm7630/interrupts.c| 155 > + arch/arm/include/asm/arch-msm7630/exclusion.h | > 4

Re: [U-Boot] [PATCH] uboot and ZFS

2012-05-11 Thread Marek Vasut
Dear Jorgen Lundman, > > Technically, U-Boot is GPLv2+ so GPLv2 only code _may_ not be accepted > > That is for Wolfgang to decide, but you have been warned :) > > Naturally, he is king after all. There will be a thousand reasons to reject > it, but hopefully not due to license. I wonder ... Ger