Re: [U-Boot] [PATCH] usb:udc: Remove duplicated USB definitions from include/linux/usb/ch9.h file

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > Remove the repeated USB descriptor code and use usbdescriptors.h file. > ch9.h file has been copied from linux and is needed for USB gadget > related work. > Now usbdescriptors.h and ch9.h shall be used together. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmi

Re: [U-Boot] [PATCH 3/4] usb:gadget: Wrapper for extracting usb_gadget from linux's device

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > include/linux/usb/gadget.h |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h > index 275cb5f.

Re: [U-Boot] [PATCH 1/4] usb:gadget:composite Composite framework - files from Linux kernel

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > Two files from Linux kernel source tree have been ported > to u-boot (Linux Kernel v2.6.36): > > ./include/linux/usb/composite.h > ./drivers/usb/gadget/composite.c > > commit d187abb9a83e6c6b6e9f2ca17962bdeafb4bc903 > Author: Randy Dunlap > Date: Wed Aug 11 12:07:1

Re: [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > This commit adds support for storing private data to Samsung's UDC > driver. This data is afterward used by usb gadget. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > drivers/usb/gadget/s3c_udc_otg.c | 12 > 1

Re: [U-Boot] [PATCH 1/6] usb:composite:g_dnl: Composite gadget (g_dnl) for USB downloading functions

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > Composite USB download gadget (g_dnl) for download functions (e.g. DFU, > THOR, others) > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > drivers/usb/gadget/Makefile |1 + > drivers/usb/gadget/g_dnl.c | 231 >

Re: [U-Boot] [PATCH 2/6] usb:g_dnl:f_usbd_thor: USB Download function to support THOR protocol

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > Implementation of USB Download function supporting THOR protocol. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > drivers/usb/gadget/Makefile |1 + > drivers/usb/gadget/f_usbd_thor.c | 808 >

Re: [U-Boot] [PATCH 3/6] usb:g_dnl:thor: THOR protocol back end support for f_usbd_thor function

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > Support for THOR download protocol. Those files are necessary for > proper f_usbd_thor function proper work. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > drivers/usb/gadget/prot_thor.c | 247 >

Re: [U-Boot] [PATCH 4/6] usb:command: Support for USB Download command

2012-04-14 Thread Marek Vasut
Dear Lukasz Majewski, > Support for usbdownload command, which starts USB Downloading process > compliant with Samsung's THOR protocol. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > common/Makefile |1 + > common/cmd_usbd.c | 161 >

[U-Boot] [PATCH] mxs_i2c: Fix internal address byte order

2012-04-14 Thread Torsten Fleischer
Large EEPROMs, e.g. 24lc32, need 2 byte to address the internal memory. These devices require that the high byte of the internal address has to be written first. The mxs_i2c driver currently writes the address' low byte first. The following patch fixes the byte order of the internal address that

Re: [U-Boot] [PATCH 2/6] usb:g_dnl:f_usbd_thor: USB Download function to support THOR protocol

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334215049-20362-3-git-send-email-l.majew...@samsung.com> you wrote: > Implementation of USB Download function supporting THOR protocol. Please add documentation what THOR is, with links to specifications, other (reference) implementations, etc. Best regards, W

Re: [U-Boot] [PATCH 2/6] usb:g_dnl:f_usbd_thor: USB Download function to support THOR protocol

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334215049-20362-3-git-send-email-l.majew...@samsung.com> you wrote: > Implementation of USB Download function supporting THOR protocol. Sorry, I hit "send" too fast... > + .bDescriptorSubtype = 0x00, /* 0x00 */ > + .bcdCDC = 0x0110, ...

Re: [U-Boot] [PATCH 3/6] usb:g_dnl:thor: THOR protocol back end support for f_usbd_thor function

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334215049-20362-4-git-send-email-l.majew...@samsung.com> you wrote: > Support for THOR download protocol. Those files are necessary for > proper f_usbd_thor function proper work. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vas

Re: [U-Boot] [PATCH 4/6] usb:command: Support for USB Download command

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334215049-20362-5-git-send-email-l.majew...@samsung.com> you wrote: > Support for usbdownload command, which starts USB Downloading process > compliant with Samsung's THOR protocol. ... > +static char dnl_tab[4][STR_SIZE]; > + > +char *find_dnl_entry(char* s, cha

Re: [U-Boot] [PATCH 5/6] usb:g_dnl: Support for g_dnl download usb gadget for GONI board

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334215049-20362-6-git-send-email-l.majew...@samsung.com> you wrote: > Support for g_dnl download usb gadget driver for Samsung's GONI target. ... > +void usbd_thor_udc_probe(void) > +{ > + puts("USB_udc_probe\n"); > + s3c_udc_probe(&s5pc110_otg_data); Le

Re: [U-Boot] [PATCH 6/6] usb:g_dnl: Support for g_dnl download usb gadget for TRATS board

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334215049-20362-7-git-send-email-l.majew...@samsung.com> you wrote: > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Minkyu Kang See comments as for GONI board. > +#ifdef CONFIG_USBDOWNLOAD_GADGET > +void usbd_thor_udc_probe(void) > +{ >

Re: [U-Boot] [PATCH 1/4] usb:gadget:composite Composite framework - files from Linux kernel

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334214931-19480-2-git-send-email-l.majew...@samsung.com> you wrote: > Two files from Linux kernel source tree have been ported > to u-boot (Linux Kernel v2.6.36): > > ./include/linux/usb/composite.h > ./drivers/usb/gadget/composite.c Please fix checkpatch e

Re: [U-Boot] [PATCH 1/4] usb:gadget:composite Composite framework - files from Linux kernel

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334214931-19480-2-git-send-email-l.majew...@samsung.com> you wrote: > Two files from Linux kernel source tree have been ported > to u-boot (Linux Kernel v2.6.36): BTW - would it not make sense to use more recent code as reference? Best regards, Wolfgang De

Re: [U-Boot] [PATCH 2/4] usb:gadget:composite: Linux composite.{h/c} code adjustement for u-boot

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334214931-19480-3-git-send-email-l.majew...@samsung.com> you wrote: > This commit fixes Linux kernel's composite.{h/c} code to work with u-boot. You mean you added non-working code first, and fix it later? This is not bisectable. Please squash. > -/* #define

Re: [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver

2012-04-14 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1334214969-19664-1-git-send-email-l.majew...@samsung.com> you wrote: > This commit adds support for storing private data to Samsung's UDC > driver. This data is afterward used by usb gadget. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc

Re: [U-Boot] [PATCH] mx6qsabresd: Add basic support

2012-04-14 Thread stefano babic
Am 14/04/2012 01:04, schrieb Fabio Estevam: > On Fri, Apr 13, 2012 at 7:36 PM, Fabio Estevam wrote: > Hi Fabio, >> So, would it be OK to use 0x1000 - 0x177f as the memory range for >> mtest? Some considerations about this issue. hopefully I am not OT. The values put in the configurati

Re: [U-Boot] [PATCH] mx6qsabresd: Add basic support

2012-04-14 Thread Fabio Estevam
Hi Stefano, On Sat, Apr 14, 2012 at 11:41 AM, stefano babic wrote: > Some considerations about this issue. hopefully I am not OT. The values > put in the configuration file are the default parameters taken by the > mtest command if no parameters are issued. I agree they must not be set > to wron

Re: [U-Boot] [PATCH] mx6qsabresd: Add basic support

2012-04-14 Thread Fabio Estevam
On Sat, Apr 14, 2012 at 12:24 PM, Fabio Estevam wrote: > Something like the patch below? (Build tested only - no hardware handy > right now) Sorry, I meant the patch below: --- a/common/cmd_mem.c +++ b/common/cmd_mem.c @@ -40,6 +40,8 @@ #define PRINTF(fmt,args...) #endif +DECLARE_GLOBAL_DATA

Re: [U-Boot] [PATCH] mx6qsabresd: Add basic support

2012-04-14 Thread stefano babic
Am 14/04/2012 17:28, schrieb Fabio Estevam: > On Sat, Apr 14, 2012 at 12:24 PM, Fabio Estevam wrote: > >> Something like the patch below? (Build tested only - no hardware handy >> right now) > > Sorry, I meant the patch below: > > --- a/common/cmd_mem.c > +++ b/common/cmd_mem.c > @@ -40,6 +40,8

[U-Boot] [PATCH v7] kirkwood: add NAS62x0 board support

2012-04-14 Thread Luka Perkov
Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220. NAS6210 has 1 SATA and 1 eSATA port while NAS6220 has 2 SATA ports. More information about the boards can be found here: http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7036 http://www.raidsonic.de/en/products/nas-

Re: [U-Boot] [PATCH v5] kirkwood: add support for Cloud Engines Pogoplug E02

2012-04-14 Thread David Purdy
Hi Wolfgang, Prafulla, Albert & all, Any chance to push this in 2012.04 release? thanks, regards, Dave On Wed, Mar 28, 2012 at 3:05 AM, Prafulla Wadaskar wrote: > > >> -Original Message- >> From: Dave Purdy [mailto:david.c.pu...@gmail.com] >> Sent: 28 March 2012 07:31 >> To: u-boot@l

Re: [U-Boot] [PATCH] mx6qsabresd: Add basic support

2012-04-14 Thread Wolfgang Denk
Dear Stefano, In message <4f898ca5.8070...@denx.de> you wrote: > > The start address CONFIG_SYS_MEMTEST_START is the lowest address of the > SDRAM that can be accessed, that is MMDC0_ARB_BASE_ADDR (0x1000) for > i.MX6. But it _should_ be the lowest address that can _safely_ be used for such t

Re: [U-Boot] [PATCH] mx6qsabresd: Add basic support

2012-04-14 Thread Wolfgang Denk
Dear Fabio Estevam, In message you wrote: > > Something like the patch below? (Build tested only - no hardware handy > right now) NAK Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebe

Re: [U-Boot] [PATCH] mx6qsabresd: Add basic support

2012-04-14 Thread Wolfgang Denk
Dear Stefano, In message <4f899f3b.2080...@denx.de> you wrote: > > Something like this, but not exactly this. After sending my answer I > remembered that the stack is *before* u-boot code, and not after as I > wrote - using gd->relocaddr is wrong. We should subtract the memory > reserve for stack

Re: [U-Boot] [PATCH] drivers/mtd/spr_smi.c: Fix build warning

2012-04-14 Thread Anatolij Gustschin
On Wed, 28 Mar 2012 16:27:54 +0200 Anatolij Gustschin wrote: > Fix: > spr_smi.c: In function 'smi_write': > spr_smi.c:325:15: warning: variable 'WM' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > Cc: Vipin Kumar > --- > drivers/mtd/spr_smi.c |5

Re: [U-Boot] Introducing myself

2012-04-14 Thread Mike Frysinger
On Thursday 12 April 2012 03:20:31 Timo Ketola wrote: > This is the first time for me to work with a community. Working practices > in a community (git procedures etc.) are all new for me. So, I'll expect > constructive critic on my forthcoming posts. g'luck! -mike signature.asc Description: Thi

[U-Boot] [PATCH v5] net: allow setting env enetaddr from net device setting

2012-04-14 Thread Rob Herring
From: Rob Herring If the net driver has setup a valid ethernet address and an ethernet address is not set in the environment already, then set the environment variables from the net driver setting. This enables pxe booting on boards which don't set ethaddr env variable. Signed-off-by: Rob Herri