Dear Lukasz Majewski,
In message <1334215049-20362-5-git-send-email-l.majew...@samsung.com> you wrote:
> Support for usbdownload command, which starts USB Downloading process
> compliant with Samsung's THOR protocol.
...
> +static char dnl_tab[4][STR_SIZE];
> +
> +char *find_dnl_entry(char* s, char *name)
...
> +int img_store(struct g_dnl *dnl, int medium)
etc. Please add sufficient comments that allow to understand what
these functions are supposed to do.
> +int do_usbd_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> + /* Simple argv[0] passing is not working since 'usbdown' cmd can
> + be run by */
> + /* 'usb', 'usbd' or 'usbdown' */
Incorrect multiline comment style, and I have to admit that I don;t
understand what you are trying to tell us here.
Also note that "usb" is already in use.
> + puts("THOR Downloader\n");
Please less verbose (see prvious comments).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"I can call spirits from the vasty deep."
"Why so can I, or so can any man; but will they come when you do call
for them?" - Shakespeare, 1 King Henry IV, Act III, Scene I.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
