Dear Lukasz Majewski, In message <1334215049-20362-7-git-send-email-l.majew...@samsung.com> you wrote: > Signed-off-by: Lukasz Majewski <l.majew...@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > Cc: Minkyu Kang <mk7.k...@samsung.com>
See comments as for GONI board. > +#ifdef CONFIG_USBDOWNLOAD_GADGET > +void usbd_thor_udc_probe(void) > +{ > + puts("USB_udc_probe\n"); > + s3c_udc_probe(&s5pc210_otg_data); > +} > +#endif Duplicated code. Please move to common location and avoid duplication. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I think there's a world market for about five computers. -- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot